Clint Rutkas
6d60249fd2
Update Resources.resx
2020-10-29 20:23:20 -07:00
Clint Rutkas
6ebea75f87
loc team feedback
2020-10-28 16:51:30 -07:00
Clint Rutkas
24b7748834
addressing kbm loc team feedback q
2020-10-28 16:44:34 -07:00
Arjun Balgovind
03ea90dced
Select all text in Target App textbox on getting focus ( #7566 )
2020-10-27 09:14:00 -07:00
Arjun Balgovind
d7912e1e12
Added tooltips for Add and Delete buttons ( #7564 )
2020-10-27 09:13:39 -07:00
Enrico Giordani
8ea09e0c95
[Keyboard Manager] new icon ( #7492 )
2020-10-25 22:54:48 +01:00
Arjun Balgovind
cd8c9c5375
Tweaked KBM comment, removed redundant assignment, and avoid sending key up for one case when not necessary ( #7315 )
...
* Changed one case to release key only if it is pressed, tweaked a comment
* Remove redundant assignment
2020-10-21 10:24:43 -07:00
Mykhailo Pylyp
eaec26a012
Fix dropdown popup narrator bug ( #7422 )
2020-10-21 11:14:30 +03:00
csigs
3801ad3030
LEGO: check in for master to temporary branch. ( #7436 )
2020-10-20 21:17:06 -07:00
Arjun Balgovind
4da4673e24
[KBM] Ignore IME keys while checking keyboard state for Shortcut Remaps ( #7386 )
...
* Ignore IME keys while checking keyboard state for Shortcut Remaps
* Add bool check
* Update Shortcut.cpp
2020-10-20 16:14:48 -07:00
csigs
334e612bce
LEGO: check in for master to temporary branch. ( #7411 )
2020-10-20 11:22:47 -07:00
Divyansh Srivastava
280d1907d8
Non localized module name ( #7170 )
...
* Added get_key to powertoysmodule interface
* Replace get_name with get_key
* Implement get_key function in modules
* Make key global constant in each module
* Update settings v1 to use key to load and save files
* Fixed fancyzones and preview pane unit tests
* Removed setings unit test as the case is not covered anymore
* Add constant files for modules and use it to reference module key
* Add constant string files to colorpicker, launcher and shortcut guide
* correct sunction signature in settings helper
* Fix powerpreview merge conflicts
* nit fix with include statement location
* add check for fields in from_json_string
* Updated preview pane tests with correct from_json_string signature
* Correct Image resizer naming
* Roll back changes for adding check for property and version
* Fix image resizer not working
2020-10-19 16:07:02 -07:00
csigs
06de5ffa07
LEGO: check in for master to temporary branch. ( #7338 )
2020-10-19 10:22:30 -07:00
Mykhailo Pylyp
7e0574cba2
Get rid of indexes in dropdowns ( #7278 )
2020-10-19 12:27:47 +03:00
csigs
36dd29c056
LEGO: check in for master to temporary branch. ( #7327 )
2020-10-16 11:03:43 -07:00
csigs
6f5cdb4674
LEGO: check in for master to temporary branch. ( #7319 )
2020-10-16 08:59:49 -07:00
Mykhailo Pylyp
4634c74f9e
Remove Drop Down from combo box name as it is redundant ( #7307 )
2020-10-16 14:09:57 +03:00
csigs
c576bb611d
LEGO: check in for master to temporary branch. ( #7305 )
...
Co-authored-by: Clint Rutkas <clint@rutkas.com >
2020-10-15 13:19:50 -07:00
Arjun Balgovind
438169e64f
[KBM] Fix shortcut remap scenarios that should/should not open start menu ( #7171 )
...
* Modify shortcut to key code more similar to shortcut to shortcuts code. Manually tested cases
* Fixed existing tests and fixed scenario with other keys pressed and action key released
* Fixed dummy key usage
* Updated comments and removed dummy key usage in key to shortcut remaps
* Added tests for disable and shortcut to key. Pending tests for dummy key
* Added test cases for each usage of dummy key event
* Remove redundant check
2020-10-15 08:53:43 -07:00
Arjun Balgovind
70bc967219
Updated double quotes logic ( #7268 )
2020-10-14 09:03:45 -07:00
csigs
45124c2245
LEGO: check in for master to temporary branch. ( #7246 )
...
Co-authored-by: Clint Rutkas <clint@rutkas.com >
2020-10-12 21:44:15 -07:00
csigs
6e8cc67824
LEGO: check in for master to temporary branch. ( #7236 )
2020-10-12 19:22:52 -07:00
csigs
c6a82ef199
LEGO: check in for master to temporary branch. ( #7217 )
2020-10-12 16:59:32 -07:00
csigs
d9d328173b
LEGO: Pull request from lego/hb_2939_20201009230714095 to master ( #7210 )
...
* LEGO: check in for master to temporary branch.
* Update pipeline.user.windows.yml
Co-authored-by: Clint Rutkas <clint@rutkas.com >
2020-10-12 15:31:47 -07:00
Arjun Balgovind
8643bfc977
Change declaration order of delay thread member in KeyDelay ( #7206 )
2020-10-09 16:13:48 -07:00
csigs
d753179d1e
LEGO: check in for master to temporary branch. ( #7186 )
...
Co-authored-by: Arjun Balgovind <32061677+arjunbalgovind@users.noreply.github.com >
2020-10-09 14:32:31 -07:00
csigs
bd3c877ca3
LEGO: check in for master to temporary branch. ( #7195 )
2020-10-09 09:38:36 -07:00
Arjun Balgovind
210426a020
Fixed lcl file bad merge ( #7189 )
2020-10-08 19:38:21 -07:00
Arjun Balgovind
c393db0b65
[KBM] Fix remaps to arrow keys/Home/Ins, etc not working with Windows Terminal ( #7143 )
...
* Added MapVirtualKey call to set scancode before calling SendInput
* Updated comment
* Update comment with link
* Added test for dummy key scan code
2020-10-08 17:52:19 -07:00
Arjun Balgovind
42ebc42c98
Changed dummy key event to send key down and key up to improve compatibility with applications ( #7166 )
2020-10-08 11:28:37 -07:00
Arjun Balgovind
e1d22c74b0
[KBM] Refactor KBM's thread safety logic to avoid mutex re-entrancy bugs and improve performance ( #6803 )
...
* Unlock mutex before ResetModifierForLowerLevelKeyHandlers method to avoid crash if two instances of KBM are running
* Added alias for Shortcut DWORD variant to clean up code
* Removed mutex usage in single key remap method and added GetSingleKeyRemap
* Added more alias
* Moved to boolean disable remapping
* Added missing ! in condition
* Remove lock statement from bad auto-merge
2020-10-08 11:28:24 -07:00
csigs
8a81bea413
LEGO: check in for master to temporary branch. ( #7168 )
2020-10-08 07:55:56 -07:00
csigs
9216aa465f
LEGO: check in for master to temporary branch. ( #7181 )
2020-10-08 07:54:53 -07:00
csigs
de4436ccc0
LEGO: check in for master to temporary branch. ( #7153 )
2020-10-07 13:30:34 -07:00
csigs
5e30ad176a
LEGO: check in for master to temporary branch. ( #7144 )
2020-10-07 13:30:12 -07:00
Yuhanun Citgez
ac3910580a
Modernized unique pointer construction ( #6982 )
2020-10-06 18:17:20 +03:00
Mykhailo Pylyp
3f25d7ccc8
Keyboard disable ( #6874 )
...
Added disable key/shortcut functionality
2020-10-02 15:36:36 +03:00
Arjun Balgovind
b2e72e1ca4
[KBM] Moved unregistering of key delays to always run on the dispatcher thread to avoid mutex re-entrancy ( #6959 )
...
* Moved unregistering of key delays to always run on the dispatcher thread
* Updated comments
2020-10-01 18:19:11 -07:00
Arjun Balgovind
b981467f1e
[KBM] Avoid checking reserved/unassigned/oem-specific/undefined key codes during shortcut remaps ( #6952 )
...
* Updated list of key codes to be ignored
* Added comments
2020-10-01 12:43:54 -07:00
csigs
67072b99d4
LEGO: check in for master to temporary branch. ( #6907 )
2020-09-30 10:26:54 -07:00
csigs
2f0937951a
LEGO: check in for master to temporary branch. ( #6802 )
2020-09-24 08:01:13 -07:00
Arjun Balgovind
75ace74d37
[Keyboard Manager] Enabled horizontal scroll on scroll viewers and tweaked ScrollViewer layout ( #6755 )
...
* Enabled horizontal scroll on scroll viewers and tweaked layout
* Added code to constrain the minimum window sizes
2020-09-22 17:46:57 -07:00
Arjun Balgovind
1ef4c43382
[Keyboard Manager] Fix crash in Keyboard Manager by ignoring MapToSameKey warnings on loading ( #6714 )
...
* Add extra argument to ignore MapToSameKey error for Key To Shortcut mapping
* added comment
2020-09-22 13:54:53 -07:00
Arjun Balgovind
e135153c45
[Keyboard Manager] Fix focusable elements should have different names accessibility issue ( #6672 )
...
* Add listview
* Added row index to accessible names
* Cleanup rowIndex
* Fixed accessibility issue with ComboBox
* Updated comments
2020-09-18 17:12:37 -07:00
Arjun Balgovind
bfbd7b53a1
Unregister key delays on closing KBM windows ( #6583 )
2020-09-11 15:16:34 -07:00
Arjun Balgovind
ab8bec8866
[KBM] Prevent keyboard manager crash when index is not found ( #6488 )
...
* Added Sleep(5000) for repro
* Added check to prevent kbm crash for index not found
* Add more safeguards
2020-09-10 11:31:49 -07:00
Arjun Balgovind
3b8fa8b4ce
Fixed KBM shortcut remapping not working after using Japanese IME ( #6450 )
2020-09-10 10:46:33 -07:00
Arjun Balgovind
fb1888f01f
Add in verbose error message and telemetry for SetWindowsHookEx failure ( #6454 )
...
* Updated error message when SetWindowsHookEx fails to show correct error message
* Added telemetry for exception in SG, FZ and KBM
* Rename exception to error
2020-09-09 14:27:40 -07:00
Arjun Balgovind
fdd7d6afa4
Add in missing telemetry for Keyboard Manager usage ( #6393 )
...
* Added key remap invoked telemetry event
* Added queryperformance call
* Added in telemetry for key and shortcut remaps
* Removed redundant if check
2020-09-08 14:40:02 -07:00
Alekhya
1a51f77fce
Fix KBM Accessibility issues ( #6379 )
...
* Added an accessible name for the combo box
* Add name for the type shortcut button
* Add accessible name for the add new remapping button in both key remapping as well as shortcut remapping windows
* Set accessible names for the delete button
* Set the accessible name to the remapped to icon
* Fix the font icon issue faced while using narrator
* Fix accessible name for Add shortcut remapping button
* Set the accessible name for the target app text box when it loses focus
* fix comment
2020-09-08 12:24:59 -07:00