* Add resource only when it is not already present (#3842)
(cherry picked from commit d2dfbff832)
* Take space into consideration while calculating the first matched index (#3874)
(cherry picked from commit a8d67a1c60)
* Fix for File explorer not showing up and multiple notepads (#3969)
* reverted the dedup code, file explorer shows up but so do duplicates
* Fixed file explorer and dedup
* Formatting
* Added tests for all the cases
* Formatting
* Tests
* take name and exe into consideration while calculating hash
* unique primes while calculating hash code
(cherry picked from commit 8cddd595d4)
Have not seen this requirement mentioned anywhere until PowerToys is already installed.
For those installing PowerToys specifically to try this, it would be useful to know the requirement in advance, especially given that https://github.com/microsoft/PowerToys/blob/master/README.md mentions only 1803.
* Increase score for exact matches in the name
* Added tests for exact matching
* Used TestCase
* variable for bonus score
* Removed comment, variable is self explanatory
* updated general settings tests
* reverted changes to solution files
* fetch test strings from a string resource
* updated bidning variable name to avoid confusion
Co-authored-by: Lavius Motileng <laviusmotileng-ms>
* Adding privacy event tags to each telemetry event.
* Moving Privacy events to Telemetry base, Removing tag values, and fixing namespaces.
* Adding documentation comments to fix style cop errors in release
* UTCReplace_AppSessionGuid boolean property to all C# telemetry events.
* Adding hardcoded version number to boot events.
* Adding reference to telemetry in settings unittest
* Adding Preview Pane events for loading w/ hardcoded version number
* Adding telemetry.h to msi for svg and markdown events
* removing unused explicit interface exception
* Removed AppxPackaging dll
* Added helper class and fixed some AppxPackage errors
* Modified it to use the COM interface
* Got it to build without errors but UWP apps don't show up
* Added app to the array
* Deleted the AppxPackaging.dll
* Added github reference
* Removed unnecessary uwp app argument
* Removed dll from installer wxs file
* Change auto-download setting's title
The update don't get automatically downloaded when the user is connected over an metered connection.
This is something the user should known about. Because of not have to be afraid on having extra costs and to not being confused if it not works on metered connections.
* auto-download title (old settings)
Did the same change also for the old web-settings.
* Deleted the dll
* Added Shell Link helper class
* Add activation manager helper
* Use helper shell link and remove shell namespace
* removed using shell and added Activation helper namespace
* Removed the dll from the installer
* formatting
* nit formatting
* Replaced UWP searchbox with WPF
* Updated foreground color scheme for textbox
* Add focus on visibility changed
* Updated initial hiding of window
* Fixed list box border
* vis issue on start, fixing border
* Revert "Merge branch 'somil55/MigrateSearchBoxToWPF' into fewTweaks"
This reverts commit 3525171621, reversing
changes made to b5daffca55.
* Remove change in startup visibility
Co-authored-by: Clint Rutkas <clint@rutkas.com>
* Added the settings hyperlink code back
* Moved the os detection code to a different file so that it can be imported by image resizer
* Added code to the Image resizer project to react to import the dll
* Added an empty dll project
* Added a dll which can be imported by image resizer
* ImageResizer binding works
* Added the setDllDirectory to load the os-detection dll
* Removed the OS detection files that has been added to the common project
* Added reference to os-detect and removed reference to common/OS-Detection.h
* Modified project files
* Revert "Modified project files"
This reverts commit 75f9d73f30.
* Removed unnecessary showAdvanced bool variables
* Removed OS Detection code from common project
* Cleaned configuration properties of soln and projects
* runner is dependent on os-detection
* Added the os-detection.dll to wxs file
* nit space formatting
* Added reference to os-detection
* Added os-detection header file
* Add os-detection reference
* Added os-detection.dll
* removed the set dll directory and using relative paths instead
* Add relative path
* WIP Confirmation dialog for orphaned keys
* Confirmation Dialog for orphaned keys
* White OK button, Anyways capitalizef
* Change Apply to Ok for shortcuts
* Validate that mappings can be made before changing keyboardManagerState
* Set fixed MinWidth for OK button
* Fix typo
* Partial remappings confirmation dialog
Both for Shortcuts and SingleKey
* Remove warning icon callback in OnClickAccept
* Add text wrapping for OrphanKeys dialog
* Updated the add button styles to a standard used in W10 settings
* Updated the "About this feature" text to About [Module name]
* Set larger changes to the Shortcut Guide opacity numberbox
* Re-organised the General page
* Improved width of the add button so it's inline with the corresponding listview.
* Seperated warning label from header. Re-organised general settings
* Consistent formatting of the word 'administrator'
* Typo fix
* Warning text is collapsed when the user runs the app as admin
* Removed underline of version number
* XAML fix
* Fixed foreground issue and added arrow
* Tweaked Remap Keyboard UI
* Fix errors in warning handling and update UI layout
* Tweaked sizes and centered to screen
* Fixed flyouts appearing on search for Single key remaps
* Fixed flyouts appearing on search for Shortcut remaps
* Remove warning exclamation icon and tooltip
* Fixed a bug where setting None on a drop down which would create a shortcut with a conflict would cause a crash
* Remove IsTypeKey logic
* Changed warning text
* Resolve comments
* Fixed foreground issue and added arrow
* Tweaked Remap Keyboard UI
* Fix errors in warning handling and update UI layout
* Tweaked sizes and centered to screen
* Changed size to scale based on resolution
* Fixed comments
* Raising Telemetry events when svg and markdown preview pane is turned off
* Properly serializing Bool property. This allows us to be backwards compatible with .17 settings but interact with the properties as boolean elements, and fire events on property changed notification
* Updated UWP app to set entry point type for each app
* Working run as admin for packaged app with permission
* Updated UWP to allow apps with mediumIl trust level to be run as admin
* cleanup variables not required
* Had reverted the changes made in the Microsoft.Launcher.rc file by mistake while resolving merge conflicts
* reverted company name to how it was before
* Add new text for Remap Keyboard
* Added text in KBM windows
* Tweaked KBM landing page view
* Changed to transparent background
* Tweaked text
* Tweaked text
* Added code to detect os build number
* To set the settings.exe according to the powerToys version that is running
* Modified the description of old UI for launcher and keyboard remapper
* Using API contracts instead of registry
* Removing file that was included by mistake
* Clean up resources taken by closed virtual desktops on FancyZones module startup.
* Overload GetVirtualDesktopIds to return wide string.
* Refactor OnDisplayChange method.
* Commented out ToggleToMod and AppSpecific function calls
* Added logic to make sure key remaps don't occur on Edit Keyboard Window
* Changed behavior such that remappings only apply after window is closed
* Update version in General Settings
* Set version in settings.json file
* Only overwrite the settings.json file if it is newer than the old version.
* Fix tests
* Fix test names and added comment
* Added output folder
* Added FileExplorerPreview output folder for all projects
* Added extra dlls and FileExplorerPreview to path
* Added folder and modified path for registry setup of preview handlers
* fixed run-elevated error and powerpreview settings not working
* removed EXTENDED_STARTUPINFO_PRESENT flag
* removed test string
* Update Microsoft.PowerToys.Settings.UnitTest.csproj
* Rename PowerLauncher.cs to PowerLauncherViewModelTest.cs
* Bypass XamlBridge Window focus handling
* Constrain only one window can be opened at a time
* Revert changes on files changed in another PR
* Changed WM_DESTROY to WM_NCDESTROY
Co-authored-by: Tomas Raies <tomas.raies@gmail.com>
* Fixed left and top window
* Added dpi Aware launcher positioning code
* Code cleanup
* Added support to drag window
* Multi monitor support added
Remaining fix : Launcher doesn't open first time on changing monitor
* removed code handling change in DPI manually
* Code cleanup
* Fix to support multimonitor display
* Code cleanup
* Revert "Code cleanup"
This reverts commit 38f39924f0.
* Revert back to WOX helper for calculating normalized DPI
* Move part of the virtual desktops related logic from FancyZones to VirtualDesktopUtils.
* Post WM message from vritual desktop tracker thread to FZ thread.
* Minor improvements in RegisterVirtualDesktopUpdates method.
* Close registry key after HandleVirtualDesktopUpdates thread finishes execution.
* Remove comment explaining workaround to VirtualDesktopUtils namespace.
* Move HandleVirtualDesktopUpdates to VirtualDesktopUtils namespace. Resolve PR comments.
* Fix typos in window messages description.
* Remove lock from OnKeyDown method to avoid deadlock.
* Handle scenario with only primary desktop and no desktop swithc in current session.
* Add scoped lock when changing current desktop id. Address PR comments.
* Explain purpose of UpdatePrimaryDesktopData method.
* Fix typo in documentation.
* "Unhooked" the Shortcut guide module from the PT event dispatcher
* Fixup: warning/undefined behavior/terrible bug
* SetWindowsHookEx and UnhookWindowsHookEx now fail silently
* Updated a comment in shortcut_guide.h
* Renamed a method, added an error message
* Removed unnecessary styling resources.
Fixed searchbox overlay.
Fixed a bug where the command buttons would fall of the list
* Fixed a bug where the app icon could overlap the title/path textblocks
* Consistent background / border color
* Tweaked shadow, background color now theme depended
* minor modifications in README
* Added launcher project and changed references to common
* Added the code to launch another process
* added shellapi header
* Added launcher to runner
* added functions to remove the abstract class error
* added the wox launcher dll
* Readded the reference to common
* modified the additional include directories for the release version
* changed the name to be displayed from Wox.Launcher to Launcher
* Localized the strings of Launcher
* Added a SearchResult Helper class
* Created a helper class to use indexer and return search results
* Added the main and settings file which declare most of the plugin interfaces
* Added references and renamed a class
* Added the images folder which contains the windows indexer icon
* Added the image
* Added the plugin.json file
* Minor changes in project files
* Added plugin.json to the project
* Modified the output paths to create the dll for the plugin in the correct location
* Refactored the code to make it unit testable
* Made the code unit testable and added unit tests for the indexer plugin
* Removed commented out code
* Code to terminate wox when we exit PowerToys
* Copy from Jeremy's fork PR
* Removed unnecessary plugins from source tree
* add missing files
* Fix postbuild event
* Added x64 for all Wox project - Debug mode
* Removed the AnyCPU config - Debug
* Added the build paths for release x64 (removed AnyCPU)
* Set warning level to 4 : Release
* Set warning level 4 : Debug
* set optimize code to false
* Removed notify icon component
* Removed setting UI XAML file and references
* Readded necessary callback functions
* Removed python path and python plugin functions
* Removed UI related to python path and the bindings related to that
* Remove python bindings
* Removed the localized string translations from pythonDirectory and SelectPythonDirectory
* Manually resolving conflicts
* Fix Wox build in project settings
* deleting unused project files
* Undo change internal
* Fix internal variable
* All wox exceptions in debug are getting rethrown, and thus causing the app to crash. This change removes the debug specific code and allows exceptions to be handled the same was as release.
* Ported Indexer plugin to .net core 3
* Added the test project back
* Removed the .net framework indexer folder
* readding the plugin.json file
* Changed the anyCPU config to x64 for windows indexer plugin
* Adding dependency to wox project on the runner. This should make sure the wox.exe can be build and launched by the runner so wox can run as a background process.
* Updating build dependencies. Wox.Launcher wasn't built as part of the F5 Experience, and nor were the plugins
* removing locks from the ResultListBox code behind file. All callbacks are accessed from the Main/UI thread.
* Remove anyCPU config and changed it to x64
* Removed anycpu of test proj
* Adding dependency
* Renaming executable to PowerLauncher. Replaceing icons with placeholder. Deleting Docs folder
* Renaming AppData directory from 'Wox' to 'PowerLauncher'. Also replacing issue link with powertoys github.
* adding support for xaml islands
* Added Neils UI code
* Replace Niels Code references
* Added assets and behaviours
* Add missing reference
* Add main view model binding
* Using proper executable name when closing 'PowerLauncher' process
* changed x:bind to Binding to avoid reference
* Updated bindings for launcher
* Added binding on searchBox
* Adding Directory.Build.targets file to kill the PowerLauncher pprocess on Build or Clean operations of all 'Launcher' projects.
* Fixed exception preventing result display
* Fixed issue with wpf marshalling events to a non UI thread
* Optimised result binding by inserting search result from multiple plugin in parallel
* copy resource files to output folder
* Corrected the output path for the indexer plugin
* windows indexer plugin is working
* Remove console print statement
* Added callback function for mouse click on search result
* Working App execution
* Cherry picked pinyin performance changes from jjw24's master branch
* change nuget package to msft for winrt compat
* Working up/down arrow key
* updating references and removing a few that seem uneeded for how stuff is referenced
* adding two back in
* Removing Squirrel dll. unsure on updating so i kept that logic in
* Updated functionality on suggestion chosen in autosuggestbox
* Added the <useWPF> tag to remove the warning
* Removed an unnecessary <useWindowsForms> tag
* Removed the item group for properties from calculator plugin
* Removed the item group for properties from folder plugin
* Removed the item group for properties from indexer, program and shell plugin
* Removed itemgrp from wox.core and wox.test csprojs
* Removed the unnecessary wox files to clean up codebase
* Renamed Wox.Plugin.Indexer to Microsoft.Plugin.Indexer
* Renamed Wox.Launcher to Microsoft.Launcher
* To avoid DBNull to String typecast exception
* Added query submitted event to handle default action on clicking a list view item
* Merge pull request #42 from microsoft/AddPinyinPerformance
Cherry picked pinyin performance changes from jjw24's master branch
(cherry picked from commit b9e437c6cd)
* Rectyfying title display
* Title display working correctly
* Removed .yml files
* adding checks
* Making wox.csproj build wox assembly instead of powerlauncher
* Removing update logic from PowerLuanch App.xaml.cs as was done in Wox project.
* Making Query internals visible to wox.
* Update Powerlauncher nuget packages to be same version as wox.csproj. Note: FoxyWeavers.xsd change is automatically done as part of nuget package update.
* Updating build dependencies to so that wox.launcher depends on powerlauncher.csproj not wox.csproj
* Removing 'Wox' branded logos from powerlauncher.csproj as was done previously or wox.csproj
* Downgraded the library to the latest stable version
* single thread execution of the indexer plugin and InvalidOperationException due to connection being closed on ExecuteReader, handled separately
* Modified the test, the connection need not be null after being disposed. There is no direct way of checking if an object has been disposed other than to throw the InvalidOperationException
* Removing x86,ARM,ARM64, build configurations, as these were added accidentally when adding xaml island support.
* Removed STAThread
* Modified the output folder produced
* Renamed the dll produced
* Added dependency on PowerLauncher to the Microsoft.Launcher project
* modified the name of the dll in the indexer plugin
* Ignoring 128 errors from taskkill, as this means the process isn't running. We don't want htis to show up in the warnings list on build
* Added fix for closing wox on pressing escape and app execution (#75)
* adding useWPF to get rid of warning
* Launcher resize issue on selecting search result (#77)
* Added fix for closing wox on pressing escape and app execution
* Added fix to prevent autosuggestbox resize
* Fixing xaml catastrophic failure, based on Miguels suggestion here: https://github.com/windows-toolkit/Microsoft.Toolkit.Win32/issues/210
* suggested fix
* removing unused mutex string
* Searches for keyword only in title and not content to improve the quality of results
* Display the title from System.Title directly instead of extracting it from the path
* Removed additional README instructions before moving to the powerToys repo
* Fix Query builder test (#86)
* Revert base viewModel class to fix tests.
* Removing unused post build and deploy scripts.
* tweaked url
* Update plugin.json
* Update README.md
* removed unused dep (#2080)
* removed reference to everything (#2133)
* SearchIndexer - Modifying QueryContentProperties and QuerySelectColumns to use System.FileName
* Search result thumbnail for PowerLauncher (#2124)
* Replace WPF Imaging library with UWP
* Removed UWP and WPF namespace conflicting files from Wox
* Removed Image hashing as it wasn't used anywhere
* Updated formatting
* Set MainViewModel visibility to hidden on startup
* Enable CI build on PowerLauncher Branch (#2181)
* Enable CI build on PowerLauncher Branch
* Updated Nuget restore to latest and added AssetTargetFallback property
* tweak text (#2177)
* [Window Walker] Migrate to Launcher (#2093)
* Copy the existing calc. plugin foldeR
* Blindly rename a bunch of things to Window Walker
* Update the solution to reference the new plugin
* Get basic Yo returned
* Remove all the languages except english
* Lower quality of icon as well as test showing it
* Add the core non-ui parts to the plugin
* Delete calculator png
* Get it to compile
* Added the actual code which apparently doesn't work
* Finally start showing results
* Fix up strings
* Switch working
* Remove unused classes
* Remove unneeded async
* Added MSI support for Launcher (#2242)
* Fixed typo in output folder of calculator plugin
* Calculator plugin works
* Modified the name of the image to remove space as space is assumed to be a separator in wcx file
* Fixed typo in calculator dll
* Fixed typo in calculator plugin
* Shell, Program, Folde and indexer plugin working
* Added the ww plugin
* Fixed typos in the calculator plugin
* Delete file that was added unintentionally
* revert calculator rename changes
* Reverted other files changed
* Reverted renaming of file with space
* Pull changes from master to dev/powerLauncher (#2255)
* Dpi unaware placement bug (#2121)
Fix for bug when placing dpi unaware window such as Notepad++ in left of right part of monitor. In that application gap of about 7px was left or right.
This fixes only single-monitor scenario
It skips correction for dpi unaware window that leaves a gap
* Move markdown parsing logic outside control thread (#2099)
* Move markdown parsing logic outside control thread
* Update MarkdownPreviewHandlerControl.cs
* Remove trailing whitespace.
That'll teach me for trying to make an edit from the GitHub page.
* Migrate power rename MRU lists from registry to JSON (#2090)
* Handle most recently used search/replace strings within settings.
* Check for last modified time of json file and reload it if needed.
* Handle changes in MRU search / replace lists size.
* Improve handling of changes in MRU list size.
* Don't check for last modified time in every getter method. Load only when starting application.
* Add const identifier to getter methods.
* Address PR comments: Add const to reg and json file paths and set them in constructor initializer. Check pushIdx validity. Move implementation to cpp of PowerRenameUI constructor.
* Add error checking when getting values from registry.
* Implementing changes suggested in #1992 (#2116)
* Implementing changes suggested in #1992
* Update Product.wxs
Co-authored-by: Ebenezer Ewumi <ebenezer.ewumi@wsu.edu>
* Fix for issue #1532 - [PowerToys tray icon] Show version on tooltip (#2117)
* Fix for issue #1532
[PowerToys] Show version on tooltip
* Update src/runner/tray_icon.cpp
Co-Authored-By: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
* FZ editor: Splitted zones positioning (#2158)
* Added a mutex to ZoneWindow, ensured no data races occur (#2154)
* Added a mutex to ZoneWindow, ensured no data races occur
* Protected draggedWindow* members with a mutex
* Ensured that critical reads happen in a single transaction
* Dpi unaware placement bug - multimontior with same DPI settings fix (#2156)
* Dpi unaware placement bug - multimontior with same DPI settings fix
* Using different enumerating method
* Changed AllMonitorHaveSameDpiScaling method
* Removed accidental file
* small rename
* Changed some methods to CamelCase
* Review comments fixes
Co-authored-by: PrzemyslawTusinski <61138537+PrzemyslawTusinski@users.noreply.github.com>
Co-authored-by: Ben Randall <veleek@gmail.com>
Co-authored-by: vldmr11080 <57061786+vldmr11080@users.noreply.github.com>
Co-authored-by: eduardodextil <55205162+eduardodextil@users.noreply.github.com>
Co-authored-by: Ebenezer Ewumi <ebenezer.ewumi@wsu.edu>
Co-authored-by: Nghia M. Luong <32159519+sqrlmn@users.noreply.github.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
Co-authored-by: Seraphima Zykova <zykovas91@gmail.com>
Co-authored-by: Ivan Stošić <ivan100sic@gmail.com>
* Somil55/merge custom ui into launcher (#2271)
* Remove Autosuggest box (#2192)
* Update Settings.Designer.cs
* Revert "Update Settings.Designer.cs"
This reverts commit a1bc0dda56.
* Updated LauncherControl XAML to add textbox and listview
* List View displayed
* Hooking up execution on the selected index, removing two way binding on selection, and experimenting with popup that doesn't work
* Updated MainViewModel to Remove context menu and history
* Added Resultist XAML Island project
* Updated SelectedItem and SelectedList Binding.
Issues : List box doesn't open when query is written for first time but opens in subsequent queries.
* 1. Mouse Click working
2. List View is can't be focused
3. Fixed width of Launcher
* Removed two way QueryText box binding
* Removed SelectedItem two way binding and replaced with a callback
* [Cleaning] Remove redundant UWP project
* [Cleaning] Updated files to keep only atomic changes against dev/powerLauncher
* Thmbnail fixed for NEW UI
* Removed PreviewMouseDown function required by older WOX code
Co-authored-by: ryanbodrug-microsoft <56318517+ryanbodrug-microsoft@users.noreply.github.com>
* Added the auto-complete feature
* Removing ContextMenuPluginInfo, and ContextMenuTopMost as these commands are not used int the new design.
* Fixed merge conflicts
* Set only when index is 0
* One way binding
* Removed unnecessary binding
* Deleting unused (commented out code) that was legacy from wox project.
* Binding Buttons to appropriate context menu commands.
1. Buttons are dynamically loaded in a listview based on the actions supported be each plugin.
This change also deletes unused commands.
Note: Most button events don't seem to be getting routed to the Selected Item. Currently using 'PointerEntered' to validate the behavior. The actions should be trigged by the button command property in the future.
* manually handling tab in mainwindow
* Loading context buttons on Selecting a suggestion list item
* Allowing hover event to load content menu items and display them as well.
* Adding context buttons to Indexer plugin. This allows for the following:
1. [Files] Open Containing folder
2. [Folders/Files] Copy Path
* Remove White background of list (#2218)
* Remove white background of list
* Removed comments
* Changed to ContainerContentChanging event
* add const variables instead of numbers
* Added comment before the updatelistSize function
* Search box UI (#2224)
* Added backdrop and rounded corner
* Fix for two alt+space press to bring searchbox issue
* Fixed merge conflict
* Clean Mainwindow.xaml code
* Fix for textbox focus on first visible
* Allowing users to tab between the context buttons for the selected resut. Also allowing users to press 'enter' to action on the selected items.
* Renaming SelectedIndex to ContextMenuSelectedIndex
* Enabling key accelerators on context buttons.
1. Add new object ContextMenuResult instead instead of reusing Result for both query results and context menu results.
2. Binding KeyboardAccelerator keys to contextmenuitemviewmodel
3. Enabling and disabling contextmenu items when selecting or deselecting each row. Because we are manually maintaining selectionwe can't use ScopeOwners as the textbox is really the only item ever in focus.
* Launching explorer instead of the UWP application when selecting 'open file location'.
* Added fix for border showing up when result count is zero
* Updated fix for border on no result
* Adding visibility after clearing result in MainViewmodel
* Launcher Light/Dark mode (#2235)
* Fixed issue with list view background not updating with Windows theme change
* Added theme change for WPF
* updated ShadowDepth for dropshadow
* Updated border thicknes of searchbox and listview
* Diff issue with ResultList.xaml
* Removed change in result delay
* Added code to pull colors from UWP
* Updated border resource to use system based SystemControlHighlightAccentBrush
* Updated corner radius in dark mode
* Updated Launcher description text
Co-authored-by: ryanbodrug-microsoft <56318517+ryanbodrug-microsoft@users.noreply.github.com>
Co-authored-by: Alekhya Reddy <reddykalekhya@gmail.com>
* Changed to SystemChromeLow from Accent brush (#2272)
* Removed ListView animations
* Positioning ContextButtons and adding background.
* Disabling scrollbars for gridview items.
* Removed folder plugin
* removed deployment for uwp apps (#2298)
* Simulating Win+backspace key press, instead of Win+Control as it was launching WW (#2250)
* text is selected whenever launcher gets hidden and is then set to visible (#2315)
* Update nuget packages across solution to latest (#2334)
* simplifying the xaml and making things tighter (#2327)
* Setting runcommand as the default execution method, and turning off run as admin by default.
* Opening explorer if the user has types a file path.
* Enable PowerLauncher toggle
* Launcher MSI - Added a required dll and removed folder plugin (#2355)
* Modified the product.wxs file
* Added the x64 config
* Modify scoring algorithm for fuzzy search (#2361)
* Modify scoring
* modified to if else
* Fixes race conditions with PointerEnter/Exit events conflicting with Selection and unselection. This change provides better encapsulation of the logic to enable a selected item for accelerator (hotkey) events, and allow mouse input on results where the pointer is over.
* Fixes an issue where PointerExit would hide the selected context buttons.
* Result List - Bad rebase overwrote margin and translation fields.
* Fixed process executing on clicking enter if no text in search box
* Codeflow cleanup when selectedItem is not null
* adjusting how programs are displayed. (#2369)
* Removing description from title
* adjusting subtitle
* removing accidently paste
* removing desc for uwp apps
* Revert "Removed folder plugin"
This reverts commit 064d638588.
We will use the folder plugin to better mimic the way the start menu and run prompt deal with directories
* Updating JetBrains.Annotations to 2020.1.0 to be consistent with other projects.
* Replacing submenu text with full path as 'Ctrl-Enter' doesn't do anything. Also reducing the String of CreateOpenCurrentResult to fit in one line.
* - Making Open Directory subtitle fixed, and the title as the current directory.
* Adding back binding to QueryText and updating the cursor position similar to how wox originally did it.
* Add the folder plugin wxs back in (#2374)
* Deduping results for program plugin (#2375)
* Removing description from title
* adjusting subtitle
* removing accidently paste
* removing desc for uwp apps
* Getting dups removed from list if LNK exists
* adjusting subtitle
* removing accidently paste
* Getting dups removed from list if LNK exists
* changed to normal forloop
* Removing WinR (#2381)
* Updated program execution to call action on background thread. (#2370)
* PowerLauncher Settings integration
* Added cold start fix (#2385)
* - Fixes cursor jumping around issue.
- Seperating the ability to set the text from initiating a query.
- Plugins have to explicitly request the query be updated.
- Updating Folder plugin to explicty update the query on folder selection.
- Removing unused changes from 'Wox' that don't compile.
* Fixing gap in logic where query was triggering when programatically setting text.
Updating the binding and settext both will trigger the TextChanged event on a seperate event dispatcher. For this reason we dynamically detect which eventhandler is most approapriate on the textchanging event.
* Updating the QueryText to the selected item when navigating up/down with the arrow keys.
* Removing action on folder result, and displaying folder path on selecting a folder result from the folder plugin.
* Making folder results from the search indexer plugin behave like folder results from folder plugin.
* Folder Results open the explorer window when selected.
* The Open Current Folder result shouldn't change the query text to 'Open {folder path}' when selecting the results.
* Initializing query text strings.
* Defensive check for QueryText being empty
* Adding file watchers for UWP detecting when apps are installed or deleted and reindexing the uwp apps
* Removing unused namespace.
* Looking at files and not filtering is better because the timer is more likely to reset while an install is happening, preventing uneeded indexing
* Fix project references
* Fix MaxResultsToShow
* Fix Alt + Space display
* Fix settings defaults
Co-authored-by: Alekhya Reddy Kommuru <reddykalekhya@gmail.com>
Co-authored-by: bkudiess <bakudies@microsoft.com>
Co-authored-by: Divyansh <somm14divi@gmail.com>
Co-authored-by: ryanbodrug-microsoft <56318517+ryanbodrug-microsoft@users.noreply.github.com>
Co-authored-by: Barbara Kudiess <bkudiess@me.com>
Co-authored-by: Jeremy Wu <jeremy24wu@gmail.com>
Co-authored-by: Clint Rutkas <clint@rutkas.com>
Co-authored-by: udit3333 <udit3333@gmail.com>
Co-authored-by: Betsegaw (Beta) Tadele <betsegaw.ta@gmail.com>
Co-authored-by: PrzemyslawTusinski <61138537+PrzemyslawTusinski@users.noreply.github.com>
Co-authored-by: Ben Randall <veleek@gmail.com>
Co-authored-by: vldmr11080 <57061786+vldmr11080@users.noreply.github.com>
Co-authored-by: eduardodextil <55205162+eduardodextil@users.noreply.github.com>
Co-authored-by: Ebenezer Ewumi <ebenezer.ewumi@wsu.edu>
Co-authored-by: Nghia M. Luong <32159519+sqrlmn@users.noreply.github.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
Co-authored-by: Seraphima Zykova <zykovas91@gmail.com>
Co-authored-by: Ivan Stošić <ivan100sic@gmail.com>
* Fixed right margin
* Fixed issue where the background of the gridview would light up on pointerover.
* Fixed issue where application title/path run through command buttons. Centrally aligned image/icon.
* Updated the shadow so it looks more like a UWP ThemeShadow.
* Handled invalid input for single key remaps
* Added some functions
* Added better error message functions and finished warnings for edit keyboard
* Updated dropdown order of keys
* Added new warning template for shortcuts
* Added show warning on Apply code
* Removed old flyout code
* Fixed issue where tooltips were replaced on Apply
* Simplified == operator
Updating the binding and settext both will trigger the TextChanged event on a seperate event dispatcher. For this reason we dynamically detect which eventhandler is most approapriate on the textchanging event.
- Seperating the ability to set the text from initiating a query.
- Plugins have to explicitly request the query be updated.
- Updating Folder plugin to explicty update the query on folder selection.
- Removing unused changes from 'Wox' that don't compile.
* Removing description from title
* adjusting subtitle
* removing accidently paste
* removing desc for uwp apps
* Getting dups removed from list if LNK exists
* adjusting subtitle
* removing accidently paste
* Getting dups removed from list if LNK exists
* changed to normal forloop
* Deprecate ATL based IPC wrapper library
* C# projects now use named pipe server implementations from two_way_pipe_message
through the interop C++/Cli library.
* Added Unit testing to interop library
* Added grid to edit keyboard
* Fixed all issues for Edit keyboard window with grid
* Added step to delete row definition and move row indices
* Handled grid operations for Edit Shortcuts
* Added dynamic layout for edit shortcuts
* Fixed resize windows message behaviour and removed warnings
* Added missing c++17 compile flag to common-md-flag
* Remove .NET native tool chain from Settings.UI release config
* This flag has to be removed because .Net Native does not support
mixed assemblies, like PowerToysInterop.
* Compare window desktop id with currently active work area desktop id.
* Improve error handling and conform to coding guidelines.
* Move virtual desktop helper functions to ZoneWindowUtils namespace.
* Ensure thread safety when creating instance of VirtualDesktopManager.
* Remove static qualifier from ServiceProvider.
* Return instead of break, as there is no need to check for other monitors, virtual desktop is the same for all.
* Move virtual desktop related helper functions to separate files.
* Skip comparing desktop ids if zone window has empty GUID for desktop id.
* Add comment describion scenario for which we need this fix.
* Fix HotkeyControl virtual key display
* A new interop project was setup to provide wrappers for C# projects
that want to access functionality in the common project.
* Add assembly info
* Remove WIN32 configurations
* Remove Autosuggest box (#2192)
* Update Settings.Designer.cs
* Revert "Update Settings.Designer.cs"
This reverts commit a1bc0dda56.
* Updated LauncherControl XAML to add textbox and listview
* List View displayed
* Hooking up execution on the selected index, removing two way binding on selection, and experimenting with popup that doesn't work
* Updated MainViewModel to Remove context menu and history
* Added Resultist XAML Island project
* Updated SelectedItem and SelectedList Binding.
Issues : List box doesn't open when query is written for first time but opens in subsequent queries.
* 1. Mouse Click working
2. List View is can't be focused
3. Fixed width of Launcher
* Removed two way QueryText box binding
* Removed SelectedItem two way binding and replaced with a callback
* [Cleaning] Remove redundant UWP project
* [Cleaning] Updated files to keep only atomic changes against dev/powerLauncher
* Thmbnail fixed for NEW UI
* Removed PreviewMouseDown function required by older WOX code
Co-authored-by: ryanbodrug-microsoft <56318517+ryanbodrug-microsoft@users.noreply.github.com>
* Added the auto-complete feature
* Removing ContextMenuPluginInfo, and ContextMenuTopMost as these commands are not used int the new design.
* Fixed merge conflicts
* Set only when index is 0
* One way binding
* Removed unnecessary binding
* Deleting unused (commented out code) that was legacy from wox project.
* Binding Buttons to appropriate context menu commands.
1. Buttons are dynamically loaded in a listview based on the actions supported be each plugin.
This change also deletes unused commands.
Note: Most button events don't seem to be getting routed to the Selected Item. Currently using 'PointerEntered' to validate the behavior. The actions should be trigged by the button command property in the future.
* manually handling tab in mainwindow
* Loading context buttons on Selecting a suggestion list item
* Allowing hover event to load content menu items and display them as well.
* Adding context buttons to Indexer plugin. This allows for the following:
1. [Files] Open Containing folder
2. [Folders/Files] Copy Path
* Remove White background of list (#2218)
* Remove white background of list
* Removed comments
* Changed to ContainerContentChanging event
* add const variables instead of numbers
* Added comment before the updatelistSize function
* Search box UI (#2224)
* Added backdrop and rounded corner
* Fix for two alt+space press to bring searchbox issue
* Fixed merge conflict
* Clean Mainwindow.xaml code
* Fix for textbox focus on first visible
* Allowing users to tab between the context buttons for the selected resut. Also allowing users to press 'enter' to action on the selected items.
* Renaming SelectedIndex to ContextMenuSelectedIndex
* Enabling key accelerators on context buttons.
1. Add new object ContextMenuResult instead instead of reusing Result for both query results and context menu results.
2. Binding KeyboardAccelerator keys to contextmenuitemviewmodel
3. Enabling and disabling contextmenu items when selecting or deselecting each row. Because we are manually maintaining selectionwe can't use ScopeOwners as the textbox is really the only item ever in focus.
* Launching explorer instead of the UWP application when selecting 'open file location'.
* Added fix for border showing up when result count is zero
* Updated fix for border on no result
* Adding visibility after clearing result in MainViewmodel
* Launcher Light/Dark mode (#2235)
* Fixed issue with list view background not updating with Windows theme change
* Added theme change for WPF
* updated ShadowDepth for dropshadow
* Updated border thicknes of searchbox and listview
* Diff issue with ResultList.xaml
* Removed change in result delay
* Added code to pull colors from UWP
* Updated border resource to use system based SystemControlHighlightAccentBrush
* Updated corner radius in dark mode
* Updated Launcher description text
Co-authored-by: ryanbodrug-microsoft <56318517+ryanbodrug-microsoft@users.noreply.github.com>
Co-authored-by: Alekhya Reddy <reddykalekhya@gmail.com>
* Dpi unaware placement bug (#2121)
Fix for bug when placing dpi unaware window such as Notepad++ in left of right part of monitor. In that application gap of about 7px was left or right.
This fixes only single-monitor scenario
It skips correction for dpi unaware window that leaves a gap
* Move markdown parsing logic outside control thread (#2099)
* Move markdown parsing logic outside control thread
* Update MarkdownPreviewHandlerControl.cs
* Remove trailing whitespace.
That'll teach me for trying to make an edit from the GitHub page.
* Migrate power rename MRU lists from registry to JSON (#2090)
* Handle most recently used search/replace strings within settings.
* Check for last modified time of json file and reload it if needed.
* Handle changes in MRU search / replace lists size.
* Improve handling of changes in MRU list size.
* Don't check for last modified time in every getter method. Load only when starting application.
* Add const identifier to getter methods.
* Address PR comments: Add const to reg and json file paths and set them in constructor initializer. Check pushIdx validity. Move implementation to cpp of PowerRenameUI constructor.
* Add error checking when getting values from registry.
* Implementing changes suggested in #1992 (#2116)
* Implementing changes suggested in #1992
* Update Product.wxs
Co-authored-by: Ebenezer Ewumi <ebenezer.ewumi@wsu.edu>
* Fix for issue #1532 - [PowerToys tray icon] Show version on tooltip (#2117)
* Fix for issue #1532
[PowerToys] Show version on tooltip
* Update src/runner/tray_icon.cpp
Co-Authored-By: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
* FZ editor: Splitted zones positioning (#2158)
* Added a mutex to ZoneWindow, ensured no data races occur (#2154)
* Added a mutex to ZoneWindow, ensured no data races occur
* Protected draggedWindow* members with a mutex
* Ensured that critical reads happen in a single transaction
* Dpi unaware placement bug - multimontior with same DPI settings fix (#2156)
* Dpi unaware placement bug - multimontior with same DPI settings fix
* Using different enumerating method
* Changed AllMonitorHaveSameDpiScaling method
* Removed accidental file
* small rename
* Changed some methods to CamelCase
* Review comments fixes
Co-authored-by: PrzemyslawTusinski <61138537+PrzemyslawTusinski@users.noreply.github.com>
Co-authored-by: Ben Randall <veleek@gmail.com>
Co-authored-by: vldmr11080 <57061786+vldmr11080@users.noreply.github.com>
Co-authored-by: eduardodextil <55205162+eduardodextil@users.noreply.github.com>
Co-authored-by: Ebenezer Ewumi <ebenezer.ewumi@wsu.edu>
Co-authored-by: Nghia M. Luong <32159519+sqrlmn@users.noreply.github.com>
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
Co-authored-by: Seraphima Zykova <zykovas91@gmail.com>
Co-authored-by: Ivan Stošić <ivan100sic@gmail.com>
* Fixed typo in output folder of calculator plugin
* Calculator plugin works
* Modified the name of the image to remove space as space is assumed to be a separator in wcx file
* Fixed typo in calculator dll
* Fixed typo in calculator plugin
* Shell, Program, Folde and indexer plugin working
* Added the ww plugin
* Fixed typos in the calculator plugin
* Delete file that was added unintentionally
* revert calculator rename changes
* Reverted other files changed
* Reverted renaming of file with space
* Added a mutex to ZoneWindow, ensured no data races occur
* Protected draggedWindow* members with a mutex
* Ensured that critical reads happen in a single transaction
* Added combobox
* Formatted and removed unused code
* Added drop down support for Edit Keyboard window
* Reordered the displayed key list
* Add shortcut stack panels and drop downs linked to detect shortcut
* Add more selected item logic
* Added complete dropdown support for edit shortcuts window
* Added Flyout warning for incorrect drop down input
* Tweaked warnings
* Removed MainWindow code
* Changed SelectedValue toSelectedIndex
* Removed unnecessary assignments
* Added a warning for two dropdowns and the first one is changed to an action key
* Added function comments in cpp file
* Fixed some comments
* Fixed all allocation and out of scope issues
* Fix most issues except reloading shortcuts
* Fixed issue while reloading shortcuts
* Fixed type cast warnings
* Changed delete to delete[]
* tweaked
* Copy the existing calc. plugin foldeR
* Blindly rename a bunch of things to Window Walker
* Update the solution to reference the new plugin
* Get basic Yo returned
* Remove all the languages except english
* Lower quality of icon as well as test showing it
* Add the core non-ui parts to the plugin
* Delete calculator png
* Get it to compile
* Added the actual code which apparently doesn't work
* Finally start showing results
* Fix up strings
* Switch working
* Remove unused classes
* Remove unneeded async
* Added Tests and Refactored code
* removed un-used file
* delete test files when test completes
* removed extra build configs
* added clean-up method
* removed unused variable
* re-added removed attributtion
* added error handling and move strings to string resource
* added error handling to file explorer view model
* moved varible assignment to if statement block
* removed savin of settings file from the UI
* re-added open source notice
* added missing controls for powerrename and fancy zones
* removed dead coded
* remove un-used configuration
* added error handling for file saving and updated powerreanme constructor
* removed added configurations
* added settings state
* Replace WPF Imaging library with UWP
* Removed UWP and WPF namespace conflicting files from Wox
* Removed Image hashing as it wasn't used anywhere
* Updated formatting
* Handle most recently used search/replace strings within settings.
* Check for last modified time of json file and reload it if needed.
* Handle changes in MRU search / replace lists size.
* Improve handling of changes in MRU list size.
* Don't check for last modified time in every getter method. Load only when starting application.
* Add const identifier to getter methods.
* Address PR comments: Add const to reg and json file paths and set them in constructor initializer. Check pushIdx validity. Move implementation to cpp of PowerRenameUI constructor.
* Add error checking when getting values from registry.
* Move markdown parsing logic outside control thread
* Update MarkdownPreviewHandlerControl.cs
* Remove trailing whitespace.
That'll teach me for trying to make an edit from the GitHub page.
Fix for bug when placing dpi unaware window such as Notepad++ in left of right part of monitor. In that application gap of about 7px was left or right.
This fixes only single-monitor scenario
It skips correction for dpi unaware window that leaves a gap
* Added CustomAction Data Models
* Updated data model
* Updated Button command trigger for keyboard manager
* Integerated custom actions in Keyboard manager module backend
* Allow Runner to launch windows on foreground
* Refactor and moved the execution logic to background thread
* Removed non-required unlock calls
* Fixed typo
* Resolve PR comments
* updating a ton of warnings.
* bunch of cleanup
* few smaller ones
* fixed naming
* reversing an oops
* adjusting json to use attribute
* more json properties
* Refactor a method which resizes windows
* Completed initial work for MultiZones
Without changing any test, they all pass!
* Implemented a basic version of Multizones, updated some tests
* Reduced the sensitivity radius
* Added a few must-have unit tests for Multizones
* Some fixups
* Took care of the conflict between this and #1938
* Improved how zones are detected, reverted a change in one unit test
* Resolved another merge conflict
* Fixed bugs related to stamping
* first set of warning fixes
* Since this is a Interop item, it should have a _
* Update Window.cs
* Update InteropAndHelpers.cs
looks like there was a space a the top
* Update Window.cs
* Added unique lock mutexes for thread safety
* Fixed a bug in detect key logic
* Changed dword to word
* Added early unlock statements to fix issue with shortcut guide
* Fixed type conversion warnings
* Migrated detect shortcut window to use Shortcut class
* made changes in Apply button logic
* Revert thread safety changes
* refactored code works on the UI side
* Refactored remapping code to use new Shortcut class
* Refactored to SetKeyEvent function
* Moved function to cpp file and added more comments
* Refactored map variable and handled common Win key
* Remove debug code
* Change arguments to const references
* Added unique lock mutexes for thread safety
* Fixed a bug in detect key logic
* Added early unlock statements to fix issue with shortcut guide
* Added comments for unlocks before SendInput and changed some unique_locks to lock_guards
* Added check keyboard state function
* Added keyboard state check to avoid n-key shortcuts being affected by 2 key shortcuts
* Added support for n key shortcuts in backend and UI
* Added a fix to ensure mouse buttons states are not checked
* reverted some debugging changes
* reverted some debugging changes
* Added EditShortcuts Window and added Detecting shortcuts functionality
* Fixed build error
* Changed detection to take place only when window is in focus
* Added solution folder
* Added a common project and refactored shared variables to an object with wrapper functions
* Added dynamic addition of shortcuts
* Moved all shared variables in detection to state variable with wrapper functions
* Added code to re-load saved shortcuts in the UI
* Added comments
* Fixed argument modifiers in Helpers
* Updated arg modifiers in all functions
* Removed unused headers and added precompiled headers
* Created PowerKeys project
* Swapping tab with shift
* Added hash map and iterators for remapping code
* Added PowerKeys flag and added toggletomod function
* Added shortcut base code
* Fixed os level shortcut functionality
* Added 1 extra event
* Added check for same modifier and comments
* Added app-specific remapping for 4 apps including UWP apps
* Changed foreground window logic
* Added a separate hook for PowerKeys which can be re-hooked by enabling and disabling
* Added a separate hook for PowerKeys which can be re-hooked by enabling and disabling
* Fixed all priority issues and changed injection flags
* Added another msedge.exe shortcut
* Added a UI which is linked to the backend hook
* Cleaned code and added comments
* Added second button
* Renamed some files/variables and added an extra button
* Use JSON data file for storing PowerRename settings instead of registry
* Address PR comments and made several improvements
* Remove WindowsApp.lib dependencies in test app and unit tests
* Revert changes in vcxproj for unit test
* Solve linker warnings generated while linking WindowsApp.lib
* Don't migrate enabled flag. Always read / write from registry.
This was needed while we were migratin device-info so
active layout could be migrated as well. At some point
we dropped migration of device-info. Therefore, this has no
puprose anymore.
* Improved styling so it looks more Fluent and native to W10
* CanvasZone border is now using the active accent color
* Updated GridZone to a similiar Fluent styling as the CanvasZone. Added a mouseover state to the GridResizer.
* Better app listing like Alt-Tab supports UWP apps and hidden apps running in another virtual desktop just like Windows Alt-Tab
* Modified not to hide cloaked apps i.e. also show apps running in another virtual desktop
* Improved listing apps, with readability and reusable abstract properties.
Including a function to detect cloaked UWP apps for future use.
* added power preview settings
* Added link to module oververview
* create settings file if one is not found
* removed run oon start up speficic callback
* Update src/core/Microsoft.PowerToys.Settings.UI.Lib/ModuleSettings.cs
Co-Authored-By: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
* fixed merge conflicts
Co-authored-by: Andrey Nekrasov <yuyoyuppe@users.noreply.github.com>
* archive
* formmated code
* reverted changes to test class file.
* reverted changes to test file: reverted name
* added class models and updated link
* removed test console project
* Enable Unit tests for PreviewPane Test Assemblies in CI
* Added Preview handlers unit tests project back
* throw for Svg to debug tests
* Removed failing test
* Removed throw statement
* Added MD unitests in yml
* Run ui tests on STA thread
* Throw svg to debug failing tests
* Updated test adaptor
* Removed failing test to validate CI
* throw svg failing test with full stack trace
* Check if mock stream is causing the issue
* narrow down the failing tests code - 1
* narrow down the failing tests code -2
* dispose all controls
* Restore SVg preview control
* Update test adaptor and dependency to latest
* #1821 Support device names with underscores (such as 'Default_Monitor') in JSONHelpers.isValidDeviceId
* Make support for '#' in device names optional
* Add more unit tests for isValidDeviceId
* Updated readme
* Updated readme for file explorer module and demo gif
* Updated figure description
* Fixed typo
* Moved the localizaton instruction to separate file
* Updated coding guidance readme
* initial doc work
* rename file to match current naming, got images working
* adjusting the "keep us functioning" section sooner
* Update run-as-admin-detection.md
* Fix for issue #1218
Design Change: Default Enter Action
* Fix for issue #1085
* change zone's number color and font
remove the light blue background
* Fix for disappearing zone number in editor
* Grid layout reversed order fix
Co-authored-by: sqrlmn <sqrlmn@users.noreply.github.com>
Co-authored-by: Enrico Giordani <enrico.giordani@gmail.com>
* Updated Parsing extension to show infobar when relative URL isblocked and updated corresponding tests
* Updated Controller to display infobar when html img tag is embedded in markdown
* Fancy zones ui update (#4)
* Draft of numeric fancyzones with numbers
* Added support for zone color configuration, improved zone number display
* Changed order of settings to more logical
* Added option to edit zone border color
* Trancparency of dragged window, transparency of displayed zones, changed font of zone numbers
* Fix for compilation
* Some refactor
* Introduced gdiplus to draw zone and zone index
* Fix for dissappering windows
* Some fixes
* another merge fix
* another merge fix
* Unit test merge fix
* Transparency with show zones on all fix
* indentation fix
* Fix for failing test
* Changed order of color pickers
* "Zone Opacity"
* Zone opacity (%)
* Added option to turn off dragged window transparency, changed default zones color values
* When moving window into zones using arrow keys, support multi-monitor scenario
* Minor coding style adjustments
* Split implementation into separate functions because of readability
* Rename certain arguments
* Modify unit tests after API changes
* Address PR comments and add unit tests
* Return true from MoveWindowIntoZoneByDirection only if window is successfully added to new zone
* Improved monitor ordering (#1)
* Implemented improved monitor ordering v1
* Fixed some embarrassing bugs, added some tests
* Added one more test
* Extracted a value to a variable
* ASCII art in unit test comments describing monitor layouts
* Removed empty line for consistency
* Update comment to match the code
* Refactored tests, added tests for X,Y offsets
Co-authored-by: Ivan Stošić <ivan100sic@gmail.com>
* Fixed rc file settings description string
* Added moved settings verbiage
* Updated Image Resizer readme
* Fixed section link
* minor changes to readme
* Fixed extra space
* Updated figures to markdown
* removed html center and img tags
* sln: set output dir prefix to "modules\" for all modules
* sln: CopyToOutputDirectory only when necessary
* sln: intermediate dir for csprojs
* sln: intermediate dir for vcxprojs
* sln: add PT as runner project deps + remove nonexisting project confs
* sln: remove AnyCPU for win-app-driver project
* editor opening tests
* moved fancy zones opening method
* moved settings restore to base class
* changed launch
* fixed tray button search
* added exit function
* Implemented proper canceling for CanvasEditor
* Implemented proper canceling for GridEditor
* Possible fix for a crash in my implementation of canceling
* Fixed a crash in FZE/Grid editor
* Fixed issue with autostarting as admin even if it should as user, fixed permissions issue for autostart configuration
* Indentation fix
* Added support for all cases of autostart task modifying
* Fix for compilation
* Commented out failing unit tests and changed the output directory of unit tests project
* Enabled Assembly redirect
* removed SvgPreviewHandlerUnitTests and PreviewPaneCommonUnitTests from the solution
* Removed the commented code project itself is removed from sln
* Import Image Resizer for Windows
* getting code analysis and stylecop hooked in
* upgrading to 4.7.2
* adding copyright
* getting stuff to work
headers and trailing commas
adding braces
updated encoder
* Revert "getting stuff to work"
This reverts commit 5310866120.
* update to .net 4.7.2
* access modifier
* zero errors
* Fixed unit tests not running issue
* Fixed ImageResizer.Test stylecop warning
* Formatted ShellExtensions project with clang-format
* Fixed annotation warnings
* Suppressed 6031 and 26812 warnings for specific lines
* Shifting ImageResizer projects to PowerToys solution (#1054)
* Shifted ImageResizer projects to PowerToys solution: Builds, all tests pass, ImageResizer C# project works independently
* Deleted extra files
* Deleted nuget config file and fixed code analysis paths
* Convert ImageResizer to a PowerToy (#1073)
* Updated vcxproj file with common project references and cpp version flags
* Added module template code to dllmain and updated headers for successful build
* Removed unnecessary include
* Added dll to runner and add fixes to show up in PT Settings
* Added settings file
* Added support for enabling/disabling based on PowerRename codebase
* Fixed missing braces
* Fixed call_custom_action
* Add ImageResizer to msi installer (dev/imageResizer) (#1094)
* Updated vcxproj file with common project references and cpp version flags
* Added module template code to dllmain and updated headers for successful build
* Removed unnecessary include
* Added dll to runner and add fixes to show up in PT Settings
* Added settings file
* Added support for enabling/disabling based on PowerRename codebase
* Fixed solution file configurations
* Removed Any CPU from ImageResizer csprojs
* Renamed registry writing and removed build time registry addition
* Added ImageResizer installation details to msi
* Fixed comment on conditions to close explorer.exe
* Sync dev/imageResizer with master (#1105)
* tweaking language
* adjusting elevated permission verbiage to match Windows
* npm audit fix to update stuff
* slight bump for fabric ui
* Remove unwanted files (#1037)
Add temp build files to gitignore
* Ensure previous search and replace texts are evaluated and updated in the UI at startup (#1043)
Ensure stored settings get evaluated after initial enumeration
There was a bug where the list view was not getting updated with the results of the search and replace on launch when we are using a stored search or replace text from a previous session.
* adding fancy zone opacity setting, enhancement #631 (#1008)
* adding fancy zone opacity setting, enhancement #631
* applying zone opacity setting to all zones during zone selection
* changing opacity setting to percentage
* runner: show message box when restarting with different elevation fails (#1061)
Also make the message box appear on top of the settings window.
* Fix misaligned display of zones in layout priview and grid editor (#1010)
Fix misaligned display of zones in layout preview and grid editor
* MSIX: Extract MSIX building functionality from msix_reinstall.ps1 to a separate script (#1068)
* MSIX: label PowerToys as Preview (#1090)
* MSIX: Code sign msixbundle (#1093)
* Update to MSIX README.md (#1095)
* Update README.md
few adjustments
* Update README.md
* Update README.md
* adding in privacy statement, removing About in dialog (#1087)
* adding in privacy statement, removing About in dialog
* added Preview
* Revert "Fix misaligned display of zones in layout priview and grid editor (#1010)" (#1097)
This reverts commit d03690cffd.
* Fix reversed order of zones in layout (#1071)
* Shifted three functions to common (#1101)
Co-authored-by: Clint Rutkas <clint@rutkas.com>
Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>
Co-authored-by: Chris Davis <chrisdavis@outlook.com>
Co-authored-by: Yosef Durr <yodurr@microsoft.com>
Co-authored-by: Bartosz Sosnowski <bzoz@users.noreply.github.com>
Co-authored-by: vldmr11080 <57061786+vldmr11080@users.noreply.github.com>
Co-authored-by: yuyoyuppe <yuyoyuppe@users.noreply.github.com>
* Revert "Sync dev/imageResizer with master (#1105)"
This reverts commit db7f15541f.
* Added icon to Resize pictures context menu entry (dev/imageResizer) (#1113)
* Updated vcxproj file with common project references and cpp version flags
* Added module template code to dllmain and updated headers for successful build
* Removed unnecessary include
* Added dll to runner and add fixes to show up in PT Settings
* Added settings file
* Added support for enabling/disabling based on PowerRename codebase
* Fixed solution file configurations
* Removed Any CPU from ImageResizer csprojs
* Renamed registry writing and removed build time registry addition
* Added ImageResizer installation details to msi
* Shifted to MII, TODO: Fix position
* Incorporated ImageResizer Icon in context menu entry
* Fixed typo
* Merged with dev/imageResizer
* Renamed Advanced Options to Settings and removed About tab (dev/imageResizer) (#1123)
* Removed about tab, renamed advanced opt to settings, changed assembly info
* Restored Resource designer file
* Reverted changes on AssemblyInfo
* MSI: Fix ImageResizer menu item position (dev/imageResizer) (#1114)
* Updated vcxproj file with common project references and cpp version flags
* Added module template code to dllmain and updated headers for successful build
* Removed unnecessary include
* Added dll to runner and add fixes to show up in PT Settings
* Added settings file
* Added support for enabling/disabling based on PowerRename codebase
* Fixed solution file configurations
* Removed Any CPU from ImageResizer csprojs
* Renamed registry writing and removed build time registry addition
* Added ImageResizer installation details to msi
* Shifted to MII, TODO: Fix position
* Incorporated ImageResizer Icon in context menu entry
* Changed registry entries to SystemFileAssociations and added index changes in InsertMenuItem
* Fixed extra newline
* Fixed merge conflict
* Refactor ImageResizer code base naming to match PowerRename (#1121)
* Created empty README file
* Renamed dll project
* Removed ShellExtensions references in src
* Fixed ImageResizerUI assembly name and added changes to MSI
* added the helper functions
* localized dllmain powerrename
* localized powerRenameExt
* localized the settings file
* built the proj
* Modified resourceIDs for strings in the table
* added common as a reference project
* Removed get_res_string_wchar and used the get_resource_string() function instead which returns a wstring typecast into wchar*
* Added new lines to the end of the file
* Removed string resources from the settings.cpp file
* rebuilt project PowerRename
* moved app name to constructor to init only once
* updated formatting of common.cpp
* reverting formatting of files
* Removed some IDs from resource file. Changed SHIFT to Shift
* Localizing C# Project of FancyZones (FancyZonesEditor) (#199) (#1122)
* removed hardcoded strings from CanvasEditorWindow.xaml
* removed hardcoded strings from GridEditorWindow.xaml
* loc
* Localized MainWindow
* reverting MainWindow.xaml as it is not rendering the window as expected
* Changed the resource settings from internal to public
* the culture is set based on the culture of the system UI set in the system settings
* Removed the french resource files used for testing
* Localized canvasWindow and mainwindow
* Removed setting the UI culture explicitly as it would be implicitly set to the culture of system UI
* Removed redundant header file
* Localize the Shortcut guide PowerToy (#199) (#1126)
* Localized shortcut_guide.cpp
* localized overlay_window.cpp
* formatting changes
* Localize overlay window
* removed the README link from the set of localized resources
* Typo: changed upper to lower
* Localize C++ Projects of FancyZones (#1130)
* localized dllmain.cpp of fancyzones project
* localized FancyZones.cpp
* format fancyzones.rc file
* Moved SuperFancyZones back to being a string instead of having it in the resource file as it is the window class name
* reverted changes for window name
* Formatted fancyzones rc file
* Align zone dimensions from layout preview with those from grid editor (#1115)
* MSIX: add a dedicated .rc for UWPUI which joins both UI and DLL .rc's (#1139)
* Runner: fix restarting with same elevation (#1133)
* MSIX: reinstall script uses bundle instead of .msi to be able to reinstall in all cases
* Telemetry: add WebView init failure errors
* Settings: initialize COM security to allow communication between elevated Settings and WebView
* Common: implement on_scope_exit helper and typed_storage
* Changes for #1140 and #569 (#1152)
* MSIX build instructions adjustmnet (#1170)
* MSIX: hide the "Run at Startup" option if running as packaged
* MSIX: update identity name and publisher (#1176)
* Runner: fix startup task state setting for MSIX (#1181)
* Add ImageResizer to MSIX installer and make the code MSIX-compatible (#1219)
* Removed ImageResizer.exe location registry key
* Added working resize pictures to MSIX context menu without icon
* Fixed missing icon on MSIX build
* Added comments
* Changed to single context handler entry
* Made changes as per PR comments
* Localize ImageResizer (#1261)
* Removed hardcoded strings
* Added resource dlls to MSIX installer
* Save ImageResizer settings in JSON format (#1258)
* Combined settings files
* Added JSON settings functionality in PowerToys format with thread safety
* Reverting changes to csproj file
* Removed settings.settings and designer file and added target sdk tools to fix warning
* Added NewtonSoft Json package
* Added 3 tests
* Added propertychanged test
* Removed unused libraries
* Removed additional allocation statements in test
* Added comments on test
* Added one-time setup code
* Added Newtonsoft.Json.dll to MSI and MSIX installer
* Fixed copyright header
* Fixed folder location in MSIX
* Renamed jsonMutex to _jsonMutex
* Fixed line endings
* Created private setup functions and added Arrange, Act, Assert comments
* Created private setup functions and added Arrange, Act, Assert comments
* Suppressed copyright warning on AppFixture and enabled treat warnings as errors
* Added comments on Reload/AppFixture and added constructor andispose
* Added telemetry to ImageResizer Shell Extension code (dev/imageResizer) (#1272)
* Added telemetry to C++ ImageResizerExt
* Added Register and unregister calls
* Changed default enable setting
* Set startup location to center of the screen (ImageResizer) (#1452)
* Added ImageResizer resources.dlls to the MSI installer (#1448)
* Implemented fix for foreground issue for ImageResizer (#1434)
* Fixed conflict in installer README.md file
* Fixed conflict in bundle.js
* Auto-generate AssemblyInfo in ImageResizer (#1467)
* Updated assembly info
* Added auto-generation of AssemblyInfo.cs
* Fixed minor issues
* Remove the License file since Notice.md have been added
* Fix errors due to resolving merge conflicts
Co-authored-by: Brice Lambson <brice@bricelam.net>
Co-authored-by: Clint Rutkas <clint@rutkas.com>
Co-authored-by: Arjun Balgovind <arbalgov@microsoft.com>
Co-authored-by: Enrico Giordani <enricogior@users.noreply.github.com>
Co-authored-by: Chris Davis <chrisdavis@outlook.com>
Co-authored-by: Yosef Durr <yodurr@microsoft.com>
Co-authored-by: Bartosz Sosnowski <bzoz@users.noreply.github.com>
Co-authored-by: vldmr11080 <57061786+vldmr11080@users.noreply.github.com>
Co-authored-by: yuyoyuppe <yuyoyuppe@users.noreply.github.com>
Co-authored-by: Alekhya Kommuru <alkommur@microsoft.com>
Co-authored-by: Alekhya <reddykalekhya@gmail.com>
Co-authored-by: yuyoyuppe <a.yuyoyuppe@gmail.com>
Co-authored-by: Udit Singh <udsing@microsoft.com>
* Added project template for common library
* Added reference to stylecop.json
* Fixed xml documetation file path for common project
* Added reference to stylecop.json
* Added COM interface interpolations to C#
* Changed namespace to Common
* Added xml doc to com interfaces
* Removed AnyCPU configuration from solution file
* Added Preview Hander and form User Control Implementation
* Fix stylecop warnings
* Added test control and handler
* Added Xaml description for preview handler
* Added Xml documenatation
* Updated the control to form
* Added registration and unregistration logic for the handler
* Moved the files in separate folder and fix PR comments
* updated the name of previewhandler class to base class
* Added the DoPreview to PreviewHandlerControl Interface
* Modified the Dopreview and Unload as virtual method
* Uncommented the DocumentText to help bug repro
* HTML Parsing Extension for preview pane markdown renderer (#1108)
* Added Extension for html post processing
* Added unit test poroject for preview pane
* Added pipline test and base test function
* Added Tests for extension
* Added tests for url slashes
* Added tests for url and figure caption
* Markdown preview pane (#1128)
* Added Extension for html post processing
* Added unit test poroject for preview pane
* Added pipline test and base test function
* Added Tests for extension
* Added handler and control for markdown
* Tests added
* Locally working version for markdown
* Working image relative url's in markdown
* Added CSS to preview display
* Updates CSS for code block
* Removed html file write comment in markdown control
* Updated assembly version and web browser control test
* Add Svg preview handler (#1129)
* Added a new project for Svg preview handler
* Added initial implementation of Svg Preview Handler
* Fixed output path
* Added Unit Test Project
* Added StreamWrapper and Update Svg Control
* Updated Svg Handler Guid
* Removed migration backup folder
* Removed Fluent Assertions NuGet
* Added Comments for StreamWrapper
* Removed the manual GC collect
* Added unit tests for Svg preview Handler
* Updated the xml doc for stream wrapper
* User/lamotile/add_powerpreviewsettings (#1075)
* Added powersettings to PowerToys Settings UI
* added settings library
* updated settings-web
* updated project oncfiguration
* updated project onfiguration
* updated project .sln file
* removed .etl file and added it to git-ignore
* separated the PowerPreviewModule into split classes .cpp and .h
* moved PowerPreviewModule implemnetations to .cpp file
* fixed StringTable formatter
* fixed spacing in resource.h
* added m_ to member varibales
* initiliaze m_isPreviewEnabled in the base class
* removed duplication of objects by using pass by refference and std::move
* made the getters const
* updated naming convention
* Split test calsses
* Add const string
* Replaced move with const string
* Made attributes private
* Made attributes private
* removed unused constructor
* Update resource.h
formatted resource.h
* Adding unit tests for preview handler common (#1156)
* Changed the name of the Common library to PreviewHandlerCommon
* Added unit tests project for PreviewHandlerCommon
* Updated ComInterop accessor type
* Added unit tests for PreviewHandlerbase
* Added tests for file and stream based handler
* Added unit tests for StreamWrapper
* Added form handler unit tests
* Added Unit tests for FormHandlerControl
* Added file header
* Add Powerpreview project
* Add spacing in sln file
* swapped string refferences (#1199)
* added registry methods and enable/disable preview handlers (#1230)
* added registry methods and enable/disable preview handlers
* formatted .rc file.
* formatted resource file
* formatted .rc file.
* formatted settings.cpp
* formatted settings.h
* formatted SVGPreviewSettingsClassTest.cpp
* Formatted MarkDownPreviewSettingsClassTest.cpp
* using wide strings
* formatted settings.h
* FileExplorerPreviewSettingsTest.cpp formatting
* fixed typo and formatting
* closing Registry and fixing typos
* formmarted code using ctrl+k+d
* fixed naming
* fixed typo
* changed if/else reverse order
* Markdown preview pane (#1220)
* Added rich text bar for information display
* Added infobar
* Added tests for extension and markdown control
* Added xml docstring for markdown preview handler control
* Updated assembly file for markdown preview pane
* Updated removal of script tag without modifying CSS
* Added info bar text string to resource file.
* Removed error with infobar display on first rendering
* Updated assembly version
* Remove script and image element from Svg (#1231)
* Added implementation to remove script and image tag
* Added Unit tests for SvgPreviewHandlerHelper
* Updated Unit tests for SvgPreviewControl
* Moved the hardcoded string to resource file
* Changed the LocalMachine to CurrentUser for preview handler registration
* Added unit tests for multiple blocked elements tags
* User/lamotile/update settings objects (#1263)
* added registry methods and enable/disable preview handlers
* formatted .rc file.
* formatted resource file
* formatted .rc file.
* formatted settings.cpp
* formatted settings.h
* formatted SVGPreviewSettingsClassTest.cpp
* Formatted MarkDownPreviewSettingsClassTest.cpp
* using wide strings
* formatted settings.h
* FileExplorerPreviewSettingsTest.cpp formatting
* fixed typo and formatting
* closing Registry and fixing typos
* formmarted code using ctrl+k+d
* fixed naming
* fixed typo
* changed if/else reverse order
* updated setiings_objects.cpp
* removed changes on files that are not part of this PR
* removed const ref on primative types
* updated pass by ref semantic and removed pas by reff on primative types
* fixed spaces in the commas
* fixed spaces in brackets
* Preview pane telemetry (#1299)
* Added telemetry base class and markdown telemetry class
* Updated docstring for telemetry event.
* Added telemetry to markdown for error
* Added try catch for markdown preview handler and display error bar
* Updated markdown telemetry to make event names global variable
* Updated parameter name to camel casing and telemetry event name naming.
* Corrected assembbly version for svg renderer
* Markdown Image files display (#1303)
* Added telemetry base class and markdown telemetry class
* Updated docstring for telemetry event.
* Added telemetry to markdown for error
* Added try catch for markdown preview handler and display error bar
* Updated markdown telemetry to make event names global variable
* Updated Markdown preview to display without vertical scrollbar and removed xml doc to html agility pack.
* Updated parameter name to camel casing and telemetry event name naming.
* Corrected assembbly version for svg renderer
* Removed duplicate function
* Add telemetry for Svg preview handler (#1314)
* Added telemetry events for Svg Preview Handler
* Added unit test in case preview handler throws
* Updated the Error event name
* Remove the not required return statement
* User/lamotile/add read me (#1332)
* add readme
* moved images
* re-added images'
* Fixed gramma
* Update figure number refference
* improve preview handler intergration (#1319)
* improve preview handler intergration
* Fixed typo
* updated typo
* updated enable() function
* updated is enabled()
* re-updated is enabled()
* added this-> key word
* (0.16) - Install preview handler with msix (#1339)
* Removed the registration logic from preview handlers
* Updated the output path
* Added logic to shim the activation of .net assembly
* Updated manifest file
* Fix the allowedsilenttakeover filed in manifest
* Updated the appxmanifest file
* Added AllowSilentDefaultTakeOver in manifest
* Fix returned error code by DllGetClassObject
* Moved the CLSID to a common header file
* Added info about where CLSID needs to be updated
* Added a .reg file for the Keys added in registry.dat
* Added comments for DllGetClassObject
* Svg Preview Handler block external component (#1368)
* Removed the registration logic from preview handlers
* Updated the output path
* Added logic to shim the activation of .net assembly
* Updated manifest file
* Fix the allowedsilenttakeover filed in manifest
* Updated the appxmanifest file
* Added AllowSilentDefaultTakeOver in manifest
* Fix returned error code by DllGetClassObject
* Moved the CLSID to a common header file
* Added info about where CLSID needs to be updated
* Added a .reg file for the Keys added in registry.dat
* Added comments for DllGetClassObject
* Extended WebBrowserSite for setting flags in DISPID_AMBIENT_DLCONTROL
* Added XML Documenatation
* Removed the logic for deleting image and script element from Svg
* Updated Unit Tests
* Updated typecast of uint
* Forwarded calls to Type.InvokeMember
* Resolve PR Comments
* Adding MSI Installation for Preview Handler (#1436)
* Updated wxs for including dll and registry keys for preview handlers
* Changed the casing for registry key
* Resolve PR Comments
* Added comments for File element
* Call GC on preview unloading (#1456)
* Call GC collect on preview unloading
* Added github issue link
* Update Web browser control for Markdown Previewer (#1464)
* Updated Webbrowser control
* Updated Unit tests
* Disabled Navigation for Svg Previewer
* Fix power preview unit tests (#1508)
* Decoupled registry interaction logic
* Updated File explorer settings
* Updated unit tests for PowerPreview Settings
* Added Asserrtion for Scope of registry key
* Updated the registry value to match with installation registry value
* Sync master settings.cpp
* Merge settings changes from PreviewHandlers
* Remove newline changes added into in example_powertoy\trace.cpp
* Chaned .net framework to 4.7.2
* Updated Csproj files to auto generate Assembly.info files
* Updated msi installer to use version variable for preview handlers assembly
* Removed the signing of Assembly and updated wxs to not include PublicKeyToken
* Updated the Path in Packaginglayout.xml to modules from Gac and the registry hive binary
* Regenerated updated JS and html file
* Resolve PR Comments
* Readded the wprp file
Co-authored-by: Divyansh <divyan@microsoft.com>
Co-authored-by: Divyansh <somm14divi@gmail.com>
Co-authored-by: Lavius Motileng <58791731+laviusmotileng-ms@users.noreply.github.com>
* Fixed a Grid editor issue
* Explained the fix in ExtendRangeToHaveEvenCellEdges
* Simplified code in ExtendRangeToHaveEvenCellEdges
* Removed redundant comment, more camelCase
* FancyZones editor magnetic snapping effect
Implemented a solution to Issue #585: FancyZones: Alignment/Snapping/Ruler
* Fixed VS complaining about names and access modifiers
* Removed reference to unused implementation of snapping in FZE
* Converted integer constants to enums in FZE/Canvas
* Convert a portion of code to a switch statement
* Improved code maintainability
* Fixed a screen resolution bug in FZE/Canvas
Fixed a bug where the editor doesn't respect the new screen resolution.
* Further maintainability improvements
* Fixed a compiler warning
* Changed some variables to camelCase
* Close input stream
Show MessageBox with exception message
Remove unused arguments
Guard all of the Editor input/output code parts and show MessageBox
with appropriate message and issue reporting link
* Extract showing messageBox into method
* Switch WindowWalker C# project to use PackageReference
* Remove packages.config leftovers
Co-authored-by: William Kent <wjk@users.noreply.github.com>
* installer: extract version number into separate file and use it where possible
* MSIX: rename package to include version on CDPx
* installer: generate assembly info for FZ editor
* MSIX: inject correct version to appxmanifest
* format_sources: exclude 3rd party sources
* format common project
* format leftovers in runner & settings projects
* move source formatting-related files according to #939
* Add handling of portable mode when updating
Additionally:
1. Changed getting version from internally rather than from RELEASES file
2. Added PortableDataPath as a constant so can be used to determine if portable mode is used
* Fix incorrectly wired auto update event handler
* Fix Sys plugin missing Shutdown command icon
* Add check update command to Sys plugin
* Add message if current Wox version is latest
* Add default silent when auto checking updates in background
Silent when current is still the latest version
* Move UserData folder to new version location
* Changes per review
1. Move IsPortableMode to Constant
2. Merge if statement
* Per comment- change variables to be more descriptive
UpdateInfo and UpdateManager renamed
* Per comment- Add exception handling and message if failed.
Uses FancyZones logic to test if window is zonable or not. Displays
window styles and results for various tests if the window should be
zonable or not.
* Introduce handling of new/old work areas (defined by virtual desktop id and monitor)
* Save data to JSON storage only once after we register all deleted virtual desktops
* Update saving mechanism
* Remove resolution from unique identifier
* Update comments related to new unique identifier
* Don't handle NULL GUID as it is default one
* Revert "Remove resolution from unique identifier"
This reverts commit 5a36651217.
* Revert "Update comments related to new unique identifier"
This reverts commit 8e89802549.
* removed MigrateDeviceInfoFromRegistry
Co-authored-by: Seraphima Zykova <zykovas91@gmail.com>
* Added PowerLauncher spec and images
* Fixed images path
* Addressed review comments
* Fixed images
* Addressed review comments, and added link to keyboard shortcut manager PowerToy
* Added Ueli in comparison table
* Added keyboard input element
* Added suggestions from community
* Moved default shell and terminal settings
* Addressed feedback
* Added community suggestion
* Modified spec based on feedback
* Modified spec based on suggestions
* Added keyboard shortcuts to context menu options
* Migrate FancyZones data persisting from Registry to JSON file
* Address PR comment: Remove redundant check
* Addres PR comment: Remove unused Dpi and add CmdArgs enum
* Address PR comment: Make methods const and inline
* Address PR comments: Expose GenerateUniqueId function and use const ref instead of passing wstring by value
* Address PR comment: Use lamdba as callback
* Address PR comment: Move GenerateUniqueId to ZoneWindowUtils namespace
* Address PR comment: Use regular comparison instead of std::wstring::compare
* Address PR comment: Use std::wstring_view for tmp file paths
* Address PR comment: Use scoped lock when accessing member data
* Address PR comment: Remove typedefs to increase code readability
* Address PR comment: removed nullptr checks with corresponding tests
* Address PR comment: Move ZoneSet object instead of copying
* Address PR comment: Make FancyZonesData instance const where possible
* Remove unnecessary gutter variable during calculating zone coordinates
* Remove uneeded subclass
* Avoid unnecessary copying and reserve space for vector if possible
* Save FancyZones data after exiting editor
* App zone history (#18)
* added window and zone set ids to app zone history
* Rename JSON file
* Remove AppZoneHistory migration
* Move parsing of ZoneWindow independent temp files outside of it
* Unit tests update (#19)
* check device existence in map
* updated ZoneSet tests
* updated JsonHelpers tests
* Use single zone count information
* Remove uneeded tests
* Remove one more test
* Remove uneeded line
* Address PR comments - Missing whitespace
* Update zoneset data for new virtual desktops (#21)
* update active zone set with actual data
* Introduce Blank zone set (used to indicate that no layout applied yet). Move parsing completely outside of ZoneWindow.
* Fix unit tests to match modifications in implementation
* Fix applying layouts on startup (second monitor)
Co-authored-by: vldmr11080 <57061786+vldmr11080@users.noreply.github.com>
Co-authored-by: Seraphima <zykovas91@gmail.com>
Splits the code use to filter windows for FancyZones and the
"active window" for the ShortcutGuide. The FancyZones logic is preserved
and merged into a single function. We keep it in common.h, as it might
be also used in other PowerToys, like maximized to new desktop. We do
however change the return type to be more descriptive. It also returns
a separate flag for if the window has a visible owner. This can be used
to implement the approved apps list.
For the ShortcutGuide, the logic is relaxed to include more windows. One
example are Explorer properties windows. Those are (and should) filtered
by the FancyZones, but should appear in the window preview in the SCG.
The new return type also includes information if the window will react
to the default Windows Snap. This is not ideal though. Currently, SCG
can only disable the entire "Windows Controls" group. OTOH windows like
"Save As..." dialogs can be snapped to corners etc., but cannot be
minimized nor maximized. Until SCG can separately disable those buttons
we will display the buttons in the enabled state only if the window
supports all settings. In the future, we should integrate FancyZones
snap override here too.
The cache was introduced to improve performance by not querying the
OS for the window process path every time we need to check if the window
is interesting to FancyZones. Since then other changes were made to the
the way we check the windows. Right now, the IsInterestingWindow function is
called when:
1) WinKey + arrows are used
2) window is started to be dragged
3) window is created
1) and 2) are initiated by the user, happen only once per interaction so
their performance impact can be dismissed. The 3) happens all the time
but for the most part the check for WS_CHILD or
GetAncestor(window, GA_ROOT) == window will filter those out. In the
end, only top-level windows will be queried for their path.
Removing the cache improves code readability and will make code
maintenance easier.
Do not swallow WinKey+Arrow events for non-interesting windows. This makes apps that are in the "excluded apps" list behave as if "Override windows snap keys" is disabled - they will react to the Windows default snap.
* localized dllmain.cpp of fancyzones project
* localized FancyZones.cpp
* format fancyzones.rc file
* Moved SuperFancyZones back to being a string instead of having it in the resource file as it is the window class name
* reverted changes for window name
* Formatted fancyzones rc file
* Localized shortcut_guide.cpp
* localized overlay_window.cpp
* formatting changes
* Localize overlay window
* removed the README link from the set of localized resources
* Typo: changed upper to lower
* removed hardcoded strings from CanvasEditorWindow.xaml
* removed hardcoded strings from GridEditorWindow.xaml
* loc
* Localized MainWindow
* reverting MainWindow.xaml as it is not rendering the window as expected
* Changed the resource settings from internal to public
* the culture is set based on the culture of the system UI set in the system settings
* Removed the french resource files used for testing
* Localized canvasWindow and mainwindow
* Removed setting the UI culture explicitly as it would be implicitly set to the culture of system UI
* Removed redundant header file
* fix typo
* make function obsolete
it is not used in the code
* rewrite the function that converts chinese chars to pinyin
1. Only difference in this rewrite is instead of returning 2D array, return as a combined single string of all the possible pinyin combination. Since fuzzy search does character matching, this shouldn't be a problem.
2. Added a function that returns a custom language converter. In this case Pinyin converter. New converters can be added.
* Use new language converter param + strip out ScoreForPinyin method
* update
* Change parameter name
* fix failing tests
* WIP
* Remove todo
There should be some distinction between score after precision filter and actual raw score derived from FuzzySearch. Although so far RawScore is used in testing, but it seems to describe the structure. Originally it was to avoid assigning score directly as it would be hard to reason about that output of FuzzySearch score is.
* Add constructors, remove default to enforce required properties
* remove setting rawscore in SearchPrecision
* Change method name to reflect intention
* Change parameter name + update comment
* update
* Remove params comment
Co-authored-by: theClueless <14300910+theClueless@users.noreply.github.com>
* adding fancy zone opacity setting, enhancement #631
* applying zone opacity setting to all zones during zone selection
* changing opacity setting to percentage
- Moved if statement that checks if all query substrings are matched into a funciton
- convert into shorthand expression the if statement that checks if all words are fully matched
Ensure stored settings get evaluated after initial enumeration
There was a bug where the list view was not getting updated with the results of the search and replace on launch when we are using a stored search or replace text from a previous session.
- Move checking if there is a prev compare string char match into function
- Move updating of index list when a better match is found for the first substring logic into function
Make the runner not run as elevated by default. Add a setting for
"run PowerToys as elevated" and buttons to restart the process
with the different elevation levels.
* docs: split usage and dev docs
* # This is a combination of 2 commits.
# This is the 1st commit message:
docs: split usage and dev docs
# The commit message #2 will be skipped:
# fixup add docs
* docs: add runner documentation and move hooks documentation to devdocs
* docs: add stubs for modules technical description
* docs: add paragraph about event thread-safety
* docs: add 'Current modules' section header
1. Creating a mock ZoneWindowHost. Previously creating a ZoneWindow would throw an exception if the ZoneWindowHost is null.
2. Passing in HWND() instead of null to get rig of SAL annotation warnings.
1efe5bff9f
It looks to me like the test cases just was also wrong and just wasn't updated with the fix.
I've modified some of the test cases to verify the expected behavior:
1) Slight refactor of the tests to pass in the SearchReplaceExpected and flags for the tests.
2) Using Assert::AreEqual instead of Assert::IsTrue for better error meesaging when failed.
3) Verifying that the behavior is the same with or without match all occurances when using *.
4) Verifying that without the `UseRegularExpressionsFlag` the `.*` characters get replaced, including when MatchAllOccurances is set.
1) Adding example project to Debug / Release Builds.
2) Including <string> in common.h
3) Using std::optional instead of PowerToysValues::is_[type]_value
4) Fixing warnings generated by unreferenced 'ex' variable in exception handling.
5) Updated relative path of version.h in exeample_powertoy.rc
Flag is used in method "ShouldUsePinyin()" to avoid calling Alphabet
service. Otherwise, tests applying to StringMatcher.FuzzySearch() would
fail because the pinyin helper library fails to initialize.
The MatchResult will always get the maximum score from either
ScoreForPinyin() or CalculateSearchScore(). ScoreForPinyin() is
completely dependant on the "ShouldUsePinyin" global setting.
The search precision must be used, so it makes sense to apply the filter
directly on score assignment. Score will be "0" if precision filter
was not met.
As Alphabet class is static, its methods could be used without
ever calling Alphabet.initialize(_settings) beforehand which would end
in an exception. Therefor only _shouldUsePinyin settings needed will
be transferred with a given default value.
SelectedSearchSource will be null if the user clicks on Edit or Delete after finishing with previous edit and not highlighting the search source again.
* Added thumbnail loader
* Deleted old shell icon extraction logic.
Refactored ImageLoader.Load to improve readibility.
* Moved error handling down into the API call itself
* Minor renamings in ImageLoader
* Load icons only for files that are not images. Fixes stutters when loading folders.
* Added the ability to load a full image through ImageLoader.
ImageLoader.Load now also has a "loadFullImage" parameter.
* Max image cache is now 5000 instead of 200.
* Added some commentaries on how thumbnails are loaded
* ProgramPaths now searches for files on a per-folder basis using a Queue instead of calling EnumerateFiles. This allows us to escape permission errors.
Issue #1779 is fixed because of this too.
Tries to convert numbers in query string to invariant culture format before passing to YAMP, and the other way around when presenting result from
YAMP. Nothing fancy, just a regular expression scanning for substrings consisting of number, decimal separator and group separator, trying a
parse and convert on them. Translation is skipped if no conversion between user locale and invariant culture number format is necessary.
Closes#436.
Added functions I commonly use on e.g. google calculator but were missed by parser.
Specifically I added:
e (constant like pi)
tan, arcsin, and arctan
log and ln
1. remove unnecessary events from MainViewModel
2. remove usage of Obsolete api (show, hide etc)
3. fix space problem in #660
4. part of #486
5. fix up/down key bug introduced in 92b7ca6a1bafd254e39ee92812ff691906cd85c1
6. fix#678
1. installer
2. auto check update on startup
3. auto start on next startup
4. remove command line arguments which breaks squirrel
5. auto generate installer on continue integration
1. Fix can't find Result.ctor bug for plugin introduced in
c0889de1f9ae460b2cc189eb59e5bd90ddb7d17e
2. use %APPDATA% for all data, part of #389
3. MISC
1. Remove ItemDropEvent
2. Remove ShowContextMenus from API
3. Fix context menu item can't be opened ( #535 ), bug introduced from PR #494 (commit 45dbb50)
4. Move open result command and load context menu command back to
MainViewModel
5. unify load context menu logic
6. other performance enhancement and potential bug fixed
1. Fix "Remember launch location", this was introduced since e7aa6022.
Fix#511
2. Fix opening position ( #510 ), bug introduced from PR #494 (commit e7aa602)
1. Reorder the sequence of initialization of UserSettings.
2. Use dictionary for CustomizedPluginConfigs, so code logic like
`.FirstOrDefault(o => o.ID == id);` are removed
3. part of #389
1. Remove ItemDropEvent
2. Remove ShowContextMenus from API
3. Fix context menu item can't be opened ( #535 ), bug introduced from PR #494 (commit 45dbb50)
4. Move open result command and load context menu command back to
MainViewModel
5. unify load context menu logic
6. other performance enhancement and potential bug fixed
1. Fix "Remember launch location", this was introduced since e7aa6022.
Fix#511
2. Fix opening position ( #510 ), bug introduced from PR #494 (commit e7aa602)
1. Reorder the sequence of initialization of UserSettings.
2. Use dictionary for CustomizedPluginConfigs, so code logic like
`.FirstOrDefault(o => o.ID == id);` are removed
3. part of #389
- Add MVVM structure(BaseViewModel)
- Create ViewModel for MainWindow
- Refactor MainWindow.xaml to support MVVM
- Move PublicAPI implementation from MainViewModel to PublicAPIInstance
- Exposed a new function "SetBlurForWindow" in WindowIntelopHelper that handles the blur.
- Deleted Accent and Test themes
- Changed SimpleBlur and Base themes according to changes
WindowIntelopHelper: Added accent handling
SettingsWindow: Added combobox with accent selector to Theme tab (not functional yet)
Languages: Added entries for accent colors (all are in english for now)
[TEMP] Blur and Accent themes experiments
[TEMP] blur set in mainwindow on load.
The last commit f132cb54baa000a245feb5da87149960f6dbd9f5 only fix UI
flickering for different icon. This commit also fix the commit for same
icon. e.g. in web search plugin, although the title is different, but
the icon is not changes.
part of #350
2,In FolderPluginSettings when trigger Delete Action need confirm;
3,Add drag and drop functionality in ProgramSetting and FileSystemSettings.
Signed-off-by: 716 <525223688@qq.com>
Stupid automatic formatting changed more then I wanted
Here is the change I made if you just want the code
case Key.Tab:
case Key.Enter:
AcceptSelect(resultCtrl.GetActiveResult());
e.Handled = true;
break;
This reverts commit cf7ae900.
Short name will produce no errors when debugging using Visual Studio hosting process. However, this will crash outside Visual Studio.
<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist
* [] Applies to #xxx
* [] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/PowerToys) and sign the CLA
* [] Tests added/passed
* [] Requires documentation to be updated
* [] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx
*[ ] Applies to #xxx
*[ ] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/PowerToys) and sign the CLA
*[ ] Tests added/passed
*[ ] Requires documentation to be updated
*[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx
<!-- Provide a more detailed description of the PR, other things fixed or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments
Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
PowerToys is a set of utilities for power users to tune and streamline their Windows experience for greater productivity. Inspired by the [Windows 95 era PowerToys project](https://en.wikipedia.org/wiki/Microsoft_PowerToys), this reboot provides power users with ways to squeeze more efficiency out of the Windows 10 shell and customize it for individual workflows. A great overview of the Windows 95 PowerToys can be found [here](https://socket3.wordpress.com/2016/10/22/using-windows-95-powertoys/).
Microsoft PowerToys is a set of utilities for power users to tune and streamline their Windows experience for greater productivity. Inspired by the [Windows 95 era PowerToys project](https://en.wikipedia.org/wiki/Microsoft_PowerToys), this reboot provides power users with ways to squeeze more efficiency out of the Windows 10 shell and customize it for individual workflows. A great overview of the Windows 95 PowerToys can be found [here](https://socket3.wordpress.com/2016/10/22/using-windows-95-powertoys/).
[<img align="left" src="./doc/images/overview/FancyZones_small.png" />](/src/modules/fancyzones/) [FancyZones](/src/modules/fancyzones/) is a window manager that makes it easy to create complex window layouts and quickly position windows into those layouts.
<br>
<br>
<br>
<br>
<br>
### GitHub
### Shortcut Guide
The preview of these utilities can be installed from the [PowerToys GitHub releases page](https://github.com/Microsoft/powertoys/releases). Click on `Assets` to show the files available in the release and then click on `PowerToysSetup.msi` to download the PowerToys installer. <br />
PDB symbols for the release are available in a separate zip file `PDB symbols.zip`.
[<img align="left" src="./doc/images/overview/Shortcut guide_small.png" />](/src/modules/shortcut_guide) [Windows key shortcut guide](/src/modules/shortcut_guide) appears when a user holds the Windows key down for more than one second and shows the available shortcuts for the current state of the desktop.
<br>
<br>
<br>
<br>
<br>
### Windows Store
### PowerRename
On backlog, [Issue #413](https://github.com/microsoft/PowerToys/issues/413)
[<img align="left" src="./doc/images/overview/PowerRename_small.PNG" />](/src/modules/powerrename) [PowerRename](/src/modules/powerrename) is a Windows Shell Extension for advanced bulk renaming using search and replace or regular expressions. PowerRename allows simple search and replace or more advanced regular expression matching. While you type in the search and replace input fields, the preview area will show what the items will be renamed to. PowerRename then calls into the Windows Explorer file operations engine to perform the rename. This has the benefit of allowing the rename operation to be undone after PowerRename exits. This code is based on [Chris Davis's SmartRename](https://github.com/chrdavis/SmartRename).
<br>
<br>
### Chocolatey (Unofficial)
### File Explorer (Preview Panes)
Download and upgrade PowerToys from [Chocolatey](https://chocolatey.org).
[<img align="left" src="./doc/images/overview/PowerPreview_small.PNG" />](/src/modules/previewpane) [File Explorer](/src/modules/previewpane) add-ons right now are just limited to Preview Pane additions for File Explorer. Preview Pane is an existing feature in the File Explorer. To enable it, you just click the View tab in the ribbon and then click "Preview Pane".
To install PowerToys, run the following command from the command line or from PowerShell:
PowerToys will now enable two types of files to be previewed: Markdown (.md) & SVG (.svg)
<br>
<br>
### Image Resizer
[<img align="left" src="./doc/images/overview/ImageResizer_small.png" />](/src/modules/imageresizer) [Image Resizer](/src/modules/imageresizer) is a Windows Shell Extension for quickly resizing images. With a simple right click from File Explorer, resize one or many images instantly. This code is based on [Brice Lambson's Image Resizer](https://github.com/bricelam/ImageResizer).
<br>
<br>
<br>
<br>
### Keyboard Manager
[<img align="left" src="./doc/images/overview/KBM_small.png" />](src/modules/keyboardmanager/) [Keyboard Manager](src/modules/keyboardmanager/) allows you to customize the keyboard to be more productive by remapping keys and creating your own keyboard shortcuts. This PowerToy requires Windows 10 1903 (build 18362) or later.
<br>
<br>
<br>
<br>
<br>
### PowerToys Run
[<img align="left" src="./doc/images/overview/PowerLauncher_small.png" />](src/modules/launcher/) [PowerToys Run](src/modules/launcher/) is a new toy in PowerToys that can help you search and launch your app instantly with a simple alt-space and start typing! It is open source and modular for additional plugins. Window Walker is now inside too! This PowerToy requires Windows 10 1903 (build 18362) or later.
<br>
<br>
<br>
<br>
## Installing and running Microsoft PowerToys
**Requirements:**
- Microsoft PowerToys requires Windows 10 1803 (build 17134) or later.
- Have [.NET Core 3.1 Desktop Runtime](https://dotnet.microsoft.com/download/dotnet-core/thank-you/runtime-desktop-3.1.4-windows-x64-installer). The installer will prompt this but we want to directly make people aware.
### Via Github with MSI [Recommended]
Install from the [Microsoft PowerToys GitHub releases page][github-release-link]. Click on `Assets` to show the files available in the release and then click on `PowerToysSetup-0.18.1-x64.msi` to download the PowerToys installer.
**Note:** After installing, you will have to start PowerToys for the first time. We will improve install experience this moving forward but due to a possible install dependency, we can't start after install currently.
This is our preferred method.
### Via WinGet (Preview)
Download PowerToys from [WinGet](https://github.com/microsoft/winget-cli/releases). To install PowerToys, run the following command from the command line / PowerShell:
```powershell
WinGetinstallpowertoys
```
### Other install methods
#### Via Chocolatey (Unofficial)
Download and upgrade PowerToys from [Chocolatey](https://chocolatey.org). If you have any issues when installing/upgrading the package please go to the [package page](https://chocolatey.org/packages/powertoys) and follow the [Chocolatey triage process](https://chocolatey.org/docs/package-triage-process)
To install PowerToys, run the following command from the command line / PowerShell:
```powershell
chocoinstallpowertoys
```
To upgrade PowerToys, run the following command from the command line or from PowerShell:
To upgrade PowerToys, run the following command from the command line / PowerShell:
```powershell
chocoupgradepowertoys
```
If you have any issues when installing/upgrading the package please go to the [package page](https://chocolatey.org/packages/powertoys) and follow the [Chocolatey triage process](https://chocolatey.org/docs/package-triage-process)
### Processor support
## PowerToy Utilities
We currently support the matrix below.
### FancyZones
[FancyZones](/src/modules/fancyzones/) - FancyZones is a window manager that makes it easy to create complex window layouts and quickly position windows into those layouts. The FancyZones backlog can be found [here](https://github.com/Microsoft/PowerToys/tree/master/doc/planning/FancyZonesBacklog.md)
### Shortcut
[Windows key shortcut guide](/src/modules/shortcut_guide) - The shortcut guide appears when a user holds the Windows key down for more than one second and shows the available shortcuts for the current state of the desktop. The shortcut guide backlog can be found [here](https://github.com/Microsoft/PowerToys/tree/master/doc/planning/ShortcutGuideBacklog.md)
### PowerRename
[PowerRename](/src/modules/powerrename) - PowerRename is a Windows Shell Extension for advanced bulk renaming using search and replace or regular expressions. PowerRename allows simple search and replace or more advanced regular expression matching. While you type in the search and replace input fields, the preview area will show what the items will be renamed to. PowerRename then calls into the Windows Explorer file operations engine to perform the rename. This has the benefit of allowing the rename operation to be undone after PowerRename exits.
Chris Davis contributed his [SmartRename tool](https://github.com/chrdavis/SmartRename) into PowerToys!
* Maximize to new desktop widget - The MTND widget shows a pop-up button when a user hovers over the maximize / restore button on any window. Clicking it creates a new desktop, sends the app to that desktop and maximizes the app on the new desktop.
We're planning to ship 0.14 before December with a handful of key bug fixes from the community. After that 0.15 will bring .msix installer support and deployment and automatic updates from the Windows Store and 0.16 will add support for X86 and ARM64 processors (including the Surface Pro X).
Our goals for 0.18 release cycle was three big items, PowerToys Run, Keyboard manager, and migrating to the new settings system. This is also the first time we'll test out the auto-updating system.
Feedback is critical. We know there are areas for improvement on PT Run. We would love feedback so we can improve. We also would love to know if you want us to be more aggressive on auto-upgrading.
- We shipped [v0.18][github-release-link]!
- New Utilities
- PowerToys Run, our new application launcher (use alt-space to activate)
- Keyboard manager, a quick easy way to remap your keyboard
- Improved performance on FancyZones [#1264](https://github.com/microsoft/PowerToys/issues/1264)
- Lots of bug fixes!
For [0.19](https://github.com/microsoft/PowerToys/issues?q=is%3Aopen+is%3Aissue+project%3Amicrosoft%2FPowerToys%2F4), we are proactively working on:
- Enable PT Run to be mapped to Win-Keys
- Stability / tech debt fixes
- Performance improvements with FancyZones
- A testing utility for FancyZones to be sure we can test different window configurations.
### Version 1.0 plan
Our plan for all the [goals and utilities for v1.0 detailed over here in the wiki][v1].
## Developer Guidance
### Build Prerequisites
* Windows 10 1803 (build 10.0.17134.0) or above to build and run PowerToys.
* Visual Studio 2019 Community edition or higher, with the 'Desktop Development with C++' component and the Windows 10 SDK version 10.0.18362.0 or higher.
### Building the Code
* Open `powertoys.sln` in Visual Studio, in the `Solutions Configuration` drop-down menu select `Release` or `Debug`, from the `Build` menu choose `Build Solution`.
* The PowerToys binaries will be in your repo under `x64\Release`.
* If you want to copy the `PowerToys.exe` binary to a different location, you'll also need to copy the `modules` and the `svgs` folders.
### Prerequisites to Build the Installer
* Install the [WiX Toolset Visual Studio 2019 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WiXToolset).
* Install the [WiX Toolset build tools](https://wixtoolset.org/releases/).
### Building the .msi Installer
* From the `installer` folder open `PowerToysSetup.sln` in Visual Studio, in the `Solutions Configuration` drop-down menu select `Release` or `Debug`, from the `Build` menu choose `Build Solution`.
* The resulting `PowerToysSetup.msi` installer will be available in the `installer\PowerToysSetup\x64\Release\` folder.
### Debugging
The following configuration issue only applies if the user is a member of the Administrators group.
Some PowerToys modules require being run with the highest permission level if the current user is a member of the Administrators group. The highest permission level is required to be able to perform some actions when an elevated application (e.g. Task Manager) is in the foreground or is the target of an action. Without elevated privileges some PowerToys modules will still work but with some limitations:
* the `FancyZones` module will be not be able to move an elevated window to a zone.
* the `Shortcut Guide` module will not appear if the foreground window belongs to an elevated application.
To run and debug PowerToys from Visual Studio when the user is a member of the Administrators group, Visual Studio has to be started with elevated privileges. If you want to avoid running Visual Studio with elevated privileges and don't mind the limitations described above, you can do the following: open the `runner` project properties and navigate to the `Linker -> Manifest File` settings, edit the `UAC Execution Level` property and change it from `highestAvailable (level='highestAvailable')` to `asInvoker (/level='asInvoker')`, save the changes.
### How to create new PowerToys
See the instructions on [how to install the PowerToys Module project template](tools/project_template). <br />
Specifications for the [PowerToys settings API](doc/specs/PowerToys-settings.md).
### Coding Guidance
Please review these brief docs below relating to our coding standards etc.
> 👉 If you find something missing from these docs, feel free to contribute to any of our documentation files anywhere in the repository (or make some new ones\!)
This is a work in progress as we learn what we'll need to provide people in order to be effective contributors to our project.
* [Coding Style](doc/coding/style.md)
* [Code Organization](doc/coding/organization.md)
Please read the [developer docs](/doc/devdocs) for a detailed breakdown.
## Contributing
This project welcomes contributions and suggestions and we are excited to work with the power user community to build a set of tools for helping you get the most out of Windows.
This project welcomes contributions of all times. Help spec'ing, design, documentation, finding bugs are ways everyone can help on top of coding features / bug fixes. We are excited to work with the power user community to build a set of tools for helping you get the most out of Windows.
We ask that **before you start work on a feature that you would like to contribute**, please read our [Contributor's Guide](contributing.md). We will be happy to work with you to figure out the best approach, provide guidance and mentorship throughout feature development, and help avoid any wasted or duplicate effort.
> ⚠ **Note**: PowerToys is still a nascent project and the team is actively working out of this repository. We will be periodically re-structuring the code to make it easier to comprehend, navigate, build, test, and contribute to, so **DO expect significant changes to code layout on a regular basis**.
### ⚠ State of code ⚠
> ⚠ **License Info**: Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, visit https://cla.opensource.microsoft.com.
PowerToys is still a very fluidic project and the team is actively working out of this repository. We will be periodically re-structuring/refactoring the code to make it easier to comprehend, navigate, build, test, and contribute to, so **DO expect significant changes to code layout on a regular basis**.
When you submit a pull request, a CLA-bot will automatically determine whether you need to provide
a CLA and decorate the PR appropriately (e.g. status check, comment). Simply follow the instructions
provided by the bot. You will only need to do this once across all repos using our CLA.
### License Info
Most contributions require you to agree to a [Contributor License Agreement (CLA)][oss-CLA] declaring that you have the right to, and actually do, grant us the rights to use your contribution.
## Code of Conduct
This project has adopted the [Microsoft Open Source Code of Conduct][conduct-code]. For more information see the [Code of Conduct FAQ][conduct-FAQ] or contact [opencode@microsoft.com][conduct-email] with any additional questions or comments.
This project has adopted the [Microsoft Open Source Code of Conduct][oss-conduct-code].
## Privacy Statement
The application logs basic telemetry. Our Telemetry Data page (Coming Soon) has the trends from the telemetry. Please read the [Microsoft privacy statement](http://go.microsoft.com/fwlink/?LinkId=521839) for more information.
The application logs basic telemetry. Our Telemetry Data page (Coming Soon) has the trends from the telemetry. Please read the [Microsoft privacy statement][privacyLink] for more information.
The PowerToys team is extremely grateful to have the support of an amazing active community. The work you do is incredibly important. PowerToys wouldn’t be near what it is without your help filing bugs, updating documentation, guiding the design, or writing features. We want to say thanks and to recognize your work. This is a living document dedicated to highlighting the high impact community members and their contributions.
Niels has helped drive large sums of our update toward a new [consistent and modern UX](https://github.com/microsoft/PowerToys/issues/891). This includes the [launcher work](https://github.com/microsoft/PowerToys/issues/44) and [icon design](https://github.com/microsoft/PowerToys/issues/1118).
Rafael has helped do the [upgrade from CppWinRT 1.x to 2.0](https://github.com/microsoft/PowerToys/issues/1907). He directly provided feedback to the CppWinRT team for bugs from this migration as well.
This JSON library is taken from the C++ REST SDK in https://github.com/microsoft/cpprestsdk
Based in the [v2.10.13 release](https://github.com/microsoft/cpprestsdk/tree/v2.10.13/Release), it consists of the needed files to build and use the JSON classes described in `include/cpprest/json.h`.
Changes made to the files in order to build in the PowerToys project:
- Removal of `#include` references to files that are not needed.
-`#include "pch.h"` instead of `#include "stdafx.h"` to use the PowerToys pre-compiled header.
-`#define _NO_ASYNCRTIMP` in [`include/cpprest/details/cpprest_compat.h`](./include/cpprest/details/cpprest_compat.h) since this class will be statically linked.
The contents of the C++ Rest SDK license are included in [license.txt](./license.txt).
1. If it's inserting something into the existing classes/functions, try to follow the existing style as closely as possible.
1. If it's brand new code or refactoring a complete class or area of the code, please follow as Modern C++ of a style as you can and reference the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines) as much as you possibly can.
Class for obtaining information about physical displays connected to the machine.
#### class Settings, class PowerToyValues, class CustomActionObject: [header](/src/common/settings_objects.h) [source](/src/common/settings_objects.cpp)
Classes used to define settings screens for the PowerToys modules.
#### class Tasklist: [header](/src/common/tasklist_positions.h) [source](/src/common/tasklist_positions.cpp)
Class that can detect the position of the windows buttons on the taskbar. It also detects which window will react to pressing `WinKey + number`.
Contains function to test if the Start menu is visible.
# Toast Notifications
#### Notifications API [header](/src/common/notifications.h) [source](/src/common/notifications.cpp)
To use UWP-style toast notifications, simply include the header and call one of these functions:
```cpp
voidshow_toast(std::wstring_viewmessage);// #1
voidshow_toast_background_activated(// #2
std::wstring_viewmessage,
std::wstring_viewbackground_handler_id,
std::vector<std::wstring_view>button_labels);
```
We might add more functions in the future if the need arises, e.g. `show_toast_xml` which will accept raw XML for rich customization.
Description:
-`#1` is for sending simple notifications without any callbacks or buttons
-`#2` is capable of showing a toast with multiple buttons and background activation
-`message` is a plain-text argument
Implement a toast activation handler/callback as a function in [handler_functions.cpp](/src/common/notifications_winrt/handler_functions.cpp) and register its `background_handler_id` via `handlers_map`, e.g.:
```cpp
// Your .cpp where you'd like to show a toast
#include<common/notifications.h>
voidsome_func(){
// ...
notifications::show_toast_background_activated(
L"Toast message!",// text displayed in a toast
L"awesome_toast",// activation handler id
{L"Press me!",L"Also could press me!",L"I'm here to be pressed!"}// buttons in a toast
Note: since _background activation_ implies that your toast handler will be invoked in a separate process, you can't share data directly from within a handler and your PT process. Also, since PT is currently a Desktop Bridge app, _foreground activation_ is [handled the same as background](https://docs.microsoft.com/en-US/windows/uwp/design/shell/tiles-and-notifications/send-local-toast-desktop-cpp-wrl#foreground-vs-background-activation), therefore we don't make a dedicated API for it. You can read more on the rationale of the current design [here](https://github.com/microsoft/PowerToys/pull/1178#issue-368768337).
In order to support localization **YOU SHOULD NOT** have hardcoded UI display strings in your code. Instead, use resource files to consume strings.
### For CPP
Use [`StringTable` resource][String Table] to store the strings and resource header file(`resource.h`) to store Id's linked to the UI display string. Add the strings with Id's referenced from the header file to the resource-definition script file. You can use [Visual Studio Resource Editor][VS Resource Editor] to create and manage resource files.
-`resource.h`:
XXX must be a unique int in the list (mostly the int ID of the last string id plus one):
```cpp
#define IDS_MODULE_DISPLAYNAME XXX
```
-`StringTable` in resource-definition script file `validmodulename.rc`:
```
STRINGTABLE
BEGIN
IDS_MODULE_DISPLAYNAME L"Module Name"
END
```
- Use the `GET_RESOURCE_STRING(UINT resource_id)` method to consume strings in your code.
Use [XML resource file(.resx)][Resx Files] to store the UI display strings and [`Resource Manager`][Resource Manager] to consume those strings in the code. You can use [Visual Studio][Resx Files VS] to create and manage XML resources files.
In case of Visual Studio is used to create the resource file. Simply use the `Resources` class in auto-generated `Resources.Designer.cs` file to access the strings which encapsulate the [`Resource Manager`][Resource Manager] logic.
State machine that handles the keyboard events. It’s responsible for deciding when to show the overlay, when to suppress the Start menu (if the overlay is displayed long enough), etc.
- **Follow the pattern of what you already see in the code.**
- [Coding style](style.md).
- Try to package new ideas/components into libraries that have nicely defined interfaces.
- Package new ideas into classes or refactor existing ideas into a class as you extend.
- When adding new classes/methos/changing existing code: add new unit tests or update the existing tests.
## Github Workflow
- Before starting to work on a fix/feature, make sure there is an open issue to track the work.
- Add the `In progress` label to the issue, if not already present also add a `Cost-Small/Medium/Large` estimate and make sure all appropriate labels are set.
- If you are a community contributor, you will not be able to add labels to the issue, in that case just add a comment saying that you started to work on the issue and try to give an estimate for the delivery date.
- If the work item has a medium/large cost, using the markdown task list, list each sub item and update the list with a check mark after completing each sub item.
- When opening a PR, follow the PR template.
- When the PR is approved, let the owner of the PR merge it. For community contributions the reviewer that approved the PR can also merge it.
- Use the `Squash and merge` option to merge a PR, if you don't want to squash it because there are logically different commits, use `Rebase and merge`.
- We don't close issues automatically when referenced in a PR, so after the PR is merged:
- mark the issue(s), that the PR solved, with the `Resolution-Fix-Committed` label, remove the `In progress` label and if the issue is assigned to a project, move the item to the `Done` status.
- don't close the issue if it's a bug in the current released version since users tend to not search for closed issues, we will close the resolved issues when a new version is released.
- if it's not a code fix that effects the end user, the issue can be closed (for example a fix in the build or a code refactoring and so on).
## Repository Overview
General project organization:
### The [`doc`](/doc) folder
Documentation for the project.
### The [`Wiki`](/wiki)
The Wiki contains the current specs for the project.
### The [`installer`](/installer) folder
Contains the source code of the PowerToys installer.
### The [`src`](/src) folder
Contains the source code of the PowerToys runner and of all of the PowerToys modules. **This is where the most of the magic happens.**
### The [`tools`](/tools) folder
Various tools used by PowerToys. Includes the Visual Studio 2019 project template for new PowerToys.
## Building code
### Build Prerequisites
- Windows 10 1803 (build 10.0.17134.0) or above to build and run PowerToys.
- Visual Studio 2019 Community edition or higher, with the 'Desktop Development with C++' component and the Windows 10 SDK version 10.0.18362.0 or higher.
### Building the Code
- Open `powertoys.sln` in Visual Studio, in the `Solutions Configuration` drop-down menu select `Release` or `Debug`, from the `Build` menu choose `Build Solution`.
- The PowerToys binaries will be in your repo under `x64\Release`.
- If you want to copy the `PowerToys.exe` binary to a different location, you'll also need to copy the `modules` and the `svgs` folders.
### Building the .msi Installer
* From the `installer` folder open `PowerToysSetup.sln` in Visual Studio, in the `Solutions Configuration` drop-down menu select `Release` or `Debug`, from the `Build` menu choose `Build Solution`.
* The resulting `PowerToysSetup.msi` installer will be available in the `installer\PowerToysSetup\x64\Release\` folder.
#### Prerequisites to Build the MSI Installer
* Install the [WiX Toolset Visual Studio 2019 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WiXToolset).
* Install the [WiX Toolset build tools](https://wixtoolset.org/releases/).
### Building the MSIX Installer
Please follow the [installer instructions](./installer/readme.md) which include items such as creating the self-signed cert for testing.
## Debugging
The following configuration issue only applies if the user is a member of the Administrators group.
Some PowerToys modules require being run with the highest permission level if the current user is a member of the Administrators group. The highest permission level is required to be able to perform some actions when an elevated application (e.g. Task Manager) is in the foreground or is the target of an action. Without elevated privileges some PowerToys modules will still work but with some limitations:
- the `FancyZones` module will be not be able to move an elevated window to a zone.
- the `Shortcut Guide` module will not appear if the foreground window belongs to an elevated application.
To run and debug PowerToys from Visual Studio when the user is a member of the Administrators group, Visual Studio has to be started with elevated privileges. If you want to avoid running Visual Studio with elevated privileges and don't mind the limitations described above, you can do the following: open the `runner` project properties and navigate to the `Linker -> Manifest File` settings, edit the `UAC Execution Level` property and change it from `highestAvailable (level='highestAvailable')` to `asInvoker (/level='asInvoker')`, save the changes.
## How to create new PowerToys
See the instructions on [how to install the PowerToys Module project template](tools/project_template). <br />
Specifications for the [PowerToys settings API](doc/specs/PowerToys-settings.md).
## Implementation details
### [`Runner`](runner.md)
The PowerToys Runner contains the project for the PowerToys.exe executable.
It's responsible for:
- Loading the individual PowerToys modules.
- Passing registered events to the PowerToys.
- Showing a system tray icon to manage the PowerToys.
- Bridging between the PowerToys modules and the Settings editor.

### [`Interface`](modules/interface.md)
Definition of the interface used by the [`runner`](/src/runner) to manage the PowerToys. All PowerToys must implement this interface.
### [`Common`](common.md)
The common lib, as the name suggests, contains code shared by multiple PowerToys components and modules, e.g. [json parsing](/src/common/json.h) and [IPC primitives](/src/common/two_way_pipe_message_ipc.h).
### [`Settings`](settings.md)
WebView project for editing the PowerToys settings.
The html portion of the project that is shown in the WebView is contained in [`settings-html`](/src/settings/settings-heml).
Instructions on how build a new version and update this project are in the [Web project for the Settings UI](./settings-web.md).
While developing, it's possible to connect the WebView to the development server running in localhost by setting the `_DEBUG_WITH_LOCALHOST` flag to `1` and following the instructions near it in `./main.cpp`.
### [`Settings-web`](settings-web.md)
This project generates the web UI shown in the [PowerToys Settings](/src/editor).
It's a `ReactJS` project created using [UI Fabric](https://developer.microsoft.com/en-us/fabric#/).
## Current modules
### [`FancyZones`](modules/fancyzones.md)
The FancyZones PowerToy that allows users to create custom zones on the screen, to which the windows will snap when moved.
### [`PowerRename`](modules/powerrename.md)
PowerRename is a Windows Shell Context Menu Extension for advanced bulk renaming using simple search and replace or more powerful regular expression matching.
### [`Shortcut Guide`](modules/shortcut_guide.md)
The Windows Shortcut Guide, displayed when the WinKey is held for some time.
An example PowerToy, that demonstrates how to create new ones. Please note, that this is going to become a Visual Studio project template soon.
This PowerToy serves as a sample to show how to implement the [PowerToys interface](/src/modules/interface/) when creating a PowerToy. It also showcases the currently implemented settings.
#### Options
This module has a setting to serve as an example for each of the currently implemented settings property:
- BoolToggle property
- IntSpinner property
- String property
- ColorPicker property
- CustomAction property

If you're running any application as an administrator (aka elevated) and PowerToys is not, a few things may not work correctly when the elevated applications are in focus or trying to interact with a PowerToys feature like FancyZones.
## Having PowerToys keep functioning properly
We understand users will run applications elevated. We do as well. We have two options for you when this scenario happens:
1.**Recommended:** PowerToys will prompt when we detect a process that is elevated. Go to PowerToys settings inside the General Tab and click "Relaunch as adminstrator".
2. Enable "Always run as administrator" in the PowerToys settings.
## What is "Run as Administrator" / Elevated processes
This is when a process runs with "elevated" privileges. Typically this would be associated with the administrator accounts on a system.
Basically it runs with additional access to the operating system. Most things do not need run elevated. A common scenario would be needing to run certain PowerShell commands or edit the registry.
How do i know my application is "elevated"? If you see this prompt (User Access Control prompt), the application is requesting it:
![alt text][uac]
At times also, elevated terminals for instance, they will typically have the phrase "Administrator" appended to the title bar. Be warned, this isn't always the case it will be appended.
![alt text][elevatedWindow]
## When does PowerToys need this
PowerToys in itself does not. It only needs to be elevated when it has to interact with other applications that are running elevated. If those applications are in focus, PowerToys may not function unless it is elevated as well.
These are the two scenarios we will not work in:
1. Intercepting certain types of keyboard strokes
2. Resizing / Moving windows
### PowerToys affected
1. FancyZones
- Snapping a window into a zone
- Moving the window to a different zone
2. Shortcut guide
- Display shortcut
3. Keyboard remapper
- key to key remapping
- Global level shortcuts remapping
- App-targeted shortcuts remapping
[uac]: ../images/runAsAdmin/uac.png "User access control (UAC)"
[elevatedWindow]: ../images/runAsAdmin/elevatedWindows.png "Run as admin"
Contains the executable starting point, initialization code and the list of known PowerToys. All singletones are also initialized here at the start. Loads all the powertoys by scanning the `./modules` folder and `enable()`s those makred as enabled in `%LOCALAPPDATA%\Microsoft\PowerToys\settings.json` config. Then it runs [a message loop](https://docs.microsoft.com/en-us/windows/win32/winmsg/using-messages-and-message-queues) for the tray UI. Note that this message loop also [handles lowlevel_keyboard_hook events](https://github.com/microsoft/PowerToys/blob/1760af50c8803588cb575167baae0439af38a9c1/src/runner/lowlevel_keyboard_event.cpp#L24).
#### [`powertoy_module.h`](/src/runner/powertoy_module.h) and [`powertoy_module.cpp`](/src/runner/powertoy_module.cpp)
Contains code for initializing and managing the PowerToy modules. `PowertoyModule` is a RAII-style holder for the `PowertoyModuleIface` pointer, which we got by [invoking module DLL's `powertoy_create` function](https://github.com/microsoft/PowerToys/blob/1760af50c8803588cb575167baae0439af38a9c1/src/runner/powertoy_module.cpp#L13-L24).
Contains code that handles the various events listeners, and forwards those events to the PowerToys modules. You can learn more about the current event architecture [here](/doc/devdocs/shared-hooks.md).
Contains code for registering the low level keyboard event hook that listens for keyboard events. Please note that `signal_event` is called from the main thread for this event.
Contains code for registering a Windows event hook through `SetWinEventHook`, that listens for various events raised when a window is interacted with. Please note, that `signal_event` is called from a separate `dispatch_thread_proc` worker thread, so you must provide thread-safety for your `signal_event` if you intend to receive it. This is a subject to change.
#### [`tray_icon.cpp`](/src/runner/tray_icon.cpp)
Contains code for managing the PowerToys tray icon and its menu commands. Note that `dispatch_run_on_main_ui_thread` is used to
transfer received json message from the [Settings window](/doc/devdocs/settings.md) to the main thread, since we're communicating with it from [a dedicated thread](https://github.com/microsoft/PowerToys/blob/7357e40d3f54de51176efe54fda6d57028837b8c/src/runner/settings_window.cpp#L267-L271).
Contains code for starting the PowerToys settings window and communicating with it. Settings window is a separate process, so we're using [Windows pipes](https://docs.microsoft.com/en-us/windows/win32/ipc/pipes) as a transport for json messages.
While the module interface passes the settings and values thorough a JSON string, **use our helper functions**. In future we might move to a different implementation. All current modules use:
*`load_module_settings` to load the settings from the disk.
*`PowerToySettings::Settings` class to define module properties and the settings screen.
*`PowerToySettings::PowerToyValues` class to parse the JSON passed by the runner.
*`save_module_settings` to store the settings on the disk.
Most functions provide two overloads - one that accepts UINT with a resource ID and one that accepts strings. **Put all strings in the resource file and use the resource ID overload.**
The following documents internal workings of the settings system.
## Overview
PowerToys runner provides a generic way for modules to define their settings.
Each module on startup is responsible for loading its own settings and initializing accordingly. When the user wants to edit settings, the runner will call [`get_config()`](modules/interface.md#get_config) module method. The module must provide a JSON which includes the module name, description but also what settings options are provided.
When settings from all modules are collected, a separate [settings editor app](/src/settings) is spawned. The editor wraps [an React app](/src/settings-web) and handles the communication with the runner.
When loaded, the React app receives the JSON passed by the runner. When user saves the settings, the editor passes the new settings values as JSON string to the runner. Runner in turn will call [`set_config()`](modules/interface.md#set_config) for all modules with appropriate JSON. When user initiates a custom action (like the Zone Editor in FancyZones), the runner will call [`call_custom_action()`](modules/interface.md#call_custom_action) providing the action name in a JSON.
There are C++ helper functions in [/src/common/settings_objects.h](/src/common/settings_objects.h) and [/src/common/settings_helpers.h](/src/common/settings_helpers.h). Those include classes for creating the settings options JSON and ones for parsing the incoming settings JSON.
### Module settings
The value returned by the [`get_config()`](modules/interface.md#get_config) call should provide a JSON object with following fields:
*`name` - The name of the PowerToy. Used on the nav panel on the left.
*`version` - The settings version. Needs to be set to `"1.0"`.
*`description` - Description of the PowerToy module.
*`overview_link`, `video_link` - Optional links to the documentation and video preview of the PowerToy module.
*`icon_key` - Name of the icon of the PowerToy. The SVGs for the icons are located in [/src/settings-web/src/svg](/src/settings-web/src/svg). They also need to be added in [/settings-web/src/setup_icons.tsx](/settings-web/src/setup_icons.tsx).
*`properties` - Optional object that contains the definition of the settings screen.
The `properties` JSON object defines what settings controls are available to the user. Each key defines one control. The controls have some common properties:
* The key in the `properties` which identifies the control.
*`editor_type` - Defines the type of the control. Those are listed further.
*`order` - Defines the order of the elements on the settings screen.
Each `editor_type` has its own set of properties.
Example module JSON (taken from Shortcut Guide):
```json
{
"name":"Shortcut Guide",
"version":"1.0",
"description":"Shows a help overlay with Windows shortcuts when the Windows key is pressed.",
PowerToys provides [a helper class](/src/common/json.h) to parse and generate JSON strings.
In [`settings_helpers.h`](/src/common/settings_helpers.h) there are two helper functions: `load_module_settings(powertoy_name)` and `save_general_settings(settings)` for loading and saving the module configuration.
In [`settings_objects.h`](/src/common/settings_objects.h) there are some helper classes:
*`Settings` - for generating JSON with module settings definition.
*`PowerToyValues` - for parsing JSON with settings - either loaded from file or from the settings editor.
*`CustomActionObject` and `HotkeyObject` - for parsing custom actions and hotkey input specific JSON.
### General settings
General settings control the PowerToys runner and decide which modules are enabled and which are not. The general settings screen is special - while modules provide the definition of the settings controls, the available settings on the general screen are hardcoded.
General settings has following properties:
*`enabled` - Enabled/disabled status of each PowerToy.
*`startup` - Should PowerToys start at user logon.
*`theme` - Settings editor theme - `light`, `dark` or `system`.
*`system_theme` - Current Windows theme - `light` or `dark`.
*`powertoys_version` - The version of the PowerToys.
The runner combines general settings and each module settings into a single JSON that is passed to the settings editor. Example combined settings look like this:
```json
{
"general":{
"enabled":{
"FancyZones":true,
"PowerRename":true,
"Shortcut Guide":true
},
"startup":true,
"theme":"light",
"system_theme":"dark",
"powertoys_version":"0.14.2.0"
},
"powertoys":{
"FancyZones":{...},
"PowerRename":{...},
"Shortcut Guide":{
"name":"Shortcut Guide",
"version":"1.0",
"description":"Shows a help overlay with Windows shortcuts when the Windows key is pressed.",
declared in [`settings_helpers.h`](/src/common/settings_helpers.h). The function will return an `json::JsonObject` object containing the module settings.
Another option is using [`PowerToySettings::PowerToyValues`](/src/common/settings_objects.h#L67) class. A static method
to parse JSON string - for example when implementing [`set_config()`](modules/interface.md#set_config). The returned `PowerToyValues` object has helper methods that return `std::optional` with values, for example:
```c++
auto settings = PowerToyValues::load_from_settings_file(L"some_powertoy");
Numeric input with dials to increment and decrement the value. Parameters:
* `name` - Key for element in the JSON.
* `description` - String or resource ID of the text displayed to the user.
* `value` - Initial control value.
* `min`, `max` - Minimum and maximum values for the input. User cannot use dials to move beyond those values, if a value out of range is inserted using the keyboard, it will get clamped to the allowed range.
The color picker value is stored as `std::wstring`:
```c++
std::optional<std::wstring> value = settings.get_string_value(L"colorpicker_name");
```
### Hotkey
```c++
settings.add_hotkey(name, description, hotkey)
```
Input for capturing hotkeys. Parameters:
* `name` - Key for element in the JSON.
* `description` - String or resource ID of the text displayed to the user.
* `hotkey` - Instance of `PowerToysSettings::HotkeyObject` class.
You can create `PowerToysSettings::HotkeyObject` object either by using helper `from_settings` static method or by providing JSON object to `from_json` static method:
The `PowerToysSettings::HotkeyObject::from_settings` take following parameters:
* `win_pressed` - Is the WinKey pressed.
* `ctrl_pressed` - Is the Ctrl key pressed.
* `alt_pressed` - Is the Alt key pressed.
* `shift_pressed` - Is the Shift key pressed.
* `vk_code` - The [virtual key-code](https://docs.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes) of the key.
The displayed key is deduced from the `vk_code` using the users keyboard layout and language settings.
Similar parameters can be passed using the `from_json` static method:
and this generated JSON (`114` is the value of `VK_F5`):
```json
{
"properties": {
"hotkey_name": {
"editor_type": "hotkey",
"order": autoincremented_number,
"display_name": "description",
"value": {
"win": true,
"ctrl": true,
"alt": true,
"shift": true,
"code": 114,
"key": "F5"
}
}
}
}
```
The hotkey value is returned as JSON, with the same format as `from_json` method uses. You can use `HotkeyObject` class to parse this JSON, since it offers some helper methods. A typical example of registering a hotkey:
```c++
std::optional<json::JsonObject> value = settings.get_json(L"hotkey_name");
if (value) {
auto hotkey = PowerToysSettings::HotkeyObject::from_json(*value);
This project generates the web UI shown in the [PowerToys Settings](/src/editor).
It's a `ReactJS` project created using [UI Fabric](https://developer.microsoft.com/en-us/fabric#/).
## Build Commands
Here are the commands to build and test this project:
@@ -22,9 +15,11 @@ npm run start
npm run build
```
**Note:** you will need to rebuild the settings project to pick up the changes
## Updating the icons
Icons inside [`src/icons/`](./src/icons/) were generated from the [Office UI Fabric Icons subset generation tool.](https://uifabricicons.azurewebsites.net/)
Icons inside [`src/icons/`](/src/settings-web/src/icons/) were generated from the [Office UI Fabric Icons subset generation tool.](https://uifabricicons.azurewebsites.net/)
In case the subset needs to be changed, additional steps are needed to include the icon font in the built `dist/bundle.js`:
- Copy the inline font data taken from [`src/icons/css/fabric-icons-inline.css`](src/icons/css/fabric-icons-inline.css) and place it in the `fontFace``src` value in [`src/icons/src/fabric-icons.ts`](src/icons/src/fabric-icons.ts).
@@ -37,44 +32,44 @@ SVG icons, including the icons for each PowerToy listed in the Settings, are con
The project structure is based on the [`UI Fabric` scaffold](https://developer.microsoft.com/en-us/fabric#/get-started/web#option-1-quick-start) obtained by initializing it with `npm init uifabric`.
#### [index.html](./index.html)
#### [index.html](/src/settings-web/index.html)
The HTML entry-point of the project.
Loads the `ReactJS` distribution script.
Defines JavaScript functions to receive and send messages to the [PowerToys Settings](/src/editor) window.
A settings control overrides the `get_value` function to return the value to be used for the Setting the control is representing.
It will use the `parent_on_change` property to signal that the user made some changes to the settings.
Here's the [`StringTextSettingsControl`](./src/components/StringTextSettingsControl.tsx) component to serve as an example:
Here's the [`StringTextSettingsControl`](/src/settings-web/src/components/StringTextSettingsControl.tsx) component to serve as an example:
```tsx
export class StringTextSettingsControl extends BaseSettingsControl {
@@ -153,8 +148,8 @@ Each settings property has a `editor_type` field that's used to differentiate be
}
```
A new Settings control component can be added to [`src/components/`](./src/components/).
To render the new Settings control, its `editor_type` and component instance need to be added to the [`ModuleSettings` component render()](./src/components/ModuleSettings.tsx):
A new Settings control component can be added to [`src/components/`](/src/settings-web/src/components/).
To render the new Settings control, its `editor_type` and component instance need to be added to the [`ModuleSettings` component render()](/src/settings-web/src/components/ModuleSettings.tsx):
```tsx
import React from 'react';
import {StringTextSettingsControl} from './StringTextSettingsControl';
PowerToys provides a common framework for settings. It can be used to save and load settings on disk, and provides a user interface for changing the options.
## Initialization
When a PowerToy module is created, it should load its configuration using [`PowerToyValues`](/src/common/settings_objects.h) class. The class provides static `load_from_settings_file` method which takes one parameter - the PowerToy module name. The `PowerToyValues` class provides methods to extract values. The method return `std::optional` - it is possible, that the method will return `std::nullopt` in which case you must use defaults.
```c++
class ExamplePowertoy : public PowertoyModuleIface
{
public:
ExamplePowertoy()
{
auto settings = PowerToySettings::PowerToyValues::load_from_settings_file(L"Example Powertoy");
// See if value is set, otherwise keep the default value
if (auto int_value = settings.get_int_value(L"int_setting"))
{
m_int_setting = *int_value;
}
if (auto string_value = setting.get_string_value("string_setting"))
{
m_string_setting = *string_value;
}
}
// ...
private:
// Settings and their default values
int m_int_setting = 10;
std::wstring m_string_setting = L"default";
}
```
## Settings screen
When users starts the settings screen, the runner will call the [`get_config()`](modules/interface.md) method. The interface expects the method to fill provided buffer. Use the [`Settings`](/src/common/settings_objects.h) class to construct proper response with proper format. The class has helper method to set description and links fields, it also provides a way to define the content of the settings screen. Keep all the strings in the resource file and provide the resource IDs to the methods.
```c++
extern "C" IMAGE_DOS_HEADER __ImageBase; // Needed to get strings from the resource file
The list of all the available settings elements and their description is [further in this doc](#available-settings-elements). New PowerToy icons need to be [added to the `settings-web` project](https://github.com/microsoft/PowerToys/blob/master/doc/devdocs/settings-web.md#updating-the-icons).
## User changes settings
When user closes the settings screen, the runner will call the [`get_config()`](modules/interface.md) method. Use [`PowerToyValues`](/src/common/settings_objects.h) class static `from_json_string` method to parse the settings. After that, the code is similar to loading the settings from disk:
auto settings = PowerToySettings::PowerToyValues::from_json_string(config);
// See if value is set update the values
if (auto int_value = settings.get_int_value(L"int_setting"))
{
m_int_setting = *int_value;
}
if (auto string_value = setting.get_string_value("string_setting"))
{
m_string_setting = *string_value;
}
// Save the new settings to disk
settings.save_to_settings_file();
}
```
## Detailed reference
For a detailed reference of how the settings are implemented in the runner and in the settings editor, consult [this detailed guide](settings-reference.md).
Numeric input with dials to increment and decrement the value. Parameters:
* `name` - Key for element in the JSON.
* `description` - Resource ID of the text displayed to the user.
* `value` - Initial control value.
* `min`, `max` - Minimum and maximum values for the input. User cannot use dials to move beyond those values, if a value out of range is inserted using the keyboard, it will get clamped to the allowed range.
* `description` - Resource ID of the text displayed to the user.
* `hotkey` - Instance of `PowerToysSettings::HotkeyObject` class.
You can create `PowerToysSettings::HotkeyObject` object either by using helper `from_settings` static method or by providing a JSON object to `from_json` static method.
The `PowerToysSettings::HotkeyObject::from_settings` take following parameters:
* `win_pressed` - Is the WinKey pressed.
* `ctrl_pressed` - Is the Ctrl key pressed.
* `alt_pressed` - Is the Alt key pressed.
* `shift_pressed` - Is the Shift key pressed.
* `vk_code` - The [virtual key-code](https://docs.microsoft.com/en-us/windows/win32/inputdev/virtual-key-codes) of the key.
The displayed key is deduced from the `vk_code` using the users keyboard layout and language settings.
The hotkey value is returned as JSON, which can be used with the `from_json` method to create a `HotkeyObject` object. A typical example of registering a hotkey:
```c++
std::optional<json::JsonObject> value = settings.get_json(L"hotkey_name");
if (value) {
auto hotkey = PowerToysSettings::HotkeyObject::from_json(*value);
* `description` - Resource ID of the text displayed to the user.
* `button_text` - Resource ID for the button label.
* `ext_description` - Resource ID for the extended description.
When the button is pressed, the `call_custom_action` method of the module will be called, with JSON containing the name of the action. Parse it using `PowerToysSettings::CustomActionObject`:
To minimize the performance impact on the machine only `runner` installs global hooks, passing the events to registered callbacks in each PowerToy module.
When a PowerToy module is loaded, the `runner` calls the [`get_events()`](/src/modules/interface/powertoy_module_interface.h#L40) method to get a NULL-terminated array of NULL-terminated strings with the names of the events that the PowerToy wants to subscribe to. A `const wchar_t*` string is provided for each of the event names.
Events are signalled by the `runner` calling the [`signal_event(name, data)`](/src/modules/interface/powertoy_module_interface.h#L53) method of the PowerToy module. The `name` parameter contains the NULL-terminated name of the event. The `data` parameter and the method return value are specific for each event.
This event is signaled whenever the user presses or releases a key on the keyboard. To subscribe to this event, add `"ll_keyboard"` to the table returned by the `get_events()` method.
The PowerToys runner installs low-level keyboard hook using `SetWindowsHookEx(WH_KEYBOARD_LL, ...)`. See [this MSDN page](https://docs.microsoft.com/en-us/previous-versions/windows/desktop/legacy/ms644985(v%3Dvs.85)) for details.
When a keyboard event is signaled and `ncCode` equals `HC_ACTION`, the `wParam` and `lParam` event parameters are passed to all subscribed clients in the [`LowlevelKeyboardEvent`](/src/modules/interface/lowlevel_keyboard_event_data.h#L38-L41) struct.
The `intptr_t data` event argument is a pointer to the `LowlevelKeyboardEvent` struct.
A non-zero return value from any of the subscribed PowerToys will cause the runner hook proc to return 1, thus swallowing the keyboard event.
Example usage, that makes Windows ignore the L key:
if (event.wParam == WM_KEYDOWN && event.lParam->vkCode == 0x4C) {
return 1;
} else {
return 0;
}
} else {
return 0;
}
}
```
## Windows Event Hook
This event is signaled for [a range of events](https://docs.microsoft.com/pl-pl/windows/win32/winauto/event-constants). To subscribe to this event, add `"win_hook_event"` to the table returned by the `get_events()` method. See [this MSDN doc](https://docs.microsoft.com/pl-pl/windows/win32/api/winuser/nf-winuser-setwineventhook) for details.
The `intptr_t data` event argument is a pointer to the [`WinHookEvent`](/src/modules/interface/win_hook_event_data.h#L43-L50) struct.
The return value of the event handler is ignored.
Example usage, that detects a window being resized:
Taking too long to process the events has negative impact on the whole system performance. To address this, the events are signaled from a different thread, not from the event hook callback itself.
# Shared hooks
To minimize the performance impact on the machine only `runner` installs global hooks, passing the events to registered callbacks in each PowerToy module.
When a PowerToy module is loaded, the `runner` calls the [`get_events()`](/src/modules/interface/powertoy_module_interface.h#L40) method to get a NULL-terminated array of NULL-terminated strings with the names of the events that the PowerToy wants to subscribe to. A `const wchar_t*` string is provided for each of the event names.
Events are signalled by the `runner` calling the [`signal_event(name, data)`](/src/modules/interface/powertoy_module_interface.h#L53) method of the PowerToy module. The `name` parameter contains the NULL-terminated name of the event. The `data` parameter and the method return value are specific for each event.
This event is signaled whenever the user presses or releases a key on the keyboard. To subscribe to this event, add `"ll_keyboard"` to the table returned by the `get_events()` method.
The PowerToys runner installs low-level keyboard hook using `SetWindowsHookEx(WH_KEYBOARD_LL, ...)`. See [this MSDN page](https://docs.microsoft.com/en-us/previous-versions/windows/desktop/legacy/ms644985(v%3Dvs.85)) for details.
When a keyboard event is signaled and `ncCode` equals `HC_ACTION`, the `wParam` and `lParam` event parameters are passed to all subscribed clients in the [`LowlevelKeyboardEvent`](/src/modules/interface/lowlevel_keyboard_event_data.h#L38-L41) struct.
The `intptr_t data` event argument is a pointer to the `LowlevelKeyboardEvent` struct.
A non-zero return value from any of the subscribed PowerToys will cause the runner hook proc to return 1, thus swallowing the keyboard event.
Example usage, that makes Windows ignore the L key:
if (event.wParam == WM_KEYDOWN && event.lParam->vkCode == 0x4C) {
return 1;
} else {
return 0;
}
} else {
return 0;
}
}
```
## Windows Event Hook
This event is signaled for [a range of events](https://docs.microsoft.com/pl-pl/windows/win32/winauto/event-constants). To subscribe to this event, add `"win_hook_event"` to the table returned by the `get_events()` method. See [this MSDN doc](https://docs.microsoft.com/pl-pl/windows/win32/api/winuser/nf-winuser-setwineventhook) for details.
The `intptr_t data` event argument is a pointer to the [`WinHookEvent`](/src/modules/interface/win_hook_event_data.h#L43-L50) struct.
The return value of the event handler is ignored.
Example usage, that detects a window being resized:
Taking too long to process the events has negative impact on the whole system performance. To address this, the events are signaled from a different thread, not from the event hook callback itself.
1. If it's inserting something into the existing classes/functions, try to follow the existing style as closely as possible.
1. If it's brand new code or refactoring a complete class or area of the code, please follow as Modern C++ of a style as you can and reference the [C++ Core Guidelines](https://github.com/isocpp/CppCoreGuidelines) as much as you possibly can.
## Formatting
- We use [`.clang-format`](https://github.com/microsoft/PowerToys/blob/master/.clang-format) style file to enable automatic code formatting. You can [easily format source files from Visual Studio](https://devblogs.microsoft.com/cppblog/clangformat-support-in-visual-studio-2017-15-7-preview-1/). For example, `CTRL+K CTRL+D` formats the current document.
- If you prefer another text editor or have ClangFormat disabled in Visual Studio, you could invoke [`format_sources`](https://github.com/microsoft/PowerToys/blob/master/format_sources.ps1) powershell script from command line. It gets a list of all currently modified files from `git` and invokes clang-format on them.
Please note that you should also have `clang-format.exe` in `%PATH%` for it to work. The script can infer the path of `clang-format.exe` version which is shipped with Visual Studio at `%VCINSTALLDIR%\Tools\Llvm\bin\`, if you launch it from the *Native Tools Command Prompt for VS*.
- CI doesn't enforce code formatting yet, since we're gradually applying code formatting to the codebase, but please adhere to our formatting style for any new code.
Some files were not shown because too many files have changed in this diff
Show More
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.