Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-02-23 19:49:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix excessive logging in Light Switch service

Browse Source 
Changed log level from info/trace to debug for frequently occurring events to prevent runaway logging that could generate hundreds of GB of log files. This addresses the issue where manual override events and settings changes could trigger excessive logging in tight loops.

Co-authored-by: shuaiyuanxx <128874481+shuaiyuanxx@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-10-28 08:05:05 +00:00
parent a0fbc9546f
commit ffe854588b
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/modules/LightSwitch/LightSwitchService/LightSwitchService.cpp
View File

@@ -293,7 +293,7 @@ DWORD WINAPI ServiceWorkerThread(LPVOID lpParam)
// --- Manual override triggered ---
if (wait == WAIT_OBJECT_0 + (hParent ? 2 : 1))
{
Logger::info(L"[LightSwitchService] Manual override received while schedule OFF.");
Logger::debug(L"[LightSwitchService] Manual override received while schedule OFF.");
ResetEvent(hManualOverride);
continue;
}
@@ -301,7 +301,7 @@ DWORD WINAPI ServiceWorkerThread(LPVOID lpParam)
// --- Settings file changed ---
if (wait == WAIT_OBJECT_0 + (hParent ? 3 : 2))
{
Logger::trace(L"[LightSwitchService] Settings change event triggered, reloading settings...");
Logger::debug(L"[LightSwitchService] Settings change event triggered, reloading settings...");
ResetEvent(LightSwitchSettings::instance().GetSettingsChangedEvent());
@@ -345,7 +345,7 @@ DWORD WINAPI ServiceWorkerThread(LPVOID lpParam)
currentSettings.darkTime / 60,
currentSettings.darkTime % 60,
static_cast<int>(currentSettings.scheduleMode));
Logger::info(msg);
Logger::debug(msg);
// --- Manual override check ---
bool manualOverrideActive = false;
@@ -360,11 +360,11 @@ DWORD WINAPI ServiceWorkerThread(LPVOID lpParam)
nowMinutes == (currentSettings.darkTime + currentSettings.sunset_offset) % 1440)
{
ResetEvent(hManualOverride);
Logger::info(L"[LightSwitchService] Manual override cleared at boundary");
Logger::debug(L"[LightSwitchService] Manual override cleared at boundary");
}
else
{
Logger::info(L"[LightSwitchService] Skipping schedule due to manual override");
Logger::debug(L"[LightSwitchService] Skipping schedule due to manual override");
goto sleep_until_next_minute;
}
}

2
src/modules/LightSwitch/LightSwitchService/LightSwitchSettings.cpp
View File

@@ -38,7 +38,7 @@ void LightSwitchSettings::InitFileWatcher()
m_settingsFileWatcher = std::make_unique<FileWatcher>(
GetSettingsFileName(),
[this]() {
Logger::info(L"[LightSwitchSettings] Settings file changed, signaling event.");
Logger::debug(L"[LightSwitchSettings] Settings file changed, signaling event.");
SetEvent(m_settingsChangedEvent);
});
}