From ffe854588bd0128850bdedb385143c1b88d3ee35 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 28 Oct 2025 08:05:05 +0000 Subject: [PATCH] Fix excessive logging in Light Switch service Changed log level from info/trace to debug for frequently occurring events to prevent runaway logging that could generate hundreds of GB of log files. This addresses the issue where manual override events and settings changes could trigger excessive logging in tight loops. Co-authored-by: shuaiyuanxx <128874481+shuaiyuanxx@users.noreply.github.com> --- .../LightSwitchService/LightSwitchService.cpp | 10 +++++----- .../LightSwitchService/LightSwitchSettings.cpp | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/modules/LightSwitch/LightSwitchService/LightSwitchService.cpp b/src/modules/LightSwitch/LightSwitchService/LightSwitchService.cpp index 7ebe4a67eb..5722b446ec 100644 --- a/src/modules/LightSwitch/LightSwitchService/LightSwitchService.cpp +++ b/src/modules/LightSwitch/LightSwitchService/LightSwitchService.cpp @@ -293,7 +293,7 @@ DWORD WINAPI ServiceWorkerThread(LPVOID lpParam) // --- Manual override triggered --- if (wait == WAIT_OBJECT_0 + (hParent ? 2 : 1)) { - Logger::info(L"[LightSwitchService] Manual override received while schedule OFF."); + Logger::debug(L"[LightSwitchService] Manual override received while schedule OFF."); ResetEvent(hManualOverride); continue; } @@ -301,7 +301,7 @@ DWORD WINAPI ServiceWorkerThread(LPVOID lpParam) // --- Settings file changed --- if (wait == WAIT_OBJECT_0 + (hParent ? 3 : 2)) { - Logger::trace(L"[LightSwitchService] Settings change event triggered, reloading settings..."); + Logger::debug(L"[LightSwitchService] Settings change event triggered, reloading settings..."); ResetEvent(LightSwitchSettings::instance().GetSettingsChangedEvent()); @@ -345,7 +345,7 @@ DWORD WINAPI ServiceWorkerThread(LPVOID lpParam) currentSettings.darkTime / 60, currentSettings.darkTime % 60, static_cast(currentSettings.scheduleMode)); - Logger::info(msg); + Logger::debug(msg); // --- Manual override check --- bool manualOverrideActive = false; @@ -360,11 +360,11 @@ DWORD WINAPI ServiceWorkerThread(LPVOID lpParam) nowMinutes == (currentSettings.darkTime + currentSettings.sunset_offset) % 1440) { ResetEvent(hManualOverride); - Logger::info(L"[LightSwitchService] Manual override cleared at boundary"); + Logger::debug(L"[LightSwitchService] Manual override cleared at boundary"); } else { - Logger::info(L"[LightSwitchService] Skipping schedule due to manual override"); + Logger::debug(L"[LightSwitchService] Skipping schedule due to manual override"); goto sleep_until_next_minute; } } diff --git a/src/modules/LightSwitch/LightSwitchService/LightSwitchSettings.cpp b/src/modules/LightSwitch/LightSwitchService/LightSwitchSettings.cpp index a7f44cca6d..2368543847 100644 --- a/src/modules/LightSwitch/LightSwitchService/LightSwitchSettings.cpp +++ b/src/modules/LightSwitch/LightSwitchService/LightSwitchSettings.cpp @@ -38,7 +38,7 @@ void LightSwitchSettings::InitFileWatcher() m_settingsFileWatcher = std::make_unique( GetSettingsFileName(), [this]() { - Logger::info(L"[LightSwitchSettings] Settings file changed, signaling event."); + Logger::debug(L"[LightSwitchSettings] Settings file changed, signaling event."); SetEvent(m_settingsChangedEvent); }); }