mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-08-29 10:09:43 +02:00
[Advanced Paste] Don't hardcode reasoning_effort=minimal for OpenAI p… (#49840)
…roviders PR #46727 added `ReasoningEffort = "minimal"` to OpenAIPromptExecutionSettings in SemanticKernelPasteProvider.CreateExecutionSettings(). The value is not user-configurable, so every OpenAI/Azure OpenAI request now fails on models that don't accept 'minimal': HTTP 400 (invalid_request_error: unsupported_value) Parameter: reasoning_effort Unsupported value: 'reasoning_effort' does not support 'minimal' with this model. Supported values are: 'medium'. This is the same class of regression PR #43766 previously fixed by removing hardcoded Temperature/tuning properties. Remove the property so the service default applies, and add a comment to prevent it being reintroduced. <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
@@ -172,10 +172,12 @@ namespace AdvancedPaste.Services.CustomActions
|
||||
{
|
||||
return _serviceType switch
|
||||
{
|
||||
// Do not set model-specific tuning properties such as ReasoningEffort here: models
|
||||
// accept different value sets (or reject the parameter outright) and any hardcoded
|
||||
// value makes every request fail with HTTP 400 on models that don't support it.
|
||||
AIServiceType.OpenAI or AIServiceType.AzureOpenAI => new OpenAIPromptExecutionSettings
|
||||
{
|
||||
FunctionChoiceBehavior = null,
|
||||
ReasoningEffort = "minimal",
|
||||
},
|
||||
_ => new PromptExecutionSettings(),
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user