From 39c048d06f4a3d4dbeeff9b34e765678af846231 Mon Sep 17 00:00:00 2001 From: Gordon Lam <73506701+yeelam-gordon@users.noreply.github.com> Date: Thu, 13 Aug 2026 19:24:09 +0800 Subject: [PATCH] =?UTF-8?q?[Advanced=20Paste]=20Don't=20hardcode=20reasoni?= =?UTF-8?q?ng=5Feffort=3Dminimal=20for=20OpenAI=20p=E2=80=A6=20(#49840)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …roviders PR #46727 added `ReasoningEffort = "minimal"` to OpenAIPromptExecutionSettings in SemanticKernelPasteProvider.CreateExecutionSettings(). The value is not user-configurable, so every OpenAI/Azure OpenAI request now fails on models that don't accept 'minimal': HTTP 400 (invalid_request_error: unsupported_value) Parameter: reasoning_effort Unsupported value: 'reasoning_effort' does not support 'minimal' with this model. Supported values are: 'medium'. This is the same class of regression PR #43766 previously fixed by removing hardcoded Temperature/tuning properties. Remove the property so the service default applies, and add a comment to prevent it being reintroduced. ## Summary of the Pull Request ## PR Checklist - [ ] Closes: #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments ## Validation Steps Performed Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .../Services/CustomActions/SemanticKernelPasteProvider.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/modules/AdvancedPaste/AdvancedPaste/Services/CustomActions/SemanticKernelPasteProvider.cs b/src/modules/AdvancedPaste/AdvancedPaste/Services/CustomActions/SemanticKernelPasteProvider.cs index 90c8d58b1b..710aa07e66 100644 --- a/src/modules/AdvancedPaste/AdvancedPaste/Services/CustomActions/SemanticKernelPasteProvider.cs +++ b/src/modules/AdvancedPaste/AdvancedPaste/Services/CustomActions/SemanticKernelPasteProvider.cs @@ -172,10 +172,12 @@ namespace AdvancedPaste.Services.CustomActions { return _serviceType switch { + // Do not set model-specific tuning properties such as ReasoningEffort here: models + // accept different value sets (or reject the parameter outright) and any hardcoded + // value makes every request fail with HTTP 400 on models that don't support it. AIServiceType.OpenAI or AIServiceType.AzureOpenAI => new OpenAIPromptExecutionSettings { FunctionChoiceBehavior = null, - ReasoningEffort = "minimal", }, _ => new PromptExecutionSettings(), };