Mirrors/task
1
0
Fork 0
mirror of https://github.com/go-task/task.git synced 2026-02-25 04:33:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(tests): normalize path separators in golden file comparison

Browse Source 
- Extend normalizeLineEndings to convert backslashes to forward slashes
- Normalize TEST_DIR with filepath.ToSlash() for template data
- Fix TestIncludedTaskfileVarMerging assertion to use filepath.ToSlash()

This fixes golden file tests on Windows where paths contain backslashes.
This commit is contained in:
Valentin Maerten
2026-01-31 10:24:16 +01:00
parent 185730bed7
commit c96e32cdd2
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
task_test.go
View File

@@ -88,7 +88,7 @@ func (tt *TaskTest) writeFixture(
if tt.fixtureTemplatingEnabled {
fixtureTemplateData := map[string]any{
"TEST_NAME": t.Name(),
"TEST_DIR": wd,
"TEST_DIR": filepath.ToSlash(wd),
}
// If the test has additional template data, copy it into the map
if tt.fixtureTemplateData != nil {
@@ -308,10 +308,13 @@ func PPSortedLines(t *testing.T, b []byte) []byte {
return []byte(strings.Join(lines, "\n") + "\n")
}
// normalizeLineEndings converts CRLF and CR to LF for cross-platform comparison
// normalizeLineEndings normalizes cross-platform differences for comparison:
// - Converts CRLF and CR to LF
// - Converts backslashes to forward slashes (Windows paths)
func normalizeLineEndings(b []byte) []byte {
b = bytes.ReplaceAll(b, []byte("\r\n"), []byte("\n"))
b = bytes.ReplaceAll(b, []byte("\r"), []byte("\n"))
b = bytes.ReplaceAll(b, []byte("\\"), []byte("/"))
return b
}
@@ -1341,7 +1344,7 @@ func TestIncludedTaskfileVarMerging(t *testing.T) {
err := e.Run(t.Context(), &task.Call{Task: test.task})
require.NoError(t, err)
assert.Contains(t, buff.String(), test.expectedOutput)
assert.Contains(t, filepath.ToSlash(buff.String()), test.expectedOutput)
})
}
}