Mirrors/task
1
0
Fork 0
mirror of https://github.com/go-task/task.git synced 2026-05-18 13:15:41 +02:00
Code Issues Packages Projects Releases Wiki Activity

chore: add nolint annotations for gosec linter

Browse Source 
Add //nolint:gosec annotations for intentional code patterns
that are safe in context (path traversal in release tool,
uintptr conversion for terminals, weak rand in tests,
TLS skip verify for user-configured insecure mode).

Assisted-by: Kimi-K2.5 via Crush <crush@charm.land>
This commit is contained in:
Andrey Nering
2026-04-13 10:32:09 -03:00
parent b36fcfd8bb
commit 219bf3e5a5
5 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cmd/release/main.go
View File

@@ -117,7 +117,7 @@ func changelog(version *semver.Version) error {
changelog = changelogReleaseRegex.ReplaceAllString(changelog, fmt.Sprintf("## v%s - %s", version, date))
// Write the changelog to the source file
if err := os.WriteFile(changelogSource, []byte(changelog), 0o644); err != nil {
if err := os.WriteFile(changelogSource, []byte(changelog), 0o644); err != nil { //nolint:gosec
return err
}
@@ -129,7 +129,7 @@ func changelog(version *semver.Version) error {
changelogWithFrontmatter := fmt.Sprintf("---\n%s\n---\n\n%s", frontmatter, changelogWithVPre)
// Write the changelog to the target file
return os.WriteFile(changelogTarget, []byte(changelogWithFrontmatter), 0o644)
return os.WriteFile(changelogTarget, []byte(changelogWithFrontmatter), 0o644) //nolint:gosec
}
func setVersionFile(fileName string, version *semver.Version) error {

2
internal/term/term.go
View File

@@ -7,5 +7,5 @@ import (
)
func IsTerminal() bool {
return term.IsTerminal(int(os.Stdin.Fd())) && term.IsTerminal(int(os.Stdout.Fd()))
return term.IsTerminal(int(os.Stdin.Fd())) && term.IsTerminal(int(os.Stdout.Fd())) //nolint:gosec
}

2
task_test.go
View File

@@ -1022,7 +1022,7 @@ func TestIncludesRemote(t *testing.T) {
for k, taskCall := range taskCalls {
t.Run(taskCall.Task, func(t *testing.T) {
expectedContent := fmt.Sprint(rand.Int64())
expectedContent := fmt.Sprint(rand.Int64()) //nolint:gosec
t.Setenv("CONTENT", expectedContent)
outputFile := fmt.Sprintf("%d.%d.txt", i, k)

2
taskfile/node_http.go
View File

@@ -38,7 +38,7 @@ func buildHTTPClient(insecure bool, caCert, cert, certKey string) (*http.Client,
}
tlsConfig := &tls.Config{
InsecureSkipVerify: insecure,
InsecureSkipVerify: insecure, //nolint:gosec
}
// Load custom CA certificate if provided

2
taskrc/reader.go
View File

@@ -65,7 +65,7 @@ func (r *Reader) Read(node *Node) (*ast.TaskRC, error) {
}
// Read the file
b, err := os.ReadFile(node.entrypoint)
b, err := os.ReadFile(node.entrypoint) //nolint:gosec
if err != nil {
return nil, err
}