Mirrors/rowy
1
0
Fork 0
mirror of https://github.com/rowyio/rowy.git synced 2025-12-29 00:16:39 +01:00
Code Issues Packages Projects Releases Wiki Activity
3,947 Commits 45 Branches 19 Tags
40477f7a36a62040741609b4297b8996a8496271
Commit Graph

3947 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rob Jackson
40477f7a36 Cast number inputs before save 2023-05-14 13:46:08 +01:00
Rob Jackson
65686d80e0 Fix number inputs on SideDrawerField 2023-05-14 13:30:44 +01:00
Rob Jackson
a292667c92 Fix Safari turning decimal number inputs to 0 
Chrome has some slightly unique input[type="number"] handling behaviour, where it restricts the characters that can be typed to numeric characters. Under-the-hood, Chrome withholds certain invalid input states from being emitted as change events – so we only receive change events for valid numbers.

Safari behaves slightly differently. It allows any characters to be entered and emits a change event on each character press, but its internal "value" is only set if the typed input is a valid number. The change events then either come through with a numeric value represented, or as an empty string.

For example, when typing "12.34" we receive onChange events with "1", "12", "", "12.3", and "12.34".

On that third onChange event when we pass "" up to React, React happily ignores the change (I _think_ bceause the incoming value "" already matches the element's value of ""; nonetheless, React have solved this issue for us).

When we parse the input via `Number(v)` we encounter problems. `Number("")` resolves to `0`, React sets the input's value to `0`, and the user is therefore unable to type decimal values successfully.

The solution for this is not to cast to a number at all. We'll rely on default browser behaviour to manage the input for us (allowing users to enter invalid characters), but we're still safe because the element's internal state will always be numeric.

In the scenario that a customer does try enter an invalid input "abc123", the input field simply blanks itself when they leave it.
 2023-05-10 15:24:25 +01:00
Harini Janakiraman
5708153798 Update CONTRIBUTING.md 
Fixed link
 2023-05-02 22:18:35 +10:00
Harini Janakiraman
4fc88e36f8 Update README.md 2023-04-09 11:18:33 +10:00
Shams
4a077b562e Merge pull request #1179 from rowyio/rc 
Rc
 2023-03-28 12:11:26 +02:00
Shams
9382d8ccb1 Merge pull request #1158 from rowyio/develop 
Develop
 2023-03-13 17:44:18 +01:00
Shams
2ef02550ea Merge pull request #1148 from iamanishroy/fix-resizing-app-crash 
ROWY-805: Fix resizing app crash
 2023-03-10 17:24:05 +01:00
iamanishroy
efce39a117 added custom hook [to be tested] 2023-03-07 12:52:13 +05:30
Shams
0987499c1a Merge pull request #1144 from rowyio/ROWY-962-ROWY-976-preview-table 
ROWY-976: preview table bug fix, ref improvements
 2023-03-02 13:51:54 +01:00
Han Tuerker
d02d72f3ea feat(preview-table): add serialized ref including parent recursively 2023-03-02 10:10:37 +01:00
Han Tuerker
f36adf296c fix(preview-table): fix table sort bug 2023-03-01 22:23:16 +01:00
Shams
11508711fb Merge pull request #1141 from rowyio/feature/code-action-consolelog 
Add code action: replace console.log with logging.log
 2023-03-01 11:36:47 +01:00
Bobby Wang
6b136b0d0e add code action: replace console.log with logging.log 2023-02-27 07:59:23 +07:00
Shams
189b1063a8 Merge pull request #1140 from rowyio/develop 
Develop
 2023-02-26 13:12:59 +01:00
Shams
276033e0f4 Merge pull request #1136 from rowyio/ROWY-969-formula-field-add-ref-to-context 
ROWY-969: Add ref object to formula context
 2023-02-26 13:11:53 +01:00
Shams
2301718ed3 Merge pull request #1139 from iamanishroy/save-sort-on-update 
Bug fix: rerendering
 2023-02-26 13:08:02 +01:00
iamanishroy
eafb209d3b added comments 2023-02-26 16:17:46 +05:30
iamanishroy
e48d06377f bug fix: infinite rendering 2023-02-26 16:13:03 +05:30
Han Tuerker
869763c5a9 add ref object to worker context 2023-02-26 08:11:43 +03:00
Shams
eef7edb15e Merge pull request #1134 from rowyio/develop 
Develop
 2023-02-24 08:45:46 +01:00
Shams
4bbe1e993d Merge pull request #1131 from rowyio/feature/logging-multi-params 
ROWY-912: allow multiple params for logging
 2023-02-24 00:48:54 +01:00
Shams
b43efea0e9 Merge pull request #1132 from iamanishroy/feat-editable-user-column 
ROWY-482: Fix: issue on clearing the value
 2023-02-24 00:48:01 +01:00
Shams
0b82b6dd3d Merge pull request #1133 from iamanishroy/save-sort-on-update 
ROWY-960: Removed not required console logs
 2023-02-24 00:47:31 +01:00
iamanishroy
e5f0cbd29a remove not required console logs 2023-02-23 21:08:18 +05:30
iamanishroy
cf569c1c12 fixed: bug on clearing value 2023-02-23 20:55:24 +05:30
Bobby Wang
f756f1f0a0 allow multiple params for logging 2023-02-23 13:54:15 +07:00
Shams
0bec338ed1 Merge pull request #1130 from rowyio/develop 
Develop
 2023-02-22 15:16:49 +01:00
Shams
eee88d944c Merge pull request #1112 from saravanan-inc/reorderImageFileField 
Reorder image file field
 2023-02-22 14:55:05 +01:00
Shams
a1604077f5 Merge pull request #1103 from iamanishroy/save-sort-on-update 
ROWY-444: Save sort on the table
 2023-02-22 12:08:53 +01:00
Shams
55bd6708e6 Merge pull request #1126 from iamanishroy/fix/import-json 
ROWY-951: Fixed minor bug in parsing JSON objects
 2023-02-22 08:17:53 +01:00
Shams
11c331b47d Merge pull request #1127 from iamanishroy/import-export-csv-fixes 
ROWY-759: test and improve import existing data fieldType detection
 2023-02-22 08:16:51 +01:00
iamanishroy
818fc52adb save default sort for the user 2023-02-21 23:58:15 +05:30
iamanishroy
c8d340e1d3 number/date fix 2023-02-18 21:45:57 +05:30
iamanishroy
e26949ac65 parse array values 2023-02-18 21:34:39 +05:30
unknown
e41e4819d0 add support for reordering in the sidedrawer 2023-02-18 20:46:16 +05:30
unknown
845c141e8e refactor: hide the drag and drop icon when there's only one image and file in the cell, to save on space 2023-02-18 19:56:25 +05:30
Shams
9163a71a1e Merge pull request #1124 from rowyio/develop 
Develop
 2023-02-17 07:27:58 +01:00
Shams
36bd687893 Merge pull request #1096 from iamanishroy/feat-editable-user-column 
ROWY-482: Feat editable user column
 2023-02-17 07:09:43 +01:00
Shams
ebb8b85374 Update index.tsx 2023-02-17 17:06:39 +11:00
Shams
9527511f40 Merge pull request #1116 from iamanishroy/new-field-array 
ROWY-688: New field Array
 2023-02-17 07:05:35 +01:00
Shams
571f60fda3 Merge pull request #1119 from iamanishroy/update-info-panel 
ROWY-936: Demo app should open with info panel
 2023-02-17 06:51:37 +01:00
Shams
0bde7dc47f Merge pull request #1118 from iamanishroy/import-export-csv-fixes 
ROWY-202: Change Export CSV date format so it can be parsed by Import CSV
 2023-02-17 06:50:39 +01:00
Shams
7a99cb90cd Merge pull request #1056 from rowyio/ROWY-831-preview-table 
ROWY-831: Add preview table
 2023-02-15 17:37:33 +01:00
Han Tuerker
00a76bbd7b fix clone object error 2023-02-15 17:32:00 +03:00
Han Tuerker
0febee0072 hide unneccessary fields 2023-02-15 17:12:49 +03:00
iamanishroy
98b316eb3c detect type fixes 2023-02-14 18:43:28 +05:30
iamanishroy
6a947c69ef removed unwanted imports 2023-02-13 16:06:53 +05:30
iamanishroy
f9b54d70a2 set common format for import export of date/time 2023-02-13 10:41:10 +05:30
Harini Janakiraman
07957585ca Update README.md 2023-02-13 12:44:40 +11:00