add functionConfig.ts validation

This commit is contained in:
Bobby
2021-03-16 20:18:59 +11:00
parent cc1e163f32
commit e7b0520bde
3 changed files with 12 additions and 5 deletions

View File

@@ -34,10 +34,17 @@ export default async function generateConfig(
await addPackages(requiredDependencies.map((p: any) => ({ name: p })));
}
await asyncExecute(
const isFunctionConfigValid = await asyncExecute(
"cd build/functions/src; tsc functionConfig.ts",
commandErrorHandler({ user })
commandErrorHandler({
user,
functionConfigTs: configFile,
description: `Invalid compiled functionConfig.ts`,
})
);
if (!isFunctionConfigValid) {
return false;
}
const { sparksConfig } = require("../functions/src/functionConfig.js");
const requiredSparks = sparksConfig.map((s: any) => s.type);

View File

@@ -13,7 +13,7 @@ export const asyncExecute = async (command: string, callback: any) =>
child.exec(command, async function (error, stdout, stderr) {
console.log({ error, stdout, stderr });
await callback(error, stdout, stderr);
resolve(true);
resolve(!error);
});
});

View File

@@ -15,7 +15,7 @@ function firetableUser(user: admin.auth.UserRecord) {
export function commandErrorHandler(meta: {
user: admin.auth.UserRecord;
description?: string;
combiledScript?: string;
functionConfigTs?: string;
sparksConfig?: string;
}) {
return async function (error, stdout, stderr) {
@@ -32,7 +32,7 @@ export function commandErrorHandler(meta: {
errorStackTrace: error?.stack ?? "",
command: error?.cmd ?? "",
description: meta?.description ?? "",
combiledScript: meta?.combiledScript ?? "",
functionConfigTs: meta?.functionConfigTs ?? "",
sparksConfig: meta?.sparksConfig ?? "",
};