Mirrors/rowy
1
0
Fork 0
mirror of https://github.com/rowyio/rowy.git synced 2025-12-29 00:16:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix the crash issue when pasting into action field input form

Browse Source
This commit is contained in:
Bobby Wang
2022-09-21 02:34:52 +08:00
parent e64b8ad713
commit 422aebdfba
1 changed files with 20 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/components/fields/Action/Settings.tsx
View File

@@ -88,7 +88,7 @@ const Settings = ({ config, onChange, fieldName }: ISettingsProps) => {
Array.isArray(config.params) ? config.params : [],
{ space: 2 }
);
const [codeValid, setCodeValid] = useState(true);
const [codeErrorMessage, setCodeErrorMessage] = useState<string | null>(null);
const scriptExtraLibs = [
[
@@ -96,14 +96,16 @@ const Settings = ({ config, onChange, fieldName }: ISettingsProps) => {
" /**",
" * actionParams are provided by dialog popup form",
" */",
(config.params ?? []).filter(Boolean).map((param: any) => {
const validationKeys = Object.keys(param.validation ?? {});
if (validationKeys.includes("string")) {
return `static ${param.name}: string`;
} else if (validationKeys.includes("array")) {
return `static ${param.name}: any[]`;
} else return `static ${param.name}: any`;
}),
(Array.isArray(config.params) ? config.params : [])
.filter(Boolean)
.map((param: any) => {
const validationKeys = Object.keys(param.validation ?? {});
if (validationKeys.includes("string")) {
return `static ${param.name}: string`;
} else if (validationKeys.includes("array")) {
return `static ${param.name}: any[]`;
} else return `static ${param.name}: any`;
}),
"}",
].join("\n"),
actionDefs,
@@ -256,25 +258,25 @@ const Settings = ({ config, onChange, fieldName }: ISettingsProps) => {
value={formattedParamsJson}
onChange={(v) => {
try {
if (v) {
const parsed = JSON.parse(v);
const parsed = JSON.parse(v ?? "");
if (Array.isArray(parsed)) {
onChange("params")(parsed);
setCodeErrorMessage(null);
} else {
setCodeErrorMessage("Form fields must be array");
}
} catch (e) {
console.log(`Failed to parse JSON: ${e}`);
setCodeValid(false);
setCodeErrorMessage("Invalid JSON");
}
}}
onValidStatusUpdate={({ isValid }) =>
setCodeValid(isValid)
}
error={!codeValid}
error={!!codeErrorMessage}
/>
</Suspense>
{!codeValid && (
{codeErrorMessage && (
<FormHelperText error variant="filled">
Invalid JSON
{codeErrorMessage}
</FormHelperText>
)}
</FormControl>