fix date filters crashing when value is null

This commit is contained in:
Sidney Alcantara
2022-06-18 14:15:01 +10:00
parent cf26243e99
commit 33d4c93ada
2 changed files with 4 additions and 3 deletions

View File

@@ -1,7 +1,7 @@
import { useState, useEffect } from "react";
import { useAtom } from "jotai";
import useMemoValue from "use-memo-value";
import { isEmpty } from "lodash-es";
import { isEmpty, isDate } from "lodash-es";
import {
Tab,
@@ -42,9 +42,9 @@ import type { TableFilter } from "@src/types/table";
const shouldDisableApplyButton = (value: any) =>
isEmpty(value) &&
!isDate(value) &&
typeof value !== "boolean" &&
typeof value !== "number" &&
typeof value !== "object";
typeof value !== "number";
enum FilterType {
yourFilter = "local_filter",

View File

@@ -347,6 +347,7 @@ export const tableFiltersToFirestoreFilters = (filters: TableFilter[]) => {
for (const filter of filters) {
if (filter.operator.startsWith("date-")) {
if (!filter.value) continue;
const filterDate =
"toDate" in filter.value ? filter.value.toDate() : filter.value;
const [startDate, endDate] = getDateRange(filterDate);