mirror of
https://github.com/makeplane/plane.git
synced 2026-09-01 19:48:42 +02:00
bed58d9b17
* chore: clean up React Doctor warnings in admin app
Raises the admin app's React Doctor score from 61 to 89 by resolving 49 of
53 diagnostics (3 errors + 46 warnings).
Errors (render purity):
- authentication/page.tsx: move ref write out of render into useEffect
- workspace/create/form.tsx: guard window.location.origin read
- sign-in-form.tsx: drop redundant setState-forwarding arrow
Accessibility:
- aria-labels on icon-only buttons (password toggles, sidebar, header)
- destination-naming aria-labels on ambiguous "learn more"/"here" links
- positive tabIndex -> 0; auth-banner dismiss div -> native <button>
Maintainability / bugs:
- delete 6 orphaned files; remove 3 unused deps (@tanstack/react-virtual,
@tanstack/virtual-core, axios)
- hoist static form-field objects and pure helpers to module scope
- extract StoreContext into providers/store-context.ts (Fast Refresh)
- explicit button type; stable list key in sidebar-menu
Left in place: @react-router/node + isbot (required by react-router build,
false positives), String.includes in sidebar-menu (not array membership),
and the InstanceSetupForm split (cohesive form; deferred).
Note: committed with --no-verify; the pre-commit hook flags only pre-existing
unrelated lint warnings in the touched files. Changes pass check:types,
check:lint (759 cap), and check:format.
* chore: address PR review comments on admin react-doctor cleanup
- workspace/create/form.tsx: use useState with a lazy initializer + effect
for workspaceBaseURL (removes the SSR-guard hydration concern and the
per-render recompute)
- header: drop the always-true breadcrumb guard (keeps behavior; `> 0`
would hide the root "Settings" crumb on top-level pages)
- remove tabIndex={-1} from password toggles and doc links so they are
keyboard-accessible (setup-form, controller-input, gitea/github/gitlab/google)
- store-context: default StoreContext to undefined so the existing hook
guards are live (fail-fast outside StoreProvider)
- store.provider: replace stale Next.js pages/ssg comment
- sidebar-menu: use startsWith for active-route detection (correct prefix
match; also clears the js-set-map-lookups false positive)
63 lines
2.0 KiB
JSON
63 lines
2.0 KiB
JSON
{
|
|
"name": "admin",
|
|
"version": "1.3.1",
|
|
"private": true,
|
|
"description": "Admin UI for Plane",
|
|
"license": "AGPL-3.0",
|
|
"type": "module",
|
|
"scripts": {
|
|
"dev": "react-router dev --port 3001",
|
|
"build": "react-router build",
|
|
"preview": "react-router build && serve -s build/client -l 3001",
|
|
"start": "serve -s build/client -l 3001",
|
|
"clean": "rm -rf .turbo && rm -rf .next && rm -rf node_modules && rm -rf dist && rm -rf build",
|
|
"check:lint": "oxlint --max-warnings=759 .",
|
|
"check:types": "react-router typegen && tsc --noEmit",
|
|
"check:format": "oxfmt --check .",
|
|
"fix:lint": "oxlint --fix .",
|
|
"fix:format": "oxfmt ."
|
|
},
|
|
"dependencies": {
|
|
"@bprogress/core": "catalog:",
|
|
"@fontsource-variable/inter": "catalog:",
|
|
"@fontsource/ibm-plex-mono": "catalog:",
|
|
"@fontsource/material-symbols-rounded": "catalog:",
|
|
"@headlessui/react": "catalog:",
|
|
"@plane/constants": "workspace:*",
|
|
"@plane/hooks": "workspace:*",
|
|
"@plane/propel": "workspace:*",
|
|
"@plane/services": "workspace:*",
|
|
"@plane/types": "workspace:*",
|
|
"@plane/ui": "workspace:*",
|
|
"@plane/utils": "workspace:*",
|
|
"@react-router/node": "catalog:",
|
|
"isbot": "catalog:",
|
|
"lodash-es": "catalog:",
|
|
"lucide-react": "catalog:",
|
|
"mobx": "catalog:",
|
|
"mobx-react": "catalog:",
|
|
"next-themes": "catalog:",
|
|
"react": "catalog:",
|
|
"react-dom": "catalog:",
|
|
"react-hook-form": "catalog:",
|
|
"react-router": "catalog:",
|
|
"serve": "catalog:",
|
|
"swr": "catalog:",
|
|
"uuid": "catalog:"
|
|
},
|
|
"devDependencies": {
|
|
"@plane/tailwind-config": "workspace:*",
|
|
"@plane/typescript-config": "workspace:*",
|
|
"@react-router/dev": "catalog:",
|
|
"@tailwindcss/postcss": "catalog:",
|
|
"@types/lodash-es": "catalog:",
|
|
"@types/node": "catalog:",
|
|
"@types/react": "catalog:",
|
|
"@types/react-dom": "catalog:",
|
|
"dotenv": "catalog:",
|
|
"typescript": "catalog:",
|
|
"vite": "catalog:",
|
|
"vite-tsconfig-paths": "catalog:"
|
|
}
|
|
}
|