bd25c20105
IssueAttachmentDetailAPIEndpoint evaluated its permission against the Issue named in the URL while the object acted on was a FileAsset that had never been bound to it. delete, get and patch all resolved on pk + slug + project_id, so a caller named a work item they were entitled to act on and reached any asset in the project. With no entity_type filter, page and comment inline images resolved through the work-item attachment route as well and could be read or destroyed. The app copy was fixed by5829f0feb(PR #9315); this is the port, plus the entity_type binding that fix did not include. The sibling list handler here already filters on entity_type, so the detail route now resolves exactly what the list route returns. patch also set created_by = request.user, so confirming an upload transferred recorded ownership. That matters beyond the audit trail: delete grants the creator a delete right, so the reassignment handed over the ability to destroy someone else's attachment. Line dropped, as the app copy dropped it. delete's allowed_roles listed every role, which made the filter a no-op and reduced the check to any active project member, contradicting both the handler's own comment and the app decorator. Narrowing it to ADMIN alone would have been wrong in both directions: user_has_issue_permission's allow_creator branch compares against issue.created_by_id, the work item's author, not the attachment's uploader. That would have granted delete to an author who never touched the file and denied it to the member who uploaded it, breaking a legitimate path. So the asset is resolved first and authorization is then admin-or-uploader against the asset, matching @allow_permission([ROLE.ADMIN], creator=True, model=FileAsset). Contract tests cover cross-work-item delete and read, a page image through the attachment route, a member deleting another member's upload, and the ownership transfer, with controls for an admin deleting a correctly bound attachment and an uploader deleting their own. Fail-before at880960390a: 5 of 13 fail, the 8 passing being this PR's existing tests plus both controls. Note for the test fixtures: BaseModel.save() resolves the current user and sets created_by to None when no request is in scope, so ownership has to be seeded with a queryset update rather than objects.create(created_by=...). Co-authored-by: Plane AI <noreply@plane.so>
Modern project management for all teams
Website • Forum • X • Documentation
Meet Plane, an open-source project management tool to track issues, run sprints cycles, and manage product roadmaps without the chaos of managing the tool itself. 🧘♀️
Plane is evolving every day. Your suggestions, ideas, and reported bugs help us immensely. Do not hesitate to join in the conversation on Forum or raise a GitHub issue. We read everything and respond to most.
🚀 Installation
Getting started with Plane is simple. Choose the setup that works best for you:
-
Plane Cloud Sign up for a free account on Plane Cloud—it's the fastest way to get up and running without worrying about infrastructure.
-
Self-host Plane Prefer full control over your data and infrastructure? Install and run Plane on your own servers. Follow our detailed deployment guides to get started.
| Installation methods | Docs link |
|---|---|
| Docker |  |
| Kubernetes |  |
Instance admins can configure instance settings with God mode.
🌟 Features
-
Work Items Efficiently create and manage tasks with a robust rich text editor that supports file uploads. Enhance organization and tracking by adding sub-properties and referencing related issues.
-
Cycles Maintain your team’s momentum with Cycles. Track progress effortlessly using burn-down charts and other insightful tools.
-
Modules Simplify complex projects by dividing them into smaller, manageable modules.
-
Views Customize your workflow by creating filters to display only the most relevant issues. Save and share these views with ease.
-
Pages Capture and organize ideas using Plane Pages, complete with AI capabilities and a rich text editor. Format text, insert images, add hyperlinks, or convert your notes into actionable items.
-
Analytics Access real-time insights across all your Plane data. Visualize trends, remove blockers, and keep your projects moving forward.
🛠️ Local development
See CONTRIBUTING
⚙️ Built with
📸 Screenshots
📝 Documentation
Explore Plane's product documentation and developer documentation to learn about features, setup, and usage.
❤️ Community
Join the Plane community on GitHub Discussions and our Forum. We follow a Code of conduct in all our community channels.
Feel free to ask questions, report bugs, participate in discussions, share ideas, request features, or showcase your projects. We’d love to hear from you!
🛡️ Security
If you discover a security vulnerability in Plane, please report it responsibly instead of opening a public issue. We take all legitimate reports seriously and will investigate them promptly. See Security policy for more info.
To disclose any security issues, please email us at security@plane.so.
🤝 Contributing
There are many ways you can contribute to Plane:
- Report bugs or submit feature requests.
- Review the documentation and submit pull requests to improve it—whether it's fixing typos or adding new content.
- Talk or write about Plane or any other ecosystem integration and let us know!
- Show your support by upvoting popular feature requests.
Please read CONTRIBUTING.md for details on the process for submitting pull requests to us.
Repo activity
We couldn't have done this without you.
License
This project is licensed under the GNU Affero General Public License v3.0.