[SILO-152] fix: remove default on flags (#2981)

* fix: remove default on flags

* fix: slack integration
This commit is contained in:
Henit Chobisa
2025-04-16 20:34:37 +05:30
committed by GitHub
parent 54228f9801
commit f484f3babe
3 changed files with 4 additions and 4 deletions

View File

@@ -36,7 +36,7 @@ const GitHubIntegration: FC<{ searchParams?: { error: string } }> = observer(({
// derived values
const workspaceSlug = workspace?.slug || undefined;
const isFeatureEnabled = useFlag(workspaceSlug?.toString() || "", E_FEATURE_FLAGS.GITHUB_INTEGRATION) || true;
const isFeatureEnabled = useFlag(workspaceSlug?.toString() || "", E_FEATURE_FLAGS.GITHUB_INTEGRATION) || false;
const workspaceConnectionId = workspaceConnectionIds[0] || undefined;
const organization = workspaceConnectionId ? workspaceConnectionById(workspaceConnectionId) : undefined;
const githubLogo = resolvedTheme === "dark" ? GithubLightLogo : GithubDarkLogo;

View File

@@ -30,7 +30,7 @@ const GitlabIntegration: FC<{ searchParams?: { error: string } }> = observer(({
// derived values
const workspaceSlug = workspace?.slug || undefined;
const isFeatureEnabled = useFlag(workspaceSlug?.toString() || "", E_FEATURE_FLAGS.GITLAB_INTEGRATION) || true;
const isFeatureEnabled = useFlag(workspaceSlug?.toString() || "", E_FEATURE_FLAGS.GITLAB_INTEGRATION) || false;
const workspaceConnectionId = workspaceConnectionIds[0] || undefined;
const organization = workspaceConnectionId ? workspaceConnectionById(workspaceConnectionId) : undefined;
const { currentWorkspaceSubscribedPlanDetail: subscriptionDetail } = useWorkspaceSubscription();

View File

@@ -7,7 +7,7 @@ import { useParams } from "next/navigation";
import useSWR from "swr";
import { ArrowLeft, Cloud } from "lucide-react";
// plane web components
import { SILO_BASE_PATH, SILO_BASE_URL } from "@plane/constants";
import { E_FEATURE_FLAGS, SILO_BASE_PATH, SILO_BASE_URL } from "@plane/constants";
import { E_INTEGRATION_KEYS, SILO_ERROR_CODES } from "@plane/etl/core";
import { useTranslation } from "@plane/i18n";
import { Loader, setToast, TOAST_TYPE } from "@plane/ui";
@@ -26,7 +26,7 @@ const SlackIntegration: FC<{ searchParams?: { error: string } }> = observer(({ s
// store hooks
const { fetchExternalApiToken, externalApiToken } = useSlackIntegration();
// derived values
const isFeatureEnabled = useFlag(workspaceSlug?.toString(), "SLACK_INTEGRATION");
const isFeatureEnabled = useFlag(workspaceSlug?.toString(), E_FEATURE_FLAGS.SLACK_INTEGRATION) || false;
const { currentWorkspaceSubscribedPlanDetail: subscriptionDetail } = useWorkspaceSubscription();
// derived values