Mirrors/plane
1
0
Fork 0
mirror of https://github.com/makeplane/plane.git synced 2026-07-13 14:01:45 +02:00
Code Issues Packages Projects Releases Wiki Activity

[WIKI-501] fix: flagged extensions in slash commands (#3522)

Browse Source
This commit is contained in:
Aaryan Khandelwal
2025-06-27 14:28:58 +05:30
committed by GitHub
parent 154f602eda
commit ca887168bb
2 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/editor/src/ee/extensions/document-extensions.tsx
View File

@@ -25,12 +25,13 @@ import { CustomCollaborationCursor } from "./collaboration-cursor";
* Each entry defines a single slash command option with its own enabling logic
*/
const slashCommandRegistry: {
isEnabled: (disabledExtensions: TExtensions[]) => boolean;
isEnabled: (disabledExtensions: TExtensions[], flaggedExtensions: TExtensions[]) => boolean;
getOption: (props: TDocumentEditorAdditionalExtensionsProps) => TSlashCommandAdditionalOption | null;
}[] = [
{
// Work item embed slash command
isEnabled: (disabledExtensions) => !disabledExtensions.includes("issue-embed"),
isEnabled: (disabledExtensions, flaggedExtensions) =>
!disabledExtensions.includes("issue-embed") && !flaggedExtensions.includes("issue-embed"),
getOption: () => ({
commandKey: "issue-embed",
key: "issue-embed",
@@ -47,7 +48,8 @@ const slashCommandRegistry: {
},
{
// Page embed slash command
isEnabled: (disabledExtensions) => !disabledExtensions.includes("nested-pages"),
isEnabled: (disabledExtensions, flaggedExtensions) =>
!disabledExtensions.includes("nested-pages") && !flaggedExtensions.includes("nested-pages"),
getOption: ({ embedConfig }) => {
// Only enable if page config with createCallback exists
const pageConfig = embedConfig?.page;
@@ -80,7 +82,8 @@ const slashCommandRegistry: {
},
{
// Attachment slash command
isEnabled: (disabledExtensions) => !disabledExtensions.includes("attachments"),
isEnabled: (disabledExtensions, flaggedExtensions) =>
!disabledExtensions.includes("attachments") && !flaggedExtensions.includes("attachments"),
getOption: () => ({
commandKey: "attachment",
key: "attachment",
@@ -106,7 +109,7 @@ const extensionRegistry: TDocumentEditorAdditionalExtensionsRegistry[] = [
getExtension: (props) => {
// Get enabled slash command options from the registry
const slashCommandOptions = slashCommandRegistry
.filter((command) => command.isEnabled(props.disabledExtensions || []))
.filter((command) => command.isEnabled(props.disabledExtensions, props.flaggedExtensions))
.map((command) => command.getOption(props))
.filter((option): option is TSlashCommandAdditionalOption => option !== null);

7
packages/editor/src/ee/extensions/rich-text/extensions.tsx
View File

@@ -18,11 +18,12 @@ import { CustomAttachmentExtension } from "../attachments/extension";
* Each entry defines a single slash command option with its own enabling logic
*/
const slashCommandRegistry: {
isEnabled: (disabledExtensions: TExtensions[]) => boolean;
isEnabled: (disabledExtensions: TExtensions[], flaggedExtensions: TExtensions[]) => boolean;
getOption: (props: TRichTextEditorAdditionalExtensionsProps) => TSlashCommandAdditionalOption | null;
}[] = [
{
isEnabled: (disabledExtensions) => !disabledExtensions.includes("attachments"),
isEnabled: (disabledExtensions, flaggedExtensions) =>
!disabledExtensions.includes("attachments") && !flaggedExtensions.includes("attachments"),
getOption: () => ({
commandKey: "attachment",
key: "attachment",
@@ -44,7 +45,7 @@ const extensionRegistry: TRichTextEditorAdditionalExtensionsRegistry[] = [
const { disabledExtensions, flaggedExtensions } = props;
// Get enabled slash command options from the registry
const slashCommandOptions = slashCommandRegistry
.filter((command) => command.isEnabled(disabledExtensions || []))
.filter((command) => command.isEnabled(disabledExtensions, flaggedExtensions))
.map((command) => command.getOption(props))
.filter((option): option is TSlashCommandAdditionalOption => option !== null);