Mirrors/plane
1
0
Fork 0
mirror of https://github.com/makeplane/plane.git synced 2026-02-24 04:00:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove backdrop event listeners

Browse Source
This commit is contained in:
Aaryan Khandelwal
2026-01-22 14:42:40 +05:30
parent c74377fdfb
commit ad9be51eb4
2 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/editor/src/core/extensions/table/plugins/drag-handles/column/drag-handle.ts
View File

@@ -67,6 +67,7 @@ export function createColumnDragHandle(config: ColumnDragHandleConfig): {
let dropdownElement: HTMLElement | null = null;
let backdropElement: HTMLElement | null = null;
let cleanupFloating: (() => void) | null = null;
let backdropClickHandler: (() => void) | null = null;
// Track drag event listeners for cleanup
let dragListeners: {
@@ -98,11 +99,16 @@ export function createColumnDragHandle(config: ColumnDragHandleConfig): {
dropdownElement = null;
}
if (backdropElement) {
// Remove backdrop listener before removing element
if (backdropClickHandler) {
backdropElement.removeEventListener("click", backdropClickHandler);
backdropClickHandler = null;
}
backdropElement.remove();
backdropElement = null;
}
// Cleanup floating UI
// Cleanup floating UI (this also removes keydown listener)
if (cleanupFloating) {
cleanupFloating();
cleanupFloating = null;
@@ -129,7 +135,8 @@ export function createColumnDragHandle(config: ColumnDragHandleConfig): {
// Create backdrop
backdropElement = document.createElement("div");
backdropElement.style.cssText = "position: fixed; inset: 0; z-index: 99;";
backdropElement.addEventListener("click", closeDropdown);
backdropClickHandler = closeDropdown;
backdropElement.addEventListener("click", backdropClickHandler);
document.body.appendChild(backdropElement);
// Create dropdown

11
packages/editor/src/core/extensions/table/plugins/drag-handles/row/drag-handle.ts
View File

@@ -67,6 +67,7 @@ export function createRowDragHandle(config: RowDragHandleConfig): {
let dropdownElement: HTMLElement | null = null;
let backdropElement: HTMLElement | null = null;
let cleanupFloating: (() => void) | null = null;
let backdropClickHandler: (() => void) | null = null;
// Track drag event listeners for cleanup
let dragListeners: {
@@ -98,11 +99,16 @@ export function createRowDragHandle(config: RowDragHandleConfig): {
dropdownElement = null;
}
if (backdropElement) {
// Remove backdrop listener before removing element
if (backdropClickHandler) {
backdropElement.removeEventListener("click", backdropClickHandler);
backdropClickHandler = null;
}
backdropElement.remove();
backdropElement = null;
}
// Cleanup floating UI
// Cleanup floating UI (this also removes keydown listener)
if (cleanupFloating) {
cleanupFloating();
cleanupFloating = null;
@@ -129,7 +135,8 @@ export function createRowDragHandle(config: RowDragHandleConfig): {
// Create backdrop
backdropElement = document.createElement("div");
backdropElement.style.cssText = "position: fixed; inset: 0; z-index: 99;";
backdropElement.addEventListener("click", closeDropdown);
backdropClickHandler = closeDropdown;
backdropElement.addEventListener("click", backdropClickHandler);
document.body.appendChild(backdropElement);
// Create dropdown