Mirrors/plane
1
0
Fork 0
mirror of https://github.com/makeplane/plane.git synced 2026-07-13 22:09:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1853 from makeplane/fix-half-blocks-dependencies

Browse Source 
[WEB-2803] fix: Timeline dependency for half blocks dragging
This commit is contained in:
pushya22
2024-12-02 20:05:22 +05:30
committed by GitHub
parent db2966eeab 322c55e0e7
commit 918e81c582
1 changed files with 44 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
web/ee/store/timeline/base-timeline.store.ts
View File

@@ -153,51 +153,61 @@ export class BaseTimeLineStore extends ExtendableTimelineStore implements IBaseT
/**
* returns updates dates of blocks post drag.
* @param id
* @param shouldUpdateHalfBlock if is a half block then update the incomplete block only if this is true
* @returns
*/
getUpdatedPositionAfterDrag = action((id: string, shouldIgnoreDependencies = false) => {
if (!this.currentViewData) return [];
getUpdatedPositionAfterDrag = action(
(id: string, shouldUpdateHalfBlock: boolean, shouldIgnoreDependencies = false) => {
if (!this.currentViewData) return [];
const ignoreDependencies = !this.isDependencyEnabled || shouldIgnoreDependencies;
const ignoreDependencies = !this.isDependencyEnabled || shouldIgnoreDependencies;
// Create a dependency tree with breadth first approach
const dependencyTree = buildDependencyTree(
id,
this.blocksMap,
this.rootStore.issue.issueDetail.relation.relationMap,
this.currentViewData,
ignoreDependencies
);
// Create a dependency tree with breadth first approach
const dependencyTree = buildDependencyTree(
id,
this.blocksMap,
this.rootStore.issue.issueDetail.relation.relationMap,
this.currentViewData,
ignoreDependencies
);
// get position updates by traversing the above tree
const blockUpdates = dependencyTree ? getBlockUpdates(dependencyTree, 0, 0) : [];
// get position updates by traversing the above tree
const blockUpdates = dependencyTree ? getBlockUpdates(dependencyTree, 0, 0) : [];
const blockNewDates: IBlockUpdateDependencyData[] = [];
const blockNewDates: IBlockUpdateDependencyData[] = [];
for (const blockUpdate of blockUpdates) {
const block = this.blocksMap[blockUpdate.blockId];
for (const blockUpdate of blockUpdates) {
const block = this.blocksMap[blockUpdate.blockId];
if (!block) continue;
if (!block) continue;
const newBlock: IBlockUpdateDependencyData = {
id: block.id,
start_date: renderFormattedPayloadDate(
getDateFromPositionOnGantt(blockUpdate.marginLeft, this.currentViewData)
),
target_date: renderFormattedPayloadDate(
getDateFromPositionOnGantt(
blockUpdate.marginLeft + (blockUpdate?.width ?? block?.position?.width ?? 0),
this.currentViewData,
-1
)
),
};
const newBlock: IBlockUpdateDependencyData = {
id: block.id,
};
blockNewDates.push(newBlock);
// If shouldUpdateHalfBlock or the start date is available then update start date only for the dragging block
if ((shouldUpdateHalfBlock && block.id === id) || block.start_date) {
newBlock.start_date = renderFormattedPayloadDate(
getDateFromPositionOnGantt(blockUpdate.marginLeft, this.currentViewData)
);
}
// If shouldUpdateHalfBlock or the target date is available then update target date only for the dragging block
if ((shouldUpdateHalfBlock && block.id === id) || block.target_date) {
newBlock.target_date = renderFormattedPayloadDate(
getDateFromPositionOnGantt(
blockUpdate.marginLeft + (blockUpdate?.width ?? block?.position?.width ?? 0),
this.currentViewData,
-1
)
);
}
blockNewDates.push(newBlock);
}
return blockNewDates;
}
return blockNewDates;
});
);
/**
* updates the block's position such as marginLeft and width wile dragging