refactor: remove unnecessary props

This commit is contained in:
Aaryan Khandelwal
2024-11-20 13:28:54 +05:30
parent 1314d3dd9c
commit 8416b48daf
3 changed files with 5 additions and 9 deletions

View File

@@ -21,7 +21,7 @@ import { DeletePageModal } from "@/components/pages";
// helpers
import { cn } from "@/helpers/common.helper";
// hooks
import { TPageOperations } from "@/hooks/use-page-operations";
import { usePageOperations } from "@/hooks/use-page-operations";
// plane web components
import { MovePageModal } from "@/plane-web/components/pages";
// store types
@@ -45,15 +45,16 @@ type Props = {
extraOptions?: (TContextMenuItem & { key: TPageActions })[];
optionsOrder: TPageActions[];
page: IPage;
pageOperations: TPageOperations;
parentRef?: React.RefObject<HTMLElement>;
};
export const PageActions: React.FC<Props> = observer((props) => {
const { extraOptions, optionsOrder, page, pageOperations, parentRef } = props;
const { extraOptions, optionsOrder, page, parentRef } = props;
// states
const [deletePageModal, setDeletePageModal] = useState(false);
const [movePageModal, setMovePageModal] = useState(false);
// page operations
const { pageOperations } = usePageOperations(page);
// derived values
const {
access,

View File

@@ -14,7 +14,6 @@ import { ExportPageModal, PageActions, TPageActions } from "@/components/pages";
import { copyTextToClipboard } from "@/helpers/string.helper";
// hooks
import { usePageFilters } from "@/hooks/use-page-filters";
import { usePageOperations } from "@/hooks/use-page-operations";
import { useQueryParams } from "@/hooks/use-query-params";
// store
import { IPage } from "@/store/pages/page";
@@ -30,8 +29,6 @@ export const PageOptionsDropdown: React.FC<Props> = observer((props) => {
const [isExportModalOpen, setIsExportModalOpen] = useState(false);
// router
const router = useRouter();
// page actions
const { pageOperations } = usePageOperations(page);
// derived values
const { name } = page;
// page filters
@@ -114,7 +111,6 @@ export const PageOptionsDropdown: React.FC<Props> = observer((props) => {
"export",
]}
page={page}
pageOperations={pageOperations}
/>
</>
);

View File

@@ -24,7 +24,7 @@ export const BlockItemAction: FC<Props> = observer((props) => {
// store hooks
const page = usePage(pageId);
const { getUserDetails } = useMember();
// page actions
// page operations
const { pageOperations } = usePageOperations(page);
// derived values
const { access, created_at, is_favorite, owned_by, canCurrentUserFavoritePage } = page;
@@ -77,7 +77,6 @@ export const BlockItemAction: FC<Props> = observer((props) => {
"delete",
]}
page={page}
pageOperations={pageOperations}
parentRef={parentRef}
/>
</>