Mirrors/plane
1
0
Fork 0
mirror of https://github.com/makeplane/plane.git synced 2026-09-02 12:09:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

[WEB-8333] test: exercise ROLE.MEMBER path in positive controls (Copilot #9461)

Browse Source 
The positive-control tests authenticate as create_user, who was an ADMIN (role
20) member of project_b — so they exercised the ADMIN path, not MEMBER, despite
the "member" docstrings. Make create_user a project MEMBER (role 15) so the
positive controls validate the ROLE.MEMBER branch of @allow_permission on the
newly-guarded handlers (all allow [ADMIN, MEMBER]; admin is covered elsewhere).

Co-authored-by: Plane AI <noreply@plane.so>
This commit is contained in:
Manish Gupta
2026-07-22 18:06:32 +05:30
parent bf7568b1e6
commit 74c0672845
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
apps/api/plane/tests/contract/app/test_undecorated_route_project_scope_app.py
View File

@@ -66,7 +66,12 @@ def _make_user(email):
@pytest.fixture
def project_b(db, workspace, create_user):
"""The victim project. ``create_user`` (workspace owner) is an active ADMIN member."""
"""The victim project. ``create_user`` is an active project MEMBER (role 15).
Deliberately MEMBER, not ADMIN, so the positive-control tests exercise the
ROLE.MEMBER branch of @allow_permission on the newly-guarded handlers (admin
behavior is covered elsewhere). All the fixed decorators allow [ADMIN, MEMBER].
"""
project = Project.objects.create(
name="Project B",
identifier="PB",
@@ -74,7 +79,7 @@ def project_b(db, workspace, create_user):
created_by=create_user,
)
ProjectMember.objects.create(
workspace=workspace, project=project, member=create_user, role=20, is_active=True
workspace=workspace, project=project, member=create_user, role=15, is_active=True
)
return project