Mirrors/plane
1
0
Fork 0
mirror of https://github.com/makeplane/plane.git synced 2026-09-01 19:48:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

[WEB-8289] test: make fixture ownership real (address Copilot review)

Browse Source 
Project and FileAsset fixtures passed created_by=create_user to
objects.create(), but BaseModel.save() nulls created_by when there is no
current request user (tests), so the ownership claim was silently a
no-op. Instantiate + save(created_by_id=...) instead — same pattern
already used for the draft — so the fixtures are accurate.

Co-authored-by: Plane AI <noreply@plane.so>
This commit is contained in:
Manish Gupta
2026-07-20 11:25:25 +05:30
parent 656acf7a5c
commit 7448c698cf
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
apps/api/plane/tests/contract/app/test_draft_to_issue_owner_scope_app.py
View File

@@ -53,28 +53,28 @@ def _no_activity(db):
@pytest.fixture
def owned_draft(db, workspace, create_user):
"""A draft owned by ``create_user`` (session_client), with a project + asset."""
project = Project.objects.create(
name="Draft Project", identifier="DRP", workspace=workspace, created_by=create_user
)
# BaseModel.save auto-sets created_by from the request user (None under
# tests), overwriting a created_by= kwarg — pass created_by_id to save so the
# fixtures' ownership is real rather than silently nulled.
project = Project(name="Draft Project", identifier="DRP", workspace=workspace)
project.save(created_by_id=create_user.id)
ProjectMember.objects.create(
project=project, member=create_user, workspace=workspace, role=20, is_active=True
)
# BaseModel.save auto-sets created_by from the request user (None under
# tests), overwriting a created_by= kwarg — pass created_by_id to save.
draft = DraftIssue(name="Private draft", workspace=workspace, project=project)
draft.save(created_by_id=create_user.id)
asset = FileAsset.objects.create(
asset = FileAsset(
attributes={"name": "secret.pdf", "type": "application/pdf", "size": 1024},
asset=f"{workspace.id}/secret.pdf",
size=1024,
workspace=workspace,
project=project,
draft_issue=draft,
created_by=create_user,
entity_type=FileAsset.EntityTypeContext.DRAFT_ISSUE_DESCRIPTION,
is_uploaded=True,
storage_metadata={"size": 1024},
)
asset.save(created_by_id=create_user.id)
return {"project": project, "draft": draft, "asset": asset}