12 Commits

Author	SHA1	Message	Date
Classic298	17df026492	Confer object-derived file write only for files the object owner owns (#26032) ... has_access_to_file() derives file access from the objects a file is attached to (knowledge bases, workspace models). Those branches returned True for any access_type whenever the user held that permission on the object, write/delete included. Since a user can create their own KB or model and attach any file they can merely READ (KB attach and the model meta.knowledge validator both gate on read access only), a user with read access to a victim file could launder it into write/delete: attach it to an object they own, then rename, overwrite or delete it via the write-gated file routes (POST /files/{id}/rename, /data/content/update, DELETE /files/{id}). This is the residual of GHSA-vjqm-6gcc-62cr (CVE-2026-54012) left open by the read-only attach validator (CWE-863). An object now confers write/delete on a file only when the object's owner owns that file, so delegation originates from the file's own owner. Read is unchanged (RAG and shared-object reads still work), and legitimate delegation is preserved: a write grant on an object whose owner owns the attached file still confers write. Applied to all three object branches: knowledge base, file home collection, and workspace model. Co-authored-by: rexpository <30176934+rexpository@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-17 03:05:57 +02:00
Classic298	d169f086da	fix: respect access_type in shared-chat file authorization branch (#24755) ... has_access_to_file granted access whenever the file was attached to a shared chat the user could read, ignoring the requested access_type. A read-only shared-chat recipient therefore satisfied write and delete checks and could delete or mutate the chat owner's attached file. Gate the shared-chat branch on read access, matching the channels branch directly above it. Co-authored-by: oxsignal <oxsignal@users.noreply.github.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-19 22:09:56 +04:00
Timothy Jaeryang Baek	6d0295588e	refac: modernize type annotations (PEP 604 / PEP 585)	2026-05-12 17:10:15 +09:00
Timothy Jaeryang Baek	2dbf7b6764	refac	2026-05-11 02:12:38 +09:00
Timothy Jaeryang Baek	2e52ad8ff2	refac: shared chat	2026-04-17 10:16:32 +09:00
Timothy Jaeryang Baek	27169124f2	refac: async db	2026-04-12 14:22:11 -05:00
Timothy Jaeryang Baek	de3317e26b	refac	2026-03-17 17:58:01 -05:00
Shamil	3a6b5ebb5f	refac: modernize type hints and imports in access_control module (#22594)	2026-03-11 15:28:39 -05:00
Timothy Jaeryang Baek	10daa64d5b	chore: format	2026-03-02 17:26:18 -06:00
Classic298	65fbbf5e35	fix: grant file access for knowledge attached to shared workspace models (#22151)	2026-03-02 18:08:49 -05:00
Timothy Jaeryang Baek	93bab8d822	refac	2026-03-01 13:54:44 -06:00
Timothy Jaeryang Baek	259d5ca596	refac	2026-03-01 13:49:36 -06:00