monograph: show error message for empty password on unlock

Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>

.github/workflows/ios.preview.firebase.yml

@@ -38,6 +38,11 @@ jobs:
         with:
           xcode-version: "26.1.1"
 
+      - name: Setup iOS Platform
+        run: |
+          xcodebuild -downloadPlatform iOS -exportPath ~/Downloads
+          xcodebuild -importPlatform ~/Downloads/iphonesimulator_26.1_23B86.dmg
+
       - name: Install node modules
         run: |
           npm ci --ignore-scripts --prefer-offline --no-audit

.github/workflows/ios.publish.yml

@@ -19,6 +19,11 @@ jobs:
         with:
           xcode-version: "26.1.1"
 
+      - name: Setup iOS Platform
+        run: |
+          xcodebuild -downloadPlatform iOS -exportPath ~/Downloads
+          xcodebuild -importPlatform ~/Downloads/iphonesimulator_26.1_23B86.dmg
+
       - name: Install node modules
         run: |
           npm ci --ignore-scripts --prefer-offline --no-audit

apps/desktop/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@notesnook/desktop",
-  "version": "3.3.19",
+  "version": "3.3.21",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@notesnook/desktop",
-      "version": "3.3.19",
+      "version": "3.3.21",
       "hasInstallScript": true,
       "license": "GPL-3.0-or-later",
       "dependencies": {

apps/desktop/package.json

@@ -2,7 +2,7 @@
   "name": "@notesnook/desktop",
   "productName": "Notesnook",
   "description": "Your private note taking space",
-  "version": "3.3.19",
+  "version": "3.3.21",
   "appAppleId": "1544027013",
   "private": true,
   "main": "./dist/cjs/index.js",

apps/desktop/src/api/os-integration.ts

@@ -33,7 +33,7 @@ import { AutoLaunch } from "../utils/autolaunch";
 import { config, DesktopIntegration } from "../utils/config";
 import { bringToFront } from "../utils/bring-to-front";
 import { getTheme, setTheme, Theme } from "../utils/theme";
-import { mkdirSync, writeFileSync } from "fs";
+import { existsSync, mkdirSync, writeFileSync } from "fs";
 import { dirname } from "path";
 import { resolvePath } from "../utils/resolve-path";
 import { observable } from "@trpc/server/observable";
@@ -43,6 +43,7 @@ import { setupDesktopIntegration } from "../utils/desktop-integration";
 import { rm } from "fs/promises";
 import { disableCustomDns, enableCustomDns } from "../utils/custom-dns";
 import type { MenuItem as NNMenuItem } from "@notesnook/ui";
+import { platform } from "os";
 
 const t = initTRPC.create();
 
@@ -192,9 +193,28 @@ export const osIntegrationRouter = t.router({
     }),
   openPath: t.procedure
     .input(z.object({ type: z.literal("path"), link: z.string() }))
-    .query(({ input }) => {
+    .query(async ({ input }) => {
+      if (isFlatpak()) return;
+
       const { type, link } = input;
-      if (type === "path") return shell.openPath(resolvePath(link));
+      if (type !== "path") return;
+
+      const resolvedPath = resolvePath(
+        // remove leading slash from path on windows
+        platform() === "win32" ? link.slice(1) : link
+      );
+      if (!existsSync(resolvedPath)) {
+        if (globalThis.window) {
+          await dialog.showMessageBox(globalThis.window, {
+            type: "error",
+            title: "Path not found",
+            message: `The path does not exist:\n${wrapPath(resolvedPath)}`
+          });
+        }
+        return;
+      }
+
+      await shell.openPath(resolvedPath);
     }),
   bringToFront: t.procedure.query(() => bringToFront()),
   changeTheme: t.procedure
@@ -299,3 +319,7 @@ function toMenuItem(
     }
   }
 }
+
+function wrapPath(path: string, maxLineLength = 100): string {
+  return path.replace(new RegExp(`(.{${maxLineLength}})`, "g"), "$1\n");
+}

apps/mobile/android/app/build.gradle

@@ -140,7 +140,7 @@ android {
         if (project.hasProperty("prBuildNumber")) {
             versionCode Integer.parseInt(prBuildNumber())
         } else {
-            versionCode 3104
+            versionCode 3105
         }
         versionName getNpmVersion()
         testBuildType System.getProperty('testBuildType', 'debug')

apps/mobile/ios/build-configs/ios-build.active.xcconfig

@@ -1,6 +1,6 @@
 // Production iOS build identifiers
-IOS_CURRENT_PROJECT_VERSION = 2183
-IOS_MARKETING_VERSION = 3.3.23
+IOS_CURRENT_PROJECT_VERSION = 2184
+IOS_MARKETING_VERSION = 3.3.24
 IOS_MAIN_BUNDLE_ID = org.streetwriters.notesnook
 IOS_WIDGET_BUNDLE_ID = org.streetwriters.notesnook.notewidget
 IOS_SHARE_BUNDLE_ID = org.streetwriters.notesnook.share

apps/mobile/ios/build-configs/ios-build.production.xcconfig

@@ -1,6 +1,6 @@
 // Production iOS build identifiers
-IOS_CURRENT_PROJECT_VERSION = 2183
-IOS_MARKETING_VERSION = 3.3.23
+IOS_CURRENT_PROJECT_VERSION = 2184
+IOS_MARKETING_VERSION = 3.3.24
 IOS_MAIN_BUNDLE_ID = org.streetwriters.notesnook
 IOS_WIDGET_BUNDLE_ID = org.streetwriters.notesnook.notewidget
 IOS_SHARE_BUNDLE_ID = org.streetwriters.notesnook.share

apps/mobile/ios/build-configs/ios-build.staging.xcconfig

@@ -1,6 +1,6 @@
 // Staging iOS build identifiers
-IOS_CURRENT_PROJECT_VERSION = 2183
-IOS_MARKETING_VERSION = 3.3.23
+IOS_CURRENT_PROJECT_VERSION = 2184
+IOS_MARKETING_VERSION = 3.3.24
 IOS_MAIN_BUNDLE_ID = org.streetwriters.notesnook
 IOS_WIDGET_BUNDLE_ID = org.streetwriters.notesnook.notewidget
 IOS_SHARE_BUNDLE_ID = org.streetwriters.notesnook.share

apps/mobile/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@notesnook/mobile",
-  "version": "3.3.23",
+  "version": "3.3.24",
   "private": true,
   "license": "GPL-3.0-or-later",
   "scripts": {

apps/monograph/app/components/monographpost/index.tsx

@@ -387,10 +387,14 @@ function MonographLockscreen({
 }) {
   const [error, setError] = useState<string>();
   const [loading, setLoading] = useState<boolean>();
-  const password = useRef<string>();
+  const password = useRef<string>("");
 
   const unlock = useCallback(async () => {
-    if (!password.current) return;
+    if (!password.current) {
+      setError("Password is required.");
+      return;
+    }
+
     setError(undefined);
     setLoading(true);
     try {
@@ -470,7 +474,9 @@ function MonographLockscreen({
             }}
             autoFocus={true}
             autofillBackgroundColor="background-secondary"
-            onChange={(event) => (password.current = event.target.value)}
+            onChange={(event) => {
+              password.current = event.target.value;
+            }}
             onKeyUp={(e) => (e.key === "Enter" ? unlock() : null)}
             type="password"
             placeholder="Enter password to continue"
@@ -480,6 +486,7 @@ function MonographLockscreen({
             title="Unlock"
             sx={{ borderRadius: 100, px: 50, mt: 1 }}
             onClick={() => unlock()}
+            disabled={loading}
           >
             Unlock
           </Button>

apps/web/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@notesnook/web",
-  "version": "3.3.19",
+  "version": "3.3.21",
   "lockfileVersion": 3,
   "requires": true,
   "packages": {
     "": {
       "name": "@notesnook/web",
-      "version": "3.3.19",
+      "version": "3.3.21",
       "hasInstallScript": true,
       "license": "GPL-3.0-or-later",
       "dependencies": {

apps/web/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@notesnook/web",
   "description": "Your private note taking space",
-  "version": "3.3.19",
+  "version": "3.3.21",
   "private": true,
   "main": "./src/app.js",
   "homepage": "https://notesnook.com/",

apps/web/src/components/day-picker/index.tsx

@@ -16,6 +16,7 @@ GNU General Public License for more details.
 You should have received a copy of the GNU General Public License
 along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
+
 import { useDatePicker } from "@rehookify/datepicker";
 import { Box, Button, Flex, Text } from "@theme-ui/components";
 import { useState } from "react";
@@ -31,6 +32,7 @@ type DayPickerProps = {
 export function DayPicker(props: DayPickerProps) {
   const { selected, sx, maxDate, minDate, onSelect } = props;
   const [selectedDates, onDatesChange] = useState<Date[]>([selected]);
+
   const {
     data: { weekDays, months, years, calendars },
     propGetters: { dayButton, addOffset, subtractOffset, setOffset }
@@ -52,6 +54,24 @@ export function DayPicker(props: DayPickerProps) {
 
   const { month, year, days } = calendars[0];
 
+  const currentMonthDate = months.find((m) => m.month === month)?.$date;
+  const isNextMonthBeyondMax =
+    maxDate && currentMonthDate
+      ? new Date(
+          currentMonthDate.getFullYear(),
+          currentMonthDate.getMonth() + 1,
+          1
+        ) > stripTime(maxDate)
+      : false;
+  const isPrevMonthBeforeMin =
+    minDate && currentMonthDate
+      ? new Date(
+          currentMonthDate.getFullYear(),
+          currentMonthDate.getMonth(),
+          1
+        ) <= stripTime(minDate)
+      : false;
+
   return (
     <Flex
       sx={{
@@ -66,7 +86,7 @@ export function DayPicker(props: DayPickerProps) {
           <Button
             variant="icon"
             sx={{ p: 0 }}
-            {...subtractOffset({ months: 1 })}
+            {...subtractOffset({ months: 1 }, { disabled: isPrevMonthBeforeMin })}
           >
             <ChevronLeft />
           </Button>
@@ -83,9 +103,12 @@ export function DayPicker(props: DayPickerProps) {
             value={month}
             onChange={(e) => {
               const selectedOption = e.target.selectedOptions[0];
-              setOffset(new Date(selectedOption.dataset.date || ""))?.onClick?.(
-                e
+              const d = clampDate(
+                new Date(selectedOption.dataset.date || ""),
+                minDate,
+                maxDate
               );
+              setOffset(d)?.onClick?.(e as any);
             }}
           >
             {months.map((month) => (
@@ -112,9 +135,12 @@ export function DayPicker(props: DayPickerProps) {
             value={year}
             onChange={(e) => {
               const selectedOption = e.target.selectedOptions[0];
-              setOffset(new Date(selectedOption.dataset.date || ""))?.onClick?.(
-                e
+              const d = clampDate(
+                new Date(selectedOption.dataset.date || ""),
+                minDate,
+                maxDate
               );
+              setOffset(d)?.onClick?.(e as any);
             }}
           >
             {years.map((year) => (
@@ -129,7 +155,16 @@ export function DayPicker(props: DayPickerProps) {
             ))}
           </select>
         </Flex>
-        <Button variant="icon" sx={{ p: 0 }} {...addOffset({ months: 1 })}>
+        <Button
+          variant="icon"
+          sx={{ p: 0 }}
+          {...addOffset(
+            { months: 1 },
+            {
+              disabled: isNextMonthBeyondMax
+            }
+          )}
+        >
           <ChevronRight />
         </Button>
       </Flex>
@@ -195,3 +230,24 @@ export function DayPicker(props: DayPickerProps) {
     </Flex>
   );
 }
+
+function clampDate(d: Date, minDate?: Date, maxDate?: Date) {
+  /**
+   * Strip time for accurate comparison
+   */
+  const normalizedMaxDate = maxDate ? stripTime(maxDate) : null;
+  const normalizedMinDate = minDate ? stripTime(minDate) : null;
+
+  if (normalizedMaxDate && d > normalizedMaxDate) {
+    return normalizedMaxDate;
+  }
+  if (normalizedMinDate && d < normalizedMinDate) {
+    return normalizedMinDate;
+  }
+
+  return d;
+}
+
+function stripTime(date: Date) {
+  return new Date(date.getFullYear(), date.getMonth(), date.getDate());
+}

apps/web/src/components/editor/index.tsx

@@ -50,7 +50,8 @@ import { FlexScrollContainer } from "../scroll-container";
 import Tiptap, { OnChangeHandler } from "./tiptap";
 import Header from "./header";
 import { Attachment } from "../icons";
-import { attachFiles, AttachmentProgress, insertAttachments } from "./picker";
+import { AttachmentProgress, insertAttachments } from "./picker";
+import { AttachFilesDialog } from "../../dialogs/attach-files-dialog";
 import { useEditorManager } from "./manager";
 import {
   saveAttachment,
@@ -617,13 +618,11 @@ export function Editor(props: EditorProps) {
           }
 
           const mime = type === "file" ? "*/*" : "image/*";
-          const attachments = await insertAttachments(mime);
-          const editor = useEditorManager.getState().getEditor(id)?.editor;
-
-          if (!attachments) return;
-          for (const attachment of attachments) {
-            editor?.attachFile(attachment);
-          }
+          await insertAttachments(mime, (attachments) => {
+            const editor = useEditorManager.getState().getEditor(id)?.editor;
+            if (!editor) return;
+            attachments.forEach((a) => editor?.attachFile(a));
+          });
         }}
         onGetAttachmentData={async (attachment) => {
           logger.debug("Getting attachment data", {
@@ -646,10 +645,14 @@ export function Editor(props: EditorProps) {
           return result;
         }}
         onAttachFiles={async (files) => {
-          const editor = useEditorManager.getState().getEditor(id)?.editor;
-          const result = await attachFiles(files);
-          if (!result) return;
-          result.forEach((attachment) => editor?.attachFile(attachment));
+          await AttachFilesDialog.show({
+            files,
+            onDone: (attachments) => {
+              const editor = useEditorManager.getState().getEditor(id)?.editor;
+              if (!editor) return;
+              attachments.forEach((a) => editor?.attachFile(a));
+            }
+          });
         }}
         onInsertInternalLink={async (attributes) => {
           const link = await NoteLinkingDialog.show({ attributes });
@@ -799,17 +802,20 @@ function DropZone(props: DropZoneProps) {
       }}
       onDrop={async (e) => {
         try {
-          const { activeEditorId, getEditor } = useEditorManager.getState();
-          const editor = getEditor(activeEditorId || "")?.editor;
-          if (!e.dataTransfer.files?.length || !editor) return;
+          const { activeEditorId } = useEditorManager.getState();
+          if (!e.dataTransfer.files?.length || !activeEditorId) return;
 
           e.preventDefault();
-          const attachments = await attachFiles(
-            Array.from(e.dataTransfer.files)
-          );
-          for (const attachment of attachments || []) {
-            editor.attachFile(attachment);
-          }
+          await AttachFilesDialog.show({
+            files: Array.from(e.dataTransfer.files),
+            onDone: (attachments) => {
+              const editor = useEditorManager
+                .getState()
+                .getEditor(activeEditorId)?.editor;
+              if (!editor) return;
+              attachments.forEach((a) => editor?.attachFile(a));
+            }
+          });
         } catch (e) {
           logger.error(e as Error, "Failed to attach file from drag and drop");
           showToast("error", strings.failedToAttachFile());

apps/web/src/components/editor/picker.ts

@@ -18,86 +18,35 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 import { SerializedKey } from "@notesnook/crypto";
-import { AppEventManager, AppEvents } from "../../common/app-events";
 import { db } from "../../common/db";
-import { TaskManager } from "../../common/task-manager";
 import { showToast } from "../../utils/toast";
 import { showFilePicker } from "../../utils/file-picker";
 import { Attachment } from "@notesnook/editor";
-import { ImagePickerDialog } from "../../dialogs/image-picker-dialog";
-import { strings } from "@notesnook/intl";
 import {
   getUploadedFileSize,
   hashStream,
   writeEncryptedFile
 } from "../../interfaces/fs";
-import Config from "../../utils/config";
 import { compressImage, FileWithURI } from "../../utils/image-compressor";
-import { ImageCompressionOptions } from "../../stores/setting-store";
 import { checkFeature } from "../../common";
+import { AttachFilesDialog } from "../../dialogs/attach-files-dialog";
+import { strings } from "@notesnook/intl";
 
-export async function insertAttachments(type = "*/*") {
+export async function insertAttachments(
+  type: string,
+  onDone: (attachments: Attachment[]) => void
+): Promise<void> {
   const files = await showFilePicker({
     acceptedFileTypes: type || "*/*",
     multiple: true
   });
-  if (!files) return;
-  return await attachFiles(files, type === "*/*");
-}
+  if (!files || files.length === 0) return;
 
-export async function attachFiles(
-  files: File[],
-  skipSpecialImageHandling = false
-) {
-  let images = files.filter((f) => f.type.startsWith("image/"));
-  const imageCompressionConfig = Config.get<ImageCompressionOptions>(
-    "imageCompression",
-    ImageCompressionOptions.ASK_EVERY_TIME
-  );
-
-  switch (imageCompressionConfig) {
-    case ImageCompressionOptions.ENABLE: {
-      const compressedImages: FileWithURI[] = [];
-      for (const image of images) {
-        const compressed = await compressImage(image, {
-          maxWidth: (naturalWidth) => Math.min(1920, naturalWidth * 0.7),
-          width: (naturalWidth) => naturalWidth,
-          height: (_, naturalHeight) => naturalHeight,
-          resize: "contain",
-          quality: 0.7
-        });
-        compressedImages.push(
-          new FileWithURI([compressed], image.name, {
-            lastModified: image.lastModified,
-            type: image.type
-          })
-        );
-      }
-      images = compressedImages;
-      break;
-    }
-    case ImageCompressionOptions.DISABLE:
-      break;
-    default:
-      images =
-        images.length > 0
-          ? (await ImagePickerDialog.show({
-              images
-            })) || []
-          : [];
-  }
-
-  const documents = files.filter((f) => !f.type.startsWith("image/"));
-  const attachments: Attachment[] = [];
-  for (const file of [...images, ...documents]) {
-    const attachment =
-      !skipSpecialImageHandling && file.type.startsWith("image/")
-        ? await pickImage(file)
-        : await pickFile(file);
-    if (!attachment) continue;
-    attachments.push(attachment);
-  }
-  return attachments;
+  await AttachFilesDialog.show({
+    files,
+    skipSpecialImageHandling: type === "*/*",
+    onDone
+  });
 }
 
 export async function reuploadAttachment(
@@ -109,9 +58,16 @@ export async function reuploadAttachment(
   });
   if (!selectedFile) return;
 
+  if (
+    !(await checkFeature("fileSize", {
+      value: selectedFile.size
+    }))
+  ) {
+    return;
+  }
+
   const options: AddAttachmentOptions = {
     expectedFileHash,
-    showProgress: false,
     forceWrite: true
   };
 
@@ -124,6 +80,72 @@ export async function reuploadAttachment(
   }
 }
 
+type AttachFilesMessage =
+  | { type: "compressing"; index: number }
+  | { type: "encrypting"; index: number }
+  | {
+      type: "done";
+      index: number;
+      attachment: Attachment | undefined;
+    }
+  | { type: "error"; index: number; error: string };
+
+export async function* attachFiles(
+  files: File[],
+  shouldCompress: boolean[],
+  skipSpecialImageHandling = false
+): AsyncGenerator<AttachFilesMessage> {
+  for (let i = 0; i < files.length; i++) {
+    let file = files[i];
+    const shouldCompressFile = shouldCompress[i];
+
+    if (shouldCompressFile) {
+      yield { type: "compressing", index: i };
+      try {
+        const compressed = await compressImage(file, {
+          maxWidth: (naturalWidth) => Math.min(1920, naturalWidth * 0.7),
+          width: (naturalWidth) => naturalWidth,
+          height: (_, naturalHeight) => naturalHeight,
+          resize: "contain",
+          quality: 0.7
+        });
+        file = new FileWithURI([compressed], file.name, {
+          lastModified: file.lastModified,
+          type: file.type
+        });
+      } catch (e) {
+        yield {
+          type: "error",
+          index: i,
+          error: (e as Error).message || strings.compressionFailed()
+        };
+        continue;
+      }
+    }
+
+    yield { type: "encrypting", index: i };
+
+    try {
+      const allowed = await checkFeature("fileSize", {
+        value: file.size,
+        type: "toast"
+      });
+      if (!allowed) {
+        throw new Error(strings.fileSizeLimitExceededPleaseUpgrade());
+      }
+
+      const attachment =
+        !skipSpecialImageHandling && file.type.startsWith("image/")
+          ? await pickImage(file)
+          : await pickFile(file);
+
+      yield { type: "done", index: i, attachment: attachment || undefined };
+    } catch (e) {
+      yield { type: "error", index: i, error: (e as Error).message };
+    }
+  }
+}
+
 /**
  * @param {File} file
  * @returns
@@ -133,8 +155,6 @@ async function pickFile(
   options?: AddAttachmentOptions
 ): Promise<Attachment | undefined> {
   try {
-    if (!(await checkFeature("fileSize", { value: file.size }))) return;
-
     const hash = await addAttachment(file, options);
     return {
       type: "file",
@@ -158,8 +178,6 @@ async function pickImage(
   options?: AddAttachmentOptions
 ): Promise<Attachment | undefined> {
   try {
-    if (!(await checkFeature("fileSize", { value: file.size }))) return;
-
     const hash = await addAttachment(file, options);
     const dimensions = await getImageDimensions(file);
     return {
@@ -171,6 +189,7 @@ async function pickImage(
       ...dimensions
     };
   } catch (e) {
+    console.error(e);
     showToast("error", (e as Error).message);
   }
 }
@@ -190,7 +209,6 @@ export type AttachmentProgress = {
 
 type AddAttachmentOptions = {
   expectedFileHash?: string;
-  showProgress?: boolean;
   forceWrite?: boolean;
 };
 
@@ -198,80 +216,46 @@ async function addAttachment(
   file: File,
   options: AddAttachmentOptions = {}
 ): Promise<string> {
-  const { expectedFileHash, showProgress = true } = options;
+  const { expectedFileHash } = options;
   let forceWrite = options.forceWrite;
 
-  const action = async () => {
-    const reader = file.stream().getReader();
-    const { hash, type: hashType } = await hashStream(reader);
-    reader.releaseLock();
+  const reader = file.stream().getReader();
+  const { hash, type: hashType } = await hashStream(reader);
+  reader.releaseLock();
 
-    if (expectedFileHash && hash !== expectedFileHash)
-      throw new Error(
-        `Please select the same file for reuploading. Expected hash ${expectedFileHash} but got ${hash}.`
-      );
+  if (expectedFileHash && hash !== expectedFileHash)
+    throw new Error(
+      `Please select the same file for reuploading. Expected hash ${expectedFileHash} but got ${hash}.`
+    );
 
-    const exists = await db.attachments.attachment(hash);
-    if (!forceWrite && exists) {
-      forceWrite = (await getUploadedFileSize(hash)) === 0;
+  const exists = await db.attachments.attachment(hash);
+  if (!forceWrite && exists) {
+    forceWrite = (await getUploadedFileSize(hash)) === 0;
+  }
+
+  if (forceWrite || !exists) {
+    if (forceWrite && exists) {
+      if (!(await db.fs().deleteFile(hash, false)))
+        throw new Error("Failed to delete attachment from server.");
+      await db.attachments.reset(exists.id);
     }
 
-    if (forceWrite || !exists) {
-      if (forceWrite && exists) {
-        if (!(await db.fs().deleteFile(hash, false)))
-          throw new Error("Failed to delete attachment from server.");
-        await db.attachments.reset(exists.id);
-      }
+    const key: SerializedKey = await getEncryptionKey();
 
-      const key: SerializedKey = await getEncryptionKey();
+    const output = await writeEncryptedFile(file, key, hash);
+    if (!output) throw new Error("Could not encrypt file.");
 
-      const output = await writeEncryptedFile(file, key, hash);
-      if (!output) throw new Error("Could not encrypt file.");
+    await db.attachments.add({
+      ...output,
+      hash,
+      hashType,
+      filename: exists?.filename || file.name,
+      mimeType: exists?.type || file.type,
+      key
+    });
+  }
 
-      await db.attachments.add({
-        ...output,
-        hash,
-        hashType,
-        filename: exists?.filename || file.name,
-        mimeType: exists?.type || file.type,
-        key
-      });
-    }
-
-    return hash;
-  };
-
-  const result = showProgress
-    ? await withProgress(file, action)
-    : await action();
-
-  if (result instanceof Error) throw result;
-  return result;
-}
-
-function withProgress<T>(
-  file: File,
-  action: () => Promise<T>
-): Promise<T | Error> {
-  return TaskManager.startTask({
-    type: "modal",
-    title: strings.encryptingAttachment(),
-    subtitle: strings.encryptingAttachmentDesc(),
-    action: (report) => {
-      const event = AppEventManager.subscribe(
-        AppEvents.UPDATE_ATTACHMENT_PROGRESS,
-        ({ type, total, loaded }: AttachmentProgress) => {
-          if (type !== "encrypt") return;
-          report({
-            current: Math.round((loaded / total) * 100),
-            total: 100,
-            text: file.name
-          });
-        }
-      );
-      return action().finally(() => event.unsubscribe());
-    }
-  });
+  return hash;
 }
 
 function getImageDimensions(file: File) {

apps/web/src/components/editor/tiptap.tsx

@@ -58,6 +58,7 @@ import { useStore as useThemeStore } from "../../stores/theme-store";
 import { writeToClipboard } from "../../utils/clipboard";
 import { useEditorStore } from "../../stores/editor-store";
 import { DayFormat, parseInternalLink } from "@notesnook/core";
+import { desktop } from "../../common/desktop-bridge";
 import Skeleton from "react-loading-skeleton";
 import useMobile from "../../hooks/use-mobile";
 import useTablet from "../../hooks/use-tablet";
@@ -68,6 +69,7 @@ import { showFeatureNotAllowedToast } from "../../common/toasts";
 import { UpgradeDialog } from "../../dialogs/buy-dialog/upgrade-dialog";
 import { ConfirmDialog } from "../../dialogs/confirm";
 import { strings } from "@notesnook/intl";
+import { showToast } from "../../utils/toast";
 
 export type OnChangeHandler = (
   content: () => string,
@@ -421,13 +423,32 @@ function TipTap(props: TipTapProps) {
       previewAttachment: onPreviewAttachment,
       createInternalLink: onInsertInternalLink,
       getAttachmentData: onGetAttachmentData,
-      openLink: (url, openInNewTab) => {
+      openLink: async (url, openInNewTab) => {
         const link = parseInternalLink(url);
         if (link && link.type === "note") {
           useEditorStore.getState().openSession(link.id, {
             activeBlockId: link.params?.blockId || undefined,
             openInNewTab: openInNewTab
           });
+        } else if (url.startsWith("file:")) {
+          if (!IS_DESKTOP_APP) {
+            showToast("error", strings.cantOpenFileLinksInBrowsers());
+            return;
+          }
+
+          const path = new URL(url).pathname;
+          const ok = await ConfirmDialog.show({
+            title: strings.openingLocalFile(),
+            message: strings.openingLocalFileDesc(path),
+            positiveButtonText: strings.open(),
+            negativeButtonText: strings.cancel()
+          });
+          if (!ok) return;
+
+          await desktop?.integration.openPath.query({
+            type: "path",
+            link: decodeURIComponent(path)
+          });
         } else window.open(url, "_blank");
       }
     };

apps/web/src/components/icons/index.tsx

@@ -229,7 +229,8 @@ import {
   mdiArrowUp,
   mdiInbox,
   mdiConsoleLine,
-  mdiDeleteSweepOutline
+  mdiDeleteSweepOutline,
+  mdiCloseCircle
 } from "@mdi/js";
 import { useTheme } from "@emotion/react";
 import { Theme } from "@notesnook/theme";
@@ -586,3 +587,4 @@ export const HamburgerMenu = createIcon(mdiMenu);
 export const ArrowUp = createIcon(mdiArrowUp);
 export const Inbox = createIcon(mdiInbox);
 export const ClearTrash = createIcon(mdiDeleteSweepOutline);
+export const CloseCircle = createIcon(mdiCloseCircle);

apps/web/src/dialogs/attach-files-dialog.tsx

@@ -0,0 +1,373 @@
+/*
+This file is part of the Notesnook project (https://notesnook.com/)
+
+Copyright (C) 2023 Streetwriters (Private) Limited
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see <http://www.gnu.org/licenses/>.
+*/
+
+import { useEffect, useMemo, useRef, useState } from "react";
+import Dialog from "../components/dialog";
+import { ScrollContainer } from "@notesnook/ui";
+import { Box, Flex, Image, Switch, Text } from "@theme-ui/components";
+import { formatBytes } from "@notesnook/common";
+import { BaseDialogProps, DialogManager } from "../common/dialog-manager";
+import { strings } from "@notesnook/intl";
+import { checkFeature } from "../common";
+import { AppEventManager, AppEvents } from "../common/app-events";
+import { attachFiles, AttachmentProgress } from "../components/editor/picker";
+import Config from "../utils/config";
+import { ImageCompressionOptions } from "../stores/setting-store";
+import { Attachment } from "@notesnook/editor";
+import {
+  CheckCircle,
+  Loading,
+  File as FileIcon,
+  CloseCircle
+} from "../components/icons";
+
+type FileStatus = "pending" | "compressing" | "encrypting" | "done" | "error";
+
+type FileState = {
+  file: File;
+  status: FileStatus;
+  progress: number;
+  error?: string;
+  compress: boolean;
+};
+
+type AttachFilesDialogProps = BaseDialogProps<false> & {
+  files: File[];
+  skipSpecialImageHandling?: boolean;
+  onDone: (attachments: Attachment[]) => void;
+};
+
+export const AttachFilesDialog = DialogManager.register(
+  function AttachFilesDialog({
+    files,
+    skipSpecialImageHandling,
+    onDone,
+    onClose
+  }: AttachFilesDialogProps) {
+    const hasImages = files.some((f) => f.type.startsWith("image/"));
+    const imageCompressionConfig = Config.get<ImageCompressionOptions>(
+      "imageCompression",
+      ImageCompressionOptions.ASK_EVERY_TIME
+    );
+    const [fileStates, setFileStates] = useState<FileState[]>(() =>
+      files.map((file) => ({
+        file,
+        status: "pending",
+        progress: 0,
+        compress: file.type.startsWith("image/")
+          ? imageCompressionConfig !== ImageCompressionOptions.DISABLE
+          : false
+      }))
+    );
+    const [showCompressionPrompt, setShowCompressionPrompt] = useState(
+      hasImages &&
+        imageCompressionConfig === ImageCompressionOptions.ASK_EVERY_TIME
+    );
+    const processingRef = useRef(false);
+
+    useEffect(() => {
+      const event = AppEventManager.subscribe(
+        AppEvents.UPDATE_ATTACHMENT_PROGRESS,
+        ({ type, total, loaded }: AttachmentProgress) => {
+          if (type !== "encrypt") return;
+
+          setFileStates((prev) =>
+            prev.map((s) => {
+              /**
+               * only one file is encrypted at a time, so we can just update progress of the state with "encrypting" status
+               */
+              if (s.status !== "encrypting") return s;
+
+              return {
+                ...s,
+                progress: Math.round((loaded / total) * 100)
+              };
+            })
+          );
+        }
+      );
+      return () => {
+        event.unsubscribe();
+      };
+    }, []);
+
+    useEffect(() => {
+      if (showCompressionPrompt || processingRef.current) return;
+
+      processingRef.current = true;
+
+      const shouldCompress: boolean[] = fileStates.map((s) => !!s.compress);
+
+      (async () => {
+        const attachments: Attachment[] = [];
+        let hasError = false;
+
+        for await (const message of attachFiles(
+          files,
+          shouldCompress,
+          skipSpecialImageHandling
+        )) {
+          const { index } = message;
+          switch (message.type) {
+            case "compressing":
+              setFileStates((prev) =>
+                prev.map((s, i) =>
+                  i === index
+                    ? { ...s, status: "compressing" as FileStatus }
+                    : s
+                )
+              );
+              break;
+            case "encrypting":
+              setFileStates((prev) =>
+                prev.map((s, i) =>
+                  i === index
+                    ? { ...s, status: "encrypting" as FileStatus, progress: 0 }
+                    : s
+                )
+              );
+              break;
+            case "done":
+              if (message.attachment) attachments.push(message.attachment);
+              setFileStates((prev) =>
+                prev.map((s, i) =>
+                  i === index
+                    ? {
+                        ...s,
+                        status: "done" as FileStatus
+                      }
+                    : s
+                )
+              );
+              break;
+            case "error":
+              hasError = true;
+              setFileStates((prev) =>
+                prev.map((s, i) =>
+                  i === index
+                    ? {
+                        ...s,
+                        status: "error" as FileStatus,
+                        error: message.error
+                      }
+                    : s
+                )
+              );
+              break;
+          }
+        }
+
+        onDone(attachments);
+        if (files.length === 1 && !hasError) onClose(false);
+      })();
+    }, [showCompressionPrompt]);
+
+    return (
+      <Dialog
+        isOpen={true}
+        title={
+          showCompressionPrompt
+            ? strings.imageCompression()
+            : strings.attachingFiles()
+        }
+        description={
+          showCompressionPrompt ? strings.imageCompressionDesc() : ""
+        }
+        onClose={() => onClose(false)}
+        width={500}
+        positiveButton={
+          showCompressionPrompt
+            ? {
+                text: strings.done(),
+                onClick: () => setShowCompressionPrompt(false)
+              }
+            : undefined
+        }
+        negativeButton={{
+          text: strings.close(),
+          onClick: () => onClose(false)
+        }}
+      >
+        <ScrollContainer
+          style={{
+            maxHeight: 350,
+            display: "flex",
+            flexDirection: "column",
+            position: "relative"
+          }}
+        >
+          {fileStates.map((state, index) => (
+            <FileRow
+              key={`${state.file.name}-${index}`}
+              state={state}
+              showDivider={fileStates.length > 1}
+              showCompressionToggle={showCompressionPrompt}
+              onToggleCompress={async () => {
+                if (
+                  !(await checkFeature("fullQualityImages", { type: "toast" }))
+                ) {
+                  return;
+                }
+
+                setFileStates((prev) =>
+                  prev.map((s, idx) =>
+                    idx === index ? { ...s, compress: !s.compress } : s
+                  )
+                );
+              }}
+            />
+          ))}
+        </ScrollContainer>
+      </Dialog>
+    );
+  }
+);
+
+function FileRow({
+  state,
+  showDivider,
+  showCompressionToggle,
+  onToggleCompress
+}: {
+  state: FileState;
+  showDivider?: boolean;
+  showCompressionToggle?: boolean;
+  onToggleCompress?: () => void;
+}) {
+  const { file, status, progress, error, compress } = state;
+  const isImage = file.type.startsWith("image/");
+  const thumbnail = useMemo(
+    () => (isImage ? URL.createObjectURL(file) : undefined),
+    [file, isImage]
+  );
+
+  useEffect(() => {
+    return () => {
+      if (thumbnail) URL.revokeObjectURL(thumbnail);
+    };
+  }, [thumbnail]);
+
+  return (
+    <Flex
+      sx={{
+        alignItems: "center",
+        py: 1,
+        px: 1,
+        gap: 2,
+        borderBottom: showDivider ? "1px solid var(--border)" : undefined
+      }}
+    >
+      {thumbnail ? (
+        <Image
+          src={thumbnail}
+          sx={{
+            width: 40,
+            height: 40,
+            objectFit: "cover",
+            borderRadius: "default",
+            flexShrink: 0
+          }}
+        />
+      ) : (
+        <Flex
+          sx={{
+            width: 40,
+            height: 40,
+            alignItems: "center",
+            justifyContent: "center",
+            flexShrink: 0,
+            bg: "background-secondary",
+            borderRadius: "default"
+          }}
+        >
+          <FileIcon size={20} color="icon" />
+        </Flex>
+      )}
+
+      <Flex sx={{ flex: 1, flexDirection: "column", minWidth: 0 }}>
+        <Text
+          variant="body"
+          sx={{
+            overflow: "hidden",
+            textOverflow: "ellipsis",
+            whiteSpace: "nowrap"
+          }}
+        >
+          {file.name}
+        </Text>
+        <Text variant="subBody" sx={{ color: "paragraph-secondary" }}>
+          {formatBytes(file.size)}
+          {status === "compressing"
+            ? ` — ${strings.compressing()}...`
+            : status === "encrypting"
+            ? ` — ${strings.encrypting()} ${progress}%`
+            : status === "error"
+            ? ` — ${error}`
+            : ""}
+        </Text>
+      </Flex>
+
+      <Flex sx={{ flexShrink: 0, alignItems: "center" }}>
+        {showCompressionToggle && isImage ? (
+          <Switch
+            sx={{
+              m: 0,
+              bg: compress ? "accent" : "icon-secondary",
+              flexShrink: 0,
+              scale: 0.75
+            }}
+            checked={compress}
+            onChange={onToggleCompress}
+          />
+        ) : showCompressionToggle && !isImage ? (
+          <Text variant="subBody" sx={{ color: "paragraph-secondary" }}>
+            N/A
+          </Text>
+        ) : status === "done" ? (
+          <CheckCircle size={20} color="accent" />
+        ) : status === "error" ? (
+          <CloseCircle size={20} color="accent-error" />
+        ) : status === "encrypting" || status === "compressing" ? (
+          <Flex sx={{ alignItems: "center", gap: 1 }}>
+            <Box
+              sx={{
+                width: 60,
+                height: 4,
+                bg: "border",
+                borderRadius: "full",
+                overflow: "hidden"
+              }}
+            >
+              <Box
+                sx={{
+                  width: `${status === "compressing" ? 50 : progress}%`,
+                  height: "100%",
+                  bg: "accent",
+                  transition: "width 0.2s ease"
+                }}
+              />
+            </Box>
+          </Flex>
+        ) : (
+          <Loading size={16} color="icon" />
+        )}
+      </Flex>
+    </Flex>
+  );
+}

apps/web/src/dialogs/confirm.tsx

@@ -123,6 +123,7 @@ export const ConfirmDialog = DialogManager.register(function ConfirmDialog(
           <Text
             as="div"
             variant="body"
+            sx={{ overflowWrap: "break-word" }}
             dangerouslySetInnerHTML={{ __html: mdToHtml(message) }}
           />
         ) : null}

apps/web/src/dialogs/feature-dialog.tsx

@@ -22,7 +22,14 @@ import Dialog from "../components/dialog";
 import { getHomeRoute, hardNavigate } from "../navigation";
 import { appVersion } from "../utils/version";
 import Config from "../utils/config";
-import { ArrowRight, Checkmark, Icon, Warn } from "../components/icons";
+import {
+  ArrowRight,
+  Checkmark,
+  Icon,
+  Warn,
+  File,
+  InternalLink
+} from "../components/icons";
 import { BaseDialogProps, DialogManager } from "../common/dialog-manager";
 import { strings } from "@notesnook/intl";
 

apps/web/src/dialogs/image-picker-dialog.tsx

@@ -1,147 +0,0 @@
-/*
-This file is part of the Notesnook project (https://notesnook.com/)
-
-Copyright (C) 2023 Streetwriters (Private) Limited
-
-This program is free software: you can redistribute it and/or modify
-it under the terms of the GNU General Public License as published by
-the Free Software Foundation, either version 3 of the License, or
-(at your option) any later version.
-
-This program is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-GNU General Public License for more details.
-
-You should have received a copy of the GNU General Public License
-along with this program.  If not, see <http://www.gnu.org/licenses/>.
-*/
-
-import { useEffect, useState } from "react";
-import Dialog from "../components/dialog";
-import { ScrollContainer } from "@notesnook/ui";
-import { Flex, Image, Label, Text } from "@theme-ui/components";
-import { formatBytes } from "@notesnook/common";
-import { compressImage, FileWithURI } from "../utils/image-compressor";
-import { BaseDialogProps, DialogManager } from "../common/dialog-manager";
-import { strings } from "@notesnook/intl";
-import { checkFeature } from "../common";
-
-export type ImagePickerDialogProps = BaseDialogProps<false | File[]> & {
-  images: File[];
-};
-
-export const ImagePickerDialog = DialogManager.register(
-  function ImagePickerDialog(props: ImagePickerDialogProps) {
-    const [images, setImages] = useState<FileWithURI[]>([]);
-    const [selectedIndex, setSelectedIndex] = useState(0);
-    const [compress, setCompress] = useState(true);
-    const selectedImage = images[selectedIndex];
-
-    useEffect(() => {
-      (async function () {
-        const images: FileWithURI[] = [];
-        for (const image of props.images) {
-          const compressed = compress
-            ? await compressImage(image, {
-                maxWidth: (naturalWidth) => Math.min(1920, naturalWidth * 0.7),
-                width: (naturalWidth) => naturalWidth,
-                height: (_, naturalHeight) => naturalHeight,
-                resize: "contain",
-                quality: 0.7
-              })
-            : image;
-          images.push(
-            new FileWithURI([compressed], image.name, {
-              lastModified: image.lastModified,
-              type: image.type
-            })
-          );
-        }
-        setImages(images);
-      })();
-    }, [props.images, compress]);
-
-    useEffect(() => {
-      return () => {
-        images.forEach((i) => URL.revokeObjectURL(i.uri));
-      };
-    }, [images]);
-
-    return (
-      <Dialog
-        isOpen={true}
-        onClose={() => props.onClose(false)}
-        positiveButton={{
-          text: strings.insert(),
-          onClick: () => props.onClose(images)
-        }}
-        negativeButton={{
-          text: strings.cancel(),
-          onClick: () => props.onClose(false)
-        }}
-      >
-        {selectedImage && (
-          <Flex sx={{ flexDirection: "column", alignItems: "center", mt: 4 }}>
-            <Image
-              src={selectedImage.uri}
-              sx={{
-                maxHeight: 250,
-                objectFit: "contain",
-                alignSelf: "center",
-                borderRadius: "default"
-              }}
-            />
-            <Text variant="subBody" sx={{ my: 2 }}>
-              {selectedImage.name} ({formatBytes(selectedImage.size)})
-            </Text>
-          </Flex>
-        )}
-        {images.length > 1 ? (
-          <ScrollContainer style={{ display: "flex" }}>
-            {images.map((image, index) => (
-              <Image
-                key={image.name + image.size}
-                src={image.uri}
-                sx={{
-                  flexShrink: 0,
-                  height: "55px",
-                  width: "55px",
-                  objectFit: "contain",
-                  border:
-                    selectedIndex === index
-                      ? "2px solid var(--accent)"
-                      : "2px solid transparent",
-                  borderRadius: "default"
-                }}
-                onClick={() => setSelectedIndex(index)}
-              />
-            ))}
-          </ScrollContainer>
-        ) : null}
-
-        <Label variant="text.body" sx={{ mt: 2 }}>
-          <input
-            type="checkbox"
-            style={{
-              accentColor: "var(--accent)",
-              marginRight: 1,
-              width: 14,
-              height: 14
-            }}
-            defaultChecked={compress}
-            checked={compress}
-            onChange={async () => {
-              if (!(await checkFeature("fullQualityImages", { type: "toast" })))
-                return;
-              setCompress((s) => !s);
-            }}
-          />
-          <span style={{ marginLeft: 5 }}>
-            Enable compression (recommended)
-          </span>
-        </Label>
-      </Dialog>
-    );
-  }
-);

apps/web/src/dialogs/note-expiry-date-dialog.tsx

@@ -54,19 +54,26 @@ export const NoteExpiryDateDialog = DialogManager.register(
     return (
       <Dialog
         isOpen={true}
-        title={"Set Custom Expiry Date"}
+        title={strings.setExpiry()}
         onClose={() => onClose(false)}
         width={400}
         positiveButton={{
           text: strings.done(),
           onClick: async () => {
             if (date.isBefore(dayjs())) {
-              showToast("error", "Expiry date must be in the future");
+              showToast("error", strings.expiryDateMustBeInTheFuture());
+              return;
+            }
+            if (date.isAfter(dayjs().add(1, "year"))) {
+              showToast(
+                "error",
+                strings.expiryDateCannotBeMoreThan1YearInTheFuture()
+              );
               return;
             }
             await db.notes.setExpiryDate(date.valueOf(), noteId);
             store.refresh();
-            showToast("success", "Expiry date set");
+            showToast("success", strings.expiryDateSet());
             onClose(true);
           }
         }}

apps/web/src/stores/editor-store.ts

@@ -286,7 +286,8 @@ class EditorStore extends BaseStore<EditorStore> {
         const clearIds: string[] = [];
         for (const session of sessions) {
           if (session.type === "new") continue;
-          if (session.note.id !== item.id && session.note.contentId !== item.id) continue;
+          if (session.note.id !== item.id && session.note.contentId !== item.id)
+            continue;
           if (isDeleted(item) || isTrashItem(item))
             clearIds.push(session.tabId);
           // if a note becomes conflicted, reopen the session
@@ -331,6 +332,13 @@ class EditorStore extends BaseStore<EditorStore> {
             !item.readonly
           )
             openSession(session.note.id, { force: true, silent: true });
+          // if a note is made readonly, reopen the session
+          else if (
+            session.type !== "readonly" &&
+            item.type === "note" &&
+            item.readonly
+          )
+            openSession(session.note.id, { force: true, silent: true });
           // update the note in all sessions
           else if (item.type === "note") {
             updateSession(

apps/web/src/utils/file-picker.ts

@@ -18,28 +18,37 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 import { PAGE_VISIBILITY_CHANGE } from "./page-visibility";
+import { strings } from "@notesnook/intl";
+import { TaskManager } from "../common/task-manager";
 
 type FilePickerOptions = { acceptedFileTypes: string; multiple?: boolean };
 
-export function showFilePicker({
+export async function showFilePicker({
   acceptedFileTypes,
   multiple
 }: FilePickerOptions): Promise<File[]> {
-  return new Promise((resolve) => {
-    PAGE_VISIBILITY_CHANGE.ignore = true;
-    const input = document.createElement("input");
-    input.setAttribute("type", "file");
-    input.setAttribute("multiple", `${multiple || false}`);
-    input.setAttribute("accept", acceptedFileTypes);
-    input.dispatchEvent(new MouseEvent("click"));
-    input.oncancel = async function () {
-      resolve([]);
-    };
-    input.onchange = async function () {
-      if (!input.files) return resolve([]);
-      resolve(Array.from(input.files));
-    };
+  PAGE_VISIBILITY_CHANGE.ignore = true;
+  const input = document.createElement("input");
+  input.setAttribute("type", "file");
+  input.setAttribute("multiple", `${multiple || false}`);
+  input.setAttribute("accept", acceptedFileTypes);
+  input.dispatchEvent(new MouseEvent("click"));
+  const result = await TaskManager.startTask<File[]>({
+    type: "modal",
+    title: strings.processing(),
+    subtitle: strings.pleaseWait(),
+    action: () =>
+      new Promise((resolve) => {
+        input.oncancel = async function () {
+          resolve([]);
+        };
+        input.onchange = async function () {
+          if (!input.files) return resolve([]);
+          resolve(Array.from(input.files));
+        };
+      })
   });
+  return result instanceof Error ? [] : result;
 }
 
 export async function readFile(file: File): Promise<string> {

apps/web/src/utils/web-extension-server.ts

@@ -88,7 +88,11 @@ export class WebExtensionServer implements Server {
         }
       );
 
-      const attachment = (await attachFiles([clippedFile]))?.at(0);
+      let attachment;
+      for await (const message of attachFiles([clippedFile], [false])) {
+        if (message.type === "done") attachment = message.attachment;
+        else if (message.type === "error") return;
+      }
       if (!attachment) return;
 
       clipContent += h("iframe", [], {

fastlane/metadata/android/en-US/changelogs/15524.txt

@@ -0,0 +1,3 @@
+- Bug fixes and improvements
+
+Thank you for using Notesnook!

fastlane/metadata/android/en-US/changelogs/15529.txt

@@ -0,0 +1,3 @@
+- Bug fixes and improvements
+
+Thank you for using Notesnook!

packages/core/src/api/sync/index.ts

@@ -400,6 +400,16 @@ export class Sync {
     }
 
     const collectionType = SYNC_COLLECTIONS_MAP[itemType];
+
+    if (!collectionType) {
+      this.logger.error(
+        new Error(
+          `Unknown collection type for item type ${itemType}. Skipping chunk.`
+        )
+      );
+      return;
+    }
+
     const collection = this.db[collectionType].collection;
     const localItems = await collection.records(chunk.items.map((i) => i.id));
     let items: (MaybeDeletedItem<Item> | undefined)[] = [];

packages/core/src/api/user-manager.ts

@@ -404,7 +404,9 @@ class UserManager {
     const masterKey = await this.getMasterKey();
     if (!masterKey) return;
 
-    const dataEncryptionKey = await this.keyManager.get("dataEncryptionKey");
+    const dataEncryptionKey = await this.keyManager.get("dataEncryptionKey", {
+      refetchUser: false
+    });
     if (!dataEncryptionKey)
       return [
         {
@@ -415,7 +417,10 @@ class UserManager {
     const keys: { version: KeyVersion; key: SerializedKey }[] = [];
 
     const legacyDataEncryptionKey = await this.keyManager.get(
-      "legacyDataEncryptionKey"
+      "legacyDataEncryptionKey",
+      {
+        refetchUser: false
+      }
     );
     if (legacyDataEncryptionKey)
       keys.push({

packages/editor/src/extensions/search-replace/search-replace.ts

@@ -18,7 +18,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 import { Extension } from "@tiptap/core";
-import { Decoration, DecorationSet } from "prosemirror-view";
+import { Decoration, DecorationSet, EditorView } from "prosemirror-view";
 import {
   EditorState,
   Plugin,
@@ -28,6 +28,7 @@ import {
 } from "prosemirror-state";
 import { SearchSettings } from "../../toolbar/stores/search-store.js";
 import { tiptapKeys } from "@notesnook/common";
+import { toggleNodesUnderPos } from "../heading/index.js";
 
 type DispatchFn = (tr: Transaction) => void;
 declare module "@tiptap/core" {
@@ -295,12 +296,11 @@ export const SearchReplace = Extension.create<SearchOptions, SearchStorage>({
             )
           );
 
-          const domNode = this.editor.view.domAtPos(from).node;
-          scrollIntoView(domNode);
-
           this.storage.selectedIndex = nextIndex;
+          tr.setMeta("isSearching", true);
           tr.setMeta("selectedIndex", nextIndex);
           if (dispatch) updateView(state, dispatch);
+
           return true;
         },
       moveToPreviousResult:
@@ -322,10 +322,8 @@ export const SearchReplace = Extension.create<SearchOptions, SearchStorage>({
             )
           );
 
-          const domNode = this.editor.view.domAtPos(from).node;
-          scrollIntoView(domNode);
-
           this.storage.selectedIndex = prevIndex;
+          tr.setMeta("isSearching", true);
           tr.setMeta("selectedIndex", prevIndex);
           if (dispatch) updateView(state, dispatch);
 
@@ -470,14 +468,90 @@ export const SearchReplace = Extension.create<SearchOptions, SearchStorage>({
           decorations(state) {
             return key.getState(state).results;
           }
+        },
+        appendTransaction: (transactions, oldState, newState) => {
+          const isSearchTransaction = transactions.find((t) =>
+            t.getMeta("isSearching")
+          );
+          const selectedResult =
+            this.storage.results?.[this.storage.selectedIndex];
+          if (!isSearchTransaction || !selectedResult) return;
+
+          const tr = newState.tr;
+
+          scrollIntoView(this.editor.view, selectedResult.from);
+          if (expandCollapsedParents(tr, selectedResult.from)) {
+            return tr;
+          }
         }
       })
     ];
   }
 });
 
-function scrollIntoView(domNode: Node) {
+function expandCollapsedParents(tr: Transaction, pos: number) {
+  try {
+    let changed = false;
+
+    const $pos = tr.doc.resolve(pos);
+
+    for (let depth = 1; depth <= $pos.depth; depth++) {
+      const node = $pos.node(depth);
+      const nodePos = $pos.before(depth);
+
+      if (
+        (node.type.name === "callout" ||
+          node.type.name === "outlineListItem") &&
+        node.attrs.collapsed
+      ) {
+        tr.setNodeAttribute(nodePos, "collapsed", false);
+        changed = true;
+      }
+
+      // expand collapsed heading that hid this node via hidden attribute
+      if (node.attrs.hidden) {
+        const parentNode = $pos.node(depth - 1);
+        const parentContentStart = depth === 1 ? 0 : $pos.before(depth - 1) + 1;
+
+        let collapsedHeadingPos = -1;
+        let collapsedHeadingLevel = -1;
+
+        parentNode.forEach((child, offset) => {
+          const childAbsPos = parentContentStart + offset;
+          if (childAbsPos >= nodePos) return;
+          if (
+            child.type.name === "heading" &&
+            child.attrs.collapsed &&
+            !child.attrs.hidden
+          ) {
+            collapsedHeadingPos = childAbsPos;
+            collapsedHeadingLevel = child.attrs.level;
+          }
+        });
+
+        if (collapsedHeadingPos !== -1) {
+          tr.setNodeAttribute(collapsedHeadingPos, "collapsed", false);
+          toggleNodesUnderPos(
+            tr,
+            collapsedHeadingPos,
+            collapsedHeadingLevel,
+            false
+          );
+          changed = true;
+        }
+      }
+    }
+
+    if (changed) tr.setMeta("preventSave", true);
+    return changed;
+  } catch (e) {
+    console.error("Error expanding collapsed parents: ", e);
+  }
+}
+
+function scrollIntoView(view: EditorView, pos: number) {
   setTimeout(() => {
+    const domNode = view.domAtPos(pos).node;
     if ("scrollIntoView" in domNode) {
       (domNode as Element).scrollIntoView({
         behavior: "instant",

packages/editor/src/toolbar/popups/search-replace.tsx

@@ -25,6 +25,7 @@ import { ToolButton } from "../components/tool-button.js";
 import { Editor } from "../../types.js";
 import { useEditorSearchStore } from "../stores/search-store.js";
 import { strings } from "@notesnook/intl";
+import { inlineDebounce } from "@notesnook/common";
 
 export type SearchReplacePopupProps = { editor: Editor };
 export function SearchReplacePopup(props: SearchReplacePopupProps) {
@@ -94,7 +95,7 @@ export function SearchReplacePopup(props: SearchReplacePopupProps) {
               sx={{ p: 0, fontFamily: "monospace" }}
               value={searchTerm}
               onChange={(e) => {
-                search(e.target.value);
+                inlineDebounce("search", () => search(e.target.value), 100);
                 useEditorSearchStore.setState({ searchTerm: e.target.value });
               }}
               onKeyDown={(e) => {

packages/intl/locale/en.po

@@ -948,6 +948,10 @@ msgstr "Are you sure you want to logout and clear all data stored on THIS DEVICE
 msgid "Are you sure you want to logout from this device? Any unsynced changes will be lost."
 msgstr "Are you sure you want to logout from this device? Any unsynced changes will be lost."
 
+#: src/strings.ts:2687
+msgid "Are you sure you want to open this file: {filePath}?"
+msgstr "Are you sure you want to open this file: {filePath}?"
+
 #: src/strings.ts:1046
 msgid "Are you sure you want to remove your name?"
 msgstr "Are you sure you want to remove your name?"
@@ -984,6 +988,10 @@ msgstr "Attach image from URL"
 msgid "Attached files"
 msgstr "Attached files"
 
+#: src/strings.ts:2678
+msgid "Attaching files"
+msgstr "Attaching files"
+
 #: src/strings.ts:290
 msgid "attachment"
 msgstr "attachment"
@@ -1646,6 +1654,10 @@ msgstr "Click to update"
 msgid "Close"
 msgstr "Close"
 
+#: src/strings.ts:2679
+msgid "Close ({seconds})"
+msgstr "Close ({seconds})"
+
 #: src/strings.ts:2019
 msgid "Close all"
 msgstr "Close all"
@@ -1755,6 +1767,14 @@ msgstr "Compress images before uploading"
 msgid "Compressed images are uploaded in Full HD resolution and usually are good enough for most use cases."
 msgstr "Compressed images are uploaded in Full HD resolution and usually are good enough for most use cases."
 
+#: src/strings.ts:2680
+msgid "Compressing"
+msgstr "Compressing"
+
+#: src/strings.ts:2684
+msgid "Compression failed"
+msgstr "Compression failed"
+
 #: src/strings.ts:2262
 msgid "Configure"
 msgstr "Configure"
@@ -2547,6 +2567,10 @@ msgstr "Encrypted backup"
 msgid "Encrypted, private, secure."
 msgstr "Encrypted, private, secure."
 
+#: src/strings.ts:2681
+msgid "Encrypting"
+msgstr "Encrypting"
+
 #: src/strings.ts:940
 msgid "Encrypting attachment"
 msgstr "Encrypting attachment"
@@ -2743,6 +2767,18 @@ msgstr "Experience the next level of private note taking\""
 msgid "Expiry date"
 msgstr "Expiry date"
 
+#: src/strings.ts:2692
+msgid "Expiry date cannot be more than 1 year in the future"
+msgstr "Expiry date cannot be more than 1 year in the future"
+
+#: src/strings.ts:2690
+msgid "Expiry date must be in the future"
+msgstr "Expiry date must be in the future"
+
+#: src/strings.ts:2693
+msgid "Expiry date set"
+msgstr "Expiry date set"
+
 #: src/strings.ts:2550
 msgid "Explore all plans"
 msgstr "Explore all plans"
@@ -2913,10 +2949,18 @@ msgstr "File length is 0. Please upload this file again from the attachment mana
 msgid "File length mismatch. Expected {expectedSize} but got {currentSize} bytes. Please upload this file again from the attachment manager."
 msgstr "File length mismatch. Expected {expectedSize} but got {currentSize} bytes. Please upload this file again from the attachment manager."
 
+#: src/strings.ts:2689
+msgid "File links cannot be opened in browsers. Please use the Notesnook desktop app."
+msgstr "File links cannot be opened in browsers. Please use the Notesnook desktop app."
+
 #: src/strings.ts:949
 msgid "File mismatch"
 msgstr "File mismatch"
 
+#: src/strings.ts:2683
+msgid "File size limit exceeded. Please upgrade your plan."
+msgstr "File size limit exceeded. Please upgrade your plan."
+
 #: src/strings.ts:945
 msgid "File size should be less than {sizeInMB}"
 msgstr "File size should be less than {sizeInMB}"
@@ -4493,6 +4537,10 @@ msgstr "Open source."
 msgid "Open the two-factor authentication (TOTP) app to view your authentication code."
 msgstr "Open the two-factor authentication (TOTP) app to view your authentication code."
 
+#: src/strings.ts:2685
+msgid "Opening local file"
+msgstr "Opening local file"
+
 #: src/strings.ts:1857
 msgid "Optional"
 msgstr "Optional"

packages/intl/locale/pseudo-LOCALE.po

@@ -948,6 +948,10 @@ msgstr ""
 msgid "Are you sure you want to logout from this device? Any unsynced changes will be lost."
 msgstr ""
 
+#: src/strings.ts:2687
+msgid "Are you sure you want to open this file: {filePath}?"
+msgstr ""
+
 #: src/strings.ts:1046
 msgid "Are you sure you want to remove your name?"
 msgstr ""
@@ -984,6 +988,10 @@ msgstr ""
 msgid "Attached files"
 msgstr ""
 
+#: src/strings.ts:2678
+msgid "Attaching files"
+msgstr ""
+
 #: src/strings.ts:290
 msgid "attachment"
 msgstr ""
@@ -1635,6 +1643,10 @@ msgstr ""
 msgid "Close"
 msgstr ""
 
+#: src/strings.ts:2679
+msgid "Close ({seconds})"
+msgstr ""
+
 #: src/strings.ts:2019
 msgid "Close all"
 msgstr ""
@@ -1742,6 +1754,14 @@ msgstr ""
 
 #: src/strings.ts:144
 msgid "Compressed images are uploaded in Full HD resolution and usually are good enough for most use cases."
+msgstr "<<<<<<< HEAD"
+
+#: src/strings.ts:2680
+msgid "Compressing"
+msgstr "<<<<<<< HEAD"
+
+#: src/strings.ts:2684
+msgid "Compression failed"
 msgstr ""
 
 #: src/strings.ts:2262
@@ -2536,6 +2556,10 @@ msgstr ""
 msgid "Encrypted, private, secure."
 msgstr ""
 
+#: src/strings.ts:2681
+msgid "Encrypting"
+msgstr ""
+
 #: src/strings.ts:940
 msgid "Encrypting attachment"
 msgstr ""
@@ -2732,6 +2756,18 @@ msgstr ""
 msgid "Expiry date"
 msgstr ""
 
+#: src/strings.ts:2692
+msgid "Expiry date cannot be more than 1 year in the future"
+msgstr ""
+
+#: src/strings.ts:2690
+msgid "Expiry date must be in the future"
+msgstr ""
+
+#: src/strings.ts:2693
+msgid "Expiry date set"
+msgstr ""
+
 #: src/strings.ts:2550
 msgid "Explore all plans"
 msgstr ""
@@ -2902,10 +2938,18 @@ msgstr ""
 msgid "File length mismatch. Expected {expectedSize} but got {currentSize} bytes. Please upload this file again from the attachment manager."
 msgstr ""
 
+#: src/strings.ts:2689
+msgid "File links cannot be opened in browsers. Please use the Notesnook desktop app."
+msgstr ""
+
 #: src/strings.ts:949
 msgid "File mismatch"
 msgstr ""
 
+#: src/strings.ts:2683
+msgid "File size limit exceeded. Please upgrade your plan."
+msgstr ""
+
 #: src/strings.ts:945
 msgid "File size should be less than {sizeInMB}"
 msgstr ""
@@ -4467,6 +4511,10 @@ msgstr ""
 msgid "Open the two-factor authentication (TOTP) app to view your authentication code."
 msgstr ""
 
+#: src/strings.ts:2685
+msgid "Opening local file"
+msgstr ""
+
 #: src/strings.ts:1857
 msgid "Optional"
 msgstr ""

packages/intl/src/strings.ts

@@ -2674,5 +2674,21 @@ Use this if changes from other devices are not appearing on this device. This wi
   
 Continue without attachments?`,
   pleaseLoginToDownloadAttachments: () =>
-    t`Please login to download attachments.`
+    t`Please login to download attachments.`,
+  attachingFiles: () => t`Attaching files`,
+  closeCountdown: (seconds: number) => t`Close (${seconds})`,
+  compressing: () => t`Compressing`,
+  encrypting: () => t`Encrypting`,
+  fileSizeLimitExceededPleaseUpgrade: () =>
+    t`File size limit exceeded. Please upgrade your plan.`,
+  compressionFailed: () => t`Compression failed`,
+  openingLocalFile: () => t`Opening local file`,
+  openingLocalFileDesc: (filePath: string) =>
+    t`Are you sure you want to open this file: ${filePath}?`,
+  cantOpenFileLinksInBrowsers: () =>
+    t`File links cannot be opened in browsers. Please use the Notesnook desktop app.`,
+  expiryDateMustBeInTheFuture: () => t`Expiry date must be in the future`,
+  expiryDateCannotBeMoreThan1YearInTheFuture: () =>
+    t`Expiry date cannot be more than 1 year in the future`,
+  expiryDateSet: () => t`Expiry date set`
 };