editor: fix Enter key not working on some keyboards in Android

2026-08-31 19:19:34 +02:00 · 2023-02-24 11:45:16 +05:00
1 changed files with 8 additions and 4 deletions
--- a/packages/editor/src/extensions/text-direction/text-direction.ts
+++ b/packages/editor/src/extensions/text-direction/text-direction.ts
@@ -68,9 +68,11 @@ export function getTextDirection(editor: Editor): TextDirections {
 export const TextDirection = Extension.create<TextDirectionOptions>({
  name: "textDirection",

-  defaultOptions: {
-    types: TEXT_DIRECTION_TYPES,
-    defaultDirection: undefined
+  addOptions() {
+    return {
+      types: TEXT_DIRECTION_TYPES,
+      defaultDirection: undefined
+    };
  },

  addGlobalAttributes() {
@@ -79,7 +81,9 @@ export const TextDirection = Extension.create<TextDirectionOptions>({
        types: this.options.types,
        attributes: {
          textDirection: {
-            default: this.options.defaultDirection,
+            // NOTE: for some reason setting this to undefined breaks enter behaviour
+            // on Android for some keyboards (GBoard etc.). Empty string works fine.
+            default: this.options.defaultDirection || "",
            parseHTML: (element) => element.dir,
            renderHTML: (attributes) => {
              if (!attributes.textDirection) {