The FilteredSelector passed into notesWithHighlighting was being mutated. This wasn't an issue in the apps/web because a fresh selector was passed in for every query. But on apps/mobile, the same selector is reused for every query on the search page.
The bug only became apparent when passing in a query like `tag:one`, then after the results came in, continuing the query: `tag:one tag:two`. This only showed results from tag:one since the selector was mutated by the previous lookup.
The mutation happens in FilteredSelector's where method. So, the bug is fixed by cloning the selector before the where method call in notesWithHighlighting.
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* fix extra quotes being added for multi word tag/color filter
* fix multiple tag/color filters not working
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* On web, long tags in menu items in the editor header would take a lot of width. The fix in the ui package will fix it for all usages of long menu items on web
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* docs: new help built with vitepress.
* docs: improve docs home ui
Added a Go to Docs button on homepage
Added a searchbar for directly searching what you are looking for in the docs
* docs(help): wire up with build system & setup proper ci
* Clean up new documentation (#10174)
* Docs: Cleanup pass 1
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
* docs: cleanup pass 2
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
* docs: Fix vscode's manglement that I missed.
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
* Update docs/help/contents/plans-and-limits.md
Co-authored-by: Abdullah Atta <thecodrr@protonmail.com>
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
* Update docs/help/contents/rich-text-editor/outline-lists.md
Co-authored-by: Abdullah Atta <thecodrr@protonmail.com>
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
* docs: Remove self-hosting guide from sidebar, and comments for reviewer.
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
---------
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
Co-authored-by: Abdullah Atta <thecodrr@protonmail.com>
* docs: some fixes
* ci: do not publish help on push
* docs(help): improve regional pricing & free trials
* docs: improve sidebar
* docs: some more fixes after re-review
* docs: improve search and nav
* docs: a few more fixes
* docs: fix tabs formatting compat with prettier
* docs: fix tabs formatting in various places
* docs: show correct plus button image for mobile
* docs: disable notesnook self hosting docs
* docs: update help docs with fixes
---------
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
Co-authored-by: Chloe Oletto <NeedsChloesure@riseup.net>
Co-authored-by: Abdullah Atta <thecodrr@protonmail.com>
- Improve drag/drop reliability be increasing the hit slop area for starting the drag.
- Ensure drag survives between rerenders
- Add a solid background to dragged item so it doesn't conflict with items underneath it
* mobile: pass value for items when searching on main screen to match other screens' pattern
Signed-off-by: Suyadi <afsuyadi@gmail.com>
* core: guard notesWithHighlighting against an undefined notes selector.
Signed-off-by: Suyadi <afsuyadi@gmail.com>
* core: add regression test for notesWithHighlighting crash.
Signed-off-by: Suyadi <afsuyadi@gmail.com>
* core: revert changes after feedback
Signed-off-by: Suyadi <afsuyadi@gmail.com>
* mobile: ensure type: "note" will make items become mandatory.
Signed-off-by: Suyadi <afsuyadi@gmail.com>
* core: remove tests after feedback
Signed-off-by: Suyadi <afsuyadi@gmail.com>
1. Use noteId defined in editorMessage when saving content, never use tabId since it can point to a different note since a tab can load a different note while a note save message is coming across the bridge.
2. If saving fails and editor saves save payloads in localStorage, add the noteId to them so we know which note the content belongs to.
3. Pending content saves must keep noteId and edit time so when we save them later, they save into the correct note and if the content is newer, we skip saving.
4. Fix the debounce key so cross contamination can never occur in new notes between two tabs.
