The bug: Select 2 text blocks fully and pressing backspace removes the conent and adds it back again. The editor thinks enter is pressed and adds the content to dom back from state.
Guard the whitespace heuristic to only fire on net insertion so backspace keeps working properly.
The patch added two console.log calls: one dumping every editor's paste
rules, one logging the selection while a view is built. Chrome retains
objects passed to the console so they can be inspected later, and each
PasteRule closes over its editor, so every editor ever opened was kept
alive along with its state and document. They also showed up in the
output of every editor test.
* core: fix quoted & repeated tag/color filters in search query
* fix extra quotes being added for multi word tag/color filter
* fix multiple tag/color filters not working
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* core: prevent db.lookup.notesWithHighlighting from mutating the passed in selector
The FilteredSelector passed into notesWithHighlighting was being mutated. This wasn't an issue in the apps/web because a fresh selector was passed in for every query. But on apps/mobile, the same selector is reused for every query on the search page.
The bug only became apparent when passing in a query like `tag:one`, then after the results came in, continuing the query: `tag:one tag:two`. This only showed results from tag:one since the selector was mutated by the previous lookup.
The mutation happens in FilteredSelector's where method. So, the bug is fixed by cloning the selector before the where method call in notesWithHighlighting.
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
---------
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
deleteItemsFromTrash reused the "restoreItems" task id from
restoreItemsFromTrash (copy-paste), so a permanent-delete and a
restore running close together shared the same status entry: the one
that finished first cleared the other's progress indicator, and the
displayed status text could reflect the wrong operation. Give the
delete task its own "deleteItems" id.
Signed-off-by: zigzagdev <msts.oo0131@gmail.com>
* On web, long tags in menu items in the editor header would take a lot of width. The fix in the ui package will fix it for all usages of long menu items on web
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
* docs: new help built with vitepress.
* docs: improve docs home ui
Added a Go to Docs button on homepage
Added a searchbar for directly searching what you are looking for in the docs
* docs(help): wire up with build system & setup proper ci
* Clean up new documentation (#10174)
* Docs: Cleanup pass 1
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
* docs: cleanup pass 2
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
* docs: Fix vscode's manglement that I missed.
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
* Update docs/help/contents/plans-and-limits.md
Co-authored-by: Abdullah Atta <thecodrr@protonmail.com>
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
* Update docs/help/contents/rich-text-editor/outline-lists.md
Co-authored-by: Abdullah Atta <thecodrr@protonmail.com>
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
* docs: Remove self-hosting guide from sidebar, and comments for reviewer.
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
---------
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
Co-authored-by: Abdullah Atta <thecodrr@protonmail.com>
* docs: some fixes
* ci: do not publish help on push
* docs(help): improve regional pricing & free trials
* docs: improve sidebar
* docs: some more fixes after re-review
* docs: improve search and nav
* docs: a few more fixes
* docs: fix tabs formatting compat with prettier
* docs: fix tabs formatting in various places
* docs: show correct plus button image for mobile
* docs: disable notesnook self hosting docs
* docs: update help docs with fixes
---------
Signed-off-by: Chloe Oletto <NeedsChloesure@riseup.net>
Co-authored-by: Abdullah Atta <abdullahatta@streetwriters.co>
Co-authored-by: Chloe Oletto <NeedsChloesure@riseup.net>
Co-authored-by: Abdullah Atta <thecodrr@protonmail.com>
