Mirrors/notesnook
1
0
Fork 0
mirror of https://github.com/streetwriters/notesnook.git synced 2025-12-23 06:59:31 +01:00
Code Issues Packages Projects Releases Wiki Activity

web: can't add a tag that's a substring of another tag (fixes #1002)

Browse Source
This commit is contained in:
Abdullah Atta
2022-09-19 17:02:16 +05:00
parent 0f44ca49a9
commit a0b8262fb6
2 changed files with 33 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
apps/web/__e2e__/notes.issues.test.ts
View File

@@ -17,5 +17,26 @@ You should have received a copy of the GNU General Public License
along with this program. If not, see <http://www.gnu.org/licenses/>.
*/
import { test } from "@playwright/test";
import { expect, test } from "@playwright/test";
import { AppModel } from "./models/app.model";
import { NOTE } from "./utils";
test.skip("TODO: make sure jump to group works", () => {});
test("#1002 Can't add a tag that's a substring of an existing tag", async ({
page
}) => {
const tags = ["chromeos-105", "chromeos"];
const app = new AppModel(page);
await app.goto();
const tagsView = await app.goToTags();
await tagsView.createItem({ title: "chromeos-105" });
const notes = await app.goToNotes();
await notes.createNote(NOTE);
await notes.editor.setTags(tags);
await page.waitForTimeout(200);
const noteTags = await notes.editor.getTags();
expect(noteTags).toHaveLength(tags.length);
expect(noteTags.every((t, i) => t === tags[i])).toBe(true);
});

13
apps/web/src/components/editor/header.js
View File

@@ -110,14 +110,21 @@ function Autosuggest({
if (filterText.length <= 0 && filtered.length <= 0) {
closeMenu();
return;
} else if (filterText.length > 0 && filtered.length <= 0) {
}
if (
filterText.length > 0 &&
filtered.every((item) => item.title !== filterText)
) {
items.push({
key: "new",
title: () => `Create "${filterText}" tag`,
icon: Icon.Plus,
onClick: () => onAction("add", filterText)
});
} else {
}
if (filtered.length > 0) {
items.push(
...filtered.map((tag) => ({
key: tag.id,
@@ -177,6 +184,8 @@ function Autosuggest({
const text = getInputValue();
if (e.key === "Enter" && !!text && !filtered.length) {
onAction("add", text);
} else if (e.key === "Enter" && !!text && !!filtered.length) {
onAction("select", filtered[0]);
} else if (!text && e.key === "Backspace") {
onRemove();
setFiltered([]);