core: always delete vault references on vault deletion

packages/core/__tests__/vault.test.js

@@ -185,7 +185,7 @@ test("delete vault without deleting all locked notes", () =>
 
     await db.vault.delete();
 
-    expect(await db.relations.from(vault, "note").has(id)).toBe(true);
+    expect(await db.relations.from(vault, "note").has(id)).toBe(false);
     expect(await db.vaults.default()).toBeUndefined();
   }));
 

packages/core/src/api/vault.ts

@@ -160,7 +160,7 @@ export default class Vault {
       await this.db.notes.remove(...lockedIds);
     }
 
-    await this.db.vaults.remove(vault.id, deleteAllLockedNotes);
+    await this.db.vaults.remove(vault.id);
     this.password = undefined;
   }
 

packages/core/src/collections/notes.ts

@@ -138,7 +138,6 @@ export class Notes implements ICollection {
           headline: headline,
 
           pinned: item.pinned,
-          locked: item.locked,
           favorite: item.favorite,
           localOnly: item.localOnly,
           conflicted: item.conflicted,

packages/core/src/collections/vaults.ts

@@ -55,9 +55,9 @@ export class Vaults implements ICollection {
     return id;
   }
 
-  async remove(id: string, unlinkAllNotes = false) {
+  async remove(id: string) {
     await this.db.transaction(async () => {
-      if (unlinkAllNotes) await this.db.relations.unlinkOfType("vault", [id]);
+      await this.db.relations.unlinkOfType("vault", [id]);
       await this.collection.softDelete([id]);
     });
   }

packages/core/src/database/migrations.ts

@@ -50,7 +50,6 @@ export class NNMigrationProvider implements MigrationProvider {
             .addColumn("headline", "text")
             .addColumn("contentId", "text")
             .addColumn("pinned", "boolean")
-            .addColumn("locked", "boolean")
             .addColumn("favorite", "boolean")
             .addColumn("localOnly", "boolean")
             .addColumn("conflicted", "boolean")