Mirrors/notesnook
1
0
Fork 0
mirror of https://github.com/streetwriters/notesnook.git synced 2025-12-23 23:19:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: scroll jumps in context menu

Browse Source
This commit is contained in:
thecodrr
2022-02-14 22:49:45 +05:00
parent 811fe12e79
commit 5d1dbf3176
1 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
apps/web/src/components/menu/index.js
View File

@@ -9,6 +9,19 @@ function useMenuFocus(items, onAction) {
const [focusIndex, setFocusIndex] = useState(-1);
const [isSubmenuOpen, setIsSubmenuOpen] = useState(false);
const moveItemIntoView = useCallback(
(index) => {
const item = items[index];
if (!item) return;
const element = document.getElementById(item.key);
if (!element) return;
element.scrollIntoView({
behavior: "auto",
});
},
[items]
);
const onKeyDown = useCallback(
(e) => {
const isSeperator = (i) => items && items[i]?.type === "seperator";
@@ -51,11 +64,12 @@ function useMenuFocus(items, onAction) {
default:
break;
}
if (nextIndex !== i) moveItemIntoView(nextIndex);
return nextIndex;
});
},
[items, isSubmenuOpen, onAction]
[items, isSubmenuOpen, moveItemIntoView, onAction]
);
useEffect(() => {
@@ -88,14 +102,6 @@ function Menu({ items, data, title, closeMenu }) {
if (item) onAction(e, item);
});
useEffect(() => {
const item = items[focusIndex];
if (!item) return;
const element = document.getElementById(item.key);
if (!element) return;
element.scrollIntoView({ behavior: "auto" });
}, [focusIndex, items]);
const subMenuRef = useRef();
useEffect(() => {
const item = items[focusIndex];