Mirrors/notesnook
1
0
Fork 0
mirror of https://github.com/streetwriters/notesnook.git synced 2025-12-16 11:47:54 +01:00
Code Issues Packages Projects Releases Wiki Activity

clipper: remove invalid element attributes for screenshot clips

Browse Source 
Signed-off-by: 01zulfi <85733202+01zulfi@users.noreply.github.com>
This commit is contained in:
01zulfi
2025-06-20 12:35:36 +05:00
committed by Abdullah Atta
parent a0f5880e2c
commit 5d1775151d
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
packages/clipper/src/domtoimage.ts
View File

@@ -138,6 +138,20 @@ function makeSvgDataUri(
) {
body.setAttribute("xmlns", "http://www.w3.org/1999/xhtml");
/**
* We're removing all attributes that contain non-word characters
* Sometimes a webpage could have invalid html and that causes attribute names to break
* HTML is resilient to this but SVG is not and will throw an error, so we remove these attributes altogether
*/
for (const element of body.querySelectorAll("img, svg, video, iframe")) {
const attributes = element.getAttributeNames();
for (const attribute of attributes) {
if (attribute.match(/\W/)) {
element.removeAttribute(attribute);
}
}
}
const xhtml = new XMLSerializer().serializeToString(body);
const xstyles = Array.from(head.getElementsByTagName("style"))