Mirrors/dokku
1
0
Fork 0
mirror of https://github.com/dokku/dokku.git synced 2025-12-29 00:25:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: write the cron config after the app.json has been deleted

Browse Source 
Without this, we try to write the config for the app even though it doesn't exist anymore, causing issues with deleting apps with invalid cron configs.
This commit is contained in:
Jose Diaz-Gonzalez
2025-06-19 01:09:15 -04:00
parent 6f0039ebf1
commit 776013b0f4
3 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/cron/Makefile
View File

@@ -1,5 +1,5 @@
SUBCOMMANDS = subcommands/list subcommands/report subcommands/run subcommands/set
TRIGGERS = triggers/cron-get-property triggers/install triggers/post-app-clone-setup triggers/post-app-rename-setup triggers/pre-delete triggers/post-delete triggers/scheduler-stop
TRIGGERS = triggers/cron-get-property triggers/install triggers/post-app-clone-setup triggers/post-app-rename-setup triggers/post-delete triggers/scheduler-stop
BUILD = commands subcommands triggers
PLUGIN_NAME = cron

3
plugins/cron/src/triggers/triggers.go
View File

@@ -40,9 +40,6 @@ func main() {
case "post-delete":
appName := flag.Arg(0)
err = cron.TriggerPostDelete(appName)
case "pre-delete":
appName := flag.Arg(0)
err = cron.TriggerPreDelete(appName)
case "report":
appName := flag.Arg(0)
err = cron.ReportSingleApp(appName, "", "")

11
plugins/cron/triggers.go
View File

@@ -55,19 +55,18 @@ func TriggerPostAppRenameSetup(oldAppName string, newAppName string) error {
return nil
}
// TriggerPreDelete stops cron for a given app
func TriggerPreDelete(appName string) error {
// TriggerPostDelete destroys the cron property for a given app container
func TriggerPostDelete(appName string) error {
scheduler := common.GetAppScheduler(appName)
_, err := common.CallPlugnTrigger(common.PlugnTriggerInput{
Trigger: "scheduler-cron-write",
Args: []string{scheduler, appName},
StreamStdio: true,
})
return err
}
if err != nil {
return err
}
// TriggerPostDelete destroys the cron property for a given app container
func TriggerPostDelete(appName string) error {
if err := common.PropertyDestroy("cron", appName); err != nil {
return err
}