Niels Laute 5eeb979339 fix(screen-ruler): migrate legacy measurement unit values (#49898)
## Summary of the Pull Request

Closes #49899

Fixes a PowerToys Settings crash when navigating away from the Screen
Ruler page with legacy measurement-unit settings.

Older Screen Ruler builds persisted `Measurement::Unit` enum values
(`Pixel = 1`, `Inch = 2`, `Centimetre = 4`, `Millimetre = 8`). The
current Settings page binds the persisted value directly to a four-item
`ComboBox.SelectedIndex`, which only accepts `0-3`. A persisted value
such as `4` therefore produces a WinUI `E_INVALIDARG` stowed exception
when the page is unloaded.

`MeasureToolViewModel` now migrates legacy values to the current
indices, validates all values before exposing them to XAML, and persists
the repaired setting:

- `4` (legacy centimetres) → `2`
- `8` (legacy millimetres) → `3`
- other out-of-range values → `0` (pixels)

## PR Checklist

- [x] Closes: #49899
- [x] **Tests:** Added/updated and all pass
- [x] **Localization:** N/A - no user-facing strings changed

## Detailed Description of the Pull Request / Additional comments

The failure was reproduced on `main` with
`%LOCALAPPDATA%\Microsoft\PowerToys\Measure Tool\settings.json`
containing:

```json
"UnitsOfMeasure": { "value": 4 }
```

Screen Ruler opened successfully, but navigating to Shortcut Guide
terminated `PowerToys.Settings.exe` in `Microsoft.UI.Xaml.dll` with
exception `0xc000027b` and `E_INVALIDARG` (`0x80070057`). Changing the
persisted value to `0` eliminated the crash, confirming the invalid
`SelectedIndex` as the cause.

The migration preserves the intended legacy centimetre/millimetre
selection rather than resetting it unnecessarily.

## Validation Steps Performed

- Built `PowerToys.Settings.csproj` in ARM64 Release.
- Added six Measure Tool ViewModel regression cases covering valid,
invalid, and legacy values.
- Ran the full Settings unit suite: **222 passed, 0 failed**.
- Reproduced the original UI flow with `UnitsOfMeasure = 4`:
  - opened Screen Ruler;
  - verified the setting migrated to `2`;
  - navigated to Shortcut Guide;
  - repeated Screen Ruler → Shortcut Guide navigation;
  - verified the Settings process remained alive after both transitions.

Copilot-Session: ebcedcc4-a067-4657-a6a9-046753f9d70c
2026-08-19 10:46:54 +08:00
2026-02-11 22:59:53 +01:00
2020-03-05 10:11:27 -08:00
2020-05-02 15:59:18 -07:00
2026-02-14 15:47:56 +08:00

Microsoft PowerToys

Microsoft PowerToys is a collection of utilities that help you customize Windows and streamline everyday tasks.

Installation · Documentation · Blog · Release notes

🔨 Utilities

PowerToys includes over 30 utilities to help you customize and optimize your Windows experience:

Advanced Paste icon Advanced Paste Always on Top icon Always on Top Awake icon Awake
Color Picker icon Color Picker Command Not Found icon Command Not Found Command Palette icon Command Palette
Crop and Lock icon Crop And Lock Environment Variables icon Environment Variables FancyZones icon FancyZones
File Explorer Add-ons icon File Explorer Add-ons File Locksmith icon File Locksmith Grab And Move icon Grab And Move
Hosts File Editor icon Hosts File Editor Image Resizer icon Image Resizer Keyboard Manager icon Keyboard Manager
Light Switch icon Light Switch Mouse Utilities icon Mouse Utilities Mouse Without Borders icon Mouse Without Borders
New+ icon New+ Peek icon Peek PowerDisplay icon PowerDisplay
PowerRename icon PowerRename PowerToys Run icon PowerToys Run Quick Accent icon Quick Accent
Registry Preview icon Registry Preview Screen Ruler icon Screen Ruler Shortcut Guide icon Shortcut Guide
Text Extractor icon Text Extractor Workspaces icon Workspaces ZoomIt icon ZoomIt

📦 Installation

For detailed installation instructions and system requirements, visit the installation docs.

But to get started quickly, choose one of the installation methods below:

Download the .exe file from GitHub

Go to the PowerToys GitHub releases, scroll down and select Assets to reveal the installation files, and choose the one that matches your architecture and install scope. For most devices, that would be x64 per-user.

Microsoft Store
You can easily install PowerToys from the Microsoft Store:

WinGet
Download PowerToys from [WinGet](https://github.com/microsoft/winget-cli#installing-the-client). Updating PowerToys via winget will respect the current PowerToys installation scope. To install PowerToys, run the following command from the command line / PowerShell:
  • User scope installer (default)
winget install Microsoft.PowerToys -s winget
  • Machine-wide scope installer
winget install --scope machine Microsoft.PowerToys -s winget
Other methods
There are [community driven install methods](https://learn.microsoft.com/windows/powertoys/install#community-driven-install-tools) such as Chocolatey and Scoop. If these are your preferred install solutions, you can find the install instructions there.

What's new?

What's new image

To see what's new, check out the release notes.

🛣️ Roadmap

We are planning some nice new features and improvements for the next releases a brand-new Shortcut Guide experience, ensuring it's easier to find and install Command Palette extensions and so much more! Stay tuned for v0.100!

❤️ PowerToys Community

The PowerToys team is extremely grateful to have the support of an amazing active community. The work you do is incredibly important. PowerToys wouldn't be nearly what it is today without your help filing bugs, updating documentation, guiding the design, or writing features. We want to say thank you and take time to recognize your work. Your contributions and feedback improve PowerToys month after month!

Contributing

This project welcomes contributions of all types. Besides coding features / bug fixes, other ways to assist include spec writing, design, documentation, and finding bugs. We are excited to work with the power user community to build a set of tools for helping you get the most out of Windows. We ask that before you start work on a feature that you would like to contribute, please read our Contributor's Guide. We would be happy to work with you to figure out the best approach, provide guidance and mentorship throughout feature development, and help avoid any wasted or duplicate effort. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you grant us the rights to use your contribution and that you have permission to do so. For guidance on developing for PowerToys, please read the developer docs for a detailed breakdown. This includes how to setup your computer to compile.

Code of conduct

This project has adopted the Microsoft Open Source Code of Conduct.

Privacy statement

The application logs basic diagnostic data (telemetry). For more privacy information and what we collect, see our PowerToys Data and Privacy documentation.

Description
Microsoft PowerToys is a collection of utilities that help you customize Windows and streamline everyday tasks
Readme MIT 734 MiB
Languages
C 45.1%
C# 26.1%
JavaScript 14.1%
C++ 13.8%
PowerShell 0.6%
Other 0.2%