mirror of
https://github.com/microsoft/PowerToys.git
synced 2025-12-16 03:37:59 +01:00
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request 1. Create Apps and Bookmarks ut project. 2. Refactor Apps and Bookmarks. And some interface in these extensions to add a abstraction layer for testing purpose. New interface list: * ISettingsInterface * IUWPApplication * IAppCache * IBookmarkDataSource 3. Add/Migrate some test case for Apps and Bookmarks extension <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #41239 #41240 - [x] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [x] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed --------- Co-authored-by: Yu Leng <yuleng@microsoft.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
110 lines
3.1 KiB
C#
110 lines
3.1 KiB
C#
// Copyright (c) Microsoft Corporation
|
|
// The Microsoft Corporation licenses this file to you under the MIT license.
|
|
// See the LICENSE file in the project root for more information.
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using System.Threading.Tasks;
|
|
using Microsoft.CmdPal.Ext.Apps.Programs;
|
|
using Microsoft.CmdPal.Ext.Apps.Storage;
|
|
using Microsoft.CmdPal.Ext.Apps.Utils;
|
|
|
|
namespace Microsoft.CmdPal.Ext.Apps;
|
|
|
|
public sealed partial class AppCache : IAppCache, IDisposable
|
|
{
|
|
private Win32ProgramFileSystemWatchers _win32ProgramRepositoryHelper;
|
|
|
|
private PackageRepository _packageRepository;
|
|
|
|
private Win32ProgramRepository _win32ProgramRepository;
|
|
|
|
private bool _disposed;
|
|
|
|
public IList<Win32Program> Win32s => _win32ProgramRepository.Items;
|
|
|
|
public IList<IUWPApplication> UWPs => _packageRepository.Items;
|
|
|
|
public static readonly Lazy<AppCache> Instance = new(() => new());
|
|
|
|
public AppCache()
|
|
{
|
|
_win32ProgramRepositoryHelper = new Win32ProgramFileSystemWatchers();
|
|
_win32ProgramRepository = new Win32ProgramRepository(_win32ProgramRepositoryHelper.FileSystemWatchers.Cast<IFileSystemWatcherWrapper>().ToList(), AllAppsSettings.Instance, _win32ProgramRepositoryHelper.PathsToWatch);
|
|
|
|
_packageRepository = new PackageRepository(new PackageCatalogWrapper());
|
|
|
|
var a = Task.Run(() =>
|
|
{
|
|
_win32ProgramRepository.IndexPrograms();
|
|
});
|
|
|
|
var b = Task.Run(() =>
|
|
{
|
|
_packageRepository.IndexPrograms();
|
|
UpdateUWPIconPath(ThemeHelper.GetCurrentTheme());
|
|
});
|
|
|
|
try
|
|
{
|
|
Task.WaitAll(a, b);
|
|
}
|
|
catch (AggregateException ex)
|
|
{
|
|
ManagedCommon.Logger.LogError("One or more errors occurred while indexing apps");
|
|
|
|
foreach (var inner in ex.InnerExceptions)
|
|
{
|
|
ManagedCommon.Logger.LogError(inner.Message, inner);
|
|
}
|
|
}
|
|
|
|
AllAppsSettings.Instance.LastIndexTime = DateTime.Today;
|
|
}
|
|
|
|
private void UpdateUWPIconPath(Theme theme)
|
|
{
|
|
if (_packageRepository is not null)
|
|
{
|
|
foreach (UWPApplication app in _packageRepository)
|
|
{
|
|
try
|
|
{
|
|
app.UpdateLogoPath(theme);
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
ManagedCommon.Logger.LogError($"Failed to update icon path for app {app.Name}", ex);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
public bool ShouldReload() => _packageRepository.ShouldReload() || _win32ProgramRepository.ShouldReload();
|
|
|
|
public void ResetReloadFlag()
|
|
{
|
|
_packageRepository.ResetReloadFlag();
|
|
_win32ProgramRepository.ResetReloadFlag();
|
|
}
|
|
|
|
public void Dispose()
|
|
{
|
|
Dispose(disposing: true);
|
|
GC.SuppressFinalize(this);
|
|
}
|
|
|
|
private void Dispose(bool disposing)
|
|
{
|
|
if (!_disposed)
|
|
{
|
|
if (disposing)
|
|
{
|
|
_win32ProgramRepositoryHelper?.Dispose();
|
|
_disposed = true;
|
|
}
|
|
}
|
|
}
|
|
}
|