mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-04 10:16:24 +02:00
Both `TopLevelCommandItemWrapper` and `TopLevelViewModel` were really the same thing. The latter was from an earlier prototype, and the former is a more correct, safer abstraction. We really should have only ever used the former, but alas, we only used it for the SUI, and it piggy-backed off the latter, and that meant the latter's bugs became the former's. tldr: I made the icon access safe in the SUI. And while I was doing this, because we now have a cleaner VM abstraction here in the host, we can actually cleanly disable extensions, because the `CommandProviderWrapper` knows which `ViewModel`s it made. Closes https://github.com/zadjii-msft/PowerToys/issues/426 Closes https://github.com/zadjii-msft/PowerToys/issues/478 Closes https://github.com/zadjii-msft/PowerToys/issues/577
48 lines
1.5 KiB
C#
48 lines
1.5 KiB
C#
// Copyright (c) Microsoft Corporation
|
|
// The Microsoft Corporation licenses this file to you under the MIT license.
|
|
// See the LICENSE file in the project root for more information.
|
|
|
|
using CommunityToolkit.Mvvm.ComponentModel;
|
|
using Microsoft.CmdPal.UI.ViewModels.Models;
|
|
using Microsoft.CommandPalette.Extensions;
|
|
using Windows.Storage.Streams;
|
|
|
|
namespace Microsoft.CmdPal.UI.ViewModels;
|
|
|
|
public partial class IconDataViewModel : ObservableObject, IIconData
|
|
{
|
|
private readonly ExtensionObject<IIconData> _model = new(null);
|
|
|
|
// If the extension previously gave us a Data, then died, the data will
|
|
// throw if we actually try to read it, but the pointer itself won't be
|
|
// null, so this is relatively safe.
|
|
public bool HasIcon => !string.IsNullOrEmpty(Icon) || Data.Unsafe != null;
|
|
|
|
// Locally cached properties from IIconData.
|
|
public string Icon { get; private set; } = string.Empty;
|
|
|
|
// Streams are not trivially copy-able, so we can't copy the data locally
|
|
// first. Hence why we're sticking this into an ExtensionObject
|
|
public ExtensionObject<IRandomAccessStreamReference> Data { get; private set; } = new(null);
|
|
|
|
IRandomAccessStreamReference? IIconData.Data => Data.Unsafe;
|
|
|
|
public IconDataViewModel(IIconData? icon)
|
|
{
|
|
_model = new(icon);
|
|
}
|
|
|
|
// Unsafe, needs to be called on BG thread
|
|
public void InitializeProperties()
|
|
{
|
|
var model = _model.Unsafe;
|
|
if (model == null)
|
|
{
|
|
return;
|
|
}
|
|
|
|
Icon = model.Icon;
|
|
Data = new(model.Data);
|
|
}
|
|
}
|