fix pipeline

Signed-off-by: Shawn Yuan (from Dev Box) <shuaiyuan@microsoft.com>

.github/actions/spell-check/expect.txt

@@ -1484,7 +1484,6 @@ remoteip
 Removelnk
 renamable
 RENAMEONCOLLISION
-RENDERFULLCONTENT
 reparented
 reparenting
 reportfileaccesses
@@ -1817,6 +1816,7 @@ TILEDWINDOW
 TILLSON
 timedate
 timediff
+timeunion
 timeutil
 TITLEBARINFO
 Titlecase

.github/copilot-instructions.md

@@ -48,9 +48,9 @@ This is the top-level guide for AI changes. Keep edits small, follow existing pa
 - `doc/devdocs/modules/readme.md`
 
 # Language style rules
-- Always enforce repo analyzers: `src/.editorconfig` plus any `stylecop.json`.
+- Always enforce repo analyzers: root `.editorconfig` plus any `stylecop.json`.
 - C# code follows StyleCop.Analyzers and Microsoft.CodeAnalysis.NetAnalyzers.
-- C++ code honors `src/.clang-format` for formatting.
+- C++ code honors `.clang-format` plus `.clang-tidy` (modernize/cppcoreguidelines/readability).
 - Markdown files wrap at 80 characters and use ATX headers with fenced code blocks that include language tags.
 - YAML files indent two spaces and add comments for complex settings while keeping keys clear.
 - PowerShell scripts use Verb-Noun names and prefer single-quoted literals while documenting parameters and satisfying PSScriptAnalyzer.

.github/prompts/create-commit-title.prompt.md

@@ -1,5 +1,6 @@
-agent: 'agent'
-model: GPT-5.1-Codex-Max
+---
+mode: 'agent'
+model: Claude Sonnet 4.5
 description: 'Generate an 80-character git commit title for the local diff.'
 ---
 

.github/prompts/create-pr-summary.prompt.md

@@ -1,5 +1,6 @@
-agent: 'agent'
-model: GPT-5.1-Codex-Max
+---
+mode: 'agent'
+model: Claude Sonnet 4.5
 description: 'Generate a PowerToys-ready pull request description from the local diff.'
 ---
 

.github/prompts/fix-issue.prompt.md

@@ -1,6 +1,7 @@
-agent: 'agent'
-model: GPT-5.1-Codex-Max
-description: "Execute the fix for a GitHub issue using the previously generated implementation plan. Apply code & tests directly in the repo. Output only a PR description (and optional manual steps)."
+---
+mode: 'agent'
+model: GPT-5-Codex (Preview)
+description: "  Execute the fix for a GitHub issue using the previously generated implementation plan. Apply code & tests directly in the repo. Output only a PR description (and optional manual steps)."
 ---
 
 # DEPENDENCY

.github/prompts/fix-spelling.prompt.md

@@ -1,5 +1,6 @@
-agent: 'agent'
-model: GPT-5.1-Codex-Max
+---
+mode: 'agent'
+model: GPT-5-Codex (Preview)
 description: 'Resolve Code scanning / check-spelling comments on the active PR.'
 ---
 

.github/prompts/review-issue.prompt.md

@@ -1,6 +1,7 @@
-agent: 'agent'
-model: GPT-5.1-Codex-Max
-description: "You are a GitHub issue review and planning expert; score (0-100) and write one implementation plan. Outputs: overview.md, implementation-plan.md."
+---
+mode: 'agent'
+model: Claude Sonnet 4.5
+description: "You are github issue review and planning expertise, Score (0–100) and write one Implementation Plan. Outputs: overview.md, implementation-plan.md."
 ---
 
 # GOAL
@@ -9,11 +10,11 @@ For **#{{issue_number}}** produce:
 2) `Generated Files/issueReview/{{issue_number}}/implementation-plan.md`
 
 ## Inputs
-Figure out required inputs {{issue_number}} from the invocation context; if anything is missing, ask for the value or note it as a gap.
+  figure out from the prompt on the 
 
 # CONTEXT (brief)
-Ground evidence using `gh issue view {{issue_number}} --json number,title,body,author,createdAt,updatedAt,state,labels,milestone,reactions,comments,linkedPullRequests`, and download images to better understand the issue context.
-Locate source code in the current workspace; feel free to use `rg`/`git grep`. Link related issues and PRs.
+Ground evidence using `gh issue view {{issue_number}} --json number,title,body,author,createdAt,updatedAt,state,labels,milestone,reactions,comments,linkedPullRequests`, and download the image for understand the context of the issue more.
+Locate source code in current workspace, but also free feel to use via `rg`/`git grep`. Link related issues/PRs.
 
 # OVERVIEW.MD
 ## Summary

.github/prompts/review-pr.prompt.md

@@ -1,5 +1,6 @@
-agent: 'agent'
-model: GPT-5.1-Codex-Max
+---
+mode: 'agent'
+model: Claude Sonnet 4.5
 description: "gh-driven PR review; per-step Markdown + machine-readable outputs"
 ---
 

.pipelines/ESRPSigning_core.json

@@ -117,7 +117,6 @@
             "WinUI3Apps\\PowerToys.FileLocksmithUI.dll",
             "WinUI3Apps\\PowerToys.FileLocksmithContextMenu.dll",
             "FileLocksmithContextMenuPackage.msix",
-            "FileLocksmithCLI.exe",
 
             "WinUI3Apps\\Peek.Common.dll",
             "WinUI3Apps\\Peek.FilePreviewer.dll",

.pipelines/v2/templates/job-build-ui-tests.yml

@@ -68,13 +68,14 @@ jobs:
 
   - template: .\steps-restore-nuget.yml
 
-  - task: MSBuild@1
+  - task: NuGetCommand@2
     displayName: Restore solution-level NuGet packages
     inputs:
-      solution: PowerToys.slnx
-      msbuildArguments: '/t:restore /p:RestorePackagesConfig=true'
-      platform: $(BuildPlatform)
-      configuration: $(BuildConfiguration)
+      command: restore
+      feedsToUse: config
+      configPath: nuget.config
+      restoreSolution: PowerToys.slnx
+      restoreDirectory: '$(Build.SourcesDirectory)\packages'
 
   # Build all UI test projects if no specific modules are specified
   - ${{ if eq(length(parameters.uiTestModules), 0) }}:

.vscode/tasks.json

@@ -1,106 +0,0 @@
-{
-  "version": "2.0.0",
-  "windows": {
-    "options": {
-      "shell": {
-        "executable": "cmd.exe",
-        "args": ["/d", "/c"]
-      }
-    }
-  },
-
-  "inputs": [
-    {
-      "id": "config",
-      "type": "pickString",
-      "description": "Configuration",
-      "options": ["Debug", "Release"],
-      "default": "Debug"
-    },
-    {
-      "id": "platform",
-      "type": "pickString",
-      "description": "Platform (leave empty to auto-detect host platform)",
-      "options": ["", "X64", "ARM64"],
-      "default": "X64"
-    },
-    {
-      "id": "msbuildExtra",
-      "type": "promptString",
-      "description": "Extra MSBuild args (optional). Example: /p:CIBuild=true /m",
-      "default": ""
-    }
-  ],
-
-  "tasks": [
-    {
-      "label": "PT: Build (quick)",
-      "type": "shell",
-      "command": "\"${workspaceFolder}\\tools\\build\\build.cmd\"",
-      "args": [
-        "-Path",
-        "${fileDirname}"
-      ],
-      "group": { "kind": "build", "isDefault": true },
-      "presentation": {
-        "reveal": "always",
-        "panel": "dedicated",
-        "clear": true
-      },
-      "problemMatcher": "$msCompile"
-    },
-
-    {
-      "label": "PT: Build (with options)",
-      "type": "shell",
-      "command": "\"${workspaceFolder}\\tools\\build\\build.cmd\"",
-      "args": [
-        "-Path",
-        "${fileDirname}",
-        "-Platform",
-        "${input:platform}",
-        "-Configuration",
-        "${input:config}",
-        "${input:msbuildExtra}"
-      ],
-      "presentation": {
-        "reveal": "always",
-        "panel": "dedicated",
-        "clear": true
-      },
-      "problemMatcher": "$msCompile"
-    },
-
-    {
-      "label": "PT: Build Essentials (quick)",
-      "type": "shell",
-      "command": "\"${workspaceFolder}\\tools\\build\\build-essentials.cmd\"",
-      "args": [],
-      "presentation": {
-        "reveal": "always",
-        "panel": "dedicated",
-        "clear": true
-      },
-      "problemMatcher": "$msCompile"
-    },
-
-    {
-      "label": "PT: Build Essentials (with options)",
-      "type": "shell",
-      "command": "\"${workspaceFolder}\\tools\\build\\build-essentials.cmd\"",
-      "args": [
-        "-Platform",
-        "${input:platform}",
-        "-Configuration",
-        "${input:config}",
-        "${input:msbuildExtra}"
-      ],
-      "presentation": {
-        "reveal": "always",
-        "panel": "dedicated",
-        "clear": true
-      },
-      "problemMatcher": "$msCompile"
-    }
-  ]
-}

COMMUNITY.md

@@ -6,6 +6,9 @@ Names are in alphabetical order based on first name.
 
 ## High impact community members
 
+### [@Noraa-Junker](https://github.com/Noraa-Junker) - [Noraa Junker](https://noraajunker.ch)
+Noraa has helped triaging, discussing, and creating a substantial number of issues and contributed features/fixes. Noraa was the primary person for helping build the File Explorer preview pane handler for developer files.
+
 ### [@cgaarden](https://github.com/cgaarden) - [Christian Gaarden Gaardmark](https://www.onegreatworld.com) 
 Christian contributed New+ utility
 
@@ -39,12 +42,6 @@ Jay has helped triaging, discussing, creating a substantial number of issues and
 ### [@jefflord](https://github.com/Jjefflord) - Jeff Lord
 Jeff added in multiple new features into Keyboard manager, such as key chord support and launching apps. He also contributed multiple features/fixes to PowerToys.
 
-### [@snickler](https://github.com/snickler) - [Jeremy Sinclair](http://sinclairinat0r.com)
-Jeremy has helped drive large sums of the ARM64 support inside PowerToys
-
-### [@jiripolasek](https://github.com/jiripolasek) - [Jiří Polášek](https://github.com/jiripolasek)
-Jiří has contributed a massive number of features and improvements to Command Palette, including drag & drop support, custom themes, Web Search enhancements, Remote Desktop extension fixes, and many UX improvements.
-
 ### [@TheJoeFin](https://github.com/TheJoeFin) - [Joe Finney](https://joefinapps.com)
 Joe has helped triaging, discussing, issues as well as fixing bugs and building features for Text Extractor.
 
@@ -60,9 +57,6 @@ Color Picker is from Martin.
 ### [@mikeclayton](https://github.com/mikeclayton) - [Michael Clayton](https://michael-clayton.com)
 Michael contributed the [initial version](https://github.com/microsoft/PowerToys/issues/23216) of the Mouse Jump tool and [a number of updates](https://github.com/microsoft/PowerToys/pulls?q=is%3Apr+author%3Amikeclayton) based on his FancyMouse utility.
 
-### [@Noraa-Junker](https://github.com/Noraa-Junker) - [Noraa Junker](https://noraajunker.ch)
-Noraa has helped triaging, discussing, and creating a substantial number of issues and contributed features/fixes. Noraa was the primary person for helping build the File Explorer preview pane handler for developer files.
-
 ### [@pedrolamas](https://github.com/pedrolamas/) - Pedro Lamas
 Pedro helped create the thumbnail and File Explorer previewers for 3D files like STL and GCode.  If you like 3D printing, these are very helpful.
 
@@ -75,12 +69,15 @@ Rafael has helped do the [upgrade from CppWinRT 1.x to 2.0](https://github.com/m
 ### [@royvou](https://github.com/royvou)
 Roy has helped out contributing multiple features to PowerToys Run
 
-### [@ThiefZero](https://github.com/ThiefZero)
-ThiefZero has helped out contributing a features to PowerToys Run such as the unit converter plugin
+### [@snickler](https://github.com/snickler) - [Jeremy Sinclair](http://sinclairinat0r.com)
+Jeremy has helped drive large sums of the ARM64 support inside PowerToys
 
 ### [@TobiasSekan](https://github.com/TobiasSekan) - Tobias Sekan
 Tobias Sekan has helped out contributing features to PowerToys Run such as Settings plugin, Registry plugin
 
+### [@ThiefZero](https://github.com/ThiefZero)
+ThiefZero has helped out contributing a features to PowerToys Run such as the unit converter plugin
+
 ## Open source projects
 
 As PowerToys creates new utilities, some will be based off existing technology. We'll continue to do our best to contribute back to these projects but their efforts were the base of some of our projects. We want to be sure their work is directly recognized.
@@ -190,10 +187,18 @@ ZoomIt source code was originally implemented by [Sysinternals](https://sysinter
 - [@niels9001](https://github.com/niels9001/) - Niels Laute - Product Manager
 - [@dhowett](https://github.com/dhowett) - Dustin Howett - Dev Lead
 - [@yeelam-gordon](https://github.com/yeelam-gordon) - Gordon Lam - Dev Lead
+- [@jamrobot](https://github.com/jamrobot) - Jerry Xu - Dev Lead
 - [@lei9444](https://github.com/lei9444) - Leilei Zhang - Dev
 - [@shuaiyuanxx](https://github.com/shuaiyuanxx) - Shawn Yuan - Dev
 - [@moooyo](https://github.com/moooyo) - Yu Leng - Dev
 - [@haoliuu](https://github.com/haoliuu) - Hao Liu - Dev
+- [@chenmy77](https://github.com/chenmy77) - Mengyuan Chen - Dev
+- [@chemwolf6922](https://github.com/chemwolf6922) - Feng Wang - Dev
+- [@yaqingmi](https://github.com/yaqingmi) - Yaqing Mi - Dev
+- [@zhaoqpcn](https://github.com/zhaoqpcn) - Qingpeng Zhao - Dev
+- [@urnotdfs](https://github.com/urnotdfs) - Xiaofeng Wang - Dev
+- [@zhaopy536](https://github.com/zhaopy536) - Peiyao Zhao - Dev
+- [@wang563681252](https://github.com/wang563681252) - Zhaopeng Wang - Dev
 - [@vanzue](https://github.com/vanzue) - Kai Tao - Dev
 - [@zadjii-msft](https://github.com/zadjii-msft) - Mike Griese - Dev
 - [@khmyznikov](https://github.com/khmyznikov) - Gleb Khmyznikov - Dev
@@ -224,12 +229,3 @@ ZoomIt source code was originally implemented by [Sysinternals](https://sysinter
 - [@SeraphimaZykova](https://github.com/SeraphimaZykova) - Seraphima Zykova - Dev
 - [@stefansjfw](https://github.com/stefansjfw) - Stefan Markovic - Dev
 - [@jaimecbernardo](https://github.com/jaimecbernardo) - Jaime Bernardo - Dev Lead
-- [@haoliuu](https://github.com/haoliuu) - Hao Liu - Dev
-- [@chenmy77](https://github.com/chenmy77) - Mengyuan Chen - Dev
-- [@chemwolf6922](https://github.com/chemwolf6922) - Feng Wang - Dev
-- [@yaqingmi](https://github.com/yaqingmi) - Yaqing Mi - Dev
-- [@zhaoqpcn](https://github.com/zhaoqpcn) - Qingpeng Zhao - Dev
-- [@urnotdfs](https://github.com/urnotdfs) - Xiaofeng Wang - Dev
-- [@zhaopy536](https://github.com/zhaopy536) - Peiyao Zhao - Dev
-- [@wang563681252](https://github.com/wang563681252) - Zhaopeng Wang - Dev
-- [@jamrobot](https://github.com/jamrobot) - Jerry Xu - Dev Lead

DATA_AND_PRIVACY.md

@@ -694,30 +694,6 @@ _If you want to find diagnostic data events in the source code, these two links
   </tr>
 </table>
 
-### Light Switch
-<table style="width:100%">
-  <tr>
-    <th>Event Name</th>
-    <th>Description</th>
-  </tr>
-  <tr>
-    <td>Microsoft.PowerToys.LightSwitch_EnableLightSwitch</td>
-    <td>Triggered when Light Switch is enabled or disabled.</td>
-  </tr>
-  <tr>
-    <td>Microsoft.PowerToys.LightSwitch_ShortcutInvoked</td>
-    <td>Occurs when the shortcut for Light Switch is invoked.</td>
-  </tr>
-  <tr>
-    <td>Microsoft.PowerToys.LightSwitch_ScheduleModeToggled</td>
-    <td>Occurs when a new schedule mode is selected for Light Switch.</td>
-  </tr>
-  <tr>
-    <td>Microsoft.PowerToys.LightSwitch_ThemeTargetChanged</td>
-    <td>Occurs when the options for targeting the system or apps is updated.</td>
-  </tr>
-</table>
-
 ### Mouse Highlighter
 <table style="width:100%">
   <tr>

PowerToys.slnx

@@ -420,7 +420,6 @@
     </Project>
   </Folder>
   <Folder Name="/modules/FileLocksmith/">
-    <Project Path="src/modules/FileLocksmith/FileLocksmithCLI/FileLocksmithCLI.vcxproj" Id="49D456D3-F485-45AF-8875-45B44F193DDC" />
     <Project Path="src/modules/FileLocksmith/FileLocksmithContextMenu/FileLocksmithContextMenu.vcxproj" Id="799a50d8-de89-4ed1-8ff8-ad5a9ed8c0ca" />
     <Project Path="src/modules/FileLocksmith/FileLocksmithExt/FileLocksmithExt.vcxproj" Id="57175ec7-92a5-4c1e-8244-e3fbca2a81de" />
     <Project Path="src/modules/FileLocksmith/FileLocksmithLib/FileLocksmithLib.vcxproj" Id="9d52fd25-ef90-4f9a-a015-91efc5daf54f" />
@@ -430,9 +429,6 @@
       <Platform Solution="*|x64" Project="x64" />
     </Project>
   </Folder>
-  <Folder Name="/modules/FileLocksmith/Tests/">
-    <Project Path="src/modules/FileLocksmith/FileLocksmithCLI/tests/FileLocksmithCLIUnitTests.vcxproj" Id="A1B2C3D4-E5F6-7890-1234-567890ABCDEF" />
-  </Folder>
   <Folder Name="/modules/Hosts/">
     <Project Path="src/modules/Hosts/Hosts/Hosts.csproj">
       <Platform Solution="*|ARM64" Project="ARM64" />

doc/devdocs/modules/cropandlock.md

@@ -20,9 +20,6 @@ Creates a window showing the selected area of the original window. Changes in th
 ### Reparent Mode
 Creates a window that replaces the original window, showing only the selected area. The application is controlled through the cropped window.
 
-### Screenshot Mode
-Creates a window showing a freezed snapshot of the original window. 
-
 ## Code Structure
 
 ### Project Layout
@@ -33,7 +30,6 @@ The Crop and Lock module is part of the PowerToys solution. All the logic-relate
 - **OverlayWindow.cpp**: Thumbnail module type's window concrete implementation.
 - **ReparentCropAndLockWindow.cpp**: Defines the UI for the reparent mode.
 - **ChildWindow.cpp**: Reparent module type's window concrete implementation.
-- **ScreenshotCropAndLockWindow.cpp**: Defines the UI for the screenshot mode.
 
 ## Known Issues
 

doc/thirdPartyRunPlugins.md

@@ -50,8 +50,7 @@ Contact the developers of a plugin directly for assistance with a specific plugi
 | [Hotkeys](https://github.com/ruslanlap/PowerToysRun-Hotkeys) | [ruslanlap](https://github.com/ruslanlap) | Create, manage, and trigger custom keyboard shortcuts directly from PowerToys Run. |
 | [RandomGen](https://github.com/ruslanlap/PowerToysRun-RandomGen) | [ruslanlap](https://github.com/ruslanlap) | 🎲 Generate random data instantly with a single keystroke. Perfect for developers, testers, designers, and anyone who needs quick access to random data. Features include secure passwords, PINs, names, business data, dates, numbers, GUIDs, color codes, and more. Especially useful for designers who need random color codes and placeholder content. |
 | [Open With Cursor](https://github.com/VictorNoxx/PowerToys-Run-Cursor/) | [VictorNoxx](https://github.com/VictorNoxx) | Open Visual Studio, VS Code recents with Cursor AI |
-| [Open With Antigravity](https://github.com/artickc/PowerToys-Run-Antygravity) | [artickc](https://github.com/artickc) | Open Visual Studio, VS Code recents with Antigravity AI |
-| [Project Launcher Plugin](https://github.com/artickc/ProjectLauncherPowerToysPlugin) | [artickc](https://github.com/artickc) | Access your projects using Project Launcher and PowerToys Run |
+| [Open With Antygravity](https://github.com/artickc/PowerToys-Run-Antygravity) | [artickc](https://github.com/artickc) | Open Visual Studio, VS Code recents with Cursor AI |
 | [CheatSheets](https://github.com/ruslanlap/PowerToysRun-CheatSheets) | [ruslanlap](https://github.com/ruslanlap) | 📚 Find cheat sheets and command examples instantly from tldr pages, cheat.sh, and devhints.io. Features include favorites system, categories, offline mode, and smart caching. |
 | [QuickAI](https://github.com/ruslanlap/PowerToysRun-QuickAi) | [ruslanlap](https://github.com/ruslanlap) | AI-powered assistance with instant, smart responses from multiple providers (Groq, Together, Fireworks, OpenRouter, Cohere) |
 

src/common/interop/Constants.cpp

@@ -223,10 +223,6 @@ namespace winrt::PowerToys::Interop::implementation
     {
         return CommonSharedConstants::CROP_AND_LOCK_REPARENT_EVENT;
     }
-    hstring Constants::CropAndLockScreenshotEvent()
-    {
-        return CommonSharedConstants::CROP_AND_LOCK_SCREENSHOT_EVENT;
-    }
     hstring Constants::ShowEnvironmentVariablesSharedEvent()
     {
         return CommonSharedConstants::SHOW_ENVIRONMENT_VARIABLES_EVENT;

src/common/interop/Constants.h

@@ -59,7 +59,6 @@ namespace winrt::PowerToys::Interop::implementation
         static hstring TerminateHostsSharedEvent();
         static hstring CropAndLockThumbnailEvent();
         static hstring CropAndLockReparentEvent();
-        static hstring CropAndLockScreenshotEvent();
         static hstring ShowEnvironmentVariablesSharedEvent();
         static hstring ShowEnvironmentVariablesAdminSharedEvent();
         static hstring WorkspacesLaunchEditorEvent();

src/common/interop/Constants.idl

@@ -56,7 +56,6 @@ namespace PowerToys
             static String TerminateHostsSharedEvent();
             static String CropAndLockThumbnailEvent();
             static String CropAndLockReparentEvent();
-            static String CropAndLockScreenshotEvent();
             static String ShowEnvironmentVariablesSharedEvent();
             static String ShowEnvironmentVariablesAdminSharedEvent();
             static String WorkspacesLaunchEditorEvent();

src/common/interop/shared_constants.h

@@ -132,7 +132,6 @@ namespace CommonSharedConstants
     // Path to the events used by CropAndLock
     const wchar_t CROP_AND_LOCK_REPARENT_EVENT[] = L"Local\\PowerToysCropAndLockReparentEvent-6060860a-76a1-44e8-8d0e-6355785e9c36";
     const wchar_t CROP_AND_LOCK_THUMBNAIL_EVENT[] = L"Local\\PowerToysCropAndLockThumbnailEvent-1637be50-da72-46b2-9220-b32b206b2434";
-    const wchar_t CROP_AND_LOCK_SCREENSHOT_EVENT[] = L"Local\\PowerToysCropAndLockScreenshotEvent-ff077ab2-8360-4bd1-864a-637389d35593";
     const wchar_t CROP_AND_LOCK_EXIT_EVENT[] = L"Local\\PowerToysCropAndLockExitEvent-d995d409-7b70-482b-bad6-e7c8666f375a";
 
     // Path to the events used by EnvironmentVariables

src/modules/CropAndLock/CropAndLock/CropAndLock.vcxproj

@@ -112,7 +112,6 @@
     <ClCompile Include="ChildWindow.cpp" />
     <ClCompile Include="main.cpp" />
     <ClCompile Include="ReparentCropAndLockWindow.cpp" />
-    <ClCompile Include="ScreenshotCropAndLockWindow.cpp" />
     <ClCompile Include="ThumbnailCropAndLockWindow.cpp" />
     <ClCompile Include="OverlayWindow.cpp" />
     <ClCompile Include="pch.cpp">
@@ -127,7 +126,6 @@
     <ClInclude Include="DisplaysUtil.h" />
     <ClInclude Include="ModuleConstants.h" />
     <ClInclude Include="ReparentCropAndLockWindow.h" />
-    <ClInclude Include="ScreenshotCropAndLockWindow.h" />
     <ClInclude Include="ThumbnailCropAndLockWindow.h" />
     <ClInclude Include="SettingsWindow.h" />
     <ClInclude Include="OverlayWindow.h" />

src/modules/CropAndLock/CropAndLock/CropAndLock.vcxproj.filters

@@ -12,7 +12,6 @@
     <ClCompile Include="ReparentCropAndLockWindow.cpp" />
     <ClCompile Include="ChildWindow.cpp" />
     <ClCompile Include="trace.cpp" />
-    <ClCompile Include="ScreenshotCropAndLockWindow.cpp" />
   </ItemGroup>
   <ItemGroup>
     <ClInclude Include="pch.h" />
@@ -29,7 +28,6 @@
     <ClInclude Include="trace.h" />
     <ClInclude Include="ModuleConstants.h" />
     <ClInclude Include="DispatcherQueue.desktop.interop.h" />
-    <ClInclude Include="ScreenshotCropAndLockWindow.h" />
   </ItemGroup>
   <ItemGroup>
     <ResourceCompile Include="CropAndLock.rc" />

src/modules/CropAndLock/CropAndLock/ScreenshotCropAndLockWindow.cpp

@@ -1,178 +0,0 @@
-#include "pch.h"
-#include "ScreenshotCropAndLockWindow.h"
-
-const std::wstring ScreenshotCropAndLockWindow::ClassName = L"CropAndLock.ScreenshotCropAndLockWindow";
-std::once_flag ScreenshotCropAndLockWindowClassRegistration;
-
-void ScreenshotCropAndLockWindow::RegisterWindowClass()
-{
-    auto instance = winrt::check_pointer(GetModuleHandleW(nullptr));
-    WNDCLASSEXW wcex = {};
-    wcex.cbSize = sizeof(wcex);
-    wcex.style = CS_HREDRAW | CS_VREDRAW;
-    wcex.lpfnWndProc = WndProc;
-    wcex.hInstance = instance;
-    wcex.hIcon = LoadIconW(instance, IDI_APPLICATION);
-    wcex.hCursor = LoadCursorW(nullptr, IDC_ARROW);
-    wcex.hbrBackground = static_cast<HBRUSH>(GetStockObject(BLACK_BRUSH));
-    wcex.lpszClassName = ClassName.c_str();
-    wcex.hIconSm = LoadIconW(wcex.hInstance, IDI_APPLICATION);
-    winrt::check_bool(RegisterClassExW(&wcex));
-}
-
-ScreenshotCropAndLockWindow::ScreenshotCropAndLockWindow(std::wstring const& titleString, int width, int height)
-{
-    auto instance = winrt::check_pointer(GetModuleHandleW(nullptr));
-
-    std::call_once(ScreenshotCropAndLockWindowClassRegistration, []() { RegisterWindowClass(); });
-
-    auto exStyle = 0;
-    auto style = WS_OVERLAPPEDWINDOW | WS_CLIPCHILDREN;
-
-    RECT rect = { 0, 0, width, height };
-    winrt::check_bool(AdjustWindowRectEx(&rect, style, false, exStyle));
-    auto adjustedWidth = rect.right - rect.left;
-    auto adjustedHeight = rect.bottom - rect.top;
-
-    winrt::check_bool(CreateWindowExW(exStyle, ClassName.c_str(), titleString.c_str(), style, CW_USEDEFAULT, CW_USEDEFAULT, adjustedWidth, adjustedHeight, nullptr, nullptr, instance, this));
-    WINRT_ASSERT(m_window);
-}
-
-ScreenshotCropAndLockWindow::~ScreenshotCropAndLockWindow()
-{
-    DestroyWindow(m_window);
-}
-
-LRESULT ScreenshotCropAndLockWindow::MessageHandler(UINT const message, WPARAM const wparam, LPARAM const lparam)
-{
-    switch (message)
-    {
-    case WM_DESTROY:
-        if (m_closedCallback != nullptr && !m_destroyed)
-        {
-            m_destroyed = true;
-            m_closedCallback(m_window);
-        }
-        break;
-    case WM_PAINT:
-        if (m_captured && m_bitmap)
-        {
-            PAINTSTRUCT ps;
-            HDC hdc = BeginPaint(m_window, &ps);
-            HDC memDC = CreateCompatibleDC(hdc);
-            SelectObject(memDC, m_bitmap.get());
-
-            RECT clientRect = {};
-            GetClientRect(m_window, &clientRect);
-            int clientWidth = clientRect.right - clientRect.left;
-            int clientHeight = clientRect.bottom - clientRect.top;
-
-            int srcWidth = m_destRect.right - m_destRect.left;
-            int srcHeight = m_destRect.bottom - m_destRect.top;
-
-            float srcAspect = static_cast<float>(srcWidth) / srcHeight;
-            float dstAspect = static_cast<float>(clientWidth) / clientHeight;
-
-            int drawWidth = clientWidth;
-            int drawHeight = static_cast<int>(clientWidth / srcAspect);
-            if (dstAspect > srcAspect)
-            {
-                drawHeight = clientHeight;
-                drawWidth = static_cast<int>(clientHeight * srcAspect);
-            }
-
-            int offsetX = (clientWidth - drawWidth) / 2;
-            int offsetY = (clientHeight - drawHeight) / 2;
-
-            SetStretchBltMode(hdc, HALFTONE);
-            StretchBlt(hdc, offsetX, offsetY, drawWidth, drawHeight, memDC, 0, 0, srcWidth, srcHeight, SRCCOPY);
-            DeleteDC(memDC);
-            EndPaint(m_window, &ps);
-        }
-        break;
-    default:
-        return base_type::MessageHandler(message, wparam, lparam);
-    }
-    return 0;
-}
-
-void ScreenshotCropAndLockWindow::CropAndLock(HWND windowToCrop, RECT cropRect)
-{
-    if (m_captured)
-    {
-        return;
-    }
-
-    // Get full window bounds
-    RECT windowRect{};
-    winrt::check_hresult(DwmGetWindowAttribute(
-        windowToCrop,
-        DWMWA_EXTENDED_FRAME_BOUNDS,
-        &windowRect,
-        sizeof(windowRect)));
-
-    RECT clientRect = ClientAreaInScreenSpace(windowToCrop);
-    auto offsetX = clientRect.left - windowRect.left;
-    auto offsetY = clientRect.top - windowRect.top;
-
-    m_sourceRect = {
-        cropRect.left + offsetX,
-        cropRect.top + offsetY,
-        cropRect.right + offsetX,
-        cropRect.bottom + offsetY
-    };
-
-    int fullWidth = windowRect.right - windowRect.left;
-    int fullHeight = windowRect.bottom - windowRect.top;
-
-    HDC fullDC = CreateCompatibleDC(nullptr);
-    HDC screenDC = GetDC(nullptr);
-    HBITMAP fullBitmap = CreateCompatibleBitmap(screenDC, fullWidth, fullHeight);
-    HGDIOBJ oldFullBitmap = SelectObject(fullDC, fullBitmap);
-
-    // Capture full window
-    winrt::check_bool(PrintWindow(windowToCrop, fullDC, PW_RENDERFULLCONTENT));
-
-
-    // Crop
-    int cropWidth = m_sourceRect.right - m_sourceRect.left;
-    int cropHeight = m_sourceRect.bottom - m_sourceRect.top;
-
-    HDC cropDC = CreateCompatibleDC(nullptr);
-    HBITMAP cropBitmap = CreateCompatibleBitmap(screenDC, cropWidth, cropHeight);
-    HGDIOBJ oldCropBitmap = SelectObject(cropDC, cropBitmap);
-    ReleaseDC(nullptr, screenDC);
-
-    BitBlt(
-        cropDC,
-        0,
-        0,
-        cropWidth,
-        cropHeight,
-        fullDC,
-        m_sourceRect.left,
-        m_sourceRect.top,
-        SRCCOPY);
-
-    SelectObject(fullDC, oldFullBitmap);
-    DeleteObject(fullBitmap);
-    DeleteDC(fullDC);
-
-    SelectObject(cropDC, oldCropBitmap);
-    DeleteDC(cropDC);
-    m_bitmap.reset(cropBitmap);
-
-    // Resize our window
-    RECT dest{ 0, 0, cropWidth, cropHeight };
-    LONG_PTR exStyle = GetWindowLongPtrW(m_window, GWL_EXSTYLE);
-    LONG_PTR style = GetWindowLongPtrW(m_window, GWL_STYLE);
-
-    winrt::check_bool(AdjustWindowRectEx(&dest, static_cast<DWORD>(style), FALSE, static_cast<DWORD>(exStyle)));
-
-    winrt::check_bool(SetWindowPos(
-        m_window, HWND_TOPMOST, 0, 0, dest.right - dest.left, dest.bottom - dest.top, SWP_NOMOVE | SWP_SHOWWINDOW));
-
-    m_destRect = { 0, 0, cropWidth, cropHeight };
-    m_captured = true;
-    InvalidateRect(m_window, nullptr, FALSE);
-}

src/modules/CropAndLock/CropAndLock/ScreenshotCropAndLockWindow.h

@@ -1,27 +0,0 @@
-#pragma once
-#include <robmikh.common/DesktopWindow.h>
-#include "CropAndLockWindow.h"
-
-struct ScreenshotCropAndLockWindow : robmikh::common::desktop::DesktopWindow<ScreenshotCropAndLockWindow>, CropAndLockWindow
-{
-    static const std::wstring ClassName;
-    ScreenshotCropAndLockWindow(std::wstring const& titleString, int width, int height);
-    ~ScreenshotCropAndLockWindow() override;
-    LRESULT MessageHandler(UINT const message, WPARAM const wparam, LPARAM const lparam);
-
-    HWND Handle() override { return m_window; }
-    void CropAndLock(HWND windowToCrop, RECT cropRect) override;
-    void OnClosed(std::function<void(HWND)> callback) override { m_closedCallback = callback; }
-
-private:
-    static void RegisterWindowClass();
-
-private:
-    std::unique_ptr<void, decltype(&DeleteObject)> m_bitmap{ nullptr, &DeleteObject };
-    RECT m_destRect = {};
-    RECT m_sourceRect = {};
-
-    bool m_captured = false;
-    bool m_destroyed = false;
-    std::function<void(HWND)> m_closedCallback;
-};

src/modules/CropAndLock/CropAndLock/SettingsWindow.h

@@ -4,5 +4,4 @@ enum class CropAndLockType
 {
 	Reparent,
 	Thumbnail,
-	Screenshot,
 };

src/modules/CropAndLock/CropAndLock/main.cpp

@@ -2,7 +2,6 @@
 #include "SettingsWindow.h"
 #include "OverlayWindow.h"
 #include "CropAndLockWindow.h"
-#include "ScreenshotCropAndLockWindow.h"
 #include "ThumbnailCropAndLockWindow.h"
 #include "ReparentCropAndLockWindow.h"
 #include "ModuleConstants.h"
@@ -134,7 +133,6 @@ int WINAPI wWinMain(_In_ HINSTANCE, _In_opt_ HINSTANCE, _In_ PWSTR lpCmdLine, _I
     // Handles and thread for the events sent from runner
     HANDLE m_reparent_event_handle;
     HANDLE m_thumbnail_event_handle;
-    HANDLE m_screenshot_event_handle;
     HANDLE m_exit_event_handle;
     std::thread m_event_triggers_thread;
 
@@ -183,11 +181,6 @@ int WINAPI wWinMain(_In_ HINSTANCE, _In_opt_ HINSTANCE, _In_ PWSTR lpCmdLine, _I
                 Logger::trace(L"Creating a thumbnail window");
                 Trace::CropAndLock::CreateThumbnailWindow();
                 break;
-            case CropAndLockType::Screenshot:
-                croppedWindow = std::make_shared<ScreenshotCropAndLockWindow>(title, 800, 600);
-                Logger::trace(L"Creating a screenshot window");
-                Trace::CropAndLock::CreateScreenshotWindow();
-                break;
             default:
                 return;
             }
@@ -222,9 +215,8 @@ int WINAPI wWinMain(_In_ HINSTANCE, _In_opt_ HINSTANCE, _In_ PWSTR lpCmdLine, _I
     // Start a thread to listen on the events.
     m_reparent_event_handle = CreateEventW(nullptr, false, false, CommonSharedConstants::CROP_AND_LOCK_REPARENT_EVENT);
     m_thumbnail_event_handle = CreateEventW(nullptr, false, false, CommonSharedConstants::CROP_AND_LOCK_THUMBNAIL_EVENT);
-    m_screenshot_event_handle = CreateEventW(nullptr, false, false, CommonSharedConstants::CROP_AND_LOCK_SCREENSHOT_EVENT);
     m_exit_event_handle = CreateEventW(nullptr, false, false, CommonSharedConstants::CROP_AND_LOCK_EXIT_EVENT);
-    if (!m_reparent_event_handle || !m_thumbnail_event_handle || !m_screenshot_event_handle || !m_exit_event_handle)
+    if (!m_reparent_event_handle || !m_thumbnail_event_handle || !m_exit_event_handle)
     {
         Logger::warn(L"Failed to create events. {}", get_last_error_or_default(GetLastError()));
         return 1;
@@ -232,10 +224,10 @@ int WINAPI wWinMain(_In_ HINSTANCE, _In_opt_ HINSTANCE, _In_ PWSTR lpCmdLine, _I
 
     m_event_triggers_thread = std::thread([&]() {
         MSG msg;
-        HANDLE event_handles[4] = { m_reparent_event_handle, m_thumbnail_event_handle, m_screenshot_event_handle, m_exit_event_handle };
+        HANDLE event_handles[3] = { m_reparent_event_handle, m_thumbnail_event_handle, m_exit_event_handle };
         while (m_running)
         {
-            DWORD dwEvt = MsgWaitForMultipleObjects(4, event_handles, false, INFINITE, QS_ALLINPUT);
+            DWORD dwEvt = MsgWaitForMultipleObjects(3, event_handles, false, INFINITE, QS_ALLINPUT);
             if (!m_running)
             {
                 break;
@@ -267,25 +259,13 @@ int WINAPI wWinMain(_In_ HINSTANCE, _In_opt_ HINSTANCE, _In_ PWSTR lpCmdLine, _I
                 break;
             }
             case WAIT_OBJECT_0 + 2:
-            {
-                // Screenshot Event
-                bool enqueueSucceeded = controller.DispatcherQueue().TryEnqueue([&]() {
-                    ProcessCommand(CropAndLockType::Screenshot);
-                });
-                if (!enqueueSucceeded)
-                {
-                    Logger::error("Couldn't enqueue message to screenshot a window.");
-                }
-                break;
-            }
-            case WAIT_OBJECT_0 + 3:
             {
                 // Exit Event
                 Logger::trace(L"Received an exit event.");
                 PostThreadMessage(mainThreadId, WM_QUIT, 0, 0);
                 break;
             }
-            case WAIT_OBJECT_0 + 4:
+            case WAIT_OBJECT_0 + 3:
                 if (PeekMessageW(&msg, nullptr, 0, 0, PM_REMOVE))
                 {
                     TranslateMessage(&msg);
@@ -315,7 +295,6 @@ int WINAPI wWinMain(_In_ HINSTANCE, _In_opt_ HINSTANCE, _In_ PWSTR lpCmdLine, _I
     SetEvent(m_reparent_event_handle);
     CloseHandle(m_reparent_event_handle);
     CloseHandle(m_thumbnail_event_handle);
-    CloseHandle(m_screenshot_event_handle);
     CloseHandle(m_exit_event_handle);
     m_event_triggers_thread.join();
 

src/modules/CropAndLock/CropAndLock/trace.cpp

@@ -41,15 +41,6 @@ void Trace::CropAndLock::ActivateThumbnail() noexcept
         TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE));
 }
 
-void Trace::CropAndLock::ActivateScreenshot() noexcept
-{
-    TraceLoggingWriteWrapper(
-        g_hProvider,
-        "CropAndLock_ActivateScreenshot",
-        ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
-        TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE));
-}
-
 void Trace::CropAndLock::CreateReparentWindow() noexcept
 {
     TraceLoggingWriteWrapper(
@@ -68,17 +59,8 @@ void Trace::CropAndLock::CreateThumbnailWindow() noexcept
         TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE));
 }
 
-void Trace::CropAndLock::CreateScreenshotWindow() noexcept
-{
-    TraceLoggingWriteWrapper(
-        g_hProvider,
-        "CropAndLock_CreateScreenshotWindow",
-        ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
-        TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE));
-}
-
 // Event to send settings telemetry.
-void Trace::CropAndLock::SettingsTelemetry(PowertoyModuleIface::Hotkey& reparentHotkey, PowertoyModuleIface::Hotkey& thumbnailHotkey, PowertoyModuleIface::Hotkey& screenshotHotkey) noexcept
+void Trace::CropAndLock::SettingsTelemetry(PowertoyModuleIface::Hotkey& reparentHotkey, PowertoyModuleIface::Hotkey& thumbnailHotkey) noexcept
 {
     std::wstring hotKeyStrReparent =
         std::wstring(reparentHotkey.win ? L"Win + " : L"") +
@@ -94,19 +76,11 @@ void Trace::CropAndLock::SettingsTelemetry(PowertoyModuleIface::Hotkey& reparent
         std::wstring(thumbnailHotkey.alt ? L"Alt + " : L"") +
         std::wstring(L"VK ") + std::to_wstring(thumbnailHotkey.key);
 
-    std::wstring hotKeyStrScreenshot =
-        std::wstring(screenshotHotkey.win ? L"Win + " : L"") +
-        std::wstring(screenshotHotkey.ctrl ? L"Ctrl + " : L"") +
-        std::wstring(screenshotHotkey.shift ? L"Shift + " : L"") +
-        std::wstring(screenshotHotkey.alt ? L"Alt + " : L"") +
-        std::wstring(L"VK ") + std::to_wstring(screenshotHotkey.key);
-
     TraceLoggingWriteWrapper(
         g_hProvider,
         "CropAndLock_Settings",
         ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
         TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE),
         TraceLoggingWideString(hotKeyStrReparent.c_str(), "ReparentHotKey"),
-        TraceLoggingWideString(hotKeyStrThumbnail.c_str(), "ThumbnailHotkey"),
-        TraceLoggingWideString(hotKeyStrScreenshot.c_str(), "ScreenshotHotkey"));
+        TraceLoggingWideString(hotKeyStrThumbnail.c_str(), "ThumbnailHotkey"));
 }

src/modules/CropAndLock/CropAndLock/trace.h

@@ -12,10 +12,8 @@ public:
         static void Enable(bool enabled) noexcept;
         static void ActivateReparent() noexcept;
         static void ActivateThumbnail() noexcept;
-        static void ActivateScreenshot() noexcept;
         static void CreateReparentWindow() noexcept;
         static void CreateThumbnailWindow() noexcept;
-        static void CreateScreenshotWindow() noexcept;
-        static void SettingsTelemetry(PowertoyModuleIface::Hotkey&, PowertoyModuleIface::Hotkey&, PowertoyModuleIface::Hotkey&) noexcept;
+        static void SettingsTelemetry(PowertoyModuleIface::Hotkey&, PowertoyModuleIface::Hotkey&) noexcept;
     };
 };

src/modules/CropAndLock/CropAndLockModuleInterface/dllmain.cpp

@@ -29,7 +29,6 @@ namespace
     const wchar_t JSON_KEY_CODE[] = L"code";
     const wchar_t JSON_KEY_REPARENT_HOTKEY[] = L"reparent-hotkey";
     const wchar_t JSON_KEY_THUMBNAIL_HOTKEY[] = L"thumbnail-hotkey";
-    const wchar_t JSON_KEY_SCREENSHOT_HOTKEY[] = L"screenshot-hotkey";
     const wchar_t JSON_KEY_VALUE[] = L"value";
 }
 
@@ -125,10 +124,6 @@ public:
                 SetEvent(m_thumbnail_event_handle);
                 Trace::CropAndLock::ActivateThumbnail();
             }
-            if (hotkeyId == 2) { // Same order as set by get_hotkeys
-                SetEvent(m_screenshot_event_handle);
-                Trace::CropAndLock::ActivateScreenshot();
-            }
 
             return true;
         }
@@ -138,13 +133,12 @@ public:
 
     virtual size_t get_hotkeys(Hotkey* hotkeys, size_t buffer_size) override
     {
-        if (hotkeys && buffer_size >= 3)
+        if (hotkeys && buffer_size >= 2)
         {
             hotkeys[0] = m_reparent_hotkey;
             hotkeys[1] = m_thumbnail_hotkey;
-            hotkeys[2] = m_screenshot_hotkey;
         }
-        return 3;
+        return 2;
     }
 
     // Enable the powertoy
@@ -177,7 +171,7 @@ public:
     virtual void send_settings_telemetry() override
     {
         Logger::info("Send settings telemetry");
-        Trace::CropAndLock::SettingsTelemetry(m_reparent_hotkey, m_thumbnail_hotkey, m_screenshot_hotkey);
+        Trace::CropAndLock::SettingsTelemetry(m_reparent_hotkey, m_thumbnail_hotkey);
     }
 
     CropAndLockModuleInterface()
@@ -188,7 +182,6 @@ public:
 
         m_reparent_event_handle = CreateDefaultEvent(CommonSharedConstants::CROP_AND_LOCK_REPARENT_EVENT);
         m_thumbnail_event_handle = CreateDefaultEvent(CommonSharedConstants::CROP_AND_LOCK_THUMBNAIL_EVENT);
-        m_screenshot_event_handle = CreateDefaultEvent(CommonSharedConstants::CROP_AND_LOCK_SCREENSHOT_EVENT);
         m_exit_event_handle = CreateDefaultEvent(CommonSharedConstants::CROP_AND_LOCK_EXIT_EVENT);
 
         init_settings();
@@ -209,7 +202,6 @@ private:
         
         ResetEvent(m_reparent_event_handle);
         ResetEvent(m_thumbnail_event_handle);
-        ResetEvent(m_screenshot_event_handle);
         ResetEvent(m_exit_event_handle);
 
         SHELLEXECUTEINFOW sei{ sizeof(sei) };
@@ -242,7 +234,6 @@ private:
 
         ResetEvent(m_reparent_event_handle);
         ResetEvent(m_thumbnail_event_handle);
-        ResetEvent(m_screenshot_event_handle);
 
         // Log telemetry
         if (traceEvent)
@@ -292,21 +283,6 @@ private:
             {
                 Logger::error("Failed to initialize CropAndLock thumbnail shortcut from settings. Value will keep unchanged.");
             }
-            try
-            {
-                Hotkey _temp_screenshot;
-                auto jsonHotkeyObject = settingsObject.GetNamedObject(JSON_KEY_PROPERTIES).GetNamedObject(JSON_KEY_SCREENSHOT_HOTKEY).GetNamedObject(JSON_KEY_VALUE);
-                _temp_screenshot.win = jsonHotkeyObject.GetNamedBoolean(JSON_KEY_WIN);
-                _temp_screenshot.alt = jsonHotkeyObject.GetNamedBoolean(JSON_KEY_ALT);
-                _temp_screenshot.shift = jsonHotkeyObject.GetNamedBoolean(JSON_KEY_SHIFT);
-                _temp_screenshot.ctrl = jsonHotkeyObject.GetNamedBoolean(JSON_KEY_CTRL);
-                _temp_screenshot.key = static_cast<unsigned char>(jsonHotkeyObject.GetNamedNumber(JSON_KEY_CODE));
-                m_screenshot_hotkey = _temp_screenshot;
-            }
-            catch (...)
-            {
-                Logger::error("Failed to initialize CropAndLock screenshot shortcut from settings. Value will keep unchanged.");
-            }
         }
         else
         {
@@ -345,11 +321,9 @@ private:
     // TODO: actual default hotkey setting in line with other PowerToys.
     Hotkey m_reparent_hotkey = { .win = true, .ctrl = true, .shift = true, .alt = false, .key = 'R' };
     Hotkey m_thumbnail_hotkey = { .win = true, .ctrl = true, .shift = true, .alt = false, .key = 'T' };
-    Hotkey m_screenshot_hotkey = { .win = true, .ctrl = true, .shift = true, .alt = false, .key = 'S' };
 
     HANDLE m_reparent_event_handle;
     HANDLE m_thumbnail_event_handle;
-    HANDLE m_screenshot_event_handle;
     HANDLE m_exit_event_handle;
 
 };

src/modules/FileLocksmith/FileLocksmithCLI/CLILogic.cpp

@@ -1,248 +0,0 @@
-#include "pch.h"
-#include "CLILogic.h"
-#include <common/utils/json.h>
-#include <iostream>
-#include <sstream>
-#include <chrono>
-#include "resource.h"
-#include <common/logger/logger.h>
-#include <common/utils/logger_helper.h>
-#include <type_traits>
-
-template<typename T>
-DWORD_PTR ToDwordPtr(T val)
-{
-    if constexpr (std::is_pointer_v<T>)
-    {
-        return reinterpret_cast<DWORD_PTR>(val);
-    }
-    else
-    {
-        return static_cast<DWORD_PTR>(val);
-    }
-}
-
-template<typename... Args>
-std::wstring FormatString(IStringProvider& strings, UINT id, Args... args)
-{
-    std::wstring format = strings.GetString(id);
-    if (format.empty()) return L"";
-
-    DWORD_PTR arguments[] = { ToDwordPtr(args)..., 0 };
-
-    LPWSTR buffer = nullptr;
-    FormatMessageW(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_STRING | FORMAT_MESSAGE_ARGUMENT_ARRAY,
-                   format.c_str(),
-                   0,
-                   0,
-                   reinterpret_cast<LPWSTR>(&buffer),
-                   0,
-                   reinterpret_cast<va_list*>(arguments));
-
-    if (buffer)
-    {
-        std::wstring result(buffer);
-        LocalFree(buffer);
-        return result;
-    }
-    return L"";
-}
-
-std::wstring get_usage(IStringProvider& strings)
-{
-    return strings.GetString(IDS_USAGE);
-}
-
-std::wstring get_json(const std::vector<ProcessResult>& results)
-{
-    json::JsonObject root;
-    json::JsonArray processes;
-
-    for (const auto& result : results)
-    {
-        json::JsonObject process;
-        process.SetNamedValue(L"pid", json::JsonValue::CreateNumberValue(result.pid));
-        process.SetNamedValue(L"name", json::JsonValue::CreateStringValue(result.name));
-        process.SetNamedValue(L"user", json::JsonValue::CreateStringValue(result.user));
-        
-        json::JsonArray files;
-        for (const auto& file : result.files)
-        {
-            files.Append(json::JsonValue::CreateStringValue(file));
-        }
-        process.SetNamedValue(L"files", files);
-        
-        processes.Append(process);
-    }
-
-    root.SetNamedValue(L"processes", processes);
-    return root.Stringify().c_str();
-}
-
-std::wstring get_text(const std::vector<ProcessResult>& results, IStringProvider& strings)
-{
-    std::wstringstream ss;
-    if (results.empty())
-    {
-        ss << strings.GetString(IDS_NO_PROCESSES);
-        return ss.str();
-    }
-
-    ss << strings.GetString(IDS_HEADER);
-    for (const auto& result : results)
-    {
-        ss << result.pid << L"\t" 
-           << result.user << L"\t" 
-           << result.name << std::endl;
-    }
-    return ss.str();
-}
-
-std::wstring kill_processes(const std::vector<ProcessResult>& results, IProcessTerminator& terminator, IStringProvider& strings)
-{
-    std::wstringstream ss;
-    for (const auto& result : results)
-    {
-        if (terminator.terminate(result.pid))
-        {
-            ss << FormatString(strings, IDS_TERMINATED, result.pid, result.name.c_str());
-        }
-        else
-        {
-            ss << FormatString(strings, IDS_FAILED_TERMINATE, result.pid, result.name.c_str());
-        }
-    }
-    return ss.str();
-}
-
-CommandResult run_command(int argc, wchar_t* argv[], IProcessFinder& finder, IProcessTerminator& terminator, IStringProvider& strings)
-{
-    Logger::info("Parsing arguments");
-    if (argc < 2)
-    {
-        Logger::warn("No arguments provided");
-        return { 1, get_usage(strings) };
-    }
-
-    bool json_output = false;
-    bool kill = false;
-    bool wait = false;
-    int timeout_ms = -1;
-    std::vector<std::wstring> paths;
-
-    for (int i = 1; i < argc; ++i)
-    {
-        std::wstring arg = argv[i];
-        if (arg == L"--json")
-        {
-            json_output = true;
-        }
-        else if (arg == L"--kill")
-        {
-            kill = true;
-        }
-        else if (arg == L"--wait")
-        {
-            wait = true;
-        }
-        else if (arg == L"--timeout")
-        {
-            if (i + 1 < argc)
-            {
-                try
-                {
-                    timeout_ms = std::stoi(argv[++i]);
-                }
-                catch (...)
-                {
-                    Logger::error("Invalid timeout value");
-                    return { 1, strings.GetString(IDS_ERROR_INVALID_TIMEOUT) };
-                }
-            }
-            else
-            {
-                Logger::error("Timeout argument missing");
-                return { 1, strings.GetString(IDS_ERROR_TIMEOUT_ARG) };
-            }
-        }
-        else if (arg == L"--help")
-        {
-            return { 0, get_usage(strings) };
-        }
-        else
-        {
-            paths.push_back(arg);
-        }
-    }
-
-    if (paths.empty())
-    {
-        Logger::error("No paths specified");
-        return { 1, strings.GetString(IDS_ERROR_NO_PATHS) };
-    }
-
-    Logger::info("Processing {} paths", paths.size());
-
-    if (wait)
-    {
-        std::wstringstream ss;
-        if (json_output)
-        {
-             Logger::warn("Wait is incompatible with JSON output");
-             ss << strings.GetString(IDS_WARN_JSON_WAIT);
-             json_output = false;
-        }
-        
-        ss << strings.GetString(IDS_WAITING);
-        auto start_time = std::chrono::steady_clock::now();
-        while (true)
-        {
-            auto results = finder.find(paths);
-            if (results.empty())
-            {
-                Logger::info("Files unlocked");
-                ss << strings.GetString(IDS_UNLOCKED);
-                break;
-            }
-
-            if (timeout_ms >= 0)
-            {
-                auto current_time = std::chrono::steady_clock::now();
-                auto elapsed = std::chrono::duration_cast<std::chrono::milliseconds>(current_time - start_time).count();
-                if (elapsed > timeout_ms)
-                {
-                    Logger::warn("Timeout waiting for files to be unlocked");
-                    ss << strings.GetString(IDS_TIMEOUT);
-                    return { 1, ss.str() };
-                }
-            }
-
-            Sleep(200);
-        }
-        return { 0, ss.str() };
-    }
-
-    auto results = finder.find(paths);
-    Logger::info("Found {} processes locking the files", results.size());
-    std::wstringstream output_ss;
-
-    if (kill)
-    {
-        Logger::info("Killing processes");
-        output_ss << kill_processes(results, terminator, strings);
-        // Re-check after killing
-        results = finder.find(paths);
-        Logger::info("Remaining processes: {}", results.size());
-    }
-
-    if (json_output)
-    {
-        output_ss << get_json(results) << std::endl;
-    }
-    else
-    {
-        output_ss << get_text(results, strings);
-    }
-
-    return { 0, output_ss.str() };
-}

src/modules/FileLocksmith/FileLocksmithCLI/CLILogic.h

@@ -1,31 +0,0 @@
-#pragma once
-#include <vector>
-#include <string>
-#include "FileLocksmithLib/FileLocksmith.h"
-#include <Windows.h>
-
-struct CommandResult
-{
-    int exit_code;
-    std::wstring output;
-};
-
-struct IProcessFinder
-{
-    virtual std::vector<ProcessResult> find(const std::vector<std::wstring>& paths) = 0;
-    virtual ~IProcessFinder() = default;
-};
-
-struct IProcessTerminator
-{
-    virtual bool terminate(DWORD pid) = 0;
-    virtual ~IProcessTerminator() = default;
-};
-
-struct IStringProvider
-{
-    virtual std::wstring GetString(UINT id) = 0;
-    virtual ~IStringProvider() = default;
-};
-
-CommandResult run_command(int argc, wchar_t* argv[], IProcessFinder& finder, IProcessTerminator& terminator, IStringProvider& strings);

src/modules/FileLocksmith/FileLocksmithCLI/FileLocksmithCLI.rc

@@ -1,19 +0,0 @@
-#include "resource.h"
-#include <windows.h>
-
-STRINGTABLE
-BEGIN
-    IDS_USAGE               "Usage: FileLocksmithCLI.exe [options] <path1> [path2] ...\nOptions:\n  --kill      Kill processes locking the files\n  --json      Output results in JSON format\n  --wait      Wait for files to be unlocked\n  --timeout   Timeout in milliseconds for --wait\n  --help      Show this help message\n"
-    IDS_NO_PROCESSES        "No processes found locking the file(s).\n"
-    IDS_HEADER              "PID\tUser\tProcess\n"
-    IDS_TERMINATED          "Terminated process %1!d! (%2)\n"
-    IDS_FAILED_TERMINATE    "Failed to terminate process %1!d! (%2)\n"
-    IDS_FAILED_OPEN         "Failed to open process %1!d! (%2)\n"
-    IDS_ERROR_NO_PATHS      "Error: No paths specified.\n"
-    IDS_WARN_JSON_WAIT      "Warning: --wait is incompatible with --json. Ignoring --json.\n"
-    IDS_WAITING             "Waiting for files to be unlocked...\n"
-    IDS_UNLOCKED            "Files unlocked.\n"
-    IDS_TIMEOUT             "Timeout waiting for files to be unlocked.\n"
-    IDS_ERROR_INVALID_TIMEOUT "Error: Invalid timeout value.\n"
-    IDS_ERROR_TIMEOUT_ARG   "Error: --timeout requires an argument.\n"
-END

src/modules/FileLocksmith/FileLocksmithCLI/FileLocksmithCLI.vcxproj

@@ -1,119 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
-  <Import Project="..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.props')" />
-  <PropertyGroup Label="Globals">
-    <VCProjectVersion>17.0</VCProjectVersion>
-    <Keyword>Win32Proj</Keyword>
-    <ProjectGuid>{49D456D3-F485-45AF-8875-45B44F193DDC}</ProjectGuid>
-    <RootNamespace>FileLocksmithCLI</RootNamespace>
-    <WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion>
-    <ProjectName>FileLocksmithCLI</ProjectName>
-  </PropertyGroup>
-  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
-  <Import Project="..\..\..\..\deps\spdlog.props" />
-  <PropertyGroup Condition="'$(Configuration)'=='Debug'" Label="Configuration">
-    <ConfigurationType>Application</ConfigurationType>
-    <UseDebugLibraries>true</UseDebugLibraries>
-    <PlatformToolset>v143</PlatformToolset>
-    <CharacterSet>Unicode</CharacterSet>
-  </PropertyGroup>
-  <PropertyGroup Condition="'$(Configuration)'=='Release'" Label="Configuration">
-    <ConfigurationType>Application</ConfigurationType>
-    <UseDebugLibraries>false</UseDebugLibraries>
-    <PlatformToolset>v143</PlatformToolset>
-    <CharacterSet>Unicode</CharacterSet>
-  </PropertyGroup>
-  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
-  <ImportGroup Label="ExtensionSettings">
-  </ImportGroup>
-  <ImportGroup Label="Shared">
-  </ImportGroup>
-  <ImportGroup Label="PropertySheets">
-    <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
-  </ImportGroup>
-  <PropertyGroup Label="UserMacros" />
-  <PropertyGroup>
-    <OutDir>..\..\..\..\$(Platform)\$(Configuration)</OutDir>
-  </PropertyGroup>
-  <ItemDefinitionGroup Condition="'$(Configuration)'=='Debug'">
-    <ClCompile>
-      <WarningLevel>Level3</WarningLevel>
-      <SDLCheck>true</SDLCheck>
-      <PreprocessorDefinitions>WIN32;_DEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
-      <ConformanceMode>false</ConformanceMode>
-      <AdditionalIncludeDirectories>$(ProjectDir)..;$(ProjectDir)..\..\..;$(ProjectDir)..\..;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
-      <PrecompiledHeader>Use</PrecompiledHeader>
-      <PrecompiledHeaderFile>pch.h</PrecompiledHeaderFile>
-      <RunCodeAnalysis>false</RunCodeAnalysis>
-    </ClCompile>
-    <Link>
-      <SubSystem>Console</SubSystem>
-      <GenerateDebugInformation>true</GenerateDebugInformation>
-      <AdditionalDependencies>shlwapi.lib;ntdll.lib;%(AdditionalDependencies)</AdditionalDependencies>
-    </Link>
-  </ItemDefinitionGroup>
-  <ItemDefinitionGroup Condition="'$(Configuration)'=='Release'">
-    <ClCompile>
-      <WarningLevel>Level3</WarningLevel>
-      <FunctionLevelLinking>true</FunctionLevelLinking>
-      <IntrinsicFunctions>true</IntrinsicFunctions>
-      <SDLCheck>true</SDLCheck>
-      <PreprocessorDefinitions>WIN32;NDEBUG;_CONSOLE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
-      <ConformanceMode>false</ConformanceMode>
-      <AdditionalIncludeDirectories>$(ProjectDir)..;$(ProjectDir)..\..\..;$(ProjectDir)..\..;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
-      <PrecompiledHeader>Use</PrecompiledHeader>
-      <PrecompiledHeaderFile>pch.h</PrecompiledHeaderFile>
-      <RunCodeAnalysis>false</RunCodeAnalysis>
-    </ClCompile>
-    <Link>
-      <SubSystem>Console</SubSystem>
-      <EnableCOMDATFolding>true</EnableCOMDATFolding>
-      <OptimizeReferences>true</OptimizeReferences>
-      <GenerateDebugInformation>true</GenerateDebugInformation>
-      <AdditionalDependencies>shlwapi.lib;ntdll.lib;%(AdditionalDependencies)</AdditionalDependencies>
-    </Link>
-  </ItemDefinitionGroup>
-  <ItemGroup>
-    <ClCompile Include="CLILogic.cpp" />
-    <ClCompile Include="main.cpp" />
-    <ClCompile Include="pch.cpp">
-      <PrecompiledHeader Condition="'$(UsePrecompiledHeaders)' != 'false'">Create</PrecompiledHeader>
-    </ClCompile>
-  </ItemGroup>
-  <ItemGroup>
-    <ClInclude Include="CLILogic.h" />
-    <ClInclude Include="pch.h" />
-    <ClInclude Include="resource.h" />
-  </ItemGroup>
-  <ItemGroup>
-    <ResourceCompile Include="FileLocksmithCLI.rc" />
-  </ItemGroup>
-  <ItemGroup>
-    <ProjectReference Include="..\FileLocksmithLib\FileLocksmithLib.vcxproj">
-      <Project>{9d52fd25-ef90-4f9a-a015-91efc5daf54f}</Project>
-    </ProjectReference>
-    <ProjectReference Include="..\..\..\common\logger\logger.vcxproj">
-      <Project>{d9b8fc84-322a-4f9f-bbb9-20915c47ddfd}</Project>
-    </ProjectReference>
-    <ProjectReference Include="..\..\..\common\SettingsAPI\SettingsAPI.vcxproj">
-      <Project>{6955446d-23f7-4023-9bb3-8657f904af99}</Project>
-    </ProjectReference>
-    <ProjectReference Include="..\..\..\common\version\version.vcxproj">
-      <Project>{1248566c-272a-43c0-88d6-e6675d569a09}</Project>
-    </ProjectReference>
-  </ItemGroup>
-  <ItemGroup>
-    <None Include="packages.config" />
-  </ItemGroup>
-  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
-  <ImportGroup Label="ExtensionTargets">
-    <Import Project="..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.targets" Condition="Exists('..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.targets')" />
-  </ImportGroup>
-  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
-    <PropertyGroup>
-      <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
-    </PropertyGroup>
-    <Error Condition="!Exists('..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.props'))" />
-    <Error Condition="!Exists('..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.targets'))" />
-  </Target>
-</Project>

src/modules/FileLocksmith/FileLocksmithCLI/FileLocksmithCLI.vcxproj.filters

@@ -1,42 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
-  <ItemGroup>
-    <Filter Include="Source Files">
-      <UniqueIdentifier>{4FC737F1-C7A5-4376-A066-2A32D752A2FF}</UniqueIdentifier>
-      <Extensions>cpp;c;cc;cxx;c++;cppm;ixx;def;odl;idl;hpj;bat;asm;asmx</Extensions>
-    </Filter>
-    <Filter Include="Header Files">
-      <UniqueIdentifier>{93995380-89BD-4b04-88EB-625FBE52EBFB}</UniqueIdentifier>
-      <Extensions>h;hh;hpp;hxx;h++;hm;inl;inc;ipp;xsd</Extensions>
-    </Filter>
-    <Filter Include="Resource Files">
-      <UniqueIdentifier>{67DA6AB6-F800-4c08-8B7A-83BB121AAD01}</UniqueIdentifier>
-      <Extensions>rc;ico;cur;bmp;dlg;rc2;rct;bin;rgs;gif;jpg;jpeg;jpe;resx;tiff;tif;png;wav;mfcribbon-ms</Extensions>
-    </Filter>
-  </ItemGroup>
-  <ItemGroup>
-    <ClCompile Include="CLILogic.cpp">
-      <Filter>Source Files</Filter>
-    </ClCompile>
-    <ClCompile Include="main.cpp">
-      <Filter>Source Files</Filter>
-    </ClCompile>
-    <ClCompile Include="pch.cpp">
-      <Filter>Source Files</Filter>
-    </ClCompile>
-  </ItemGroup>
-  <ItemGroup>
-    <ClInclude Include="CLILogic.h">
-      <Filter>Header Files</Filter>
-    </ClInclude>
-    <ClInclude Include="pch.h">
-      <Filter>Header Files</Filter>
-    </ClInclude>
-    <ClInclude Include="resource.h">
-      <Filter>Header Files</Filter>
-    </ClInclude>
-  </ItemGroup>
-  <ItemGroup>
-    <None Include="packages.config" />
-  </ItemGroup>
-</Project>

src/modules/FileLocksmith/FileLocksmithCLI/main.cpp

@@ -1,71 +0,0 @@
-#include "pch.h"
-#include "CLILogic.h"
-#include "FileLocksmithLib/FileLocksmith.h"
-#include <iostream>
-#include "resource.h"
-#include <common/logger/logger.h>
-#include <common/utils/logger_helper.h>
-
-struct RealProcessFinder : IProcessFinder
-{
-    std::vector<ProcessResult> find(const std::vector<std::wstring>& paths) override
-    {
-        return find_processes_recursive(paths);
-    }
-};
-
-struct RealProcessTerminator : IProcessTerminator
-{
-    bool terminate(DWORD pid) override
-    {
-        HANDLE hProcess = OpenProcess(PROCESS_TERMINATE, FALSE, pid);
-        if (hProcess)
-        {
-            bool result = TerminateProcess(hProcess, 0);
-            CloseHandle(hProcess);
-            return result;
-        }
-        return false;
-    }
-};
-
-struct RealStringProvider : IStringProvider
-{
-    std::wstring GetString(UINT id) override
-    {
-        wchar_t buffer[4096];
-        int len = LoadStringW(GetModuleHandle(NULL), id, buffer, ARRAYSIZE(buffer));
-        if (len > 0)
-        {
-            return std::wstring(buffer, len);
-        }
-        return L"";
-    }
-};
-
-#ifndef UNIT_TEST
-int wmain(int argc, wchar_t* argv[])
-{
-    winrt::init_apartment();
-    LoggerHelpers::init_logger(L"FileLocksmithCLI", L"", LogSettings::fileLocksmithLoggerName);
-    Logger::info("FileLocksmithCLI started");
-
-    RealProcessFinder finder;
-    RealProcessTerminator terminator;
-    RealStringProvider strings;
-
-    auto result = run_command(argc, argv, finder, terminator, strings);
-
-    if (result.exit_code != 0)
-    {
-        Logger::error("Command failed with exit code {}", result.exit_code);
-    }
-    else
-    {
-        Logger::info("Command succeeded");
-    }
-
-    std::wcout << result.output;
-    return result.exit_code;
-}
-#endif

src/modules/FileLocksmith/FileLocksmithCLI/packages.config

@@ -1,4 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<packages>
-  <package id="Microsoft.Windows.CppWinRT" version="2.0.240111.5" targetFramework="native" />
-</packages>

src/modules/FileLocksmith/FileLocksmithCLI/pch.cpp

@@ -1 +0,0 @@
-#include "pch.h"

src/modules/FileLocksmith/FileLocksmithCLI/pch.h

@@ -1,22 +0,0 @@
-#pragma once
-
-#ifndef PCH_H
-#define PCH_H
-
-#define NOMINMAX
-#define WIN32_LEAN_AND_MEAN
-#include <Windows.h>
-#include <winternl.h>
-#include <Psapi.h>
-#include <shellapi.h>
-
-#include <iostream>
-#include <vector>
-#include <string>
-#include <map>
-#include <set>
-#include <algorithm>
-
-#include <winrt/base.h>
-
-#endif // PCH_H

src/modules/FileLocksmith/FileLocksmithCLI/resource.h

@@ -1,16 +0,0 @@
-// resource.h
-#pragma once
-
-#define IDS_USAGE                       101
-#define IDS_NO_PROCESSES                102
-#define IDS_HEADER                      103
-#define IDS_TERMINATED                  104
-#define IDS_FAILED_TERMINATE            105
-#define IDS_FAILED_OPEN                 106
-#define IDS_ERROR_NO_PATHS              107
-#define IDS_WARN_JSON_WAIT              108
-#define IDS_WAITING                     109
-#define IDS_UNLOCKED                    110
-#define IDS_TIMEOUT                     111
-#define IDS_ERROR_INVALID_TIMEOUT       112
-#define IDS_ERROR_TIMEOUT_ARG           113

src/modules/FileLocksmith/FileLocksmithCLI/tests/FileLocksmithCLITests.cpp

@@ -1,130 +0,0 @@
-#include "pch.h"
-#include "CppUnitTest.h"
-#include "../CLILogic.h"
-#include <map>
-
-using namespace Microsoft::VisualStudio::CppUnitTestFramework;
-
-namespace FileLocksmithCLIUnitTests
-{
-    struct MockProcessFinder : IProcessFinder
-    {
-        std::vector<ProcessResult> results;
-        std::vector<ProcessResult> find(const std::vector<std::wstring>& paths) override
-        {
-            (void)paths;
-            return results;
-        }
-    };
-
-    struct MockProcessTerminator : IProcessTerminator
-    {
-        bool shouldSucceed = true;
-        std::vector<DWORD> terminatedPids;
-        bool terminate(DWORD pid) override
-        {
-            terminatedPids.push_back(pid);
-            return shouldSucceed;
-        }
-    };
-
-    struct MockStringProvider : IStringProvider
-    {
-        std::map<UINT, std::wstring> strings;
-        std::wstring GetString(UINT id) override
-        {
-            if (strings.count(id)) return strings[id];
-            return L"String_" + std::to_wstring(id);
-        }
-    };
-
-    TEST_CLASS(CLITests)
-    {
-    public:
-        
-        TEST_METHOD(TestNoArgs)
-        {
-            MockProcessFinder finder;
-            MockProcessTerminator terminator;
-            MockStringProvider strings;
-            
-            wchar_t* argv[] = { (wchar_t*)L"exe" };
-            auto result = run_command(1, argv, finder, terminator, strings);
-            
-            Assert::AreEqual(1, result.exit_code);
-        }
-
-        TEST_METHOD(TestHelp)
-        {
-            MockProcessFinder finder;
-            MockProcessTerminator terminator;
-            MockStringProvider strings;
-            
-            wchar_t* argv[] = { (wchar_t*)L"exe", (wchar_t*)L"--help" };
-            auto result = run_command(2, argv, finder, terminator, strings);
-            
-            Assert::AreEqual(0, result.exit_code);
-        }
-
-        TEST_METHOD(TestFindProcesses)
-        {
-            MockProcessFinder finder;
-            finder.results = { { L"process", 123, L"user", { L"file1" } } };
-            MockProcessTerminator terminator;
-            MockStringProvider strings;
-            
-            wchar_t* argv[] = { (wchar_t*)L"exe", (wchar_t*)L"file1" };
-            auto result = run_command(2, argv, finder, terminator, strings);
-            
-            Assert::AreEqual(0, result.exit_code);
-            Assert::IsTrue(result.output.find(L"123") != std::wstring::npos);
-            Assert::IsTrue(result.output.find(L"process") != std::wstring::npos);
-        }
-
-        TEST_METHOD(TestJsonOutput)
-        {
-            MockProcessFinder finder;
-            finder.results = { { L"process", 123, L"user", { L"file1" } } };
-            MockProcessTerminator terminator;
-            MockStringProvider strings;
-            
-            wchar_t* argv[] = { (wchar_t*)L"exe", (wchar_t*)L"file1", (wchar_t*)L"--json" };
-            auto result = run_command(3, argv, finder, terminator, strings);
-            
-            Microsoft::VisualStudio::CppUnitTestFramework::Logger::WriteMessage(result.output.c_str());
-
-            Assert::AreEqual(0, result.exit_code);
-            Assert::IsTrue(result.output.find(L"\"pid\"") != std::wstring::npos);
-            Assert::IsTrue(result.output.find(L"123") != std::wstring::npos);
-        }
-
-        TEST_METHOD(TestKill)
-        {
-            MockProcessFinder finder;
-            finder.results = { { L"process", 123, L"user", { L"file1" } } };
-            MockProcessTerminator terminator;
-            MockStringProvider strings;
-            
-            wchar_t* argv[] = { (wchar_t*)L"exe", (wchar_t*)L"file1", (wchar_t*)L"--kill" };
-            auto result = run_command(3, argv, finder, terminator, strings);
-            
-            Assert::AreEqual(0, result.exit_code);
-            Assert::AreEqual((size_t)1, terminator.terminatedPids.size());
-            Assert::AreEqual((DWORD)123, terminator.terminatedPids[0]);
-        }
-
-        TEST_METHOD(TestTimeout)
-        {
-            MockProcessFinder finder;
-            // Always return results so it waits
-            finder.results = { { L"process", 123, L"user", { L"file1" } } };
-            MockProcessTerminator terminator;
-            MockStringProvider strings;
-            
-            wchar_t* argv[] = { (wchar_t*)L"exe", (wchar_t*)L"file1", (wchar_t*)L"--wait", (wchar_t*)L"--timeout", (wchar_t*)L"100" };
-            auto result = run_command(5, argv, finder, terminator, strings);
-            
-            Assert::AreEqual(1, result.exit_code);
-        }
-    };
-}

src/modules/FileLocksmith/FileLocksmithCLI/tests/FileLocksmithCLIUnitTests.vcxproj

@@ -1,84 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Project DefaultTargets="Build" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
-  <Import Project="..\..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.props" Condition="Exists('..\..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.props')" />
-  <PropertyGroup Label="Globals">
-    <ProjectGuid>{A1B2C3D4-E5F6-7890-1234-567890ABCDEF}</ProjectGuid>
-    <Keyword>Win32Proj</Keyword>
-    <RootNamespace>FileLocksmithCLIUnitTests</RootNamespace>
-    <ProjectName>FileLocksmithCLI.UnitTests</ProjectName>
-    <WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion>
-  </PropertyGroup>
-  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
-  <Import Project="..\..\..\..\..\deps\spdlog.props" />
-  <PropertyGroup Label="Configuration">
-    <PlatformToolset>v143</PlatformToolset>
-    <ConfigurationType>DynamicLibrary</ConfigurationType>
-    <CharacterSet>Unicode</CharacterSet>
-  </PropertyGroup>
-  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.props" />
-  <ImportGroup Label="ExtensionSettings">
-  </ImportGroup>
-  <ImportGroup Label="Shared">
-  </ImportGroup>
-  <ImportGroup Label="PropertySheets">
-    <Import Project="$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props" Condition="exists('$(UserRootDir)\Microsoft.Cpp.$(Platform).user.props')" Label="LocalAppDataPlatform" />
-  </ImportGroup>
-  <PropertyGroup Label="UserMacros" />
-  <PropertyGroup>
-    <OutDir>..\..\..\..\..\$(Platform)\$(Configuration)\tests\FileLocksmithCLI\</OutDir>
-  </PropertyGroup>
-  <ItemDefinitionGroup>
-    <ClCompile>
-      <AdditionalIncludeDirectories>..\;..\..\;..\..\..\..\;$(VCInstallDir)UnitTest\include;%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
-      <PreprocessorDefinitions>WIN32;UNIT_TEST;%(PreprocessorDefinitions)</PreprocessorDefinitions>
-      <UseFullPaths>true</UseFullPaths>
-      <PrecompiledHeader>Use</PrecompiledHeader>
-      <PrecompiledHeaderFile>pch.h</PrecompiledHeaderFile>
-      <DisableSpecificWarnings>26466;%(DisableSpecificWarnings)</DisableSpecificWarnings>
-    </ClCompile>
-    <Link>
-      <AdditionalLibraryDirectories>$(VCInstallDir)UnitTest\lib;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
-      <AdditionalDependencies>shlwapi.lib;ntdll.lib;%(AdditionalDependencies)</AdditionalDependencies>
-    </Link>
-  </ItemDefinitionGroup>
-  <ItemGroup>
-    <ClInclude Include="pch.h" />
-  </ItemGroup>
-  <ItemGroup>
-    <ClCompile Include="pch.cpp">
-      <PrecompiledHeader Condition="'$(UsePrecompiledHeaders)' != 'false'">Create</PrecompiledHeader>
-    </ClCompile>
-    <ClCompile Include="FileLocksmithCLITests.cpp" />
-    <ClCompile Include="..\CLILogic.cpp">
-      <PrecompiledHeader>NotUsing</PrecompiledHeader>
-    </ClCompile>
-  </ItemGroup>
-  <ItemGroup>
-    <ProjectReference Include="..\..\FileLocksmithLib\FileLocksmithLib.vcxproj">
-      <Project>{9d52fd25-ef90-4f9a-a015-91efc5daf54f}</Project>
-    </ProjectReference>
-    <ProjectReference Include="..\..\..\..\common\logger\logger.vcxproj">
-      <Project>{d9b8fc84-322a-4f9f-bbb9-20915c47ddfd}</Project>
-    </ProjectReference>
-    <ProjectReference Include="..\..\..\..\common\SettingsAPI\SettingsAPI.vcxproj">
-      <Project>{6955446d-23f7-4023-9bb3-8657f904af99}</Project>
-    </ProjectReference>
-    <ProjectReference Include="..\..\..\..\common\version\version.vcxproj">
-      <Project>{1248566c-272a-43c0-88d6-e6675d569a09}</Project>
-    </ProjectReference>
-  </ItemGroup>
-  <ItemGroup>
-    <None Include="packages.config" />
-  </ItemGroup>
-  <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
-  <ImportGroup Label="ExtensionTargets">
-    <Import Project="..\..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.targets" Condition="Exists('..\..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.targets')" />
-  </ImportGroup>
-  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
-    <PropertyGroup>
-      <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
-    </PropertyGroup>
-    <Error Condition="!Exists('..\..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.props')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.props'))" />
-    <Error Condition="!Exists('..\..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.targets')" Text="$([System.String]::Format('$(ErrorText)', '..\..\..\..\..\packages\Microsoft.Windows.CppWinRT.2.0.240111.5\build\native\Microsoft.Windows.CppWinRT.targets'))" />
-  </Target>
-</Project>

src/modules/FileLocksmith/FileLocksmithCLI/tests/packages.config

@@ -1,4 +0,0 @@
-<?xml version="1.0" encoding="utf-8"?>
-<packages>
-  <package id="Microsoft.Windows.CppWinRT" version="2.0.240111.5" targetFramework="native" />
-</packages>

src/modules/FileLocksmith/FileLocksmithCLI/tests/pch.cpp

@@ -1 +0,0 @@
-#include "pch.h"

src/modules/FileLocksmith/FileLocksmithCLI/tests/pch.h

@@ -1,9 +0,0 @@
-#pragma once
-#include <winrt/base.h>
-#include <Windows.h>
-#include <shellapi.h>
-#include <string>
-#include <vector>
-#include <iostream>
-#include <sstream>
-#include "CppUnitTest.h"

src/modules/FileLocksmith/FileLocksmithLib/FileLocksmith.h

@@ -1,9 +0,0 @@
-#pragma once
-
-#include "ProcessResult.h"
-
-// Second version, checks handles towards files and all subfiles and folders of given dirs, if any.
-std::vector<ProcessResult> find_processes_recursive(const std::vector<std::wstring>& paths);
-
-// Gives the full path of the executable, given the process id
-std::wstring pid_to_full_path(DWORD pid);

src/modules/FileLocksmith/FileLocksmithLib/FileLocksmithLib.vcxproj

@@ -34,9 +34,9 @@
     <ClCompile>
       <WarningLevel>Level3</WarningLevel>
       <SDLCheck>true</SDLCheck>
-      <PreprocessorDefinitions>WIN32;_DEBUG;_LIB;FILELOCKSMITH_LIB_STATIC;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <PreprocessorDefinitions>WIN32;_DEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>
-      <AdditionalIncludeDirectories>..\FileLocksmithLibInterop;../../..;../..;</AdditionalIncludeDirectories>
+      <AdditionalIncludeDirectories>../../..;../..;</AdditionalIncludeDirectories>
     </ClCompile>
     <Link>
       <SubSystem>
@@ -50,9 +50,9 @@
       <FunctionLevelLinking>true</FunctionLevelLinking>
       <IntrinsicFunctions>true</IntrinsicFunctions>
       <SDLCheck>true</SDLCheck>
-      <PreprocessorDefinitions>WIN32;NDEBUG;_LIB;FILELOCKSMITH_LIB_STATIC;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <PreprocessorDefinitions>WIN32;NDEBUG;_LIB;%(PreprocessorDefinitions)</PreprocessorDefinitions>
       <ConformanceMode>true</ConformanceMode>
-      <AdditionalIncludeDirectories>..\FileLocksmithLibInterop;../../..;../..;</AdditionalIncludeDirectories>
+      <AdditionalIncludeDirectories>../../..;../..;</AdditionalIncludeDirectories>
     </ClCompile>
     <Link>
       <SubSystem>
@@ -68,15 +68,13 @@
     <ClInclude Include="Settings.h" />
     <ClInclude Include="Trace.h" />
     <ClInclude Include="framework.h" />
+    <ClInclude Include="pch.h" />
   </ItemGroup>
   <ItemGroup>
     <ClCompile Include="IPC.cpp" />
     <ClCompile Include="Settings.cpp" />
     <ClCompile Include="Trace.cpp" />
     <ClCompile Include="FileLocksmithLib.cpp" />
-    <ClCompile Include="..\FileLocksmithLibInterop\FileLocksmith.cpp" />
-    <ClCompile Include="..\FileLocksmithLibInterop\NtdllBase.cpp" />
-    <ClCompile Include="..\FileLocksmithLibInterop\NtdllExtensions.cpp" />
     <ClCompile Include="pch.cpp">
       <PrecompiledHeader Condition="'$(UsePrecompiledHeaders)' != 'false'">Create</PrecompiledHeader>
     </ClCompile>

src/modules/FileLocksmith/FileLocksmithLib/FileLocksmithLib.vcxproj.filters

@@ -38,15 +38,6 @@
     <ClCompile Include="FileLocksmithLib.cpp">
       <Filter>Source Files</Filter>
     </ClCompile>
-    <ClCompile Include="FileLocksmith.cpp">
-      <Filter>Source Files</Filter>
-    </ClCompile>
-    <ClCompile Include="NtdllBase.cpp">
-      <Filter>Source Files</Filter>
-    </ClCompile>
-    <ClCompile Include="NtdllExtensions.cpp">
-      <Filter>Source Files</Filter>
-    </ClCompile>
     <ClCompile Include="pch.cpp">
       <Filter>Source Files</Filter>
     </ClCompile>

src/modules/FileLocksmith/FileLocksmithLib/ProcessResult.h

@@ -1,12 +0,0 @@
-#pragma once
-#include <string>
-#include <vector>
-#include <Windows.h>
-
-struct ProcessResult
-{
-    std::wstring name;
-    DWORD pid;
-    std::wstring user;
-    std::vector<std::wstring> files;
-};

src/modules/FileLocksmith/FileLocksmithLib/Settings.cpp

@@ -2,7 +2,6 @@
 #include "Settings.h"
 #include "Constants.h"
 
-#include <filesystem>
 #include <common/utils/json.h>
 #include <common/SettingsAPI/settings_helpers.h>
 

src/modules/FileLocksmith/FileLocksmithLib/pch.h

@@ -0,0 +1,13 @@
+// pch.h: This is a precompiled header file.
+// Files listed below are compiled only once, improving build performance for future builds.
+// This also affects IntelliSense performance, including code completion and many code browsing features.
+// However, files listed here are ALL re-compiled if any one of them is updated between builds.
+// Do not add files here that you will be updating frequently as this negates the performance advantage.
+
+#ifndef PCH_H
+#define PCH_H
+
+// add headers that you want to pre-compile here
+#include "framework.h"
+
+#endif //PCH_H

src/modules/FileLocksmith/FileLocksmithLibInterop/pch.h

@@ -18,6 +18,4 @@
 #include <algorithm>
 #include <fstream>
 
-#ifndef FILELOCKSMITH_LIB_STATIC
 #include <winrt/PowerToys.Interop.h>
-#endif

src/modules/LightSwitch/LightSwitchModuleInterface/dllmain.cpp

@@ -405,7 +405,6 @@ public:
     {
         m_enabled = true;
         Logger::info(L"Enabling Light Switch module...");
-        Trace::Enable(true);
 
         unsigned long powertoys_pid = GetCurrentProcessId();
         std::wstring args = L"--pid " + std::to_wstring(powertoys_pid);
@@ -483,8 +482,7 @@ public:
             CloseHandle(m_process);
             m_process = nullptr;
         }
-        
-        Trace::Enable(false);
+
         StopToggleListener();
     }
 
@@ -541,8 +539,6 @@ public:
         if (m_enabled)
         {
             Logger::trace(L"Light Switch hotkey pressed");
-            Trace::ShortcutInvoked();
-
             if (!is_process_running())
             {
                 enable();

src/modules/LightSwitch/LightSwitchModuleInterface/trace.cpp

@@ -19,21 +19,12 @@ void Trace::UnregisterProvider()
     TraceLoggingUnregister(g_hProvider);
 }
 
-void Trace::Enable(bool enabled) noexcept
+void Trace::MyEvent()
 {
     TraceLoggingWrite(
         g_hProvider,
-        "LightSwitch_EnableLightSwitch",
-        ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
-        TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE),
-        TraceLoggingBoolean(enabled, "Enabled"));
-}
-
-void Trace::ShortcutInvoked() noexcept
-{
-    TraceLoggingWrite(
-        g_hProvider,
-        "LightSwitch_ShortcutInvoked",
+        "PowerToyName_MyEvent",
         ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
+        TraceLoggingBoolean(TRUE, "UTCReplace_AppSessionGuid"),
         TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE));
 }

src/modules/LightSwitch/LightSwitchModuleInterface/trace.h

@@ -11,6 +11,5 @@ class Trace
 public:
     static void RegisterProvider();
     static void UnregisterProvider();
-    static void Enable(bool enabled) noexcept;
-    static void ShortcutInvoked() noexcept;
+    static void MyEvent();
 };

src/modules/LightSwitch/LightSwitchService/LightSwitchService.cpp

@@ -14,7 +14,6 @@
 #include "LightSwitchStateManager.h"
 #include <LightSwitchUtils.h>
 #include <NightLightRegistryObserver.h>
-#include <trace.h>
 
 SERVICE_STATUS g_ServiceStatus = {};
 SERVICE_STATUS_HANDLE g_StatusHandle = nullptr;
@@ -358,8 +357,6 @@ DWORD WINAPI ServiceWorkerThread(LPVOID lpParam)
 
 int APIENTRY wWinMain(HINSTANCE, HINSTANCE, PWSTR, int)
 {
-    Trace::LightSwitch::RegisterProvider();
-
     if (powertoys_gpo::getConfiguredLightSwitchEnabledValue() == powertoys_gpo::gpo_rule_configured_disabled)
     {
         wchar_t msg[160];
@@ -367,14 +364,12 @@ int APIENTRY wWinMain(HINSTANCE, HINSTANCE, PWSTR, int)
             msg,
             L"Tried to start with a GPO policy setting the utility to always be disabled. Please contact your systems administrator.");
         Logger::info(msg);
-        Trace::LightSwitch::UnregisterProvider();
         return 0;
     }
+
     int argc = 0;
     LPWSTR* argv = CommandLineToArgvW(GetCommandLineW(), &argc);
     int rc = _tmain(argc, argv); // reuse your existing logic
     LocalFree(argv);
-
-    Trace::LightSwitch::UnregisterProvider();
     return rc;
 }

src/modules/LightSwitch/LightSwitchService/LightSwitchService.vcxproj

@@ -80,7 +80,6 @@
     <ClCompile Include="SettingsConstants.cpp" />
     <ClCompile Include="ThemeHelper.cpp" />
     <ClCompile Include="ThemeScheduler.cpp" />
-    <ClCompile Include="trace.cpp" />
     <ClCompile Include="WinHookEventIDs.cpp" />
   </ItemGroup>
   <ItemGroup>
@@ -95,7 +94,6 @@
     <ClInclude Include="SettingsObserver.h" />
     <ClInclude Include="ThemeHelper.h" />
     <ClInclude Include="ThemeScheduler.h" />
-    <ClInclude Include="trace.h" />
     <ClInclude Include="WinHookEventIDs.h" />
   </ItemGroup>
   <ItemGroup>

src/modules/LightSwitch/LightSwitchService/LightSwitchService.vcxproj.filters

@@ -39,9 +39,6 @@
     <ClCompile Include="NightLightRegistryObserver.cpp">
       <Filter>Source Files</Filter>
     </ClCompile>
-    <ClCompile Include="trace.cpp">
-      <Filter>Source Files</Filter>
-    </ClCompile>
   </ItemGroup>
   <ItemGroup>
     <ClInclude Include="ThemeScheduler.h">
@@ -71,9 +68,6 @@
     <ClInclude Include="NightLightRegistryObserver.h">
       <Filter>Header Files</Filter>
     </ClInclude>
-    <ClInclude Include="trace.h">
-      <Filter>Header Files</Filter>
-    </ClInclude>
   </ItemGroup>
   <ItemGroup>
     <Natvis Include="$(MSBuildThisFileDirectory)..\..\natvis\wil.natvis" />

src/modules/LightSwitch/LightSwitchService/LightSwitchSettings.cpp

@@ -5,7 +5,6 @@
 #include <filesystem>
 #include <fstream>
 #include <logger.h>
-#include <LightSwitchService/trace.h>
 
 using namespace std;
 
@@ -152,7 +151,6 @@ void LightSwitchSettings::LoadSettings()
             if (m_settings.scheduleMode != newMode)
             {
                 m_settings.scheduleMode = newMode;
-                Trace::LightSwitch::ScheduleModeToggled(val);
                 NotifyObservers(SettingId::ScheduleMode);
             }
         }
@@ -222,8 +220,6 @@ void LightSwitchSettings::LoadSettings()
             }
         }
 
-        bool themeTargetChanged = false;
-
         // ChangeSystem
         if (const auto jsonVal = values.get_bool_value(L"changeSystem"))
         {
@@ -231,7 +227,6 @@ void LightSwitchSettings::LoadSettings()
             if (m_settings.changeSystem != val)
             {
                 m_settings.changeSystem = val;
-                themeTargetChanged = true;
                 NotifyObservers(SettingId::ChangeSystem);
             }
         }
@@ -243,16 +238,9 @@ void LightSwitchSettings::LoadSettings()
             if (m_settings.changeApps != val)
             {
                 m_settings.changeApps = val;
-                themeTargetChanged = true;
                 NotifyObservers(SettingId::ChangeApps);
             }
         }
-
-        // For ChangeSystem/ChangeApps changes, log telemetry
-        if (themeTargetChanged)
-        {
-            Trace::LightSwitch::ThemeTargetChanged(m_settings.changeApps, m_settings.changeSystem);
-        }
     }
     catch (...)
     {

src/modules/LightSwitch/LightSwitchService/trace.cpp

@@ -1,43 +0,0 @@
-#include "pch.h"
-#include "trace.h"
-
-// Telemetry strings should not be localized.
-#define LoggingProviderKey "Microsoft.PowerToys"
-
-TRACELOGGING_DEFINE_PROVIDER(
-    g_hProvider,
-    LoggingProviderKey,
-    // {38e8889b-9731-53f5-e901-e8a7c1753074}
-    (0x38e8889b, 0x9731, 0x53f5, 0xe9, 0x01, 0xe8, 0xa7, 0xc1, 0x75, 0x30, 0x74),
-    TraceLoggingOptionProjectTelemetry());
-
-void Trace::LightSwitch::RegisterProvider()
-{
-    TraceLoggingRegister(g_hProvider);
-}
-
-void Trace::LightSwitch::UnregisterProvider()
-{
-    TraceLoggingUnregister(g_hProvider);
-}
-
-void Trace::LightSwitch::ScheduleModeToggled(const std::wstring& newMode) noexcept
-{
-    TraceLoggingWriteWrapper(
-        g_hProvider,
-        "LightSwitch_ScheduleModeToggled",
-        ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
-        TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE),
-        TraceLoggingWideString(newMode.c_str(), "NewMode"));
-}
-
-void Trace::LightSwitch::ThemeTargetChanged(bool changeApps, bool changeSystem) noexcept
-{
-    TraceLoggingWriteWrapper(
-        g_hProvider,
-        "LightSwitch_ThemeTargetChanged",
-        ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
-        TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE),
-        TraceLoggingBoolean(changeApps, "ChangeApps"),
-        TraceLoggingBoolean(changeSystem, "ChangeSystem"));
-}

src/modules/LightSwitch/LightSwitchService/trace.h

@@ -1,17 +0,0 @@
-#pragma once
-
-#include <common/Telemetry/TraceBase.h>
-#include <string>
-
-class Trace
-{
-public:
-    class LightSwitch : public telemetry::TraceBase
-    {
-    public:
-        static void RegisterProvider();
-        static void UnregisterProvider();
-        static void ScheduleModeToggled(const std::wstring& newMode) noexcept;
-        static void ThemeTargetChanged(bool changeApps, bool changeSystem) noexcept;
-    };
-};

src/modules/MouseUtils/FindMyMouse/FindMyMouse.cpp

@@ -77,8 +77,10 @@ protected:
     int m_sonarRadius = FIND_MY_MOUSE_DEFAULT_SPOTLIGHT_RADIUS;
     int m_sonarZoomFactor = FIND_MY_MOUSE_DEFAULT_SPOTLIGHT_INITIAL_ZOOM;
     DWORD m_fadeDuration = FIND_MY_MOUSE_DEFAULT_ANIMATION_DURATION_MS;
+    int m_finalAlphaNumerator = 100; // legacy (root now always animates to 1.0; kept for GDI fallback compatibility)
     std::vector<std::wstring> m_excludedApps;
     int m_shakeMinimumDistance = FIND_MY_MOUSE_DEFAULT_SHAKE_MINIMUM_DISTANCE;
+    static constexpr int FinalAlphaDenominator = 100;
     winrt::Microsoft::UI::Dispatching::DispatcherQueueController m_dispatcherQueueController{ nullptr };
 
     // Don't consider movements started past these milliseconds to detect shaking.
@@ -153,7 +155,7 @@ private:
     void DetectShake();
     bool KeyboardInputCanActivate();
 
-    void StartSonar(FindMyMouseActivationMethod activationMethod);
+    void StartSonar();
     void StopSonar();
 };
 
@@ -273,7 +275,7 @@ LRESULT SuperSonar<D>::BaseWndProc(UINT message, WPARAM wParam, LPARAM lParam) n
     {
         if (m_sonarStart == NoSonar)
         {
-            StartSonar(FindMyMouseActivationMethod::Shortcut);
+            StartSonar();
         }
         else
         {
@@ -382,7 +384,7 @@ void SuperSonar<D>::OnSonarKeyboardInput(RAWINPUT const& input)
                 IsEqual(m_lastKeyPos, ptCursor))
             {
                 m_sonarState = SonarState::ControlDown2;
-                StartSonar(m_activationMethod);
+                StartSonar();
             }
             else
             {
@@ -449,7 +451,7 @@ void SuperSonar<D>::DetectShake()
     if (diagonal > 0 && distanceTravelled / diagonal > (m_shakeFactor / 100.f))
     {
         m_movementHistory.clear();
-        StartSonar(m_activationMethod);
+        StartSonar();
     }
 }
 
@@ -517,7 +519,7 @@ void SuperSonar<D>::OnSonarMouseInput(RAWINPUT const& input)
 }
 
 template<typename D>
-void SuperSonar<D>::StartSonar(FindMyMouseActivationMethod activationMethod)
+void SuperSonar<D>::StartSonar()
 {
     // Don't activate if game mode is on.
     if (m_doNotActivateOnGameMode && detect_game_mode())
@@ -530,7 +532,7 @@ void SuperSonar<D>::StartSonar(FindMyMouseActivationMethod activationMethod)
         return;
     }
 
-    Trace::MousePointerFocused(static_cast<int>(activationMethod));
+    Trace::MousePointerFocused();
     // Cover the entire virtual screen.
     // HACK: Draw with 1 pixel off. Otherwise, Windows glitches the task bar transparency when a transparent window fill the whole screen.
     SetWindowPos(m_hwnd, HWND_TOPMOST, GetSystemMetrics(SM_XVIRTUALSCREEN) + 1, GetSystemMetrics(SM_YVIRTUALSCREEN) + 1, GetSystemMetrics(SM_CXVIRTUALSCREEN) - 2, GetSystemMetrics(SM_CYVIRTUALSCREEN) - 2, 0);
@@ -814,16 +816,13 @@ private:
         // Dim color (source)
         m_dimColorBrush = m_compositor.CreateColorBrush(m_backgroundColor);
         // Radial gradient mask (center transparent, outer opaque)
-        // Fixed feather width: 1px for radius < 300, 2px for radius >= 300
-        const float featherPixels = (m_sonarRadius >= 300) ? 2.0f : 1.0f;
-        const float featherOffset = 1.0f - featherPixels / (rDip * zoom);
         m_spotlightMaskGradient = m_compositor.CreateRadialGradientBrush();
         m_spotlightMaskGradient.MappingMode(muxc::CompositionMappingMode::Absolute);
         m_maskStopCenter = m_compositor.CreateColorGradientStop();
         m_maskStopCenter.Offset(0.0f);
         m_maskStopCenter.Color(winrt::Windows::UI::ColorHelper::FromArgb(0, 0, 0, 0));
         m_maskStopInner = m_compositor.CreateColorGradientStop();
-        m_maskStopInner.Offset(featherOffset);
+        m_maskStopInner.Offset(0.995f);
         m_maskStopInner.Color(winrt::Windows::UI::ColorHelper::FromArgb(0, 0, 0, 0));
         m_maskStopOuter = m_compositor.CreateColorGradientStop();
         m_maskStopOuter.Offset(1.0f);
@@ -853,7 +852,23 @@ private:
         m_root.ImplicitAnimations(collection);
 
         // 6) Spotlight radius shrinks as opacity increases (expression animation)
-        SetupRadiusAnimations(rDip * zoom, rDip, featherPixels);
+        auto radiusExpression = m_compositor.CreateExpressionAnimation();
+        radiusExpression.SetReferenceParameter(L"Root", m_root);
+
+        wchar_t expressionText[256];
+        winrt::check_hresult(StringCchPrintfW(
+            expressionText, ARRAYSIZE(expressionText), L"Lerp(Vector2(%d, %d), Vector2(%d, %d), Root.Opacity)", m_sonarRadius * m_sonarZoomFactor, m_sonarRadius * m_sonarZoomFactor, m_sonarRadius, m_sonarRadius));
+
+        radiusExpression.Expression(expressionText);
+        m_spotlightMaskGradient.StartAnimation(L"EllipseRadius", radiusExpression);
+        // Also animate spotlight geometry radius for visual consistency
+        if (m_circleGeometry)
+        {
+            auto radiusExpression2 = m_compositor.CreateExpressionAnimation();
+            radiusExpression2.SetReferenceParameter(L"Root", m_root);
+            radiusExpression2.Expression(expressionText);
+            m_circleGeometry.StartAnimation(L"Radius", radiusExpression2);
+        }
 
         // Composition created successfully
         return true;
@@ -872,41 +887,6 @@ private:
         }
     }
 
-    // Helper to setup radius and feather expression animations
-    void SetupRadiusAnimations(float startRadiusDip, float endRadiusDip, float featherPixels)
-    {
-        // Radius expression: shrinks from startRadiusDip to endRadiusDip as opacity goes 0->1
-        auto radiusExpression = m_compositor.CreateExpressionAnimation();
-        radiusExpression.SetReferenceParameter(L"Root", m_root);
-        wchar_t expressionText[256];
-        winrt::check_hresult(StringCchPrintfW(
-            expressionText, ARRAYSIZE(expressionText),
-            L"Lerp(Vector2(%.1f, %.1f), Vector2(%.1f, %.1f), Root.Opacity)",
-            startRadiusDip, startRadiusDip, endRadiusDip, endRadiusDip));
-        radiusExpression.Expression(expressionText);
-        m_spotlightMaskGradient.StartAnimation(L"EllipseRadius", radiusExpression);
-
-        // Feather expression: maintains fixed pixel width as radius changes
-        auto featherExpression = m_compositor.CreateExpressionAnimation();
-        featherExpression.SetReferenceParameter(L"Root", m_root);
-        wchar_t featherExpressionText[256];
-        winrt::check_hresult(StringCchPrintfW(
-            featherExpressionText, ARRAYSIZE(featherExpressionText),
-            L"1.0f - %.1ff / Lerp(%.1ff, %.1ff, Root.Opacity)",
-            featherPixels, startRadiusDip, endRadiusDip));
-        featherExpression.Expression(featherExpressionText);
-        m_maskStopInner.StartAnimation(L"Offset", featherExpression);
-
-        // Circle geometry radius for visual consistency
-        if (m_circleGeometry)
-        {
-            auto radiusExpression2 = m_compositor.CreateExpressionAnimation();
-            radiusExpression2.SetReferenceParameter(L"Root", m_root);
-            radiusExpression2.Expression(expressionText);
-            m_circleGeometry.StartAnimation(L"Radius", radiusExpression2);
-        }
-    }
-
     void UpdateIslandSize()
     {
         if (!m_island)
@@ -984,21 +964,27 @@ public:
                     const float scale = static_cast<float>(m_surface.XamlRoot().RasterizationScale());
                     const float rDip = m_sonarRadiusFloat / scale;
                     const float zoom = static_cast<float>(m_sonarZoomFactor);
-                    const float featherPixels = (m_sonarRadius >= 300) ? 2.0f : 1.0f;
-                    const float startRadiusDip = rDip * zoom;
                     m_spotlightMaskGradient.StopAnimation(L"EllipseRadius");
-                    m_maskStopInner.StopAnimation(L"Offset");
-                    if (m_circleGeometry)
-                    {
-                        m_circleGeometry.StopAnimation(L"Radius");
-                    }
-                    m_spotlightMaskGradient.EllipseCenter({ startRadiusDip, startRadiusDip });
+                    m_spotlightMaskGradient.EllipseCenter({ rDip * zoom, rDip * zoom });
                     if (m_spotlight)
                     {
                         m_spotlight.Size({ rDip * 2 * zoom, rDip * 2 * zoom });
-                        m_circleShape.Offset({ startRadiusDip, startRadiusDip });
+                        m_circleShape.Offset({ rDip * zoom, rDip * zoom });
+                    }
+                    auto radiusExpression = m_compositor.CreateExpressionAnimation();
+                    radiusExpression.SetReferenceParameter(L"Root", m_root);
+                    wchar_t expressionText[256];
+                    winrt::check_hresult(StringCchPrintfW(expressionText, ARRAYSIZE(expressionText), L"Lerp(Vector2(%d, %d), Vector2(%d, %d), Root.Opacity)", m_sonarRadius * m_sonarZoomFactor, m_sonarRadius * m_sonarZoomFactor, m_sonarRadius, m_sonarRadius));
+                    radiusExpression.Expression(expressionText);
+                    m_spotlightMaskGradient.StartAnimation(L"EllipseRadius", radiusExpression);
+                    if (m_circleGeometry)
+                    {
+                        m_circleGeometry.StopAnimation(L"Radius");
+                        auto radiusExpression2 = m_compositor.CreateExpressionAnimation();
+                        radiusExpression2.SetReferenceParameter(L"Root", m_root);
+                        radiusExpression2.Expression(expressionText);
+                        m_circleGeometry.StartAnimation(L"Radius", radiusExpression2);
                     }
-                    SetupRadiusAnimations(startRadiusDip, rDip, featherPixels);
                 }
             });
             if (!enqueueSucceeded)
@@ -1032,6 +1018,202 @@ private:
     muxc::ScalarKeyFrameAnimation m_animation{ nullptr };
 };
 
+template<typename D>
+struct GdiSonar : SuperSonar<D>
+{
+    LRESULT WndProc(UINT message, WPARAM wParam, LPARAM lParam) noexcept
+    {
+        switch (message)
+        {
+        case WM_CREATE:
+            SetLayeredWindowAttributes(this->m_hwnd, 0, 0, LWA_ALPHA);
+            break;
+
+        case WM_TIMER:
+            switch (wParam)
+            {
+            case TIMER_ID_FADE:
+                OnFadeTimer();
+                break;
+            }
+            break;
+
+        case WM_PAINT:
+            this->Shim()->OnPaint();
+            break;
+        }
+        return this->BaseWndProc(message, wParam, lParam);
+    }
+
+    void BeforeMoveSonar() { this->Shim()->InvalidateSonar(); }
+    void AfterMoveSonar() { this->Shim()->InvalidateSonar(); }
+
+    void SetSonarVisibility(bool visible)
+    {
+        m_alphaTarget = visible ? MaxAlpha : 0;
+        m_fadeStart = GetTickCount() - FadeFramePeriod;
+        SetTimer(this->m_hwnd, TIMER_ID_FADE, FadeFramePeriod, nullptr);
+        OnFadeTimer();
+    }
+
+    void OnFadeTimer()
+    {
+        auto now = GetTickCount();
+        auto step = (int)((now - m_fadeStart) * MaxAlpha / this->m_fadeDuration);
+
+        this->Shim()->InvalidateSonar();
+        if (m_alpha < m_alphaTarget)
+        {
+            m_alpha += step;
+            if (m_alpha > m_alphaTarget)
+                m_alpha = m_alphaTarget;
+        }
+        else if (m_alpha > m_alphaTarget)
+        {
+            m_alpha -= step;
+            if (m_alpha < m_alphaTarget)
+                m_alpha = m_alphaTarget;
+        }
+        SetLayeredWindowAttributes(this->m_hwnd, 0, (BYTE)m_alpha, LWA_ALPHA);
+        this->Shim()->InvalidateSonar();
+        if (m_alpha == m_alphaTarget)
+        {
+            KillTimer(this->m_hwnd, TIMER_ID_FADE);
+            if (m_alpha == 0)
+            {
+                ShowWindow(this->m_hwnd, SW_HIDE);
+            }
+        }
+        else
+        {
+            ShowWindow(this->m_hwnd, SW_SHOWNOACTIVATE);
+        }
+    }
+
+protected:
+    int CurrentSonarRadius()
+    {
+        int range = MaxAlpha - m_alpha;
+        int radius = this->m_sonarRadius + this->m_sonarRadius * range * (this->m_sonarZoomFactor - 1) / MaxAlpha;
+        return radius;
+    }
+
+private:
+    static constexpr DWORD FadeFramePeriod = 10;
+    int MaxAlpha = SuperSonar<D>::m_finalAlphaNumerator * 255 / SuperSonar<D>::FinalAlphaDenominator;
+    static constexpr DWORD TIMER_ID_FADE = 101;
+
+private:
+    int m_alpha = 0;
+    int m_alphaTarget = 0;
+    DWORD m_fadeStart = 0;
+};
+
+struct GdiSpotlight : GdiSonar<GdiSpotlight>
+{
+    void InvalidateSonar()
+    {
+        RECT rc;
+        auto radius = CurrentSonarRadius();
+        rc.left = this->m_sonarPos.x - radius;
+        rc.top = this->m_sonarPos.y - radius;
+        rc.right = this->m_sonarPos.x + radius;
+        rc.bottom = this->m_sonarPos.y + radius;
+        InvalidateRect(this->m_hwnd, &rc, FALSE);
+    }
+
+    void OnPaint()
+    {
+        PAINTSTRUCT ps;
+        BeginPaint(this->m_hwnd, &ps);
+
+        auto radius = CurrentSonarRadius();
+        auto spotlight = CreateRoundRectRgn(
+            this->m_sonarPos.x - radius, this->m_sonarPos.y - radius, this->m_sonarPos.x + radius, this->m_sonarPos.y + radius, radius * 2, radius * 2);
+
+        FillRgn(ps.hdc, spotlight, static_cast<HBRUSH>(GetStockObject(WHITE_BRUSH)));
+        Sleep(1000 / 60);
+        ExtSelectClipRgn(ps.hdc, spotlight, RGN_DIFF);
+        FillRect(ps.hdc, &ps.rcPaint, static_cast<HBRUSH>(GetStockObject(BLACK_BRUSH)));
+        DeleteObject(spotlight);
+
+        EndPaint(this->m_hwnd, &ps);
+    }
+};
+
+struct GdiCrosshairs : GdiSonar<GdiCrosshairs>
+{
+    void InvalidateSonar()
+    {
+        RECT rc;
+        auto radius = CurrentSonarRadius();
+        GetClientRect(m_hwnd, &rc);
+        rc.left = m_sonarPos.x - radius;
+        rc.right = m_sonarPos.x + radius;
+        InvalidateRect(m_hwnd, &rc, FALSE);
+
+        GetClientRect(m_hwnd, &rc);
+        rc.top = m_sonarPos.y - radius;
+        rc.bottom = m_sonarPos.y + radius;
+        InvalidateRect(m_hwnd, &rc, FALSE);
+    }
+
+    void OnPaint()
+    {
+        PAINTSTRUCT ps;
+        BeginPaint(this->m_hwnd, &ps);
+
+        auto radius = CurrentSonarRadius();
+        RECT rc;
+
+        HBRUSH white = static_cast<HBRUSH>(GetStockObject(WHITE_BRUSH));
+
+        rc.left = m_sonarPos.x - radius;
+        rc.top = ps.rcPaint.top;
+        rc.right = m_sonarPos.x + radius;
+        rc.bottom = ps.rcPaint.bottom;
+        FillRect(ps.hdc, &rc, white);
+
+        rc.left = ps.rcPaint.left;
+        rc.top = m_sonarPos.y - radius;
+        rc.right = ps.rcPaint.right;
+        rc.bottom = m_sonarPos.y + radius;
+        FillRect(ps.hdc, &rc, white);
+
+        HBRUSH black = static_cast<HBRUSH>(GetStockObject(BLACK_BRUSH));
+
+        // Top left
+        rc.left = ps.rcPaint.left;
+        rc.top = ps.rcPaint.top;
+        rc.right = m_sonarPos.x - radius;
+        rc.bottom = m_sonarPos.y - radius;
+        FillRect(ps.hdc, &rc, black);
+
+        // Top right
+        rc.left = m_sonarPos.x + radius;
+        rc.top = ps.rcPaint.top;
+        rc.right = ps.rcPaint.right;
+        rc.bottom = m_sonarPos.y - radius;
+        FillRect(ps.hdc, &rc, black);
+
+        // Bottom left
+        rc.left = ps.rcPaint.left;
+        rc.top = m_sonarPos.y + radius;
+        rc.right = m_sonarPos.x - radius;
+        rc.bottom = ps.rcPaint.bottom;
+        FillRect(ps.hdc, &rc, black);
+
+        // Bottom right
+        rc.left = m_sonarPos.x + radius;
+        rc.top = m_sonarPos.y + radius;
+        rc.right = ps.rcPaint.right;
+        rc.bottom = ps.rcPaint.bottom;
+        FillRect(ps.hdc, &rc, black);
+
+        EndPaint(this->m_hwnd, &ps);
+    }
+};
+
 #pragma endregion Super_Sonar_Base_Code
 
 #pragma region Super_Sonar_API
@@ -1102,4 +1284,4 @@ HWND GetSonarHwnd() noexcept
     return nullptr;
 }
 
-#pragma endregion Super_Sonar_API
+#pragma endregion Super_Sonar_API

src/modules/MouseUtils/FindMyMouse/FindMyMouse.vcxproj

@@ -154,4 +154,4 @@
 
   <Import Project="$(VCTargetsPath)\Microsoft.Cpp.targets" />
   <Import Project="..\..\..\..\deps\spdlog.props" />
-</Project>
+</Project>

src/modules/MouseUtils/FindMyMouse/trace.cpp

@@ -22,12 +22,11 @@ void Trace::EnableFindMyMouse(const bool enabled) noexcept
 }
 
 // Log that the user activated the module by focusing the mouse pointer
-void Trace::MousePointerFocused(const int activationMethod) noexcept
+void Trace::MousePointerFocused() noexcept
 {
     TraceLoggingWriteWrapper(
         g_hProvider,
         "FindMyMouse_MousePointerFocused",
         ProjectTelemetryPrivacyDataTag(ProjectTelemetryTag_ProductAndServicePerformance),
-        TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE),
-        TraceLoggingInt32(activationMethod, "ActivationMethod"));
+        TraceLoggingKeyword(PROJECT_KEYWORD_MEASURE));
 }

src/modules/MouseUtils/FindMyMouse/trace.h

@@ -9,6 +9,5 @@ public:
     static void EnableFindMyMouse(const bool enabled) noexcept;
 
     // Log that the user activated the module by focusing the mouse pointer
-    // activationMethod: 0 = DoubleLeftControlKey, 1 = DoubleRightControlKey, 2 = ShakeMouse, 3 = Shortcut
-    static void MousePointerFocused(const int activationMethod) noexcept;
+    static void MousePointerFocused() noexcept;
 };

src/modules/MouseWithoutBorders/App/Class/IClipboardHelper.cs

@@ -18,12 +18,12 @@ using System.Threading.Tasks;
 using System.Windows.Forms;
 
 using Microsoft.VisualStudio.Threading;
-using MouseWithoutBorders.Core;
 using Newtonsoft.Json;
 using StreamJsonRpc;
 
 #if !MM_HELPER
 using MouseWithoutBorders.Class;
+using MouseWithoutBorders.Core;
 #endif
 
 using SystemClipboard = System.Windows.Forms.Clipboard;
@@ -246,11 +246,11 @@ WellKnownSidType.AuthenticatedUserSid, null);
                 CancellationToken cancellationToken = _serverTaskCancellationSource.Token;
 
                 IpcChannel<ClipboardHelper>.StartIpcServer(ChannelName + "/" + RemoteObjectName, cancellationToken);
-                IpcChannelHelper.IpcChannelCreated = true;
+                Common.IpcChannelCreated = true;
             }
             catch (Exception e)
             {
-                IpcChannelHelper.IpcChannelCreated = false;
+                Common.IpcChannelCreated = false;
                 Common.ShowToolTip("Error setting up clipboard sharing, clipboard sharing will not work!", 5000, ToolTipIcon.Error);
                 Logger.Log(e);
             }
@@ -405,7 +405,7 @@ WellKnownSidType.AuthenticatedUserSid, null);
 
             try
             {
-                rv = IpcChannelHelper.Retry(nameof(SystemClipboard.ContainsFileDropList), () => { return SystemClipboard.ContainsFileDropList(); }, (log) => Log(log));
+                rv = Common.Retry(nameof(SystemClipboard.ContainsFileDropList), () => { return SystemClipboard.ContainsFileDropList(); }, (log) => Log(log));
             }
             catch (ExternalException e)
             {
@@ -427,7 +427,7 @@ WellKnownSidType.AuthenticatedUserSid, null);
 
             try
             {
-                rv = IpcChannelHelper.Retry(nameof(SystemClipboard.ContainsImage), () => { return SystemClipboard.ContainsImage(); }, (log) => Log(log));
+                rv = Common.Retry(nameof(SystemClipboard.ContainsImage), () => { return SystemClipboard.ContainsImage(); }, (log) => Log(log));
             }
             catch (ExternalException e)
             {
@@ -449,7 +449,7 @@ WellKnownSidType.AuthenticatedUserSid, null);
 
             try
             {
-                rv = IpcChannelHelper.Retry(nameof(SystemClipboard.ContainsText), () => { return SystemClipboard.ContainsText(); }, (log) => Log(log));
+                rv = Common.Retry(nameof(SystemClipboard.ContainsText), () => { return SystemClipboard.ContainsText(); }, (log) => Log(log));
             }
             catch (ExternalException e)
             {
@@ -471,7 +471,7 @@ WellKnownSidType.AuthenticatedUserSid, null);
 
             try
             {
-                rv = IpcChannelHelper.Retry(nameof(SystemClipboard.GetFileDropList), () => { return SystemClipboard.GetFileDropList(); }, (log) => Log(log));
+                rv = Common.Retry(nameof(SystemClipboard.GetFileDropList), () => { return SystemClipboard.GetFileDropList(); }, (log) => Log(log));
             }
             catch (ExternalException e)
             {
@@ -493,7 +493,7 @@ WellKnownSidType.AuthenticatedUserSid, null);
 
             try
             {
-                rv = IpcChannelHelper.Retry(nameof(SystemClipboard.GetImage), () => { return SystemClipboard.GetImage(); }, (log) => Log(log));
+                rv = Common.Retry(nameof(SystemClipboard.GetImage), () => { return SystemClipboard.GetImage(); }, (log) => Log(log));
             }
             catch (ExternalException e)
             {
@@ -515,7 +515,7 @@ WellKnownSidType.AuthenticatedUserSid, null);
 
             try
             {
-                rv = IpcChannelHelper.Retry(nameof(SystemClipboard.GetText), () => { return SystemClipboard.GetText(format); }, (log) => Log(log));
+                rv = Common.Retry(nameof(SystemClipboard.GetText), () => { return SystemClipboard.GetText(format); }, (log) => Log(log));
             }
             catch (ExternalException e)
             {
@@ -539,7 +539,7 @@ WellKnownSidType.AuthenticatedUserSid, null);
         {
             try
             {
-                _ = IpcChannelHelper.Retry(
+                _ = Common.Retry(
                     nameof(SystemClipboard.SetImage),
                     () =>
                 {
@@ -568,7 +568,7 @@ WellKnownSidType.AuthenticatedUserSid, null);
         {
             try
             {
-                _ = IpcChannelHelper.Retry(
+                _ = Common.Retry(
                     nameof(SystemClipboard.SetText),
                     () =>
                 {
@@ -600,4 +600,44 @@ WellKnownSidType.AuthenticatedUserSid, null);
     {
         internal const int QUIT_CMD = 0x409;
     }
+
+    internal sealed partial class Common
+    {
+        internal static bool IpcChannelCreated { get; set; }
+
+        internal static T Retry<T>(string name, Func<T> func, Action<string> log, Action preRetry = null)
+        {
+            int count = 0;
+
+            do
+            {
+                try
+                {
+                    T rv = func();
+
+                    if (count > 0)
+                    {
+                        log($"Trace: {name} has been successful after {count} retry.");
+                    }
+
+                    return rv;
+                }
+                catch (Exception)
+                {
+                    count++;
+
+                    preRetry?.Invoke();
+
+                    if (count > 10)
+                    {
+                        throw;
+                    }
+
+                    Application.DoEvents();
+                    Thread.Sleep(200);
+                }
+            }
+            while (true);
+        }
+    }
 }

src/modules/MouseWithoutBorders/App/Core/Clipboard.cs

@@ -1036,7 +1036,7 @@ internal static class Clipboard
         {
             try
             {
-                _ = IpcChannelHelper.Retry(
+                _ = Common.Retry(
                     nameof(SystemClipboard.SetFileDropList),
                     () =>
                     {
@@ -1073,7 +1073,7 @@ internal static class Clipboard
         {
             try
             {
-                _ = IpcChannelHelper.Retry(
+                _ = Common.Retry(
                     nameof(SystemClipboard.SetImage),
                     () =>
                 {
@@ -1104,7 +1104,7 @@ internal static class Clipboard
         {
             try
             {
-                _ = IpcChannelHelper.Retry(
+                _ = Common.Retry(
                     nameof(SystemClipboard.SetText),
                     () =>
                 {

src/modules/MouseWithoutBorders/App/Core/Helper.cs

@@ -295,9 +295,9 @@ internal static class Helper
             return;
         }
 
-        if (!IpcChannelHelper.IpcChannelCreated)
+        if (!Common.IpcChannelCreated)
         {
-            Logger.TelemetryLogTrace($"{nameof(IpcChannelHelper.IpcChannelCreated)} = {IpcChannelHelper.IpcChannelCreated}. {Logger.GetStackTrace(new StackTrace())}", SeverityLevel.Warning);
+            Logger.TelemetryLogTrace($"{nameof(Common.IpcChannelCreated)} = {Common.IpcChannelCreated}. {Logger.GetStackTrace(new StackTrace())}", SeverityLevel.Warning);
             return;
         }
 

src/modules/MouseWithoutBorders/App/Core/IpcChannelHelper.cs

@@ -1,53 +0,0 @@
-// Copyright (c) Microsoft Corporation
-// The Microsoft Corporation licenses this file to you under the MIT license.
-// See the LICENSE file in the project root for more information.
-
-using System;
-using System.Threading;
-using System.Windows.Forms;
-
-#if !MM_HELPER
-using Thread = MouseWithoutBorders.Core.Thread;
-#endif
-
-namespace MouseWithoutBorders.Core;
-
-internal static class IpcChannelHelper
-{
-    internal static bool IpcChannelCreated { get; set; }
-
-    internal static T Retry<T>(string name, Func<T> func, Action<string> log, Action preRetry = null)
-    {
-        int count = 0;
-
-        do
-        {
-            try
-            {
-                T rv = func();
-
-                if (count > 0)
-                {
-                    log($"Trace: {name} has been successful after {count} retry.");
-                }
-
-                return rv;
-            }
-            catch (Exception)
-            {
-                count++;
-
-                preRetry?.Invoke();
-
-                if (count > 10)
-                {
-                    throw;
-                }
-
-                Application.DoEvents();
-                Thread.Sleep(200);
-            }
-        }
-        while (true);
-    }
-}

src/modules/MouseWithoutBorders/App/Core/Logger.cs

@@ -198,6 +198,7 @@ internal static class Logger
             }
 
             Logger.DumpProgramLogs(sb, level);
+            Logger.DumpOtherLogs(sb, level);
             Logger.DumpStaticTypes(sb, level);
 
             log = string.Format(
@@ -239,16 +240,19 @@ internal static class Logger
         _ = Logger.PrivateDump(sb, AllLogs, "[Program logs]\r\n===============\r\n", 0, level, false);
     }
 
+    internal static void DumpOtherLogs(StringBuilder sb, int level)
+    {
+        _ = Logger.PrivateDump(sb, new Common(), "[Other Logs]\r\n===============\r\n", 0, level, false);
+    }
+
     internal static void DumpStaticTypes(StringBuilder sb, int level)
     {
         var staticTypes = new List<Type>
         {
             typeof(Clipboard),
-            typeof(Common),
             typeof(DragDrop),
             typeof(Encryption),
             typeof(Event),
-            typeof(IpcChannelHelper),
             typeof(InitAndCleanup),
             typeof(Helper),
             typeof(Launch),

src/modules/MouseWithoutBorders/App/Form/Settings/SetupPage2b.cs

@@ -2,8 +2,6 @@
 // The Microsoft Corporation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
-using MouseWithoutBorders.Core;
-
 namespace MouseWithoutBorders
 {
     public partial class SetupPage2b : SettingsFormPage

src/modules/MouseWithoutBorders/App/Form/frmAbout.cs

@@ -15,8 +15,6 @@ using System.Globalization;
 using System.Reflection;
 using System.Windows.Forms;
 
-using MouseWithoutBorders.Core;
-
 namespace MouseWithoutBorders
 {
     internal partial class FrmAbout : System.Windows.Forms.Form, IDisposable

src/modules/MouseWithoutBorders/App/Form/frmMessage.cs

@@ -6,8 +6,6 @@ using System;
 using System.Globalization;
 using System.Windows.Forms;
 
-using MouseWithoutBorders.Core;
-
 namespace MouseWithoutBorders
 {
     public partial class FrmMessage : System.Windows.Forms.Form

src/modules/MouseWithoutBorders/App/Form/frmMouseCursor.cs

@@ -6,7 +6,6 @@ using System;
 using System.Windows.Forms;
 
 using MouseWithoutBorders.Class;
-using MouseWithoutBorders.Core;
 
 namespace MouseWithoutBorders
 {

src/modules/MouseWithoutBorders/App/Helper/MouseWithoutBordersHelper.csproj

@@ -49,9 +49,6 @@
     <Compile Include="..\Class\IClipboardHelper.cs">
       <Link>IClipboardHelper.cs</Link>
     </Compile>
-    <Compile Include="..\Core\IpcChannelHelper.cs">
-      <Link>IpcChannelHelper.cs</Link>
-    </Compile>
   </ItemGroup>
 
   <ItemGroup>

src/modules/MouseWithoutBorders/MouseWithoutBorders.UnitTests/Core/Logger.PrivateDump.expected.txt

@@ -1,38 +1,9 @@
 [Program logs]
 ===============
  = System.String[]
-[Clipboard]
-===============
-Comma = System.Char[]
---System.Char[] = System.Char[]: N/A
-Star = System.Char[]
---System.Char[] = System.Char[]: N/A
-NullSeparator = System.Char[]
---System.Char[] = System.Char[]: N/A
-lastClipboardEventTime = 0
-clipboardCopiedTime = 0
-<LastIDWithClipboardData>k__BackingField = NONE
-<NextClipboardViewer>k__BackingField = 0
-<IsClipboardDataImage>k__BackingField = False
-lastClipboardObject = 
-<HasSwitchedMachineSinceLastCopy>k__BackingField = False
-ClipboardThreadOldLock = Lock
---_owningThreadId = 0
---_state = 0
---_recursionCount = 0
---_spinCount = 22
---_waiterStartTimeMs = 0
---s_contentionCount = 0
---s_maxSpinCount = 22
---s_minSpinCountForAdaptiveSpin = -100
-BIG_CLIPBOARD_DATA_TIMEOUT = 30000
-MAX_CLIPBOARD_DATA_SIZE_CAN_BE_SENT_INSTANTLY_TCP = 1048576
-MAX_CLIPBOARD_FILE_SIZE_CAN_BE_SENT = 104857600
-TEXT_HEADER_SIZE = 12
-DATA_SIZE = 48
-TEXT_TYPE_SEP = {4CFF57F7-BEDD-43d5-AE8F-27A61E886F2F}
-[Common]
+[Other Logs]
 ===============
+ = MouseWithoutBorders.Common
 screenWidth = 0
 screenHeight = 0
 lastX = 0
@@ -75,6 +46,7 @@ avgSendTime = 0
 maxSendTime = 0
 totalSendCount = 0
 totalSendTime = 0
+<IpcChannelCreated>k__BackingField = False
 TOGGLE_ICONS_SIZE = 4
 ICON_ONE = 0
 ICON_ALL = 1
@@ -83,6 +55,36 @@ ICON_BIG_CLIPBOARD = 3
 ICON_ERROR = 4
 JUST_GOT_BACK_FROM_SCREEN_SAVER = 9999
 NETWORK_STREAM_BUF_SIZE = 1048576
+[Clipboard]
+===============
+Comma = System.Char[]
+--System.Char[] = System.Char[]: N/A
+Star = System.Char[]
+--System.Char[] = System.Char[]: N/A
+NullSeparator = System.Char[]
+--System.Char[] = System.Char[]: N/A
+lastClipboardEventTime = 0
+clipboardCopiedTime = 0
+<LastIDWithClipboardData>k__BackingField = NONE
+<NextClipboardViewer>k__BackingField = 0
+<IsClipboardDataImage>k__BackingField = False
+lastClipboardObject = 
+<HasSwitchedMachineSinceLastCopy>k__BackingField = False
+ClipboardThreadOldLock = Lock
+--_owningThreadId = 0
+--_state = 0
+--_recursionCount = 0
+--_spinCount = 22
+--_waiterStartTimeMs = 0
+--s_contentionCount = 0
+--s_maxSpinCount = 22
+--s_minSpinCountForAdaptiveSpin = -100
+BIG_CLIPBOARD_DATA_TIMEOUT = 30000
+MAX_CLIPBOARD_DATA_SIZE_CAN_BE_SENT_INSTANTLY_TCP = 1048576
+MAX_CLIPBOARD_FILE_SIZE_CAN_BE_SENT = 104857600
+TEXT_HEADER_SIZE = 12
+DATA_SIZE = 48
+TEXT_TYPE_SEP = {4CFF57F7-BEDD-43d5-AE8F-27A61E886F2F}
 [DragDrop]
 ===============
 isDragging = False
@@ -172,9 +174,6 @@ actualLastPos = {X=0,Y=0}
 --Empty = {X=0,Y=0}
 myLastX = 0
 myLastY = 0
-[IpcChannelHelper]
-===============
-<IpcChannelCreated>k__BackingField = False
 [InitAndCleanup]
 ===============
 initDone = False
@@ -441,7 +440,6 @@ WM_LBUTTONDBLCLK = 515
 WM_RBUTTONDBLCLK = 518
 WM_MBUTTONDBLCLK = 521
 WM_MOUSEWHEEL = 522
-WM_MOUSEHWHEEL = 526
 WM_KEYDOWN = 256
 WM_KEYUP = 257
 WM_SYSKEYDOWN = 260

src/modules/MouseWithoutBorders/MouseWithoutBorders.UnitTests/Core/LoggerTests.cs

@@ -117,6 +117,7 @@ public static class LoggerTests
             // copied from DumpObjects in Logger.cs
             var sb = new StringBuilder(1000000);
             Logger.DumpProgramLogs(sb, settingsDumpObjectsLevel);
+            Logger.DumpOtherLogs(sb, settingsDumpObjectsLevel);
             Logger.DumpStaticTypes(sb, settingsDumpObjectsLevel);
             var actual = sb.ToString();
 

src/modules/cmdpal/Microsoft.CmdPal.UI/Settings/GeneralPage.xaml

@@ -106,7 +106,7 @@
                             <controls:SettingsCard HorizontalContentAlignment="Left" ContentAlignment="Left">
                                 <StackPanel Margin="-12,0,0,0" Orientation="Vertical">
                                     <HyperlinkButton x:Uid="Settings_GeneralPage_About_GithubLink_Hyperlink" NavigateUri="https://go.microsoft.com/fwlink/?linkid=2310837" />
-                                    <HyperlinkButton x:Uid="Settings_GeneralPage_About_SDKDocs_Hyperlink" NavigateUri="https://aka.ms/cmdpalextensions-devdocs" />
+                                    <HyperlinkButton x:Uid="Settings_GeneralPage_About_SDKDocs_Hyperlink" NavigateUri="https://go.microsoft.com/fwlink/?linkid=2310639" />
                                 </StackPanel>
                             </controls:SettingsCard>
                         </controls:SettingsExpander.Items>

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.PowerToys/Commands/CropAndLock/CropAndLockReparentCommand.cs

@@ -4,7 +4,6 @@
 
 using System;
 using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CommandPalette.Extensions.Toolkit;
 using PowerToys.Interop;
 
@@ -22,20 +21,15 @@ internal sealed partial class CropAndLockReparentCommand : InvokableCommand
 
     public override CommandResult Invoke()
     {
-        Task.Run(async () =>
+        try
         {
-            await Task.Delay(500);
-            try
-            {
-                using var evt = new EventWaitHandle(false, EventResetMode.AutoReset, Constants.CropAndLockReparentEvent());
-                evt.Set();
-            }
-            catch
-            {
-                // Ignore errors after dismissing
-            }
-        });
-
-        return CommandResult.Dismiss();
+            using var evt = new EventWaitHandle(false, EventResetMode.AutoReset, Constants.CropAndLockReparentEvent());
+            evt.Set();
+            return CommandResult.Dismiss();
+        }
+        catch (Exception ex)
+        {
+            return CommandResult.ShowToast($"Failed to start Crop and Lock (Reparent): {ex.Message}");
+        }
     }
 }

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.PowerToys/Commands/CropAndLock/CropAndLockScreenshotCommand.cs

@@ -1,41 +0,0 @@
-// Copyright (c) Microsoft Corporation
-// The Microsoft Corporation licenses this file to you under the MIT license.
-// See the LICENSE file in the project root for more information.
-
-using System;
-using System.Threading;
-using System.Threading.Tasks;
-using Microsoft.CommandPalette.Extensions.Toolkit;
-using PowerToys.Interop;
-
-namespace PowerToysExtension.Commands;
-
-/// <summary>
-/// Triggers Crop and Lock screenshot mode via the shared event.
-/// </summary>
-internal sealed partial class CropAndLockScreenshotCommand : InvokableCommand
-{
-    public CropAndLockScreenshotCommand()
-    {
-        Name = "Crop and Lock (Screenshot)";
-    }
-
-    public override CommandResult Invoke()
-    {
-        Task.Run(async () =>
-        {
-            await Task.Delay(500);
-            try
-            {
-                using var evt = new EventWaitHandle(false, EventResetMode.AutoReset, Constants.CropAndLockScreenshotEvent());
-                evt.Set();
-            }
-            catch
-            {
-                // Ignore errors after dismissing
-            }
-        });
-
-        return CommandResult.Dismiss();
-    }
-}

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.PowerToys/Commands/CropAndLock/CropAndLockThumbnailCommand.cs

@@ -4,7 +4,6 @@
 
 using System;
 using System.Threading;
-using System.Threading.Tasks;
 using Microsoft.CommandPalette.Extensions.Toolkit;
 using PowerToys.Interop;
 
@@ -22,20 +21,15 @@ internal sealed partial class CropAndLockThumbnailCommand : InvokableCommand
 
     public override CommandResult Invoke()
     {
-        Task.Run(async () =>
+        try
         {
-            await Task.Delay(500);
-            try
-            {
-                using var evt = new EventWaitHandle(false, EventResetMode.AutoReset, Constants.CropAndLockThumbnailEvent());
-                evt.Set();
-            }
-            catch
-            {
-                // Ignore errors after dismissing
-            }
-        });
-
-        return CommandResult.Dismiss();
+            using var evt = new EventWaitHandle(false, EventResetMode.AutoReset, Constants.CropAndLockThumbnailEvent());
+            evt.Set();
+            return CommandResult.Dismiss();
+        }
+        catch (Exception ex)
+        {
+            return CommandResult.ShowToast($"Failed to start Crop and Lock (Thumbnail): {ex.Message}");
+        }
     }
 }

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.PowerToys/Modules/CropAndLockModuleCommandProvider.cs

@@ -34,13 +34,6 @@ internal sealed class CropAndLockModuleCommandProvider : ModuleCommandProvider
                 Subtitle = Resources.CropAndLock_Thumbnail_Subtitle,
                 Icon = icon,
             };
-
-            yield return new ListItem(new CropAndLockScreenshotCommand())
-            {
-                Title = Resources.CropAndLock_Screenshot_Title,
-                Subtitle = Resources.CropAndLock_Screenshot_Subtitle,
-                Icon = icon,
-            };
         }
 
         yield return new ListItem(new OpenInSettingsCommand(module, title))

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.PowerToys/Properties/Resources.Designer.cs

@@ -375,24 +375,6 @@ namespace PowerToysExtension.Properties {
             }
         }
         
-        /// <summary>
-        ///   Looks up a localized string similar to Crop and Lock (Screenshot).
-        /// </summary>
-        internal static string CropAndLock_Screenshot_Title {
-            get {
-                return ResourceManager.GetString("CropAndLock_Screenshot_Title", resourceCulture);
-            }
-        }
-        
-        /// <summary>
-        ///   Looks up a localized string similar to Create a cropped screenshot window.
-        /// </summary>
-        internal static string CropAndLock_Screenshot_Subtitle {
-            get {
-                return ResourceManager.GetString("CropAndLock_Screenshot_Subtitle", resourceCulture);
-            }
-        }
-        
         /// <summary>
         ///   Looks up a localized string similar to Launch Environment Variables editor.
         /// </summary>

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.PowerToys/Properties/Resources.resx

@@ -260,12 +260,6 @@
   <data name="CropAndLock_Thumbnail_Subtitle" xml:space="preserve">
     <value>Create a cropped thumbnail window</value>
   </data>
-  <data name="CropAndLock_Screenshot_Title" xml:space="preserve">
-    <value>Crop and Lock (Screenshot)</value>
-  </data>
-  <data name="CropAndLock_Screenshot_Subtitle" xml:space="preserve">
-    <value>Create a cropped screenshot window</value>
-  </data>
   <data name="CropAndLock_Settings_Subtitle" xml:space="preserve">
     <value>Open Crop and Lock settings</value>
   </data>

src/modules/cmdpal/extensionsdk/README.md

@@ -7,7 +7,7 @@ Palette, and use the "Create a new extension" command. That will set up a
 project for you, with the packaging, dependencies, and basic program structure
 ready to go.
 
-To view the full docs, you can head over to [our docs site](https://aka.ms/cmdpalextensions-devdocs)
+To view the full docs, you can head over to [our docs site](https://go.microsoft.com/fwlink/?linkid=2310639)
 
 There are samples of just about everything you can do in [the samples project].
 Head over there to see basic usage of the APIs.

src/runner/settings_window.cpp

@@ -148,19 +148,16 @@ std::optional<std::wstring> dispatch_json_action_to_module(const json::JsonObjec
     return result;
 }
 
-void send_json_config_to_module(const std::wstring& module_key, const std::wstring& settings, bool hotkeyUpdated)
+void send_json_config_to_module(const std::wstring& module_key, const std::wstring& settings)
 {
     auto moduleIt = modules().find(module_key);
     if (moduleIt != modules().end())
     {
         moduleIt->second->set_config(settings.c_str());
 
-        if (hotkeyUpdated)
-        {
-            moduleIt->second.remove_hotkey_records();
-            moduleIt->second.update_hotkeys();
-            moduleIt->second.UpdateHotkeyEx();
-        }
+        moduleIt->second.remove_hotkey_records();
+        moduleIt->second.update_hotkeys();
+        moduleIt->second.UpdateHotkeyEx();
     }
 }
 
@@ -169,22 +166,7 @@ void dispatch_json_config_to_modules(const json::JsonObject& powertoys_configs)
     for (const auto& powertoy_element : powertoys_configs)
     {
         const auto element = powertoy_element.Value().Stringify();
-
-        /* As PowerToys Run hotkeys are not registered by the runner, hotkey updates are
-         * triggered only when hotkey properties change to avoid incorrect conflict detection; 
-         * otherwise, the existing logic remains.
-         */
-        auto settings = powertoy_element.Value().GetObjectW();
-        bool hotkeyUpdated = true;
-        if (settings.HasKey(L"properties"))
-        {
-            const auto properties = settings.GetNamedObject(L"properties");
-
-            // Currently, only PowerToys Run settings use the 'hotkey_changed' property.
-            json::get(properties, L"hotkey_changed", hotkeyUpdated, true);
-        }
-        
-        send_json_config_to_module(powertoy_element.Key().c_str(), element.c_str(), hotkeyUpdated);
+        send_json_config_to_module(powertoy_element.Key().c_str(), element.c_str());
     }
 };
 

src/settings-ui/Settings.UI.Library/CropAndLockProperties.cs

@@ -11,13 +11,11 @@ namespace Microsoft.PowerToys.Settings.UI.Library
     {
         public static readonly HotkeySettings DefaultReparentHotkeyValue = new HotkeySettings(true, true, false, true, 0x52); // Ctrl+Win+Shift+R
         public static readonly HotkeySettings DefaultThumbnailHotkeyValue = new HotkeySettings(true, true, false, true, 0x54); // Ctrl+Win+Shift+T
-        public static readonly HotkeySettings DefaultScreenshotHotkeyValue = new HotkeySettings(true, true, false, true, 0x53); // Ctrl+Win+Shift+S
 
         public CropAndLockProperties()
         {
             ReparentHotkey = new KeyboardKeysProperty(DefaultReparentHotkeyValue);
             ThumbnailHotkey = new KeyboardKeysProperty(DefaultThumbnailHotkeyValue);
-            ScreenshotHotkey = new KeyboardKeysProperty(DefaultScreenshotHotkeyValue);
         }
 
         [JsonPropertyName("reparent-hotkey")]
@@ -25,8 +23,5 @@ namespace Microsoft.PowerToys.Settings.UI.Library
 
         [JsonPropertyName("thumbnail-hotkey")]
         public KeyboardKeysProperty ThumbnailHotkey { get; set; }
-
-        [JsonPropertyName("screenshot-hotkey")]
-        public KeyboardKeysProperty ScreenshotHotkey { get; set; }
     }
 }

src/settings-ui/Settings.UI.Library/CropAndLockSettings.cs

@@ -44,10 +44,6 @@ namespace Microsoft.PowerToys.Settings.UI.Library
                     () => Properties.ThumbnailHotkey.Value,
                     value => Properties.ThumbnailHotkey.Value = value ?? CropAndLockProperties.DefaultThumbnailHotkeyValue,
                     "CropAndLock_ThumbnailActivation_Shortcut"),
-                new HotkeyAccessor(
-                    () => Properties.ScreenshotHotkey.Value,
-                    value => Properties.ScreenshotHotkey.Value = value ?? CropAndLockProperties.DefaultScreenshotHotkeyValue,
-                    "CropAndLock_ScreenshotActivation_Shortcut"),
             };
 
             return hotkeyAccessors.ToArray();

src/settings-ui/Settings.UI.Library/PowerLauncherProperties.cs

@@ -94,9 +94,6 @@ namespace Microsoft.PowerToys.Settings.UI.Library
         [JsonPropertyName("generate_thumbnails_from_files")]
         public bool GenerateThumbnailsFromFiles { get; set; }
 
-        [JsonPropertyName("hotkey_changed")]
-        public bool HotkeyChanged { get; set; } = false;
-
         [CmdConfigureIgnoreAttribute]
         public HotkeySettings DefaultOpenPowerLauncher => new HotkeySettings(false, false, true, false, 32);
 

src/settings-ui/Settings.UI/SettingsXAML/OOBE/Views/OobeCropAndLock.xaml

@@ -16,8 +16,6 @@
 
                 <controls:ShortcutWithTextLabelControl x:Name="ReparentHotkeyControl" x:Uid="Oobe_CropAndLock_HowToUse_Reparent" />
 
-                <controls:ShortcutWithTextLabelControl x:Name="ScreenshotHotkeyControl" x:Uid="Oobe_CropAndLock_HowToUse_Screenshot" />
-
                 <StackPanel Orientation="Horizontal" Spacing="8">
                     <Button x:Uid="OOBE_Settings" Click="SettingsLaunchButton_Click" />
 

src/settings-ui/Settings.UI/SettingsXAML/OOBE/Views/OobeCropAndLock.xaml.cs

@@ -35,10 +35,8 @@ namespace Microsoft.PowerToys.Settings.UI.OOBE.Views
         protected override void OnNavigatedTo(NavigationEventArgs e)
         {
             ViewModel.LogOpeningModuleEvent();
-
             ReparentHotkeyControl.Keys = SettingsRepository<CropAndLockSettings>.GetInstance(SettingsUtils.Default).SettingsConfig.Properties.ReparentHotkey.Value.GetKeysList();
             ThumbnailHotkeyControl.Keys = SettingsRepository<CropAndLockSettings>.GetInstance(SettingsUtils.Default).SettingsConfig.Properties.ThumbnailHotkey.Value.GetKeysList();
-            ScreenshotHotkeyControl.Keys = SettingsRepository<CropAndLockSettings>.GetInstance(SettingsUtils.Default).SettingsConfig.Properties.ScreenshotHotkey.Value.GetKeysList();
         }
 
         protected override void OnNavigatedFrom(NavigationEventArgs e)

src/settings-ui/Settings.UI/SettingsXAML/Views/CropAndLockPage.xaml

@@ -44,12 +44,6 @@
                             AllowDisable="True"
                             HotkeySettings="{x:Bind Path=ViewModel.ReparentActivationShortcut, Mode=TwoWay}" />
                     </tkcontrols:SettingsCard>
-                    <tkcontrols:SettingsCard x:Uid="CropAndLock_ScreenshotActivation_Shortcut" HeaderIcon="{ui:FontIcon Glyph=&#xEDA7;}">
-                        <controls:ShortcutControl
-                            MinWidth="{StaticResource SettingActionControlMinWidth}"
-                            AllowDisable="True"
-                            HotkeySettings="{x:Bind Path=ViewModel.ScreenshotActivationShortcut, Mode=TwoWay}" />
-                    </tkcontrols:SettingsCard>
                 </controls:SettingsGroup>
             </StackPanel>
         </controls:SettingsPageControl.ModuleContent>

src/settings-ui/Settings.UI/Strings/en-us/Resources.resw

@@ -3107,12 +3107,6 @@ Right-click to remove the key combination, thereby deactivating the shortcut.</v
   <data name="CropAndLock_ThumbnailActivation_Shortcut.Description" xml:space="preserve">
     <value>Creates a cropped, non-interactive thumbnail of another window. Improves app compatibility.</value>
   </data>
-  <data name="CropAndLock_ScreenshotActivation_Shortcut.Header" xml:space="preserve">
-    <value>Screenshot shortcut</value>
-  </data>
-  <data name="CropAndLock_ScreenshotActivation_Shortcut.Description" xml:space="preserve">
-    <value>Creates a cropped, static screenshot of another window. The screenshot won't update with the original window's content.</value>
-  </data>
   <data name="CropAndLock.SecondaryLinksHeader" xml:space="preserve">
     <value>Attribution</value>
     <comment>giving credit to the projects this utility was based on</comment>
@@ -3131,9 +3125,6 @@ Right-click to remove the key combination, thereby deactivating the shortcut.</v
   <data name="Oobe_CropAndLock_HowToUse_Reparent.Text" xml:space="preserve">
     <value>to crop an application's window into a cropped window. This is experimental and can cause issues with some applications, since the cropped window will contain the original application window.</value>
   </data>
-  <data name="Oobe_CropAndLock_HowToUse_Screenshot.Text" xml:space="preserve">
-    <value>to crop an application's window into a screenshot window. The screenshot won't update with the original window's content.</value>
-  </data>
   <data name="AlwaysOnTop.ModuleDescription" xml:space="preserve">
     <value>Always On Top is a quick and easy way to pin windows on top.</value>
     <comment>{Locked="Always On Top"}</comment>
@@ -3391,9 +3382,6 @@ Activate by holding the key for the character you want to add an accent to, then
   <data name="CropAndLock_Reparent" xml:space="preserve">
     <value>Crop an app's window into a cropped window</value>
   </data>
-  <data name="CropAndLock_Screenshot" xml:space="preserve">
-    <value>Crop an app into a screenshot window</value>
-  </data>
   <data name="FancyZones_OpenEditor" xml:space="preserve">
     <value>Open editor</value>
   </data>

src/settings-ui/Settings.UI/ViewModels/CropAndLockViewModel.cs

@@ -49,7 +49,6 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
 
             _reparentHotkey = Settings.Properties.ReparentHotkey.Value;
             _thumbnailHotkey = Settings.Properties.ThumbnailHotkey.Value;
-            _screenshotHotkey = Settings.Properties.ScreenshotHotkey.Value;
 
             // set the callback functions value to handle outgoing IPC message.
             SendConfigMSG = ipcMSGCallBackFunc;
@@ -74,7 +73,7 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
         {
             var hotkeysDict = new Dictionary<string, HotkeySettings[]>
             {
-                [ModuleName] = [ReparentActivationShortcut, ThumbnailActivationShortcut, ScreenshotActivationShortcut],
+                [ModuleName] = [ReparentActivationShortcut, ThumbnailActivationShortcut],
             };
 
             return hotkeysDict;
@@ -173,36 +172,6 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
             }
         }
 
-        public HotkeySettings ScreenshotActivationShortcut
-        {
-            get => _screenshotHotkey;
-            set
-            {
-                if (value != _screenshotHotkey)
-                {
-                    if (value == null)
-                    {
-                        _screenshotHotkey = CropAndLockProperties.DefaultScreenshotHotkeyValue;
-                    }
-                    else
-                    {
-                        _screenshotHotkey = value;
-                    }
-
-                    Settings.Properties.ScreenshotHotkey.Value = _screenshotHotkey;
-                    NotifyPropertyChanged();
-
-                    // Using InvariantCulture as this is an IPC message
-                    SendConfigMSG(
-                        string.Format(
-                            CultureInfo.InvariantCulture,
-                            "{{ \"powertoys\": {{ \"{0}\": {1} }} }}",
-                            CropAndLockSettings.ModuleName,
-                            JsonSerializer.Serialize(Settings, SourceGenerationContextContext.Default.CropAndLockSettings)));
-                }
-            }
-        }
-
         public void NotifyPropertyChanged([CallerMemberName] string propertyName = null)
         {
             OnPropertyChanged(propertyName);
@@ -220,6 +189,5 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
         private bool _isEnabled;
         private HotkeySettings _reparentHotkey;
         private HotkeySettings _thumbnailHotkey;
-        private HotkeySettings _screenshotHotkey;
     }
 }

src/settings-ui/Settings.UI/ViewModels/DashboardViewModel.cs

@@ -483,7 +483,6 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
             {
                 new DashboardModuleShortcutItem() { Label = resourceLoader.GetString("CropAndLock_Thumbnail"), Shortcut = settings.Properties.ThumbnailHotkey.Value.GetKeysList() },
                 new DashboardModuleShortcutItem() { Label = resourceLoader.GetString("CropAndLock_Reparent"), Shortcut = settings.Properties.ReparentHotkey.Value.GetKeysList() },
-                new DashboardModuleShortcutItem() { Label = resourceLoader.GetString("CropAndLock_Screenshot"), Shortcut = settings.Properties.ScreenshotHotkey.Value.GetKeysList() },
             };
             return new ObservableCollection<DashboardModuleItem>(list);
         }

src/settings-ui/Settings.UI/ViewModels/PowerLauncherViewModel.cs

@@ -31,7 +31,6 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
         private bool _enabledStateIsGPOConfigured;
         private bool _isEnabled;
         private string _searchText;
-        private bool _hotkeyChanged;
 
         private GeneralSettings GeneralSettingsConfig { get; set; }
 
@@ -163,12 +162,6 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
             // Notify UI of property change
             OnPropertyChanged(propertyName);
 
-            // Since PowerLauncher registers its hotkeys independently within the module process,
-            // the runner is notified to update PowerLauncher<65>s hotkeys only when changes occur.
-            // This prevents incorrect conflict detection results.
-            settings.Properties.HotkeyChanged = _hotkeyChanged;
-            _hotkeyChanged = false;
-
             callback(settings);
         }
 
@@ -342,7 +335,6 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
                 if (settings.Properties.OpenPowerLauncher != value)
                 {
                     settings.Properties.OpenPowerLauncher = value ?? settings.Properties.DefaultOpenPowerLauncher;
-                    _hotkeyChanged = true;
                     UpdateSettings();
                 }
             }

src/settings-ui/Settings.UI/ViewModels/ShortcutConflictViewModel.cs

@@ -243,15 +243,6 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
                     // No need to save settings here, the runner will call module interface to save it
                     // SaveSettingsToFile(settings);
 
-                    // For PowerToys Run, we should set the 'HotkeyChanged' property here to avoid issue #41468
-                    if (string.Equals(moduleName, PowerLauncherSettings.ModuleName, StringComparison.OrdinalIgnoreCase))
-                    {
-                        if (settings is PowerLauncherSettings powerLauncherSettings)
-                        {
-                            powerLauncherSettings.Properties.HotkeyChanged = true;
-                        }
-                    }
-
                     // Send IPC notification using the same format as other ViewModels
                     SendConfigMSG(settingsConfig, moduleName);
 

tools/build/build.ps1

@@ -11,9 +11,6 @@ Target platform (e.g., 'x64', 'arm64'). If omitted the script will try to detect
 .PARAMETER Configuration
 Build configuration (e.g., 'Debug', 'Release'). Default: 'Debug'.
 
-.PARAMETER Path
-Optional directory path containing projects to build. If not specified, uses the current working directory.
-
 .PARAMETER RestoreOnly
 If specified, only perform package restore for local projects and skip the build steps for a solution file (i.e. .sln).
 
@@ -24,10 +21,6 @@ Any remaining, positional arguments passed to the script are forwarded to MSBuil
 .\tools\build\build.ps1
 Builds any .sln/.csproj/.vcxproj in the current working directory (auto-detects Platform).
 
-.EXAMPLE
-.\tools\build\build.ps1 -Platform x64 -Configuration Release -Path "C:\MyProject\src"
-Builds local projects in the specified directory for x64 Release.
-
 .EXAMPLE
 .\tools\build\build.ps1 -Platform x64 -Configuration Release
 Builds local projects for x64 Release.
@@ -48,7 +41,6 @@ Only restores packages for local projects; ExtraArgs still forwarded to msbuild'
 param (
     [string]$Platform = '',
     [string]$Configuration = 'Debug',
-    [string]$Path = '',
     [switch]$RestoreOnly,
     [Parameter(ValueFromRemainingArguments=$true)]
     [string[]]$ExtraArgs
@@ -86,11 +78,7 @@ if (-not $Platform -or $Platform -eq '') {
     }
 }
 
-$cwd = if ($Path) {
-    (Resolve-Path $Path).ProviderPath
-} else {
-    (Get-Location).ProviderPath
-}
+$cwd = (Get-Location).ProviderPath
 $extraArgsString = $null
 if ($ExtraArgs -and $ExtraArgs.Count -gt 0) { $extraArgsString = ($ExtraArgs -join ' ') }