Make spelling bot happy

<!-- Enter a brief description/summary of your PR here. What does it
fix/what does it change/how was it tested (even manually, if necessary)?
-->
## Summary of the Pull Request

Fixes a YAML comment that contains pattern forbidden by the spellchecker
introduces in #41723.

See https://github.com/microsoft/PowerToys/security/code-scanning/36008

<!-- Please review the items on the PR checklist before submitting-->
## PR Checklist

- [ ] Closes: #xxx
- [ ] **Communication:** I've discussed this with core contributors
already. If the work hasn't been agreed, this work might be rejected
- [ ] **Tests:** Added/updated and all pass
- [ ] **Localization:** All end-user-facing strings can be localized
- [ ] **Dev docs:** Added/updated
- [ ] **New binaries:** Added on the required places
- [ ] [JSON for
signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json)
for new binaries
- [ ] [WXS for
installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs)
for new binaries and localization folder
- [ ] [YML for CI
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml)
for new test projects
- [ ] [YML for signed
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml)
- [ ] **Documentation updated:** If checked, please file a pull request
on [our docs
repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys)
and link it here: #xxx

<!-- Provide a more detailed description of the PR, other things fixed,
or any additional comments/features here -->
## Detailed Description of the Pull Request / Additional comments

<!-- Describe how you validated the behavior. Add automated tests
wherever possible, but list manual validation steps taken as well -->
## Validation Steps Performed

.github/workflows/automatic-issue-deduplication.yml

@@ -0,0 +1,19 @@
+name: Automatic New Issue Deduplication
+on:
+  issues:
+    types: [opened, reopened]
+permissions:
+  models: read
+  issues: write
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.issue.number }}
+  cancel-in-progress: true
+jobs:
+  deduplicate:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Run Deduplicate Action
+        uses: pelikhan/action-genai-issue-dedup@v0
+        with:
+          github_token: ${{ secrets.GITHUB_TOKEN }}
+          label_as_duplicate: true

.pipelines/v2/templates/job-build-project.yml

@@ -418,7 +418,7 @@ jobs:
       }
       
       if ($Packages.Count -gt 0) {
-          # Priority: Look for platform-specific MSIX (x64/arm64) first, then fallback to any
+          # Priority: Look for platform-specific MSIX (x64/arm64) first, then fall back to any
           $PlatformPackage = $Packages | Where-Object { $_.Name -match "Microsoft\.CmdPal\.UI_.*_(x64|arm64)\.msix$" } | Select-Object -First 1
           if ($PlatformPackage) {
               $Package = $PlatformPackage

src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/IconMarginConverter.cs

@@ -0,0 +1,20 @@
+// Copyright (c) Microsoft Corporation
+// The Microsoft Corporation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using Microsoft.UI.Xaml;
+using Microsoft.UI.Xaml.Data;
+
+namespace Microsoft.CmdPal.UI.Controls;
+
+public sealed class IconMarginConverter : IValueConverter
+{
+    public object Convert(object value, Type targetType, object parameter, string language)
+    {
+        // Only include a margin if there is text to separate from the icon.
+        var text = value as string;
+        return string.IsNullOrEmpty(text) ? new Thickness(0) : new Thickness(0, 0, 4, 0);
+    }
+
+    public object ConvertBack(object value, Type targetType, object parameter, string language) => throw new NotImplementedException();
+}

src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/Tag.xaml

@@ -27,6 +27,8 @@
     <Thickness x:Key="TagPadding">4,2,4,2</Thickness>
     <Thickness x:Key="TagBorderThickness">1</Thickness>
 
+    <local:IconMarginConverter x:Key="IconMarginConverter" />
+
     <Style BasedOn="{StaticResource DefaultTagStyle}" TargetType="local:Tag" />
 
     <Style x:Key="DefaultTagStyle" TargetType="local:Tag">
@@ -71,7 +73,7 @@
                                 x:Name="PART_Icon"
                                 Grid.Column="0"
                                 Height="12"
-                                Margin="0,0,4,0"
+                                Margin="{Binding Text, RelativeSource={RelativeSource TemplatedParent}, Converter={StaticResource IconMarginConverter}}"
                                 SourceKey="{TemplateBinding Icon}" />
                             <TextBlock
                                 Grid.Column="1"

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Helpers/AppSettings.cs

@@ -0,0 +1,24 @@
+// Copyright (c) Microsoft Corporation
+// The Microsoft Corporation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+#nullable enable
+
+using System.Text.Json.Serialization;
+
+namespace Microsoft.CmdPal.Ext.WindowsTerminal.Helpers;
+
+/// <summary>
+/// Strongly typed application-level settings for the Windows Terminal extension.
+/// These are distinct from the dynamic command palette <see cref="JsonSettingsManager"/> based settings
+/// and are meant for simple persisted state (e.g. last selections).
+/// </summary>
+public sealed class AppSettings
+{
+    /// <summary>
+    /// Gets or sets the last selected channel identifier for the Windows Terminal extension.
+    /// Empty string when no channel has been selected yet.
+    /// </summary>
+    [JsonPropertyName("lastSelectedChannel")]
+    public string LastSelectedChannel { get; set; } = string.Empty;
+}

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Helpers/AppSettingsJsonContext.cs

@@ -0,0 +1,15 @@
+// Copyright (c) Microsoft Corporation
+// The Microsoft Corporation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+#nullable enable
+
+using System.Text.Json.Serialization;
+
+namespace Microsoft.CmdPal.Ext.WindowsTerminal.Helpers;
+
+[JsonSourceGenerationOptions(WriteIndented = true)]
+[JsonSerializable(typeof(AppSettings))]
+internal sealed partial class AppSettingsJsonContext : JsonSerializerContext
+{
+}

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Helpers/AppSettingsManager.cs

@@ -0,0 +1,72 @@
+// Copyright (c) Microsoft Corporation
+// The Microsoft Corporation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+#nullable enable
+
+using System;
+using System.IO;
+using System.Text.Json;
+using ManagedCommon;
+using Microsoft.CommandPalette.Extensions.Toolkit;
+
+namespace Microsoft.CmdPal.Ext.WindowsTerminal.Helpers;
+
+#nullable enable
+
+public sealed class AppSettingsManager
+{
+    private const string FileName = "appsettings.json";
+
+    private static string SettingsPath()
+    {
+        var directory = Utilities.BaseSettingsPath("Microsoft.CmdPal");
+        Directory.CreateDirectory(directory);
+        return Path.Combine(directory, FileName);
+    }
+
+    private readonly string _filePath;
+
+    public AppSettings Current { get; private set; } = new();
+
+    public AppSettingsManager()
+    {
+        _filePath = SettingsPath();
+        Load();
+    }
+
+    public void Load()
+    {
+        try
+        {
+            if (File.Exists(_filePath))
+            {
+                var json = File.ReadAllText(_filePath);
+                var loaded = JsonSerializer.Deserialize(json, AppSettingsJsonContext.Default.AppSettings);
+                if (loaded is not null)
+                {
+                    Current = loaded;
+                }
+            }
+        }
+        catch (Exception ex)
+        {
+            ExtensionHost.LogMessage(new LogMessage { Message = ex.ToString() });
+            Logger.LogError("Failed to load app settings", ex);
+        }
+    }
+
+    public void Save()
+    {
+        try
+        {
+            var json = JsonSerializer.Serialize(Current, AppSettingsJsonContext.Default.AppSettings);
+            File.WriteAllText(_filePath, json);
+        }
+        catch (Exception ex)
+        {
+            ExtensionHost.LogMessage(new LogMessage { Message = ex.ToString() });
+            Logger.LogError("Failed to save app settings", ex);
+        }
+    }
+}

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Helpers/SettingsManager.cs

@@ -34,13 +34,21 @@ public class SettingsManager : JsonSettingsManager
         Resources.open_quake_description,
         false);
 
+    private readonly ToggleSetting _saveLastSelectedChannel = new(
+        Namespaced(nameof(SaveLastSelectedChannel)),
+        Resources.save_last_selected_channel!,
+        Resources.save_last_selected_channel_description!,
+        false);
+
     public bool ShowHiddenProfiles => _showHiddenProfiles.Value;
 
     public bool OpenNewTab => _openNewTab.Value;
 
     public bool OpenQuake => _openQuake.Value;
 
-    internal static string SettingsJsonPath()
+    public bool SaveLastSelectedChannel => _saveLastSelectedChannel.Value;
+
+    private static string SettingsJsonPath()
     {
         var directory = Utilities.BaseSettingsPath("Microsoft.CmdPal");
         Directory.CreateDirectory(directory);
@@ -56,6 +64,7 @@ public class SettingsManager : JsonSettingsManager
         Settings.Add(_showHiddenProfiles);
         Settings.Add(_openNewTab);
         Settings.Add(_openQuake);
+        Settings.Add(_saveLastSelectedChannel);
 
         // Load settings from file upon initialization
         LoadSettings();

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Helpers/TerminalQuery.cs

@@ -61,7 +61,7 @@ public class TerminalQuery : ITerminalQuery
         return profiles.OrderBy(p => p.Name);
     }
 
-    private IEnumerable<TerminalPackage> GetTerminals()
+    public IEnumerable<TerminalPackage> GetTerminals()
     {
         var user = WindowsIdentity.GetCurrent().User;
         var localAppDataPath = Environment.GetEnvironmentVariable("LOCALAPPDATA");

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Icons.cs

@@ -6,9 +6,11 @@ using Microsoft.CommandPalette.Extensions.Toolkit;
 
 namespace Microsoft.CmdPal.Ext.WindowsTerminal;
 
-internal sealed class Icons
+internal static class Icons
 {
     internal static IconInfo TerminalIcon { get; } = IconHelpers.FromRelativePath("Assets\\WindowsTerminal.svg");
 
     internal static IconInfo AdminIcon { get; } = new IconInfo("\xE7EF"); // Admin icon
+
+    internal static IconInfo FilterIcon { get; } = new IconInfo("\uE71C"); // Funnel icon
 }

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Pages/ProfilesListPage.cs

@@ -2,40 +2,73 @@
 // The Microsoft Corporation licenses this file to you under the MIT license.
 // See the LICENSE file in the project root for more information.
 
+#nullable enable
+
+using System;
 using System.Collections.Generic;
+using System.Diagnostics;
+using System.Linq;
+using ManagedCommon;
 using Microsoft.CmdPal.Ext.WindowsTerminal.Commands;
 using Microsoft.CmdPal.Ext.WindowsTerminal.Helpers;
 using Microsoft.CmdPal.Ext.WindowsTerminal.Properties;
 using Microsoft.CommandPalette.Extensions;
 using Microsoft.CommandPalette.Extensions.Toolkit;
+using Windows.Foundation;
 
 namespace Microsoft.CmdPal.Ext.WindowsTerminal.Pages;
 
-internal sealed partial class ProfilesListPage : ListPage
+internal sealed partial class ProfilesListPage : ListPage, INotifyItemsChanged
 {
+    event TypedEventHandler<object, IItemsChangedEventArgs> INotifyItemsChanged.ItemsChanged
+    {
+        add
+        {
+            ItemsChanged += value;
+            EnsureInitialized();
+            SelectTerminalFilter();
+        }
+
+        remove
+        {
+            ItemsChanged -= value;
+        }
+    }
+
     private readonly TerminalQuery _terminalQuery = new();
     private readonly SettingsManager _terminalSettings;
+    private readonly AppSettingsManager _appSettingsManager;
 
     private bool showHiddenProfiles;
     private bool openNewTab;
     private bool openQuake;
 
-    public ProfilesListPage(SettingsManager terminalSettings)
+    private bool initialized;
+    private TerminalChannelFilters? terminalFilters;
+
+    public ProfilesListPage(SettingsManager terminalSettings, AppSettingsManager appSettingsManager)
     {
         Icon = Icons.TerminalIcon;
         Name = Resources.profiles_list_page_name;
         _terminalSettings = terminalSettings;
+        _appSettingsManager = appSettingsManager;
     }
 
-#pragma warning disable SA1108
-    public List<ListItem> Query()
+    private List<ListItem> Query()
     {
+        EnsureInitialized();
+
         showHiddenProfiles = _terminalSettings.ShowHiddenProfiles;
         openNewTab = _terminalSettings.OpenNewTab;
         openQuake = _terminalSettings.OpenQuake;
 
         var profiles = _terminalQuery.GetProfiles();
 
+        if (terminalFilters?.IsAllSelected == false)
+        {
+            profiles = profiles.Where(profile => profile.Terminal.AppUserModelId == terminalFilters.CurrentFilterId);
+        }
+
         var result = new List<ListItem>();
 
         foreach (var profile in profiles)
@@ -52,12 +85,66 @@ internal sealed partial class ProfilesListPage : ListPage
                 MoreCommands = [
                     new CommandContextItem(new LaunchProfileAsAdminCommand(profile.Terminal.AppUserModelId, profile.Name, openNewTab, openQuake)),
                 ],
-#pragma warning restore SA1108
             });
         }
 
         return result;
     }
 
-    public override IListItem[] GetItems() => Query().ToArray();
+    private void EnsureInitialized()
+    {
+        if (initialized)
+        {
+            return;
+        }
+
+        var terminals = _terminalQuery.GetTerminals();
+        terminalFilters = new TerminalChannelFilters(terminals);
+        terminalFilters.PropChanged += TerminalFiltersOnPropChanged;
+        SelectTerminalFilter();
+        Filters = terminalFilters;
+        initialized = true;
+    }
+
+    private void SelectTerminalFilter()
+    {
+        Trace.Assert(terminalFilters != null);
+
+        // Select the preferred channel if it exists; we always select the preferred channel,
+        // but user have an option to save the preferred channel when he changes the filter
+        if (_terminalSettings.SaveLastSelectedChannel)
+        {
+            if (!string.IsNullOrWhiteSpace(_appSettingsManager.Current.LastSelectedChannel) &&
+                terminalFilters.ContainsFilter(_appSettingsManager.Current.LastSelectedChannel))
+            {
+                terminalFilters.CurrentFilterId = _appSettingsManager.Current.LastSelectedChannel;
+            }
+        }
+        else
+        {
+            terminalFilters.CurrentFilterId = TerminalChannelFilters.AllTerminalsFilterId;
+        }
+    }
+
+    private void TerminalFiltersOnPropChanged(object sender, IPropChangedEventArgs args)
+    {
+        Trace.Assert(terminalFilters != null);
+
+        RaiseItemsChanged();
+        _appSettingsManager.Current.LastSelectedChannel = terminalFilters.CurrentFilterId;
+        _appSettingsManager.Save();
+    }
+
+    public override IListItem[] GetItems()
+    {
+        try
+        {
+            return [.. Query()];
+        }
+        catch (Exception ex)
+        {
+            Logger.LogError("Failed to list Windows Terminal profiles", ex);
+            throw;
+        }
+    }
 }

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Pages/TerminalChannelFilters.cs

@@ -0,0 +1,56 @@
+// Copyright (c) Microsoft Corporation
+// The Microsoft Corporation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using System.Collections.Generic;
+using Microsoft.CmdPal.Ext.WindowsTerminal.Properties;
+using Microsoft.CommandPalette.Extensions;
+using Microsoft.CommandPalette.Extensions.Toolkit;
+
+namespace Microsoft.CmdPal.Ext.WindowsTerminal.Pages;
+
+internal sealed partial class TerminalChannelFilters : Filters
+{
+    internal const string AllTerminalsFilterId = "all";
+
+    private readonly List<TerminalPackage> _terminals;
+
+    public bool IsAllSelected => CurrentFilterId == AllTerminalsFilterId;
+
+    public TerminalChannelFilters(IEnumerable<TerminalPackage> terminals, string preselectedFilterId = AllTerminalsFilterId)
+    {
+        CurrentFilterId = preselectedFilterId;
+        _terminals = [.. terminals];
+    }
+
+    public override IFilterItem[] GetFilters()
+    {
+        var items = new List<IFilterItem>
+        {
+            new Filter()
+            {
+                Id = AllTerminalsFilterId,
+                Name = Resources.all_channels,
+                Icon = Icons.FilterIcon,
+            },
+            new Separator(),
+        };
+
+        foreach (var terminalPackage in _terminals)
+        {
+            items.Add(new Filter()
+            {
+                Id = terminalPackage.AppUserModelId,
+                Name = terminalPackage.DisplayName,
+                Icon = new IconInfo(terminalPackage.LogoPath),
+            });
+        }
+
+        return [.. items];
+    }
+
+    public bool ContainsFilter(string id)
+    {
+        return _terminals.FindIndex(terminal => terminal.AppUserModelId == id) > -1;
+    }
+}

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Properties/Resources.Designer.cs

@@ -60,6 +60,15 @@ namespace Microsoft.CmdPal.Ext.WindowsTerminal.Properties {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to All channels.
+        /// </summary>
+        internal static string all_channels {
+            get {
+                return ResourceManager.GetString("all_channels", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Windows Terminal Profiles.
         /// </summary>
@@ -132,6 +141,24 @@ namespace Microsoft.CmdPal.Ext.WindowsTerminal.Properties {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Preferred channel.
+        /// </summary>
+        internal static string preferred_channel {
+            get {
+                return ResourceManager.GetString("preferred_channel", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Preferred channel.
+        /// </summary>
+        internal static string preferred_channel_description {
+            get {
+                return ResourceManager.GetString("preferred_channel_description", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Windows Terminal Profiles.
         /// </summary>
@@ -159,6 +186,24 @@ namespace Microsoft.CmdPal.Ext.WindowsTerminal.Properties {
             }
         }
         
+        /// <summary>
+        ///   Looks up a localized string similar to Keep last channel filter.
+        /// </summary>
+        internal static string save_last_selected_channel {
+            get {
+                return ResourceManager.GetString("save_last_selected_channel", resourceCulture);
+            }
+        }
+        
+        /// <summary>
+        ///   Looks up a localized string similar to Remember the last selected channel instead of resetting to All Channels..
+        /// </summary>
+        internal static string save_last_selected_channel_description {
+            get {
+                return ResourceManager.GetString("save_last_selected_channel_description", resourceCulture);
+            }
+        }
+        
         /// <summary>
         ///   Looks up a localized string similar to Settings.
         /// </summary>

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/Properties/Resources.resx

@@ -158,4 +158,19 @@
   <data name="list_item_title" xml:space="preserve">
     <value>Open Windows Terminal Profiles</value>
   </data>
+  <data name="preferred_channel" xml:space="preserve">
+    <value>Preferred channel</value>
+  </data>
+  <data name="preferred_channel_description" xml:space="preserve">
+    <value>Preferred channel</value>
+  </data>
+  <data name="all_channels" xml:space="preserve">
+    <value>All channels</value>
+  </data>
+  <data name="save_last_selected_channel" xml:space="preserve">
+    <value>Keep last channel filter</value>
+  </data>
+  <data name="save_last_selected_channel_description" xml:space="preserve">
+    <value>Remember the last selected channel instead of resetting to All Channels.</value>
+  </data>
 </root>

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/TerminalTopLevelCommandItem.cs

@@ -11,8 +11,8 @@ namespace Microsoft.CmdPal.Ext.WindowsTerminal;
 
 public partial class TerminalTopLevelCommandItem : CommandItem
 {
-    public TerminalTopLevelCommandItem(SettingsManager settingsManager)
-        : base(new ProfilesListPage(settingsManager))
+    public TerminalTopLevelCommandItem(SettingsManager settingsManager, AppSettingsManager appSettingsManager)
+        : base(new ProfilesListPage(settingsManager, appSettingsManager))
     {
         Icon = Icons.TerminalIcon;
         Title = Resources.list_item_title;

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WindowsTerminal/WindowsTerminalCommandsProvider.cs

@@ -13,6 +13,7 @@ public partial class WindowsTerminalCommandsProvider : CommandProvider
 {
     private readonly TerminalTopLevelCommandItem _terminalCommand;
     private readonly SettingsManager _settingsManager = new();
+    private readonly AppSettingsManager _appSettingsManager = new();
 
     public WindowsTerminalCommandsProvider()
     {
@@ -21,7 +22,7 @@ public partial class WindowsTerminalCommandsProvider : CommandProvider
         Icon = Icons.TerminalIcon;
         Settings = _settingsManager.Settings;
 
-        _terminalCommand = new TerminalTopLevelCommandItem(_settingsManager)
+        _terminalCommand = new TerminalTopLevelCommandItem(_settingsManager, _appSettingsManager)
         {
             MoreCommands = [
                 new CommandContextItem(Settings.SettingsPage),