Also only Query for context menu

Add pattern for learn.microsoft links
Update src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp
2025-12-29 00:24:42 +01:00 · 2024-12-20 16:06:43 +00:00 · 2024-12-20 15:59:50 +00:00 · 2024-12-20 15:41:55 +00:00 · 2024-12-20 15:37:15 +00:00 · 2024-12-20 14:28:34 +00:00
2 changed files with 10 additions and 3 deletions
--- a/.github/actions/spell-check/patterns.txt
+++ b/.github/actions/spell-check/patterns.txt
@@ -131,7 +131,7 @@ _mm_(?!dd)\w+

 # hit-count: 4 file-count: 4
 # microsoft
-\b(?:https?://|)(?:(?:(?:blogs|download\.visualstudio|developer|docs|msdn2?|research)\.|)microsoft|blogs\.msdn)\.co(?:m|\.\w\w)/[-_a-zA-Z0-9()=./%]*
+\b(?:https?://|)(?:(?:(?:blogs|download\.visualstudio|developer|docs|learn|msdn2?|research)\.|)microsoft|blogs\.msdn)\.co(?:m|\.\w\w)/[-_a-zA-Z0-9()=./%#]*

 aka\.ms/[a-zA-Z0-9]+

--- a/src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp
+++ b/src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp
@@ -38,9 +38,9 @@ IFACEMETHODIMP shell_context_menu_win10::QueryContextMenu(HMENU menu_handle, UIN
        return E_FAIL;
    }

-    if (menu_flags & CMF_DEFAULTONLY)
+    if (menu_flags & (CMF_DEFAULTONLY | CMF_VERBSONLY | CMF_OPTIMIZEFORINVOKE))
    {
-        return MAKE_HRESULT(SEVERITY_SUCCESS, FACILITY_NULL, 0);
+        return E_UNEXPECTED;
    }

    try
@@ -217,6 +217,13 @@ IFACEMETHODIMP shell_context_menu_win10::InvokeCommand(CMINVOKECOMMANDINFO* para
        return E_FAIL;
    }

+    if (HIWORD(params->lpVerb)!=0)
+    {
+        // Not a menu command. It's likely a string verb command from another menu.
+        // The logic to interpret lpVerb is explained here: https://learn.microsoft.com/en-us/previous-versions//bb776881(v=vs.85)#invokecommand-method
+        return E_FAIL;
+    }
+
    // Get selected menu item (a template or the "Open templates" item)
    const auto selected_menu_item_index = LOWORD(params->lpVerb) - 1;
    if (selected_menu_item_index < 0)
Author	SHA1	Message	Date
Jaime Bernardo	08deccf549	Also only Query for context menu	2024-12-20 16:06:43 +00:00
Jaime Bernardo	b8d5b59031	Add pattern for learn.microsoft links	2024-12-20 15:59:50 +00:00
Jaime Bernardo	3bfcb581cb	Update src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp	2024-12-20 15:41:55 +00:00
Jaime Bernardo	ce9f568779	Update src/modules/NewPlus/NewShellExtensionContextMenu.win10/shell_context_menu_win10.cpp	2024-12-20 15:37:15 +00:00
Jaime Bernardo	62a1dc45ae	[New+]Don't override New actions from Explorer	2024-12-20 14:28:34 +00:00