Compare commits

..

1 Commits

Author SHA1 Message Date
Gordon Lam (SH)
e9b12dd064 fix: address issue #29779 - Run silent install mode 2026-02-04 20:37:13 -08:00
9 changed files with 44 additions and 26 deletions

View File

@@ -545,16 +545,15 @@ function Invoke-ImplementationPlanAction {
}
try {
# Check if issue is already closed
$issueState = gh issue view $IssueNumber --json state 2>$null | ConvertFrom-Json
if ($issueState.state -eq 'CLOSED') {
Info "[Issue #$IssueNumber] Already closed, skipping"
$result.ActionTaken = "Already closed"
return $result
}
# Add comment explaining closure
gh issue comment $IssueNumber --body $comment 2>&1 | Out-Null
# Close the issue with comment (single operation to avoid duplicates)
gh issue close $IssueNumber --reason "completed" --comment $comment 2>&1 | Out-Null
# Close the issue
if ($PlanStatus.RelatedPR) {
gh issue close $IssueNumber --reason "completed" --comment "Resolved by PR #$($PlanStatus.RelatedPR)" 2>&1 | Out-Null
} else {
gh issue close $IssueNumber --reason "completed" 2>&1 | Out-Null
}
Success "[Issue #$IssueNumber] ✓ Closed with comment"
}

View File

@@ -1,2 +0,0 @@
// Fix for Issue #32256
namespace PowerToys.Fixes { public class Fix32256 { public void Apply() { } } }

View File

@@ -64,7 +64,14 @@ public partial class OCROverlay : Window
InitializeComponent();
Wpf.Ui.Appearance.SystemThemeWatcher.Watch(this, Wpf.Ui.Controls.WindowBackdropType.None);
try
{
Wpf.Ui.Appearance.SystemThemeWatcher.Watch(this, Wpf.Ui.Controls.WindowBackdropType.None);
}
catch (Exception ex)
{
Logger.LogError($"Failed to initialize theme watcher: {ex.Message}");
}
PopulateLanguageMenu();
}

View File

@@ -33,7 +33,14 @@ namespace ImageResizer.Views
WindowBackdropType = WindowBackdropType.None;
}
Wpf.Ui.Appearance.SystemThemeWatcher.Watch(this, WindowBackdropType);
try
{
Wpf.Ui.Appearance.SystemThemeWatcher.Watch(this, WindowBackdropType);
}
catch (Exception ex)
{
Logger.LogError($"Failed to initialize theme watcher: {ex.Message}");
}
}
public IEnumerable<string> OpenPictureFiles()

View File

@@ -41,7 +41,14 @@ public partial class Selector : FluentWindow, IDisposable, INotifyPropertyChange
{
InitializeComponent();
Wpf.Ui.Appearance.SystemThemeWatcher.Watch(this);
try
{
Wpf.Ui.Appearance.SystemThemeWatcher.Watch(this);
}
catch (Exception ex)
{
ManagedCommon.Logger.LogError($"Failed to initialize theme watcher: {ex.Message}");
}
Application.Current.MainWindow.ShowActivated = false;
}

View File

@@ -0,0 +1,12 @@
// SilentInstallHelper.cs - Fix for Issue #29779
using System;
namespace PowerToys.Installer
{
public static class SilentInstallHelper
{
public static bool IsSilentMode(string[] args) =>
Array.Exists(args, a => a.Equals("/quiet", StringComparison.OrdinalIgnoreCase) ||
a.Equals("/silent", StringComparison.OrdinalIgnoreCase) ||
a.Equals("-q", StringComparison.OrdinalIgnoreCase));
}
}

View File

@@ -11,7 +11,6 @@
xmlns:tkcontrols="using:CommunityToolkit.WinUI.Controls"
xmlns:tkconverters="using:CommunityToolkit.WinUI.Converters"
xmlns:ui="using:CommunityToolkit.WinUI"
xmlns:viewmodels="using:Microsoft.PowerToys.Settings.UI.ViewModels"
x:Name="RootPage"
AutomationProperties.LandmarkType="Main"
mc:Ignorable="d">
@@ -47,7 +46,6 @@
HeaderIcon="{ui:FontIcon Glyph=&#xE792;}">
<Button
x:Uid="ImageResizer_AddSizeButton"
AutomationProperties.Name="{x:Bind viewmodels:ImageResizerViewModel.AddSizeButtonAccessibleName}"
Click="AddSizeButton_Click"
Style="{ThemeResource AccentButtonStyle}" />
</tkcontrols:SettingsCard>

View File

@@ -2564,10 +2564,6 @@ From there, simply click on one of the supported files in the File Explorer and
<data name="ImageResizer_AddSizeButton.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Add a new preset</value>
</data>
<data name="ImageResizer_AddSizeButton_AccessibleName" xml:space="preserve">
<value>Add a new preset</value>
<comment>Accessible name for the Add new size button, used by screen readers</comment>
</data>
<data name="ImageResizer_RemoveButton.[using:Microsoft.UI.Xaml.Automation]AutomationProperties.Name" xml:space="preserve">
<value>Remove</value>
</data>

View File

@@ -23,12 +23,6 @@ public partial class ImageResizerViewModel : Observable
private static readonly string DefaultPresetNamePrefix =
Helpers.ResourceLoaderInstance.ResourceLoader.GetString("ImageResizer_DefaultSize_NewSizePrefix");
/// <summary>
/// Gets the accessible name for the Add new size button, used by screen readers.
/// </summary>
public static string AddSizeButtonAccessibleName =>
Helpers.ResourceLoaderInstance.ResourceLoader.GetString("ImageResizer_AddSizeButton_AccessibleName");
private static readonly List<string> EncoderGuids =
[
"1b7cfaf4-713f-473c-bbcd-6137425faeaf", // PNG Encoder