[PTRun]Fix locking link files for MSI installers. Warning 1946 (#37654)

* [Runner] fix MSI installer issue. Warning 1946

* Fix catching exceptions

* Better error handling

* Revert "Better error handling"

This reverts commit 0f3ec2a3ef.

.pipelines/v2/templates/job-test-project.yml

@@ -61,9 +61,18 @@ jobs:
         reg add "HKLM\Software\Policies\Microsoft\Edge\WebView2\ReleaseChannels" /v PowerToys.exe /t REG_SZ /d "3"
       displayName: "Enable WebView2 Canary Channel"
 
-  - template: steps-download-artifacts-with-azure-cli.yml
-    parameters:
-      artifactName: $(TestArtifactsName)
+  - ${{ if ne(parameters.platform, 'arm64') }}:
+      - download: current
+        displayName: Download artifacts
+        artifact: $(TestArtifactsName)
+        patterns: |-
+          **
+          !**\*.pdb
+          !**\*.lib
+  - ${{ else }}:
+      - template: steps-download-artifacts-with-azure-cli.yml
+        parameters:
+          artifactName: $(TestArtifactsName)
 
   - template: steps-ensure-dotnet-version.yml
     parameters:

.pipelines/v2/templates/pipeline-ci-build.yml

@@ -72,7 +72,7 @@ stages:
               winAppSDKVersionNumber: ${{ parameters.winAppSDKVersionNumber }}
               useExperimentalVersion: ${{ parameters.useExperimentalVersion }}
 
-    - ${{ if eq(parameters.runTests, true) }}:
+    - ${{ if and(eq(parameters.runTests, true), not(and(eq(platform, 'arm64'), eq(variables['System.PullRequest.IsFork'], true)))) }}:
       - stage: Test_${{ platform }}
         displayName: Test ${{ platform }}
         dependsOn:

src/modules/Workspaces/WorkspacesWindowArranger/WindowArranger.cpp

@@ -62,10 +62,10 @@ namespace PlacementHelper
         else
         {
             placement.showCmd = SW_RESTORE;
+            ScreenToWorkAreaCoords(window, monitor, rect);
+            placement.rcNormalPosition = rect;
         }
 
-        ScreenToWorkAreaCoords(window, monitor, rect);
-        placement.rcNormalPosition = rect;
         placement.flags |= WPF_ASYNCWINDOWPLACEMENT;
 
         auto result = ::SetWindowPlacement(window, &placement);

src/modules/launcher/Wox.Infrastructure/ShellLinkHelper.cs

@@ -136,13 +136,25 @@ namespace Wox.Infrastructure
             var link = new ShellLink();
             const int STGM_READ = 0;
 
+            // Make sure not to open exclusive handles.
+            // See: https://github.com/microsoft/WSL/issues/11276
+            const int STGM_SHARE_DENY_NONE = 0x00000040;
+            const int STGM_TRANSACTED = 0x00010000;
+
             try
             {
-                ((IPersistFile)link).Load(path, STGM_READ);
+                ((IPersistFile)link).Load(path, STGM_READ | STGM_SHARE_DENY_NONE | STGM_TRANSACTED);
             }
             catch (System.IO.FileNotFoundException ex)
             {
-                Log.Exception("Path could not be retrieved", ex, GetType(), path);
+                Log.Exception("Path could not be retrieved " + path, ex, GetType(), path);
+                Marshal.ReleaseComObject(link);
+                return string.Empty;
+            }
+            catch (System.Exception ex)
+            {
+                Log.Exception("Exception loading path " + path, ex, GetType(), path);
+                Marshal.ReleaseComObject(link);
                 return string.Empty;
             }