update

Fixes #44487

## Summary
Fixed issue where the details pane would display stale information when
navigating from an item with details to an item without details or where
details failed to load.

## Changes
1. **ListViewModel.cs**: Added HideDetailsMessage when SafeSlowInit()
fails to ensure previous details are cleared
2. **InstallPackageListItem.cs**: Added exception handling for WinRT
marshaling errors when accessing metadata.Documentations and
metadata.Tags collections

The fix ensures graceful degradation - if certain metadata collections
fail to load due to WinRT issues, the details pane still displays
available information rather than failing completely.

src/modules/cmdpal/Core/Microsoft.CmdPal.Core.ViewModels/ListViewModel.cs

@@ -486,6 +486,11 @@ public partial class ListViewModel : PageViewModel, IDisposable
     {
         if (!item.SafeSlowInit())
         {
+            // Even if initialization fails, we need to hide any previously shown details
+            DoOnUiThread(() =>
+            {
+                WeakReferenceMessenger.Default.Send<HideDetailsMessage>();
+            });
             return;
         }
 

src/modules/cmdpal/ext/Microsoft.CmdPal.Ext.WinGet/Pages/InstallPackageListItem.cs

@@ -132,12 +132,20 @@ public partial class InstallPackageListItem : ListItem
             // These can be l o n g
             { Properties.Resources.winget_release_notes, (metadata.ReleaseNotes, string.Empty) },
         };
-        var docs = metadata.Documentations;
-        var count = docs.Count;
-        for (var i = 0; i < count; i++)
+
+        try
         {
-            var item = docs[i];
-            simpleData.Add(item.DocumentLabel, (string.Empty, item.DocumentUrl));
+            var docs = metadata.Documentations;
+            var count = docs.Count;
+            for (var i = 0; i < count; i++)
+            {
+                var item = docs[i];
+                simpleData.Add(item.DocumentLabel, (string.Empty, item.DocumentUrl));
+            }
+        }
+        catch (Exception ex)
+        {
+            Logger.LogWarning($"Failed to retrieve documentations from metadata: {ex.Message}");
         }
 
         UriCreationOptions options = default;
@@ -159,14 +167,21 @@ public partial class InstallPackageListItem : ListItem
             }
         }
 
-        if (metadata.Tags.Count > 0)
+        try
         {
-            DetailsElement pair = new()
+            if (metadata.Tags.Count > 0)
             {
-                Key = "Tags",
-                Data = new DetailsTags() { Tags = metadata.Tags.Select(t => new Tag(t)).ToArray() },
-            };
-            detailsElements.Add(pair);
+                DetailsElement pair = new()
+                {
+                    Key = "Tags",
+                    Data = new DetailsTags() { Tags = metadata.Tags.Select(t => new Tag(t)).ToArray() },
+                };
+                detailsElements.Add(pair);
+            }
+        }
+        catch (Exception ex)
+        {
+            Logger.LogWarning($"Failed to retrieve tags from metadata: {ex.Message}");
         }
 
         return detailsElements;

src/settings-ui/Settings.UI/ViewModels/AdvancedPasteViewModel.cs

@@ -76,16 +76,19 @@ namespace Microsoft.PowerToys.Settings.UI.ViewModels
 
             GeneralSettingsConfig = settingsRepository.SettingsConfig;
 
-            // To obtain the settings configurations of Fancy zones.
-            ArgumentNullException.ThrowIfNull(settingsRepository);
+            // To obtain the settings configurations of Advanced Paste.
+            ArgumentNullException.ThrowIfNull(advancedPasteSettingsRepository);
 
             _dispatcherQueue = DispatcherQueue.GetForCurrentThread();
 
             _settingsUtils = settingsUtils ?? throw new ArgumentNullException(nameof(settingsUtils));
 
-            ArgumentNullException.ThrowIfNull(advancedPasteSettingsRepository);
+            _advancedPasteSettings = advancedPasteSettingsRepository.SettingsConfig ?? throw new ArgumentException("SettingsConfig cannot be null", nameof(advancedPasteSettingsRepository));
 
-            _advancedPasteSettings = advancedPasteSettingsRepository.SettingsConfig;
+            if (_advancedPasteSettings.Properties is null)
+            {
+                throw new ArgumentException("AdvancedPasteSettings.Properties cannot be null", nameof(advancedPasteSettingsRepository));
+            }
 
             AttachConfigurationHandlers();