mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-09-01 19:51:34 +02:00
ec0830396b02cd5b3b7d6f9fddbb3ff3b7713dfd
9410 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
ec0830396b |
[QuickAccent] Clarify, expand and correct currency symbol mappings (#49343)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request After a review of the current currency-related mappings, this PR makes a few corrections, adds explanatory comments where certain mappings may be confusing, and adds a small number of new mappings to fill gaps and to complete euro area country coverage for `€`. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Changes: 1. Removed `z` from the Currency set. I think this was mistakenly added alongside `ł` for the Polish Złoty (`zł`), but it's just a plain `z` character so does not need to be present. 2. Added comments for all the characters in the currency set which do not independently represent a currency. For example, c with caron `č` is required for Czech Koruna (`Kč`), but `K` is a standard letter. 3. Added the Euro `€` character to the **E** key for the Greece set. It has been the currency in Greece since 2001, so this was a real gap. Now all the eurozone countries represented in Quick Accent have the same mapping. 4. Added the Shekel (or NIS/ILS) `₪` to the Hebrew set. 5. Added the Dong `₫` to the Vietnamese set. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Compiled and ran locally to confirm new additions were present: <img width="750" height="108" alt="image" src="https://github.com/user-attachments/assets/ce30e425-446f-4288-bb52-72e29768ef76" /> Confirmed all Quick Accent unit tests still ran successfully: <img width="348" height="78" alt="image" src="https://github.com/user-attachments/assets/b275a966-65d9-406e-838e-675b9dcd2c50" /> |
||
|
|
1f00859680 |
[Quick Accent] Correction and additions to Bulgarian key mappings (#49344)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This corrects the short I being present on the **I** key, and adds the euro and common punctuation characters for the Bulgarian set. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments `й` was present in the Bulgarian set, which made no sense because every Bulgarian keyboard layout includes the short I. This must have been a mis-type for `ѝ`, which is present on most layouts, but absent on the traditional non-BDS layout. This update replaces the short I with `ѝ`. Bulgaria adopted the euro currency in January 2026, replacing the lev, so including it on **E** makes sense, as it will become more and more common in written communication and is not present on one of the keyboard layouts. Finally, Bulgarian typographic quotes (the `„` low-9 and `“` high-6) are added, along with the double angle quotes for compatibility with other Belarusian sets. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Compiled locally and checked that the new characters were available: <img width="750" height="110" alt="image" src="https://github.com/user-attachments/assets/d5ac0ac1-5814-492e-b2ba-e7747204e668" /> Confirmed that all unit tests still pass: <img width="336" height="75" alt="image" src="https://github.com/user-attachments/assets/eb4360c1-ac7e-4e5c-9cfb-a51a95c41c2a" /> |
||
|
|
0bc78235cc |
CmdPal: Reorder CommandPalette.slnf (#49337)
## Summary of the Pull Request This PR reorders the items in CommandPalette.slnf lexicographically because: 1. It is easier to read. 1. Visual Studio goes bonkers and reorders them anyway, creating extra noise in the diff. Regressed in #49252 <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
e62a41c53a |
CmdPal / Settings: Prevent shortcut dialogs invocation from crashing the parent app (#49334)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request It looks like, when the stars align, changing the system theme can cause the ContentDialog to open multiple times, especially if the user repeatedly clicks the button that opens it. - Adds a ThreadStatic flag to ensure the dialog is opened only once. - Adds a try/catch guard in case my assumption about the flag is wrong. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #49310 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
a291b43df4 |
CmdPal: Add Control Panel tasks to Windows Settings search (#49252)
## Summary of the Pull Request The Command Palette's Windows Settings extension only matches queries against the static `WindowsSettings.json` list, so Control Panel tasks that Windows itself exposes — "Set up USB game controllers", "File History", "Adjust the appearance and performance of Windows" — can never be found, even though Control Panel's own search finds them instantly. This adds a second, dynamic source. At startup the extension enumerates the Control Panel tasks from the shell's "All Tasks" folder (the same data Control Panel search uses, ~150 tasks) and merges them into the searchable set, de-duplicated against the existing entries. ## PR Checklist - [x] Closes: #48539 - [x] **Communication:** Discussed in #48539 - [x] **Tests:** Added/updated and all pass - [x] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places ## Detailed Description of the Pull Request / Additional comments **Enumeration.** `ControlPanelTasksHelper` binds the shell "All Tasks" folder (`shell:::{ED7BA470-8E54-465E-825C-99712043E01C}`) to `IEnumShellItems` and reads each item's display name. Those names come from the shell **already localized**, so the merge deliberately runs *after* `TranslationHelper.TranslateAllSettings` — they must not go through resx translation. Merged entries are typed as Control Panel, so their subtitle reuses the existing localized string. **Launching.** Control Panel task items have no executable command line, and they cannot be re-parsed from their parsing name (`SHParseDisplayName` fails on them). Their shell id list (PIDL) is therefore captured during enumeration via `SHGetIDListFromObject` and stored on the entry; invoking the result launches it with `ShellExecuteEx(SEE_MASK_IDLIST)`. **AOT.** All interop is source-generated (`LibraryImport` + `GeneratedComInterface` with `StrategyBasedComWrappers`), so the extension stays `IsAotCompatible`. **Startup.** Enumeration runs on a background task so the provider constructor never blocks, and it degrades gracefully — if the shell namespace is unavailable the helper logs a warning and returns an empty list, leaving search exactly as it is today. **UX.** Merged entries get `AppHomepageScore = 0`, so they never appear on an empty query. De-duplication checks both `Name` and `AltNames` of existing settings. **No pipeline changes needed:** the new unit test project follows the same pattern as `Microsoft.CmdPal.Ext.Registry.UnitTests` — registered in `PowerToys.slnx` and the CmdPal solution filters, and picked up by the existing `**\*UnitTest*.dll` glob. No sibling CmdPal unit test project is listed in `.pipelines`. ## Validation Steps Performed **Automated** — added `Microsoft.CmdPal.Ext.WindowsSettings.UnitTests` (this extension's first test project). 8 tests, all passing: - 7 unit tests over the merge: adds new tasks; skips duplicate names case-insensitively; skips names matching an existing entry's `AltNames`; skips entries missing a name or command; de-duplicates within the incoming list; returns 0 for an empty list; preserves the shell command prefix. - 1 functional test that enumerates the real shell folder and asserts every task has a name, a `::{`-prefixed parsing name, a non-empty id list, and the expected settings path. **Manual (Windows 11, x64 Debug)** — built `Microsoft.CmdPal.UI` and drove the real palette: - `Windows Settings` → `game controllers` returns **Set up USB game controllers**, subtitle **Control Panel**. - The File History and "appearance and performance" tasks are found. - Invoking the result opens the real Windows **Game Controllers** dialog; the performance task opens **Performance Options**. - Typing the exact task name at the root surfaces it via the fallback item, without entering the page. - Regression: existing `power` → **Power and sleep** still resolves, the empty query still shows only the homepage entries, and there are no duplicate rows. - No perceptible delay — results were available as soon as CmdPal finished loading. <img width="1000" height="600" alt="01-windows-settings-game-controllers" src="https://github.com/user-attachments/assets/04d6ad8e-a69d-4c95-b480-05146aef8784" /> <img width="1000" height="600" alt="02-existing-power-result" src="https://github.com/user-attachments/assets/62e75ea8-4a99-489a-8e7c-f7bf5813185f" /> <img width="1000" height="600" alt="03-root-fallback-game-controllers" src="https://github.com/user-attachments/assets/03eb8908-b8f9-4635-a02e-29b413f0ff24" /> <img width="581" height="1080" alt="04-game-controllers-dialog" src="https://github.com/user-attachments/assets/c8fa24ec-7e41-4da4-b862-e888a88dab7b" /> --------- Co-authored-by: Jiří Polášek <me@jiripolasek.com> |
||
|
|
7c5a384c61 |
CmdPal: Manually set the clock band icon to blank (#49309)
When we added a primary command to open the notification center, that changed the icon of the clock band. It now defaulted to using the "OpenLink" icon, from the command. By manually setting the icon to blank, we remove that icon we didn't want. |
||
|
|
1bbcf27296 |
CmdPal: Hide separator between search bar and context grids when collapsed (#49313)
## Summary of the Pull Request This PR updates a conditional visibility of a border/separator line between search bar and page content to hide it when the ShellPage is in collapsed mode. ## Pictures? Pictures! <img width="472" height="108" alt="image" src="https://github.com/user-attachments/assets/eebc6be2-7dbf-4861-812e-d06ab1d42257" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #49312 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
3a1e642db5 |
[Monaco] Add .uproject and .uplugin support for Unreal Engine files (#47931)
## Summary of the Pull Request Register `.uproject` and `.uplugin` (Unreal Engine project and plugin files) as JSON in Monaco preview, enabling syntax highlighting, folding, and structured navigation for these files in the Monaco preview pane and Peek. This supersedes #45523, which mixed an unrelated de-minification refactor with the feature change. ## PR Checklist - [x] **Communication:** Single-line change, no design decisions - [x] **Tests:** Manual validation only (preview/highlighting feature, no automated tests in this area) - [x] **Localization:** N/A (no end-user-facing strings) - [x] **Dev docs:** N/A - [x] **New binaries:** N/A ## Detailed Description of the Pull Request / Additional comments A single-line edit in `src/Monaco/monaco_languages.json`: `.uproject` and `.uplugin` are appended to the existing built-in `json` language entry. `MonacoHelper.GetLanguage()` then returns `"json"` for these files, and Monaco renders them with its full built-in JSON mode (tokenizer, brace matching, folding, schema validation). Follows the same pattern as #39246, which added `.shproj`/`.projitems` directly to the built-in `xml` entry. No change is needed in `monacoSpecialLanguages.js`: Monaco's JSON support is provided by the language service (`vs/language/json/`), not by a `vs/basic-languages/json/json` module, so the `registerAdditionalLanguage(...)` helper used for other alias languages doesn't apply here. ### About the force-pushes on this PR Apologies for the churn. The original commit tried to register a `jsonExt` alias via `registerAdditionalLanguage("jsonExt", [...], "json", monaco)`. Copilot correctly pointed out that this can't work: the helper requires a `vs/basic-languages/<id>/<id>` module, and Monaco's JSON support lives under `vs/language/json/`, not `vs/basic-languages/json/` — so the alias would have been registered with no tokenizer attached and `.uproject`/`.uplugin` would have rendered as plaintext. While iterating I also overthought the regeneration concern around `monaco_languages.json` (generated by `src/Monaco/generateLanguagesJson.html`) and pushed a couple of intermediate approaches that touched `monacoSpecialLanguages.js` as well. After checking the repo history (#39246, #36499) and confirming there's no CI/pipeline that regenerates this file, the convention here is to edit `monaco_languages.json` directly when the change is purely an extension association on a built-in language — hence the final minimal diff. ## Validation Steps Performed - Verified \`MonacoHelper.GetLanguage(".uproject")\` and \`GetLanguage(".uplugin")\` both return \`"json"\`. - Manually previewed \`.uproject\` and \`.uplugin\` files in Explorer's Monaco preview pane and in Peek after a local Debug build: JSON syntax highlighting, brace matching, folding, and structured navigation all work as expected with text highlighting: <img width="2107" height="829" alt="arestoys-20260516-174242011" src="https://github.com/user-attachments/assets/b5a53ccd-e7f4-4452-b989-782605196c5e" /> |
||
|
|
89db81d058 |
CmdPal: Add a new setting for toast window location (#49262)
## Summary of the Pull Request This PR adds a new settings card to General page in Settings window that allows user to select position of the toast notifications, with options that matches the system setting (Bottom center, Top Left, Top center). - Adds a new drop-down to General page in Settings. - Teaches ToastWindow to position itself to match the new settings. - Adds a default option "Use system settings" that looks into registry what the OS is using right now. ## Pictures? Pictures <img width="1832" height="436" alt="image" src="https://github.com/user-attachments/assets/e973db8e-8d2a-45f6-b518-100e84bc2ac9" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #49261 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
bfce606af9 |
CmdPal: Fix breadcrumb navigation in Settings in non-English locales (#49253)
## Summary of the Pull Request This PR fixes Settings window breadcrumbs in non-English locales. For some reason localized strings leaked as navigation identifiers. - Replaces localized titles in Crumb.Data with const names. - Adds PageTags constants for settings page navigation tags. - Uses new constants in Navigate() switch, initial navigation, and Internal Tools nav item. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #45855 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
a1bef58c7f |
CmdPal: Add an optional icon and an optional action button to toasts (#49260)
## Summary of the Pull Request This PR adds new options to toast notifications in Command Palette. - Adds `IToastArgs2` interface (based on `IToastArgs`) with optional Icon and Command; backwards compatible both ways. - Toolkit `ToastArgs` class implements IToastArgs2. - `ToastWindow` renders the icon and an action button; action toasts stay up 5s and hover pauses auto-hide. - The action runs through the normal PerformCommandMessage pipeline; new opt-in ShowWindowIfPage flag summons the palette for page commands (default false). - New samples for both new properties. ## Pictures? Pictures! Action command: <img width="548" height="144" alt="image" src="https://github.com/user-attachments/assets/aa0e50fa-baa6-43e1-a761-a9a43be0afb0" /> Icon: <img width="704" height="132" alt="image" src="https://github.com/user-attachments/assets/2424a946-ffb5-4928-818c-6cb24453b34d" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #49259 - [x] Closes: #49258 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
9d09e50372 |
CmdPal: Add Settings and Help menu items to the search bar context menu (#49266)
## Summary of the Pull Request This PR expands context menu of search bar with new options: Settings and Help so user can find them and access them more easily. It builds on existing context menu, so all default items are kept in place. ## Pictures? Pictures! <img width="1284" height="366" alt="image" src="https://github.com/user-attachments/assets/cb0b47db-f7bf-43a2-b6fe-b86a8dbc04c6" /> <img width="510" height="392" alt="image" src="https://github.com/user-attachments/assets/f16f2083-8dc2-4ded-834e-4568d5777eea" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #49265 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
fc5ef38326 |
CmdPal: Recognize internet shortcuts for Origin, UPlay and XBox as apps (#49241)
## Summary of the Pull Request This PR extends allow list of protocols that are recognized as valid apps with - Origin (`origin://game` and `origin2://game`) - UPlay (`uplay://launch/`) - XBox (`msgamelaunch://shortcutLaunch/`) As a flyby it improves readability of the regex and replaces it with regular expression source generator. ## Pictures? Pictures! <img width="1256" height="1478" alt="image" src="https://github.com/user-attachments/assets/efbb319a-b9a3-4603-b0df-24622f63cc8e" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #49236 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
d5fe397b05 |
Follow-up: UITest framework Next - stability improvements (#49242)
This pull request addresses several CI flakiness and reliability issues in the UI test automation harness, especially around foreground window handling and build artifact resolution. The main improvements ensure that UI interactions (like real mouse clicks) reliably target the correct window, even in complex CI and build environments, and that test code accurately locates module executables regardless of output layout. **Foreground window handling and input reliability:** * Added `Session.EnsureForeground()` and improved `WindowControl.TryBringToForeground()` to reliably raise the target window above others, defeating the Win32 foreground lock using `AttachThreadInput` and related APIs. This prevents coordinate-based clicks from landing on the wrong window, a common cause of CI test flakiness. (`src/common/UITestAutomation.Next/Session.cs`, `src/common/UITestAutomation.Next/WindowControl.cs`, `src/common/UITestAutomation.Next/Element/Element.cs`, `.github/skills/ui-tests-migration/references/ci-stability.md`, `src/modules/MeasureTool/Tests/ScreenRuler.UITests.Next/TestHelper.cs`) [[1]](diffhunk://#diff-713524f4ead9951000b3578248f2740088729981051b68c3fa3655ebb548f20fR91-R118) [[2]](diffhunk://#diff-60be6ec24a99f8974cff00414fc47ea1e60e3ab9aee706b5d6845eb8df19165fR59-R76) [[3]](diffhunk://#diff-60be6ec24a99f8974cff00414fc47ea1e60e3ab9aee706b5d6845eb8df19165fL247-R332) [[4]](diffhunk://#diff-3c00581cb1d2b6a4302b8378b87c27cdad2f87c2aefc37eec0bdc6c39af9291aR100-R103) [[5]](diffhunk://#diff-98e5aea12baaac99aba10e7dd341ed3f2efdd24cb80b29306bb500816de09e2fR96-R114) [[6]](diffhunk://#diff-d8766b48614fe4a99e3f100e69e611ca2464de6ba0be257586c12d51f9278ed0L498-R504) **Build artifact and executable path resolution:** * Refactored `ModuleInfo.GetDevelopmentPath()` to dynamically walk up from the test assembly and find the module executable in various build output layouts, including CI artifacts and local builds. This eliminates hardcoded path offsets and makes test launches robust to different build structures. (`src/common/UITestAutomation/ModuleInfo.cs`) * Updated `ModuleConfigData.GetModulePath()` to use the improved path resolution and fall back to installed builds if necessary, ensuring that test runs can always locate the correct executable. (`src/common/UITestAutomation/ModuleConfigData.cs`) * Simplified `SessionHelper` so that `locationPath` is always empty, leveraging the fact that module paths are now absolute. (`src/common/UITestAutomation/SessionHelper.cs`) [[1]](diffhunk://#diff-c001f0fd3432c8b6102c3120597fc48f24902eaa0d755f51adfa7646344b3833L7-L10) [[2]](diffhunk://#diff-c001f0fd3432c8b6102c3120597fc48f24902eaa0d755f51adfa7646344b3833L46-R54) These changes collectively improve test reliability, especially in CI environments, and make the harness more resilient to changes in build output structure. --------- Co-authored-by: Boliang Zhang (from Dev Box) <bozhang@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
|
18edd52239 |
Fix Peek Ctrl+W shortcut not working after clicking preview (#48293)
## Summary Fixes #48274 When previewing a file with Peek, clicking inside the preview content (PDF, text/code, markdown, HTML) makes **Ctrl+W unable to close the window**. This happens because the preview controls (WebView2 for most file types, native shell handlers for others) capture keyboard focus in their own message loop, bypassing the XAML keyboard accelerator system entirely. ## Problem Peek defines keyboard shortcuts (Ctrl+W to close, Escape to close, arrow keys to navigate) as `KeyboardAccelerator` elements on the main XAML Grid. These only fire when keyboard input flows through the XAML input system. However: - **WebView2** (used for PDF, text/code via Monaco, markdown, HTML): Runs Chromium in a separate process that consumes all keyboard input when focused. Ctrl+W is particularly problematic because Chromium treats it as "close tab." - **Shell Preview Handlers** (native HWND): Run in a child Win32 window that handles keyboard messages independently. Once either of these controls gets focus via a mouse click, keyboard shortcuts stop working. ## Solution Added a **low-level keyboard hook** (`WH_KEYBOARD_LL`) that intercepts key events at the OS level, regardless of which control has focus: - **Ctrl+W** and **Escape** → close the Peek window - **Arrow keys** (Left/Right/Up/Down without Ctrl) → navigate between files The hook is installed only while the Peek window is visible and only acts when Peek is the foreground window, so it has no impact on other applications. As additional defense-in-depth, `AreBrowserAcceleratorKeysEnabled` is set to `false` on the WebView2 control, preventing Chromium from consuming browser-specific shortcuts like Ctrl+W. ## Changes | File | Change | |------|--------| | `Peek.UI/PeekXAML/MainWindow.xaml.cs` | Install/uninstall keyboard hook in Initialize/Uninitialize; hook callback handles Ctrl+W, Escape, and arrow keys | | `Peek.UI/Native/NativeMethods.cs` | P/Invoke declarations for `SetWindowsHookEx`, `UnhookWindowsHookEx`, `CallNextHookEx`, `GetAsyncKeyState` | | `Peek.FilePreviewer/Controls/BrowserControl.xaml.cs` | Disable browser accelerator keys on WebView2 | ## Validation - [x] Ctrl+W closes Peek after clicking inside PDF preview - [x] Ctrl+W closes Peek after clicking inside text/code preview (Monaco) - [x] Escape closes Peek after clicking inside preview - [x] Arrow keys navigate between files after clicking inside preview - [x] Normal typing/interaction inside previews still works (Ctrl+C, scrolling, etc.) - [x] Shortcuts still work without clicking (existing behavior preserved) --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> |
||
|
|
3fd6a03ed4 |
Make PowerShell script invocation more reliable (#46729)
## Summary of the Pull Request - Protect against issues caused by loading PowerShell profile scripts - Ignore any warnings that may be generated by auto-loaded PowerShell modules. Warnings are written to stderr which the Exec then interprets as an error <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #46618 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [x] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [x] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments The build contains PowerShell invocations. The issue with these prior to this change is that they are vulnerable to what ever may be in the current user's PowerShell profile script. They are also vulnerable to any auto-loaded PowerShell modules that may generate warnings, as the warning output is interpreted as an error by the MSBuild `Exec` task. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed 1. Built successfully from command line and in Visual Studio 2. Tested locally and also tested MouseWithoutBorders against second machine. |
||
|
|
4881f23545 |
Add PR Needs-Author-Feedback lifecycle to fabricbot configuration (#49151)
## Summary Adds fabricbot rules to manage the `Needs-Author-Feedback` label lifecycle for **pull requests**, complementing the existing issue management rules in `resourceManagement.yml`. This is a **simpler alternative** to the GitHub Actions workflow approach (PR #48812), trading advanced features (draft conversion, author-specific activity tracking) for zero-maintenance fabricbot automation. ## Behavior ### Flow diagram ``` ┌──────────────────────────────────────────────────────────────────────┐ │ Maintainer adds "Needs-Author-Feedback" label to a PR │ └──────────────────────────────────────────────────────────────────────┘ │ ▼ ┌─────────────────────────────────────┐ ┌──────────────────────────────────┐ │ 7 days, no activity │────►│ Add "Status-No recent activity" │ │ │ │ + post warning comment │ └─────────────────────────────────────┘ └──────────────────────────────────┘ │ │ ▼ ▼ ┌─────────────────────────────────────┐ ┌──────────────────────────────────┐ │ 7 more days (14 total), no activity│────►│ Close PR + post closing comment │ └─────────────────────────────────────┘ └──────────────────────────────────┘ ┌──────────────────────────────────────────────────────────────────────┐ │ Author pushes commits OR comments on PR (at any point) │ └──────────────────────────────────────────────────────────────────────┘ │ ▼ Remove "Needs-Author-Feedback" → Add "Needs-Triage" Remove "Status-No recent activity" (if present) ``` ### Scheduled searches (every 6 hours) | Condition | Action | |-----------|--------| | PR + `Needs-Author-Feedback` + 7 days inactive + no `Status-No recent activity` | Add `Status-No recent activity` label + warning comment | | PR + `Needs-Author-Feedback` + `Status-No recent activity` + 7 more days inactive | Post closing comment + close PR | ### Event responders | Trigger | Action | |---------|--------| | Author comments on PR (`Issue_Comment` + `issueAuthor`) | Remove `Needs-Author-Feedback`, add `Needs-Triage` + `Needs-Team-Response` | | Author pushes commits (`Pull_Request` + `Synchronize` + `issueAuthor`) | Remove `Needs-Author-Feedback`, add `Needs-Triage` | | Any PR update activity | Remove `Status-No recent activity` | ### Bot messages **Warning (at 7 days):** > This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for **7 days**. It will be closed if no further activity occurs **within 7 days of this comment**. To keep this PR active, please push your changes or leave a comment. **Closing (at 14 days):** > This pull request has been automatically closed because it has been marked as requiring author feedback but has not had any activity for **14 days**. If you would like to continue working on this, please reopen the PR and push your changes. ## Comparison with GitHub Actions workflow (PR #48812) | Feature | This PR (fabricbot) | PR #48812 (Actions) | |---------|-------------------|-------------------| | Convert to draft at 7 days | ❌ Not supported | ✅ Via GraphQL | | Close at 14 days | ✅ | ✅ | | Author-specific activity tracking | ❌ Any activity resets timer | ✅ Only author activity counts | | Bot comment resets timer | ⚠️ Yes (fabricbot limitation) | ✅ No (filtered out) | | Maintenance burden | None (fabricbot managed) | Low (workflow file) | | Testing before merge | ❌ No local testing | ✅ `workflow_dispatch` + dry-run | | Review comment detection | ❌ Only issue comments | ✅ Reviews + inline comments | ## Trade-offs **Pros:** - Zero maintenance — fabricbot is a managed service - Consistent with existing issue management patterns in the same file - No workflow YAML to debug or maintain **Cons:** - No draft conversion (fabricbot cannot call GraphQL) - `noActivitySince` counts **all** activity — bot comments, maintainer comments, and label changes all reset the inactivity timer - Cannot distinguish author activity from other activity - No way to test locally or with dry-run before merge ## Relationship to existing automation Mirrors the existing issue rules (lines 11-43) which use the same pattern: - Issues: 5 days → warning, 5 more days → close - PRs (this change): 7 days → warning, 7 more days → close Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
|
85f698677a |
[UITests] AI migration skill + ScreenRuler tests example port. (#48842)
This PR is build on top of https://github.com/microsoft/PowerToys/pull/48717 and https://github.com/microsoft/PowerToys/pull/48467 It adds the ui-tests-migration skill which should be used to migrate the old UITest module by module to use new .Next UI framework. As an example, the screen ruller tests was ported here. --------- Co-authored-by: Boliang Zhang (from Dev Box) <bozhang@microsoft.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
|
4395b1d0ca |
[skill] Generalize verification skill into 2 scenarios (module checklist / PR validation) (#48848)
## Summary of the Pull Request Generalizes the `powertoys-verification` agent skill from "one module checklist" into a **single shared engine that serves two verification scenarios**, using the *shared engine + per-scenario reference docs* design (no duplication of the winapp mechanics): - **A — Module checklist**: verify a supplied module checklist against the installed build. - **B — PR validation**: derive each PR's checklist from its description + diff, then drive it. A single **bits sub-decision** picks the target — drive the **installed** build when the PR's code is already shipped (a merged PR, or a whole release/hotfix set, e.g. the 0.100.1 14-PR sign-off), or **build + sideload** the affected module when it isn't (an unmerged or not-yet-released PR, e.g. #45242). Both scenarios share the same `winapp ui` drive techniques, helper scripts, per-module profiles, taxonomy, and report format. They differ mainly on **what bits you run**, so the only new content is a thin scenario layer. ## PR Checklist - [ ] **Closes:** N/A (follow-up to the merged `powertoys-verification` skill) - [x] **Communication:** design discussed and agreed before implementation - [x] **Tests:** N/A — docs/skill-only change; validated link/constraint checks (see below) - [x] **Localization:** N/A - [x] **Dev docs:** this PR *is* skill documentation - [x] **New binaries:** none ## Detailed Description of the Pull Request / Additional comments **`SKILL.md` (shared engine)** — broaden `description` + "When to use" to cover both scenarios, add a **Step-0 scenario router** (plus, for B, the bits sub-decision "is the PR's code in the build under test?"), keep the supplied-checklist read **Scenario-A-only**, and make the bootstrap/placeholders/"What NOT to do" scenario-aware. **`references/scenarios/`:** - `index.md` — router table (A/B); the **"bits under test" contract** (the one real conflict: installed-and-immutable, vs build-and-sideload when the PR's code isn't in the build, echoed in the report header so the evidence chain is trustworthy); and a verdict-vocabulary mapping (engine `PASS/FAIL/BLOCKED` <-> legacy labels). - `module-checklist.md` (A) — supplied checklist, installed bits. - `pr-validation.md` (B, **new — merges the former release-PR and active-PR docs**) — derive each PR's checklist from `gh pr view/diff`; the **bits sub-decision**; a **PR-discovery model with a size gate** (auto-verify hotfix-sized sets <=25; for full ~100-PR releases, scope-and-confirm instead of blind-looping) and a non-runtime-PR pre-filter; per-PR folders + roll-up; and the **build + sideload** front-end (in-repo worktree helper + build commands), unpackaged (run the built runner, dismiss the expected partial-build dialogs) vs packaged/CmdPal (`Add-AppxPackage -Register`) deploy recipes, prove-your-bits, and restore-to-shipped cleanup. Removed the separate `release-pr-signoff.md` and `active-pr-validation.md` (folded into `pr-validation.md`). The existing engine docs (`winapp-ui-testing.md`, `pre-flight.md`, `reporting-format.md`), per-module profiles, and helper scripts are reused unchanged — single source of truth. The `BITS:` header version is a `<version>` placeholder (not pinned to a release). ## Validation Steps Performed - `SKILL.md` within authoring limits: **331 lines** (< 500) and **description 999 chars** (< 1024). - All relative markdown links in `references/scenarios/*.md` resolve, and every engine doc they cite exists. - Scenario B exercised end-to-end both ways: the 0.100.1 14-PR sign-off (8 PASS / 6 BLOCKED, installed bits) and PR #45242 (Advanced Paste, 3/3 PASS, build + sideload). --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
|
6b5c21000f |
Align ZoomIt dialog controls (#49210)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This change deals with ZoomIt standalone texts. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
99d01dc37b |
CmdPal: Fix "Open Command Palette" dock item (#49095)
## Summary of the Pull Request This PR fixes the "Open Command Palette" dock item. Dock only opens Command Palette for page commands (see DockControl.InvokeItem). The recent dock home change introduced `GoHomeDockCommand` as an invokable command, so the Palette no longer opened from the dock item. - Restores dock home to use the shared root page. - Adds a deferred root page accessor to avoid DI cycles. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #49089 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
f740d0b3e5 |
Build(deps): Bump actions/dependency-review-action from 4 to 5 (#47907)
Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4 to 5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/dependency-review-action/releases">actions/dependency-review-action's releases</a>.</em></p> <blockquote> <h2>5.0.0</h2> <p>This is a new major version of the Dependency Review Action which updates the runtime to node24. This requires a minimum Actions Runner version <a href="https://github.com/actions/runner/releases/tag/v2.327.1">v2.327.1</a> to run.</p> <h2>What's Changed</h2> <ul> <li>Add .github/copilot-instructions.md for Copilot coding agent by <a href="https://github.com/ahpook"><code>@ahpook</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1067">actions/dependency-review-action#1067</a></li> <li>Update Node.js runtime from 20 to 24 by <a href="https://github.com/scottschreckengaust"><code>@scottschreckengaust</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1084">actions/dependency-review-action#1084</a></li> <li>Bump spdx-license-ids from 3.0.20 to 3.0.23 by <a href="https://github.com/mongolyy"><code>@mongolyy</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1091">actions/dependency-review-action#1091</a></li> <li>docs: bump actions/checkout from v4 to v6 in workflow examples by <a href="https://github.com/Marukome0743"><code>@Marukome0743</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1077">actions/dependency-review-action#1077</a></li> <li>fix: patched version display for advisories with non-strict semver ranges (e.g. Maven beta versions) by <a href="https://github.com/tspascoal"><code>@tspascoal</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1076">actions/dependency-review-action#1076</a></li> <li>Resolve security findings by <a href="https://github.com/AshelyTC"><code>@AshelyTC</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1094">actions/dependency-review-action#1094</a></li> <li>v5.0.0 release branch by <a href="https://github.com/ahpook"><code>@ahpook</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1098">actions/dependency-review-action#1098</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/scottschreckengaust"><code>@scottschreckengaust</code></a> made their first contribution in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1084">actions/dependency-review-action#1084</a></li> <li><a href="https://github.com/mongolyy"><code>@mongolyy</code></a> made their first contribution in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1091">actions/dependency-review-action#1091</a></li> <li><a href="https://github.com/Marukome0743"><code>@Marukome0743</code></a> made their first contribution in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1077">actions/dependency-review-action#1077</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/dependency-review-action/compare/v4.9.0...v5.0.0">https://github.com/actions/dependency-review-action/compare/v4.9.0...v5.0.0</a></p> <h2>Dependency Review Action 4.9.0</h2> <p>This feature release contains a couple of notable changes:</p> <ul> <li>There is a new configuration option <code>show_patched_versions</code> which will add a column to the output, showing the fix version of each vulnerable dependency. Thanks <a href="https://github.com/felickz"><code>@felickz</code></a>!</li> <li>Runs which do not display OpenSSF scorecards no longer fetch scorecard information; previously it was fetched regardless of whether or not it was displayed, causing unneccessary slowness. Great catch <a href="https://github.com/jantiebot"><code>@jantiebot</code></a>!</li> <li>There are a couple of fixes to purl parsing which should improve match accuracy for <code>allow-package-dependency</code> lists, including case (in)sensitivity and url-encoded namespaces Thanks <a href="https://github.com/juxtin"><code>@juxtin</code></a>!</li> </ul> <h2>What's Changed</h2> <ul> <li>Compare normalized purls to account for encoding quirks by <a href="https://github.com/juxtin"><code>@juxtin</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1056">actions/dependency-review-action#1056</a></li> <li>Make purl comparisons case insensitive by <a href="https://github.com/juxtin"><code>@juxtin</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1057">actions/dependency-review-action#1057</a></li> <li>Feat: Add <code>Patched Version</code> to <code>Vulnerabilities</code> summary by <a href="https://github.com/felickz"><code>@felickz</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1045">actions/dependency-review-action#1045</a></li> <li>fix: only get scorecard levels if user wants to see the OpenSSF scorecard by <a href="https://github.com/jantiebot"><code>@jantiebot</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1060">actions/dependency-review-action#1060</a></li> <li>Bump actions/stale from 10.1.0 to 10.2.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a>[bot] in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1058">actions/dependency-review-action#1058</a></li> <li>Bump actions/checkout from 4 to 6 by <a href="https://github.com/dependabot"><code>@dependabot</code></a>[bot] in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1021">actions/dependency-review-action#1021</a></li> <li>Updates for release 4.9.0 by <a href="https://github.com/ahpook"><code>@ahpook</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1064">actions/dependency-review-action#1064</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/jantiebot"><code>@jantiebot</code></a> made their first contribution in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1060">actions/dependency-review-action#1060</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/actions/dependency-review-action/compare/v4.8.3...v4.9.0">https://github.com/actions/dependency-review-action/compare/v4.8.3...v4.9.0</a></p> <h2>4.8.3</h2> <h2>Dependency Review Action v4.8.3</h2> <p>This is a bugfix release that updates a number of upstream dependencies and includes a fix for the earlier feature that detected oversized summaries and upload them as artifacts, which could occasionally crash the action.</p> <p>We have also updated the release process to use a long-lived <code>v4</code> <strong>branch</strong> for the action, instead of a force-pushed tag, which aligns better with git branching strategies; the change should be transparent to end users.</p> <h2>What's Changed</h2> <ul> <li>GitHub Actions can't push to our protected main by <a href="https://github.com/dangoor"><code>@dangoor</code></a> in <a href="https://redirect.github.com/actions/dependency-review-action/pull/1017">actions/dependency-review-action#1017</a></li> <li>Bump actions/stale from 9.1.0 to 10.1.0 by <a href="https://github.com/dependabot"><code>@dependabot</code></a>[bot] in <a href="https://redirect.github.com/actions/dependency-review-action/pull/995">actions/dependency-review-action#995</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
|
dd21dc976f |
Quick Accent: Renormalize CharacterMappings.cs line endings (#49203)
The Belarusian Cyrillic block had a stray line-ending inconsistency in the committed blob that violated the file's .gitattributes (text, eol=crlf). This caused git to report the file as perpetually modified since clean(blob) != blob, so it could never be restored to a clean working tree. <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
bd025098c6 |
Move wiki triage queries into the repo (#48744)
Consolidates the **Triage-queries** and **Common-Triage-Issue** wiki pages into a single \doc/devdocs/triage-queries.md\ file so the content lives in the repository instead of the wiki. - Merged both pages into one document - Dropped empty sections (Advanced Paste, New+, Workspaces) - Minor formatting cleanup --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
|
15cb76f9b8 |
Fix dev setup .vsconfig component IDs for Visual Studio 2026 (#48824)
## Summary Fixes #48778 — the automated developer setup (`winget configure .config\configuration.winget`) provisions **Visual Studio 2026** but feeds it a `.vsconfig` containing **Visual Studio 2022-era component IDs** that were renamed or removed in VS 2026. The `VSComponents` DSC resource silently skips the invalid IDs, so the **Windows 11 SDK (26100)** and **WindowsAppSDK C# support** never install — breaking the build with cppwinrt (exit code 3) and WindowsAppSDK target failures, exactly as reported. ## Root cause PR #45534 bumped `.config/configuration.winget` from VS 2022 → VS 2026 (`Microsoft.VisualStudio.Community`, `channelId: VisualStudio.18.Release`) but left `.vsconfig` untouched. Five component IDs in `.vsconfig` are invalid in the VS 2026 (Dev18) catalog: | `.vsconfig` (old, VS 2022) | VS 2026 reality | |---|---| | `Component.Windows10SDK.22621` | renamed → `Component.Windows11SDK.22621` | | `Component.Windows10SDK.26100` | renamed → `Component.Windows11SDK.26100` (the build's target SDK) | | `ComponentGroup.WindowsAppSDK.Cs` | renamed → `WindowsAppSdkSupport.CSharp` | | `Component.Windows10SDK.19041` | removed from VS 2026 (only a `WindowsTargetPlatformMinVersion` floor — never a real install requirement) | | `Component.Windows10SDK.20348` | removed from VS 2026 (not referenced by the build) | A single `.vsconfig` is the source of truth for all three winget variants (`configuration.winget`, `configuration.vsProfessional.winget`, `configuration.vsEnterprise.winget`), which reference it via `${WinGetConfigRoot}\..\.vsconfig`, so this one edit fixes every automated path. ## Changes - `Windows10SDK.22621/26100` → `Windows11SDK.22621/26100` - `ComponentGroup.WindowsAppSDK.Cs` → `WindowsAppSdkSupport.CSharp`, and added `WindowsAppSdkSupport.Cpp` (PowerToys' C++/WinRT projects need it) - Removed `Windows10SDK.19041` and `Windows10SDK.20348` - `doc/devdocs/readme.md`: corrected the `10.0.22621.0` SDK label from "Windows 10 SDK" to "Windows 11 SDK" ## Validation - All 18 resulting component IDs validated against a live VS 2026 (18.7.0) installation via `vswhere -include packages` — all present/valid. - `.vsconfig` parses as valid JSON. - Build target requirements confirmed from `Cpp.Build.props` (`WindowsTargetPlatformVersion = 10.0.26100.0`, min `10.0.19041.0`) and `Common.Dotnet.CsWinRT.props`. ## Notes The docs still list "VS 2022 17.4+" as an alternative; this `.vsconfig` is aligned to the recommended/automated VS 2026 path. The VS Installer treats any unrecognized component IDs in `.vsconfig` gracefully (shown as unavailable, non-blocking) for VS 2022 users. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
|
b3a3c132da |
Add Shortcut Guide manifest for ON1 Photo RAW (#49143)
Adds a Shortcut Guide keyboard shortcut manifest for ON1 Photo RAW. ON1 Photo RAW has no WinGet package, so the manifest uses the `+` prefix convention. ## Summary of the Pull Request New manifest file `+ON1.PhotoRAW.en-US.yml` targeting `ON1PhotoRAW.exe` with 71 shortcuts across 9 sections: - **Module navigation** — Browse (G), Develop (D), Effects (S), Portrait (I), Local Adjustments (A), Resize (Y) - **File operations** — Undo, Redo, Quick export, Print, Quit - **Image navigation** — Zoom in/out, Fit to screen, 100% zoom, Pan - **View** — Grid/Photo/Filmstrip/Compare views, panel toggles, split-screen compare, original view toggle - **Browse module** — Folder browsing, selection, ratings (1–5), like/dislike flags, delete - **Editing settings** — Rotate, reset/copy/paste/sync settings, create version - **Tools** — Crop, Adjustment brush, Adjustable gradient, Perfect Eraser, Retouch, Clone stamp, Masking brush, Gradient mask, Refine mask, Zoom/Pan, Move/Transform, Text - **Brush adjustments** — Size, feather, opacity controls; Perfect Brush toggle; paint-in/out - **Masking** — Invert mask, show/hide mask, show clipping ## PR Checklist - [ ] Closes: #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments ON1 Photo RAW has no WinGet package entry, so the manifest ID is prefixed with `+` per the [keyboard shortcuts schema spec](doc/specs/WinGet%20Manifest%20Keyboard%20Shortcuts%20schema.md). The executable name `ON1PhotoRAW.exe` is consistent across yearly releases (the installation folder changes per year, but the binary name does not). Shortcut data sourced from the [official ON1 keyboard shortcuts reference](https://www.on1.com/bookshelf/photo-raw-keyboard-shortcuts/). ## Validation Steps Performed - YAML parsed successfully with Python `yaml.safe_load` - Structure verified against existing manifests (same field names, casing conventions, key notation) --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> |
||
|
|
13835c1931 |
[Deps] Update .NET packages from 10.0.8 to 10.0.9 (#48568)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request Updates `Directory.Packages.props` to align several Microsoft and System package references from `10.0.8` to `10.0.9`. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [x] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments Bumped dependency versions for the following packages: - `Microsoft.Data.Sqlite` - `Microsoft.Bcl.AsyncInterfaces` - `Microsoft.Extensions.Caching.Abstractions` - `Microsoft.Extensions.Caching.Memory` - `Microsoft.Extensions.DependencyInjection` - `Microsoft.Extensions.Logging` - `Microsoft.Extensions.Logging.Abstractions` - `Microsoft.Extensions.Hosting` - `Microsoft.Extensions.Hosting.WindowsServices` - `Microsoft.Win32.SystemEvents` - `Microsoft.Windows.Compatibility` - `System.CodeDom` - `System.ComponentModel.Composition` - `System.Configuration.ConfigurationManager` - `System.Data.OleDb` - `System.Diagnostics.EventLog` - `System.Diagnostics.PerformanceCounter` - `System.Drawing.Common` - `System.Management` - `System.Runtime.Caching` - `System.ServiceProcess.ServiceController` - `System.Text.Encoding.CodePages` - `System.Text.Json` <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed - Verified the version-only dependency update in `Directory.Packages.props` |
||
|
|
889860ec49 |
fix: Peek.UI persists as a media player after closed & redundant SMTC… (#46899)
… control for audio preview <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request [Peek] Fix https://github.com/microsoft/PowerToys/issues/26755 and remove redundant SMTC control for audio preview. 1. If it is not a media file, the Hardware Media Key UI will not be displayed. 2. When navigating between files using the arrow keys, only media files display the Hardware Media Key UI. 3. After the Peek window is closed, the Hardware Media Key UI disappears. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #26755 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [x] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Manually verified: When peeking at media and non-media files, navigating between different types of files using the arrow keys, and closing the Peek window, the Hardware Media Key UI all works as expected. Co-authored-by: Muyuan Li (from Dev Box) <muyuanli@microsoft.com> |
||
|
|
7306acdc3b |
CmdPal: compact is supposed to be off by default (#49186)
Title. It should be off by default. Oops. |
||
|
|
74e6c3ad79 |
[UITests] New framework around WinApp CLI, no WinAppDriver or Selenium. (#48467)
# Add winappcli-based UI test harness (no WinAppDriver / Selenium) ## Summary Introduces a new UI test harness — `Microsoft.PowerToys.UITest.Next` — that drives PowerToys modules through Microsoft's [winappcli](https://github.com/microsoft/WinAppCli) (UI Automation CLI) instead of WinAppDriver + Selenium. Engine is a single executable shelled out from C#; no third-party NuGet packages, no driver process, no Appium server. Adds two real consumers: a full ColorPicker end-to-end scenario and a Settings shell navigation smoke test. This is opt-in and additive — the existing `UITestAutomation` library and the WinAppDriver-based test projects are untouched. Both can coexist while we evaluate the new harness. Inspired in part by [#48414](https://github.com/microsoft/PowerToys/pull/48414), which lands the same architectural bet (winappcli, AutomationId selectors, no WinAppDriver) at a smaller scope. This PR generalizes it into a reusable library. ## Why WinAppDriver + Selenium is a legacy pre-agentic solution that is no longer actively maintained. It's unreliable, heavyweight, and slow. To achieve 100% UI test coverage, we should leverage modern, reliable solutions, and WinApp CLI is a strong candidate. ## What's in this PR ### Harness library — [`src/common/UITestAutomation.Next/`](src/common/UITestAutomation.Next/) | File | Purpose | |---|---| | [`WinappCli.cs`](src/common/UITestAutomation.Next/WinappCli.cs) | Process wrapper around `winapp.exe`. `Invoke` / `InvokeAssertSuccess` / `InvokeJson` / `IsAvailable` / `TryResolveExecutable`. `Result` carries the args and emits `DescribeFailure()` like `winapp ui invoke X -w 12345 -> exit 1; stderr: ...` | | [`Session.cs`](src/common/UITestAutomation.Next/Session.cs) | Test session, scoped by either HWND (`-w`) or process (`-a`) via `TargetScope`. `Find<T>` / `FindAll<T>` / `Inspect` / `Screenshot` / `SendKeys`. `Session.FromProcess(...)` factory for the single-window-per-process case | | [`SessionHelper.cs`](src/common/UITestAutomation.Next/SessionHelper.cs) | Owns the launch + window-readiness flow. Static `EnsureRunning(scope, timeout)` returns whether the call had to launch (so cleanup only kills what we started). Uses `UseShellExecute=true` so child handles don't keep MSTest hanging | | [`UITestBase.cs`](src/common/UITestAutomation.Next/UITestBase.cs) | MSTest base class. Pre-flights `WinappCli.IsAvailable()` once per process and fails fast with the install hint if `winapp.exe` isn't on PATH | | [`Element/*.cs`](src/common/UITestAutomation.Next/Element/) | `Element`, `Button`, `ToggleSwitch`, `TextBox`, `NavigationViewItem`, `Window`. `Click` / `MouseClick` / `Focus` / `GetProperty` / `GetValue` / `HelpText` / `WaitForProperty` / `WaitForGone` plus coords (`X`/`Y`/`Width`/`Height`) | | [`By.cs`](src/common/UITestAutomation.Next/By.cs) | `By.Name` / `By.AccessibilityId` / `By.Id` / `By.Slug` | | [`Windows.cs`](src/common/UITestAutomation.Next/Windows.cs) | `WindowsFinder.ListAll` / `ListByApp` / `WaitForWindowByApp` / `WaitForWindowByProcess`. Notes the winappcli bug where unfiltered `list-windows` drops untitled windows | | [`WindowControl.cs`](src/common/UITestAutomation.Next/WindowControl.cs) | Tolerant Win32 helpers — `TryCloseByApp` / `TryFocusByApp` / `SafeCloseAndFocus` / `TryKillProcess` — for `finally` blocks | | [`KeyboardHelper.cs`](src/common/UITestAutomation.Next/KeyboardHelper.cs) | Hybrid `keybd_event` + `SendKeys.SendWait` chord sender — required for global PowerToys hotkeys | | [`MouseHelper.cs`](src/common/UITestAutomation.Next/MouseHelper.cs) | `MoveTo` / `LeftClick` / `RightClick` / `LeftClickAt` Win32 wrappers | | [`ClipboardHelper.cs`](src/common/UITestAutomation.Next/ClipboardHelper.cs) | STA-thread `Clipboard` access with `WaitForText` | | [`ModuleConfigData.cs`](src/common/UITestAutomation.Next/ModuleConfigData.cs) | `PowerToysModule` enum + path/process-name resolution | ### Tests **[`src/modules/colorPicker/ColorPicker.UITests/`](src/modules/colorPicker/ColorPicker.UITests/)** — replaces the previous empty `UITest-ColorPicker` stub. One test, [`ColorPickerEndToEndTests.NavigateReadShortcutActivateAndCapture`](src/modules/colorPicker/ColorPicker.UITests/ColorPickerEndToEndTests.cs), drives the full E2E: 1. Navigate to the Color Picker page via the dashboard utilities stack 2. Toggle the module OFF, verify `PowerToys.ColorPickerUI` exits; toggle ON, verify it respawns 3. Read the activation shortcut from the page's `ShortcutControl` (`EditButton.HelpText`) 4. Clear clipboard, park cursor, send the chord 5. Wait for the picker overlay window 6. Read the displayed HEX from a hidden XAML automation peer (see below) 7. Left-click to capture; assert the clipboard value matches the peer's HEX 8. Wait for the editor window and assert the captured color appears in its tree **[`src/settings-ui/Settings.UITests/`](src/settings-ui/Settings.UITests/)** — `SettingsNavigationSmokeTests.NavigationItem_NavigatesWithoutCrashing` is one `[TestMethod]` parameterized with `[DynamicData]`, producing 31 discrete results — one per `NavigationViewItem` in [`ShellPage.xaml`](src/settings-ui/Settings.UI/SettingsXAML/Views/ShellPage.xaml). For each item: navigate, settle 250ms, assert `PowerToys.Settings` is still alive. Catches FailFast regressions in `ShellViewModel.Frame_NavigationFailed` that pure-logic unit tests can't reach (the failure path needs a `NavigationFailedEventArgs` which is a sealed WinRT projection). ### Product change **[`src/modules/colorPicker/ColorPickerUI/Views/MainView.xaml`](src/modules/colorPicker/ColorPickerUI/Views/MainView.xaml)** — adds a hidden `TextBlock` automation peer: ```xml <TextBlock x:Name="ColorHexAutomationPeer" AutomationProperties.AutomationId="ColorHexAutomationPeer" IsHitTestVisible="False" Opacity="0" Text="{Binding ColorText}" /> ``` The visible `ColorTextBlock` has `AutomationProperties.Name="{Binding ColorName}"`, which masks the HEX value in the UIA tree (you see "White" instead of `#FFFFFF`). This zero-impact peer mirrors `ColorText` so tests can read the actually-displayed HEX. `Opacity=0` + `IsHitTestVisible=False` keep it out of the visual layout and out of accessibility focus. ### Project wiring - [`PowerToys.slnx`](PowerToys.slnx) — registers `UITestAutomation.Next` under `/common/`, `ColorPicker.UITests` under `/modules/colorpicker/Tests/`, and `Settings.UITests` under `/settings-ui/Tests/`. Original `UITest-ColorPicker` stub csproj removed. - [`.github/actions/spell-check/expect.txt`](.github/actions/spell-check/expect.txt) — adds `winapp` / `winappcli`. ### Not in this PR - No pipeline changes. `winapp.exe` is expected to be pre-staged on the test agent image. If it's missing, `UITestBase` fails the first test with the install hint (`winget install Microsoft.winappcli`) rather than producing 30 opaque per-test errors. - No changes to the legacy `UITestAutomation` library or any of the existing `*.UITests` projects. ## Validation - All three projects build clean on `x64|Debug` (empty `build.<config>.<plat>.errors.log`): - `src/common/UITestAutomation.Next/` - `src/modules/colorPicker/ColorPicker.UITests/` - `src/settings-ui/Settings.UITests/` - Both tests run in Test Explorer / `dotnet test` via Microsoft.Testing.Platform (already enabled repo-wide in `Directory.Build.props`). - Local runs: ColorPicker E2E green; Settings smoke green across all 31 nav items. - `winapp 0.3.2` from `winget install Microsoft.winappcli`. ## Notes for reviewers - **`UseShellExecute = true`** in `SessionHelper.EnsureRunning` is intentional — `false` makes child processes inherit the test host's stdin/stdout/stderr handles, which keeps MTP/Test Explorer marking the run as "in progress" until the spawned PowerToys exits. - **Process-scope (`-a`) targeting** in the Settings smoke test handles single-instance handoff: the EXE you launch may exit with code 0 immediately after signalling an existing owner, so the alive check uses `Process.GetProcessesByName` rather than the launcher PID. - **AutomationId-only selectors** in the Settings smoke list keep the test localization-independent. Parent groups have `SelectsOnInvoked="False"` and only expand on click — `Element.Click` tries `InvokePattern → TogglePattern → SelectionItemPattern → ExpandCollapsePattern` so the same call works for both leaves and groups. - **Untitled-window discovery**: filtered `winapp ui list-windows -a <name>` returns windows that the unfiltered call drops (e.g. ColorPicker editor). `WindowsFinder.ListByApp` uses the filtered form. Reported upstream. ## Before Merge - Add the `winappcli` install step to the UI-test pipeline. |
||
|
|
f5c6f50e30 |
[Quick Accent] Add Belarusian Latin and Belarusian Cyrillic character sets (#48344)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This PR adds support for Łacinka (Belarusian Latin) and Belarusian Cyrillic character sets to Quick Accent. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #36571 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [x] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments This is a standard character set addition, with new entries in the Language enum, the sets themselves added to CharacterMappings.All and new resource strings for the user-facing names in the Settings page. <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed (Manual tests.) - Confirmed that the new character set entries were present in the Quick Accent settings page list. - Tested that each of the characters in both the sets could be selected and typed. |
||
|
|
3ab6e182f8 |
CmdPal: fix the HWND frame on compact mode (#49184)
Admittedly, LLM discovered fix here. The window frame for compact mode in cmdpal is very very wackadoodle. User32 is dark and full of terrors, especially when we're trying to both keep the original resize handles but also make them hidden from view. TIL about [`RedrawWindow`](https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-redrawwindow), which if you slather that about, helps make sure that the window frame is correctly repainted by DWM as transparent. The repro for this before was easy to see with a debug build with the debugger attached: * open cmdpal * make sure the frame is gone and the cmdpal window is focused * click on another window * PRESTO, window frame is back by adding more RedrawWindow calls, we can make sure that our frame is correctly erased even when DWM wants to put it back. Closes: oh no one filed this? |
||
|
|
c1ef511697 |
CmdPal: Add keyboard shortcuts to manually expand compact mode palette (#49177)
## Summary of the Pull Request This PR adds support for new keyboard shortcuts to expand CmdPal when in Compact mode. Both of them are "natural" - Down arrow key - Tab key <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #49112 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
188f6a58a8 |
CmdPal: Stop item action being executed when CmdPal is compact and collapsed (#49182)
## Summary of the Pull Request This PR prevents Command Palette in collapsed compact mode executing actions on a selected item. Since user is not aware what item is selected or what action are |
||
|
|
9449ae3686 |
Fix dock clock: show seconds, fix stale display, a11y (#48253)
Fixes the Command Palette Dock clock/date extension which showed time ~1 minute late and did not display seconds (unlike the taskbar clock). The problem was that `timeExtended` was hardcoded `false` in `NowDockBand.UpdateText()`. Fixed that by passing `true` to `TimeAndDateHelper.GetStringFormat()`, selecting the `"T"` (long time) format which includes seconds. Also, changed from using `PropertyChanged` on `Title` to using `RaiseItemsChanged` to mimic the behavior used for updating in the Performance Monitor extension. Fixes #46192 --------- Co-authored-by: root <root@io.bbq> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Hawk <hawk@example.com> |
||
|
|
a32c75928b |
CmdPal: Avoid unnecessary handler runs on settings changes (part 1) (#49171)
## Summary of the Pull Request This PR stops Command Palette subscribers from re-running their full hot-reload path on every SettingsChanged event. Previously any settings edit re-registered hotkeys, rebuilt the backdrop, and tore down/recreated dock windows even when nothing the subscriber consumed had changed. - `MainWindow`: added `MainWindowSettingsComparer `(IEqualityComparer<SettingsModel>); skips HotReloadSettings unless a consumed setting changed. - `DockWindowManager`: OnSettingsChanged bails unless EnableDock/DockSettings changed; monitor-topology path still always syncs. - `DockWindow `/ `DockViewModel`: guard reloads with _settings == args.DockSettings. - `DockSettings `/ `DockMonitorConfig`: list backing fields now use a new EquatableList<T> wrapper, giving record equality content-based (not reference-based) list comparison so guards hold after a reload rebuilds the lists. - Tests: EquatableListTests and DockSettingsEqualityTests cover the wrapper and structural DockSettings equality. - Public API and persisted JSON contract unchanged (EquatableList<T> is backing-field only; properties still expose ImmutableList<T>). <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #49168 - [ ] <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
c7e53c6ad9 |
CmdPal: Fix issues related to deferred loading of pages in Compact mode (#49165)
## Summary of the Pull Request This PR fixes a navigation issue in Compact mode. When Compact mode is enabled, the frame might not always load the page right away, so the attached behavior does not trigger. - Search box visibility update - Search box visibility is now reliably re-evaluated when navigating to the home page. Until now, it was handled in the `Loaded` event handler, but since that is deferred in Compact mode, it was not evaluated in time and blocked the app. - A11Y announcements after navigation - Navigation announcements are now more consistent and reliable. As in the previous point, the announcement was previously triggered by the `Loaded` event. - Adds a note mentioning FocusState.Keyboard to Narrator annoucements. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #49116 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
52df5882a3 |
CmdPal: For each single-metric band, add a matching band in softdisabled state (#49162)
## Summary of the Pull Request This PR updates Performance Monitor safe mode to add a placeholder page for each Dock band that is available in normal mode. This way, when Performance Monitor is soft-disabled, the user still sees the Dock band and is informed that it is disabled. This PR does not fix the missing battery Dock band, since that should be moved to a separate extension soon(TM). ## Pictures? Pictures! <img width="1022" height="134" alt="image" src="https://github.com/user-attachments/assets/12bd33e6-041f-4f36-ad22-ed8287f19a3e" /> <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Related to: #49159 - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
0790674ddf |
CmdPal: Subscribe DetailsViewModel to PropChanged for live pane updates (#48070)
## Summary Fixes #47745 — the details pane now updates live when an extension modifies its `IDetails` properties (Title, Body, HeroImage, Metadata) after initial display. ## Changes ### `DetailsViewModel.cs` - Subscribe to `INotifyPropChanged` at construction (runtime check, since `IDetails` doesn't require it) - `Model_PropChanged` → `FetchProperty` with switch on Title, Body, HeroImage, Metadata - `RebuildMetadata` rebuilds the metadata list from the model - `UnsafeCleanup` unsubscribes from PropChanged ### `ListItemViewModel.cs` - Call `Details?.SafeCleanup()` before replacing the DetailsViewModel in `FetchProperty("Details")`, ensuring the old subscription is cleaned up. ### `DetailsViewModelTests.cs` (new) - 6 unit tests covering PropChanged subscription, property updates, metadata rebuild, cleanup/unsubscribe, and non-observable IDetails handling. --------- Co-authored-by: root <root@io.bbq> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> |
||
|
|
fb656bf040 |
Add Launchy to third-party Run plugins (#49080)
## Summary of the Pull Request Adds Launchy to the third-party PowerToys Run plugins list. Launchy is a community PowerToys Run plugin that indexes and launches files from user-configured folders with per-folder extension, recursion depth, and folder inclusion rules. ## PR Checklist - [ ] Closes: #xxx - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [x] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments This updates the existing third-party PowerToys Run plugins list with a link to the Launchy plugin repository. No product code is changed. ## Validation Steps Performed - Verified the Launchy repository is public. - Verified the plugin README includes installation, usage, settings, screenshots, and release assets. - Verified this PR only changes doc/thirdPartyRunPlugins.md. --------- Co-authored-by: PsychodelEKS <konstantin.efremov@clickio.com> |
||
|
|
b329b3f243 |
Shortcut Guide: Add keyboard shortcut manifest for new Outlook (olk.exe) (#48821)
## Summary of the Pull Request Shortcut Guide had no manifest for the new Outlook for Windows app, so it showed no shortcuts when `olk.exe` was the foreground process. Adds a new YAML manifest (`Microsoft.OutlookForWindows.en-US.yml`) with `WindowFilter: "olk.exe"` covering email, navigation, text editing, formatting, and calendar shortcuts. ## PR Checklist - [ ] Closes: #48798 - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments New file: `src/modules/ShortcutGuide/ShortcutGuide.Ui/Assets/ShortcutGuide/Manifests/Microsoft.OutlookForWindows.en-US.yml` - **PackageName:** `Microsoft.OutlookForWindows` (WinGet package ID) - **WindowFilter:** `olk.exe` — process name for the new Outlook app (distinct from classic `outlook.exe`) - **Display name:** `Outlook (new)` - **Shortcut categories:** Frequently used · Navigate Outlook · Text editing · Format text · Calendar The `.csproj` already globs `Assets\ShortcutGuide\Manifests\*.yml`, so no project file changes are needed. ## Validation Steps Performed - Verified the YAML structure matches existing manifests (e.g., `Microsoft.Outlook.en-US.yml`). - Confirmed `olk.exe` is the correct process name for new Outlook for Windows. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> |
||
|
|
b6f0a7ae91 |
Add Shortcut Guide manifest for the Godot editor (#48959)
## Summary of the Pull Request
Adds bundled Shortcut Guide support for the Godot editor so Godot
shortcuts can appear when `Godot.exe` is the active app.
- **Shortcut Guide manifest**
- Added `+Godot.Godot.en-US.yml` under the bundled Shortcut Guide
manifests
- Uses the no-WinGet-package Godot editor identity expected by Shortcut
Guide:
```yml
PackageName: +Godot.Godot
WindowFilter: "Godot.exe"
```
- **Shortcut coverage**
- Includes the reporter-provided Godot editor mappings across core
editor workflows, panels, 2D/3D editors, text editor, and project
manager
- **Schema compliance**
- Uses spec-compliant bracketed literal digit tokens such as `"<0>"`
- Uses spec-compliant bracketed special key tokens such as `"<Tab>"`,
`"<Space>"`, `"<Insert>"`, `"<Delete>"`, `"<Escape>"`, `"<PageUp>"`, and
`"<PageDown>"`
## PR Checklist
- [ ] **Communication:** I've discussed this with core contributors
already. If the work hasn't been agreed, this work might be rejected
- [ ] **Tests:** Added/updated and all pass
- [x] **Localization:** All end-user-facing strings can be localized
- [ ] **Dev docs:** Added/updated
- [ ] **New binaries:** Added on the required places
- [ ] [JSON for
signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json)
for new binaries
- [ ] [WXS for
installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs)
for new binaries and localization folder
- [ ] [YML for CI
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml)
for new test projects
- [ ] [YML for signed
pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml)
- [ ] **Documentation updated:** If checked, please file a pull request
on [our docs
repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys)
and link it here: #xxx
## Detailed Description of the Pull Request / Additional comments
Shortcut Guide already copies all bundled manifest assets at startup and
builds its app index from those files. This change only extends that
manifest set with a Godot definition and aligns the manifest data with
the keyboard shortcuts schema; no runtime logic changed.
## Validation Steps Performed
- Parsed the new `+Godot.Godot.en-US.yml` file to verify YAML validity
and required top-level fields
- Confirmed the manifest targets `Godot.exe` and contains the expected
`+Godot.Godot` package identity
- Confirmed literal digit shortcuts use bracketed tokens like `"<0>"`
- Confirmed special keys use bracketed schema-compliant tokens where
applicable
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
|
||
|
|
3df0535473 |
Add Obsidian manifest for Shortcut Guide (#48960)
## Summary of the Pull Request Adds built-in Shortcut Guide support for Obsidian by shipping an app manifest keyed to `Obsidian.exe`. This lets Shortcut Guide recognize Obsidian as the foreground app and show a curated set of common Obsidian shortcuts. Closes: #48596 ## PR Checklist - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments - **Shortcut Guide manifest** - Adds `src/modules/ShortcutGuide/ShortcutGuide.Ui/Assets/ShortcutGuide/Manifests/Obsidian.Obsidian.en-US.yml` - Uses `PackageName: Obsidian.Obsidian` - Matches the app via `WindowFilter: "Obsidian.exe"` - **Curated Obsidian shortcuts** - Adds common shortcuts across: - Navigation - Tabs - Editing - Includes key Obsidian actions such as command palette, quick switcher, tab navigation, reading/editing mode toggle, and core editing commands - **No code-path changes** - This is a data-only addition that plugs into the existing manifest-driven Shortcut Guide app support ```yml PackageName: Obsidian.Obsidian Name: Obsidian WindowFilter: "Obsidian.exe" BackgroundProcess: false ``` ## Validation Steps Performed - Verified the new manifest is the only repository change - Parsed the new manifest structure successfully - Confirmed the manifest follows existing Shortcut Guide key/token conventions used by other bundled app manifests --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> |
||
|
|
23a26428d3 |
Grab And Move mod click passthrough (#49121)
This lets Alt/Win + click/rclick (no drag) go through if no mouse movement is recorded. Now the target window goes either into the "all clicks go through" or "all clicks are considered resizes/moves" based on whether the first mouse action after the modifier is pressed is a click or the beginning of a mouse drag action. <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
6da052247f |
CmdPal: Prevent stealing focus from other apps (#49087)
## Summary of the Pull Request
Gate search bar focus updates so they only run when the window is
visible.
The search bar can update its focus after context changes, but that
update may be dispatched after the window has already been hidden. In
that case, focusing the search box can bring the window back into focus
and steal focus from another app.
This change prevents the focus update from running when the owning
window is no longer visible.
Also as a flyby, `FocusSearchBoxMessage` is now handled by the ShellPage
instead of SearchBar, and goes through the same gate.
Regressed with the new token based params
(
|
||
|
|
cccd2b7510 |
GrabAndMove drag maximized windows relative to the click point (#49118)
This aligns the behavior with resize. <!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request When grabbing and moving a maximized icon, the old behavior was to first restore the window with its title bar under the cursor, then proceed with the move. Now the window is restored and moved proportionally around the cursor, exactly like in the case of the grab and resize behavior. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [ ] Closes: #xxx <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed Ensure the window geometry/coordinates change exactly the same as for grab and resize on it, when starting from a maximized state. |
||
|
|
e4ef90d168 |
[Peek] Options for AlwaysOnTop and ShowOnTaskbar (#44645)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request * Add the option for Peek to allow the window to be always on top * Add the option for Peek to allow to not show its icon on the taskbar <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #26274 - [x] Closes: #43093 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [x] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [x] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: https://github.com/MicrosoftDocs/windows-dev-docs/pull/5824 <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments AlwaysOnTop defaults to `false`, and ShowOnTaskbar defaults to `true` to match the current behavior. Peek settings after the change: <img width="1642" height="714" alt="image" src="https://github.com/user-attachments/assets/e9c8b390-8a8b-40aa-8990-c671b1fffd96" /> Peek window behavior with AlwaysOnTop set to `true` and ShowOnTaskbar set to `false`: <img width="1813" height="1161" alt="image" src="https://github.com/user-attachments/assets/e5fbda14-0ba8-4a70-840c-2e8493b7d920" /> <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed 1. Start PowerToys with Peek enabled 2. In settings, turn off close window on focus loss for ease of validation 3. Peek something 4. Turn on always on top, observe the window is now always on top 5. Turn off always on top, observe the window is no longer always on top 6. Turn off show icon on taskbar, observe the icon disappeared immediately from the taskbar 7. Turn on show icon on taskbar, observe the icon re-appeared on the taskbar |
||
|
|
e0fe3c48cf |
CmdPal: Stretch main window card vertically when in expanded mode (#49109)
## Summary of the Pull Request This PR updates the behavior of CmdPal's main window in expanded (non-compact) mode to match the previous behavior. The page content now stretches across the entire window instead of collapsing to the actual content height. <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #48872 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
029dd04ce4 |
CmdPal: Fix compact mode not toggling the list/command bar at runtime (#49111)
<!-- Enter a brief description/summary of your PR here. What does it fix/what does it change/how was it tested (even manually, if necessary)? --> ## Summary of the Pull Request This PR hooks `ShellPage` to `ISettingsService` and triggers update of expanded state when the Compact mode settings is changed. Toggling the compact-mode setting while the palette was open neverre-evaluated `ShellPage.ExpandedMode`, so disabling compact mode left the palette collapsed (only the search box visible). <!-- Please review the items on the PR checklist before submitting--> ## PR Checklist - [x] Closes: #48933 <!-- - [ ] Closes: #yyy (add separate lines for additional resolved issues) --> - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx <!-- Provide a more detailed description of the PR, other things fixed, or any additional comments/features here --> ## Detailed Description of the Pull Request / Additional comments <!-- Describe how you validated the behavior. Add automated tests wherever possible, but list manual validation steps taken as well --> ## Validation Steps Performed |
||
|
|
3d3cef73da |
Add Zoom Workspace keyboard shortcut manifest for Shortcut Guide (#49062)
## Summary of the Pull Request Adds a new Shortcut Guide manifest for Zoom Workspace so Zoom-specific shortcuts are available in the overlay when `zoom.exe` is active. The manifest follows existing in-repo schema and naming conventions for app-specific keyboard shortcut files. ## PR Checklist - [ ] **Communication:** I've discussed this with core contributors already. If the work hasn't been agreed, this work might be rejected - [ ] **Tests:** Added/updated and all pass - [ ] **Localization:** All end-user-facing strings can be localized - [ ] **Dev docs:** Added/updated - [ ] **New binaries:** Added on the required places - [ ] [JSON for signing](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ESRPSigning_core.json) for new binaries - [ ] [WXS for installer](https://github.com/microsoft/PowerToys/blob/main/installer/PowerToysSetup/Product.wxs) for new binaries and localization folder - [ ] [YML for CI pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/ci/templates/build-powertoys-steps.yml) for new test projects - [ ] [YML for signed pipeline](https://github.com/microsoft/PowerToys/blob/main/.pipelines/release.yml) - [ ] **Documentation updated:** If checked, please file a pull request on [our docs repo](https://github.com/MicrosoftDocs/windows-uwp/tree/docs/hub/powertoys) and link it here: #xxx ## Detailed Description of the Pull Request / Additional comments - **Manifest addition** - Added `src/modules/ShortcutGuide/ShortcutGuide.Ui/Assets/ShortcutGuide/Manifests/Zoom.Zoom.en-US.yml`. - Targets `WindowFilter: "zoom.exe"` with `PackageName: Zoom.Zoom`. - **Shortcut coverage** - Added high-value Zoom shortcuts grouped by section: - `General` - `View` - `Meeting controls` - Includes core actions such as mute/unmute, start/stop video, share, full-screen, and meeting exit. - **Schema alignment** - Uses existing Shortcut Guide manifest structure (`SectionName` / `Properties` / `Shortcut`) and key token conventions already used in adjacent manifests. ```yaml PackageName: Zoom.Zoom Name: Zoom Workspace WindowFilter: "zoom.exe" BackgroundProcess: false ``` ## Validation Steps Performed - Manifest content was kept within existing Shortcut Guide manifest schema and repository conventions for built-in app manifests. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> |