Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-04-03 09:46:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

[Wox.Plugin] Enable analyzer and fix warnings (#16547)

Browse Source
This commit is contained in:
CleanCodeDeveloper
2022-03-08 17:46:36 +01:00
committed by GitHub
parent 9cf39654d9
commit ec3ea5c4ae
4 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/modules/launcher/Wox.Plugin/Common/DefaultBrowserInfo.cs
View File

@@ -187,7 +187,7 @@ namespace Wox.Plugin.Common
if (string.IsNullOrEmpty(Path))
{
throw new Exception("Browser path is null or empty.");
throw new ArgumentOutOfRangeException(nameof(Path), "Browser path is null or empty.");
}
}
catch (Exception e)
@@ -217,7 +217,7 @@ namespace Wox.Plugin.Common
return stringBuilder.ToString();
}
throw new Exception("Could not load indirect string.");
throw new ArgumentNullException(nameof(Path), "Could not load indirect string.");
}
}
}

4
src/modules/launcher/Wox.Plugin/Common/Win32/NativeMethods.cs
View File

@@ -801,9 +801,9 @@ namespace Wox.Plugin.Common.Win32
return !r1.Equals(r2);
}
public bool Equals(RECT r)
public bool Equals(RECT other)
{
return r.Left == Left && r.Top == Top && r.Right == Right && r.Bottom == Bottom;
return other.Left == Left && other.Top == Top && other.Right == Right && other.Bottom == Bottom;
}
public override bool Equals(object obj)

2
src/modules/launcher/Wox.Plugin/Constant.cs
View File

@@ -18,7 +18,7 @@ namespace Wox.Plugin
{
if (obj == null)
{
throw new NullReferenceException();
throw new ArgumentNullException(nameof(obj));
}
else
{

2
src/modules/launcher/Wox.Plugin/Wox.Plugin.csproj
View File

@@ -14,6 +14,8 @@
<AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>
<Platforms>x64</Platforms>
<NeutralLanguage>en-US</NeutralLanguage>
<EnableNETAnalyzers>true</EnableNETAnalyzers>
<AnalysisMode>Recommended</AnalysisMode>
</PropertyGroup>