Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-02-23 19:49:43 +01:00
Code Issues Packages Projects Releases Wiki Activity

Implement failure handling in ExecuteUpdatesAsync: limit retries to 3 and log errors for unsupported hardware features.

Browse Source
This commit is contained in:
Yu Leng (from Dev Box)
2025-10-17 17:39:32 +08:00
parent 08c324f17f
commit c2d82a72ca
1 changed files with 30 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/modules/powerdisplay/PowerDisplay/Helpers/MonitorPropertyManager.cs
View File

@@ -78,6 +78,9 @@ namespace PowerDisplay.Helpers
/// </summary>
private async Task ExecuteUpdatesAsync(Func<int, CancellationToken, Task<bool>> updateAction)
{
int consecutiveFailures = 0;
const int MaxConsecutiveFailures = 3; // 最多连续失败3次就放弃
while (true)
{
int valueToApply;
@@ -109,17 +112,40 @@ namespace PowerDisplay.Helpers
_currentValue = valueToApply;
}
ManagedCommon.Logger.LogDebug($"[{_monitorId}] {_propertyName} successfully updated to {valueToApply}");
consecutiveFailures = 0; // 成功后重置失败计数
}
else
{
ManagedCommon.Logger.LogWarning($"[{_monitorId}] {_propertyName} failed to update to {valueToApply}");
// Continue to check if there's a newer target value
consecutiveFailures++;
ManagedCommon.Logger.LogWarning($"[{_monitorId}] {_propertyName} failed to update to {valueToApply} (attempt {consecutiveFailures}/{MaxConsecutiveFailures})");
if (consecutiveFailures >= MaxConsecutiveFailures)
{
ManagedCommon.Logger.LogError($"[{_monitorId}] {_propertyName} failed {MaxConsecutiveFailures} times, giving up. Hardware may not support this feature.");
// 放弃：假装成功，避免无限循环
lock (_stateLock)
{
_currentValue = valueToApply;
}
return;
}
}
}
catch (Exception ex)
{
ManagedCommon.Logger.LogError($"[{_monitorId}] {_propertyName} update exception: {ex.Message}");
// Continue to check if there's a newer target value
consecutiveFailures++;
ManagedCommon.Logger.LogError($"[{_monitorId}] {_propertyName} update exception: {ex.Message} (attempt {consecutiveFailures}/{MaxConsecutiveFailures})");
if (consecutiveFailures >= MaxConsecutiveFailures)
{
ManagedCommon.Logger.LogError($"[{_monitorId}] {_propertyName} exception {MaxConsecutiveFailures} times, giving up. Hardware may not support this feature.");
// 放弃：假装成功，避免无限循环
lock (_stateLock)
{
_currentValue = valueToApply;
}
return;
}
}
// Loop back to check if target changed during the update