Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-02-24 04:00:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Add validation to prevent empty/null names in ImageResizer settings

Browse Source 
Co-authored-by: yeelam-gordon <73506701+yeelam-gordon@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-05 15:19:36 +00:00
parent 3857cf809d
commit bf7b762576
2 changed files with 47 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/settings-ui/Settings.UI.Library/ImageSize.cs
View File

@@ -69,7 +69,14 @@ public partial class ImageSize : INotifyPropertyChanged, IHasId
public string Name
{
get => _name;
set => SetProperty(ref _name, value);
set
{
// Prevent setting empty or null names
if (!string.IsNullOrWhiteSpace(value))
{
SetProperty(ref _name, value);
}
}
}
[JsonPropertyName("fit")]

39
src/settings-ui/Settings.UI.UnitTests/ViewModelTests/ImageResizer.cs
View File

@@ -313,5 +313,44 @@ namespace ViewModelTests
Assert.AreEqual(50, imageSize.Width);
Assert.AreEqual(50, imageSize.Height);
}
[TestMethod]
public void ImageSizeNameShouldNotBeSetToEmptyOrNull()
{
// arrange
ImageSize imageSize = new ImageSize()
{
Id = 0,
Name = "Original Name",
Fit = ResizeFit.Fit,
Width = 100,
Height = 100,
Unit = ResizeUnit.Pixel,
};
// Act - try to set name to empty string
imageSize.Name = string.Empty;
// Assert - name should remain unchanged
Assert.AreEqual("Original Name", imageSize.Name);
// Act - try to set name to null
imageSize.Name = null;
// Assert - name should remain unchanged
Assert.AreEqual("Original Name", imageSize.Name);
// Act - try to set name to whitespace only
imageSize.Name = " ";
// Assert - name should remain unchanged
Assert.AreEqual("Original Name", imageSize.Name);
// Act - set name to valid value
imageSize.Name = "New Valid Name";
// Assert - name should be updated
Assert.AreEqual("New Valid Name", imageSize.Name);
}
}
}