Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2025-12-15 03:07:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused MonitorInfo properties and constructors

Browse Source 
Clean up MonitorInfo by removing obsolete constructors and several computed properties (ColorTemperatureDisplay, VcpCodesSummary, HasColorPresets, BrightnessTooltip, ContrastTooltip). Update XML docs for clarity and rely on remaining properties for display logic.
This commit is contained in:
Yu Leng
2025-12-12 11:10:20 +08:00
parent dea4cbd045
commit a001d5cacd
1 changed files with 2 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
src/settings-ui/Settings.UI.Library/MonitorInfo.cs
View File

@@ -10,7 +10,6 @@ using System.Text.Json.Serialization;
using Microsoft.PowerToys.Settings.UI.Library.Helpers;
using PowerDisplay.Common.Drivers;
using PowerDisplay.Common.Interfaces;
using PowerDisplay.Common.Models;
using PowerDisplay.Common.Utils;
namespace Microsoft.PowerToys.Settings.UI.Library
@@ -66,23 +65,6 @@ namespace Microsoft.PowerToys.Settings.UI.Library
{
}
public MonitorInfo(string name, string internalName, string communicationMethod)
{
Name = name;
InternalName = internalName;
CommunicationMethod = communicationMethod;
}
public MonitorInfo(string name, string internalName, string hardwareId, string communicationMethod, int currentBrightness, int colorTemperatureVcp)
{
Name = name;
InternalName = internalName;
HardwareId = hardwareId;
CommunicationMethod = communicationMethod;
CurrentBrightness = currentBrightness;
ColorTemperatureVcp = colorTemperatureVcp;
}
[JsonPropertyName("name")]
public string Name
{
@@ -217,7 +199,6 @@ namespace Microsoft.PowerToys.Settings.UI.Library
/// <summary>
/// Gets or sets the color temperature VCP preset value (raw DDC/CI value from VCP code 0x14).
/// This stores the raw VCP value (e.g., 0x05 for 6500K preset), not the Kelvin temperature.
/// Use MonitorValueConverter to convert to human-readable Kelvin values for display.
/// </summary>
[JsonPropertyName("colorTemperatureVcp")]
public int ColorTemperatureVcp
@@ -229,19 +210,11 @@ namespace Microsoft.PowerToys.Settings.UI.Library
{
_colorTemperatureVcp = value;
OnPropertyChanged();
OnPropertyChanged(nameof(ColorTemperatureDisplay));
OnPropertyChanged(nameof(ColorPresetsForDisplay)); // Update display list when current value changes
}
}
}
/// <summary>
/// Gets the color temperature as a human-readable display string.
/// Converts the VCP value to a Kelvin temperature display.
/// </summary>
[JsonIgnore]
public string ColorTemperatureDisplay => MonitorValueConverter.FormatColorTemperatureDisplay(ColorTemperatureVcp);
/// <summary>
/// Gets or sets the current contrast value (0-100).
/// </summary>
@@ -371,7 +344,6 @@ namespace Microsoft.PowerToys.Settings.UI.Library
{
_vcpCodes = value ?? new List<string>();
OnPropertyChanged();
OnPropertyChanged(nameof(VcpCodesSummary));
}
}
}
@@ -437,24 +409,6 @@ namespace Microsoft.PowerToys.Settings.UI.Library
return true;
}
[JsonIgnore]
public string VcpCodesSummary
{
get
{
if (_vcpCodes == null || _vcpCodes.Count == 0)
{
return "No VCP codes detected";
}
var count = _vcpCodes.Count;
var preview = string.Join(", ", _vcpCodes.Take(10));
return count > 10
? $"{count} VCP codes: {preview}..."
: $"{count} VCP codes: {preview}";
}
}
[JsonPropertyName("supportsBrightness")]
public bool SupportsBrightness
{
@@ -527,7 +481,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
}
/// <summary>
/// Available color temperature presets computed from VcpCodesFormatted (VCP code 0x14).
/// Gets available color temperature presets computed from VcpCodesFormatted (VCP code 0x14).
/// This is a computed property that parses the VCP capabilities data on-demand.
/// </summary>
[JsonIgnore]
@@ -598,7 +552,7 @@ namespace Microsoft.PowerToys.Settings.UI.Library
}
/// <summary>
/// Color presets for display in ComboBox, includes current value if not in preset list.
/// Gets color presets for display in ComboBox, includes current value if not in preset list.
/// Uses caching to avoid recreating collections on every access.
/// </summary>
[JsonIgnore]
@@ -648,21 +602,12 @@ namespace Microsoft.PowerToys.Settings.UI.Library
}
}
[JsonIgnore]
public bool HasColorPresets => AvailableColorPresets != null && AvailableColorPresets.Count > 0;
[JsonIgnore]
public bool HasCapabilities => !string.IsNullOrEmpty(_capabilitiesRaw);
[JsonIgnore]
public bool ShowCapabilitiesWarning => _communicationMethod.Contains("WMI", StringComparison.OrdinalIgnoreCase);
[JsonIgnore]
public string BrightnessTooltip => _supportsBrightness ? string.Empty : "Brightness control not supported by this monitor";
[JsonIgnore]
public string ContrastTooltip => _supportsContrast ? string.Empty : "Contrast control not supported by this monitor";
/// <summary>
/// Generate formatted text of all VCP codes for clipboard
/// </summary>