Mirrors/PowerToys
1
0
Fork 0
mirror of https://github.com/microsoft/PowerToys.git synced 2026-02-24 04:00:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix form submits, once and for all (#284)

Browse Source 
if you don't hang onto a reference to the RenderedAdaptiveCard, then the GC might clean it up sometime, even while the card is in the UI tree. If this gets GC'd, then it'll revoke our Action handler, and the form will do seemingly nothing.
This commit is contained in:
Mike Griese
2025-01-08 15:36:50 -06:00
committed by GitHub
parent a56916fc33
commit 55f4632ad8
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/modules/cmdpal/Microsoft.CmdPal.UI/Controls/FormControl.xaml.cs
View File

@@ -14,6 +14,12 @@ public sealed partial class FormControl : UserControl
private static readonly AdaptiveCardRenderer _renderer;
private FormViewModel? _viewModel;
// LOAD-BEARING: if you don't hang onto a reference to the RenderedAdaptiveCard
// then the GC might clean it up sometime, even while the card is in the UI
// tree. If this gets GC'd, then it'll revoke our Action handler, and the
// form will do seemingly nothing.
private RenderedAdaptiveCard? _renderedCard;
public FormViewModel? ViewModel { get => _viewModel; set => AttachViewModel(value); }
static FormControl()
@@ -71,10 +77,10 @@ public sealed partial class FormControl : UserControl
private void DisplayCard(AdaptiveCardParseResult result)
{
var rendered = _renderer.RenderAdaptiveCard(result.AdaptiveCard);
rendered.Action += Rendered_Action;
_renderedCard = _renderer.RenderAdaptiveCard(result.AdaptiveCard);
ContentGrid.Children.Clear();
ContentGrid.Children.Add(rendered.FrameworkElement);
ContentGrid.Children.Add(_renderedCard.FrameworkElement);
_renderedCard.Action += Rendered_Action;
}
private void Rendered_Action(RenderedAdaptiveCard sender, AdaptiveActionEventArgs args) =>