mirror of
https://github.com/microsoft/PowerToys.git
synced 2026-04-07 03:36:44 +02:00
Settings UI: Fix spelling error and make spell checker happy (#41403)
## Summary of the Pull Request - Renames `NavigatablePage` to `NavigablePage` to fix a spelling error. - Reverts related entries in `exclude.txt` that triggered a forbidden pattern error in the spell checker. - The spell checker does not allow PascalCase words like `NavigatablePage` in `exclude.txt` because of its automatic casing rules. Regression: #41285 --------- Co-authored-by: vanzue <vanzue@outlook.com>
This commit is contained in:
121
src/settings-ui/Settings.UI/Helpers/NavigablePage.cs
Normal file
121
src/settings-ui/Settings.UI/Helpers/NavigablePage.cs
Normal file
@@ -0,0 +1,121 @@
|
||||
// Copyright (c) Microsoft Corporation
|
||||
// The Microsoft Corporation licenses this file to you under the MIT license.
|
||||
// See the LICENSE file in the project root for more information.
|
||||
|
||||
using System;
|
||||
using System.Numerics;
|
||||
using System.Threading.Tasks;
|
||||
using CommunityToolkit.WinUI.Controls;
|
||||
using Microsoft.UI.Xaml;
|
||||
using Microsoft.UI.Xaml.Controls;
|
||||
using Microsoft.UI.Xaml.Hosting;
|
||||
using Microsoft.UI.Xaml.Media;
|
||||
using Windows.UI;
|
||||
|
||||
namespace Microsoft.PowerToys.Settings.UI.Helpers;
|
||||
|
||||
public abstract partial class NavigablePage : Page
|
||||
{
|
||||
private const int ExpandWaitDuration = 500;
|
||||
private const int AnimationDuration = 2000;
|
||||
|
||||
private NavigationParams _pendingNavigationParams;
|
||||
|
||||
public NavigablePage()
|
||||
{
|
||||
Loaded += OnPageLoaded;
|
||||
}
|
||||
|
||||
protected override void OnNavigatedTo(Microsoft.UI.Xaml.Navigation.NavigationEventArgs e)
|
||||
{
|
||||
base.OnNavigatedTo(e);
|
||||
|
||||
// Handle both old string parameter and new NavigationParams
|
||||
if (e.Parameter is NavigationParams navParams)
|
||||
{
|
||||
_pendingNavigationParams = navParams;
|
||||
}
|
||||
else if (e.Parameter is string elementKey)
|
||||
{
|
||||
_pendingNavigationParams = new NavigationParams(elementKey);
|
||||
}
|
||||
}
|
||||
|
||||
private async void OnPageLoaded(object sender, RoutedEventArgs e)
|
||||
{
|
||||
if (_pendingNavigationParams != null && !string.IsNullOrEmpty(_pendingNavigationParams.ElementName))
|
||||
{
|
||||
// First, expand parent if specified
|
||||
if (!string.IsNullOrEmpty(_pendingNavigationParams.ParentElementName))
|
||||
{
|
||||
var parentElement = FindElementByName(_pendingNavigationParams.ParentElementName);
|
||||
if (parentElement is SettingsExpander expander)
|
||||
{
|
||||
expander.IsExpanded = true;
|
||||
|
||||
// Give time for the expander to animate
|
||||
await Task.Delay(ExpandWaitDuration);
|
||||
}
|
||||
}
|
||||
|
||||
// Then find and navigate to the target element
|
||||
var target = FindElementByName(_pendingNavigationParams.ElementName);
|
||||
|
||||
target?.StartBringIntoView(new BringIntoViewOptions
|
||||
{
|
||||
VerticalOffset = -20,
|
||||
AnimationDesired = true,
|
||||
});
|
||||
|
||||
await OnTargetElementNavigatedAsync(target, _pendingNavigationParams.ElementName);
|
||||
|
||||
_pendingNavigationParams = null;
|
||||
}
|
||||
}
|
||||
|
||||
protected virtual async Task OnTargetElementNavigatedAsync(FrameworkElement target, string elementKey)
|
||||
{
|
||||
if (target == null)
|
||||
{
|
||||
return;
|
||||
}
|
||||
|
||||
// Get the visual and compositor
|
||||
var visual = ElementCompositionPreview.GetElementVisual(target);
|
||||
var compositor = visual.Compositor;
|
||||
|
||||
// Create a subtle glow effect using drop shadow
|
||||
var dropShadow = compositor.CreateDropShadow();
|
||||
dropShadow.Color = (Color)Application.Current.Resources["SystemAccentColorLight2"];
|
||||
dropShadow.BlurRadius = 16f;
|
||||
dropShadow.Opacity = 0f;
|
||||
dropShadow.Offset = new Vector3(0, 0, 0);
|
||||
|
||||
var spriteVisual = compositor.CreateSpriteVisual();
|
||||
spriteVisual.Size = new Vector2((float)target.ActualWidth, (float)target.ActualHeight);
|
||||
spriteVisual.Shadow = dropShadow;
|
||||
spriteVisual.Offset = new Vector3(0, 0, 0);
|
||||
|
||||
// Insert the shadow visual behind the target element
|
||||
ElementCompositionPreview.SetElementChildVisual(target, spriteVisual);
|
||||
|
||||
// Create a simple fade in/out animation
|
||||
var fadeAnimation = compositor.CreateScalarKeyFrameAnimation();
|
||||
fadeAnimation.InsertKeyFrame(0f, 0f);
|
||||
fadeAnimation.InsertKeyFrame(0.5f, 0.3f);
|
||||
fadeAnimation.InsertKeyFrame(1f, 0f);
|
||||
fadeAnimation.Duration = TimeSpan.FromMilliseconds(AnimationDuration);
|
||||
|
||||
dropShadow.StartAnimation("Opacity", fadeAnimation);
|
||||
await Task.Delay(AnimationDuration);
|
||||
|
||||
// Clean up the shadow visual
|
||||
ElementCompositionPreview.SetElementChildVisual(target, null);
|
||||
}
|
||||
|
||||
protected FrameworkElement FindElementByName(string name)
|
||||
{
|
||||
var element = this.FindName(name) as FrameworkElement;
|
||||
return element;
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user