Mirrors/yjs
1
0
Fork 0
mirror of https://github.com/yjs/yjs.git synced 2026-08-29 10:09:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix remaining issues with cached ytype.delta

Browse Source
This commit is contained in:
Kevin Jahns
2026-07-01 01:36:43 +02:00
parent 562c1e32d8
commit dd8c2ab193
2 changed files with 44 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/attribution.tests.js
View File

@@ -605,15 +605,19 @@ export const testRdtFormatEmbedInBold = () => {
}
/**
* FAILING (known bug — minimal, deterministic, no prng): formatting a char and then deleting it under a
* diffing renderer leaves the maintained `delta` with a stale bold value + `{format:{bold:[]}}` attribution
* on the deleted char, where a fresh deep render keeps only the `{delete:[]}` suggestion.
* Regression (minimal, deterministic, no prng): formatting a char and then deleting it under a diffing
* renderer used to leave the maintained `delta` with a stale bold value + `{format:{bold:[]}}`
* attribution on the deleted char, where a fresh deep render keeps only the `{delete:[]}` suggestion.
*
* maintained .delta : "a" { format:{bold:true}, attribution:{ format:{bold:[]}, delete:[] } }
* toDelta({deep}) : "a" { attribution:{ delete:[] } }
* maintained .delta : "a" { format:{bold:true}, attribution:{ format:{bold:[]}, delete:[] } } (was)
* toDelta({deep}) : "a" { attribution:{ delete:[] } } (correct)
*
* This is the remaining stale-`{format:{bold:[]}}`-on-wrong-content (re-assert) class, distinct from the
* (fixed) `{format:{bold:null}}` null-leaf.
* On delete, the format markers around the char are cleaned up (deleted) too; their insert+delete
* suggestion nets to no attribution, so the change render skipped them and never undid the value +
* attribution the format step had written to the cache. The fix (in `toDelta`): a retain emits the
* format *diff* (`changedAttributes`, which carries the `bold→null` clear), and a deleted format marker
* that actually removes a format under an attributing renderer emits an explicit `{format:{<key>:null}}`
* attribution clear. This was the stale-`{format:{bold:[]}}`-on-deleted-content (re-assert) class.
*/
export const testRdtFormatDeleteFormatted = () => {
const doc = new Y.Doc()