bahdotsh ac63a0d797 fix: clean up review findings in step guards, secret store, and test fixture ...

The PR review flagged three issues worth fixing before merge.

First, run_step_with_guards had a bogus StepStatus::Skipped check
in the abort_job logic. The condition tested for Failure *or*
Skipped, then only actually aborted on Failure — meaning the
Skipped branch did nothing except confuse anyone reading the code.
Simplify to just check Failure directly.

Second, EncryptedSecretStore::from_json would silently fail with a
generic serde error when fed the old serialization format (which
had a shared top-level nonce field). Now it detects the old format
by checking for the "nonce" key and returns a clear error pointing
at BREAKING_CHANGES.md. Added a test for this.

Third, tests/workflows/continue-on-error-test.yml was an orphan
fixture — nothing referenced it. The same content is already
tested inline by parse_continue_on_error_workflow in the parser.
Removed it.

2026-04-01 22:44:43 +05:30

..

1-basic-workflow.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

2-reusable-workflow-caller.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

3-reusable-workflow-definition.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

4-mixed-jobs.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

5-no-name-reusable-caller.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

6-invalid-reusable-format.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

7-invalid-regular-job.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

8-cyclic-dependencies.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

cpp-test.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

example.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

matrix-example.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

node-test.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

python-test.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

runs-on-array-test.yml

fix: Support array format for runs-on field in GitHub Actions workflows

2025-08-13 13:21:58 +05:30

rust-test.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

test.yml

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

trigger_gitlab.sh

feat: reorganize test files and delete manual test checklist

2025-08-09 15:30:53 +05:30

working-secrets-test.yml

fix(docker): mount GitHub environment files directory into containers

2025-09-05 08:01:29 +05:30