From 024a30080ff182eae41cbdbf64ef62bd04bf37be Mon Sep 17 00:00:00 2001 From: bahdotsh Date: Mon, 13 Apr 2026 10:24:42 +0530 Subject: [PATCH] fix(test): skip emulation artifact roundtrip test on Windows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The artifact roundtrip test runs `bash -c "mkdir ... && echo ..."` through EmulationRuntime, which does `Command::new("bash")`. On Windows CI runners, this resolves to WSL's `bash.exe` sitting in `C:\Windows\System32\`, not Git Bash. And since the runner has no WSL distributions installed, the test blows up with a helpful "Windows Subsystem for Linux has no installed distributions" and a link to the Microsoft Store. The test is inherently Unix-only — it exercises Unix shell commands on a real EmulationRuntime. Gate it with `cfg(not(target_os = "windows"))`. --- crates/executor/src/engine.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/crates/executor/src/engine.rs b/crates/executor/src/engine.rs index 0788ebd..4a7b516 100644 --- a/crates/executor/src/engine.rs +++ b/crates/executor/src/engine.rs @@ -7630,6 +7630,7 @@ runs: /// This test drives a real `EmulationRuntime` end-to-end through /// run → upload-artifact → download-artifact and asserts the payload /// round-trips byte-for-byte. + #[cfg(not(target_os = "windows"))] #[tokio::test] async fn run_step_upload_download_artifact_roundtrip_emulation() { let runtime = emulation::EmulationRuntime::new();